From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DADCD6DDEA for ; Fri, 15 Nov 2024 08:49:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 125B96B0089; Fri, 15 Nov 2024 03:49:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5376B008A; Fri, 15 Nov 2024 03:49:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDE9E6B008C; Fri, 15 Nov 2024 03:49:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D02726B0089 for ; Fri, 15 Nov 2024 03:49:20 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 76F4AC0FFC for ; Fri, 15 Nov 2024 08:49:20 +0000 (UTC) X-FDA: 82787702130.20.1757F12 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by imf21.hostedemail.com (Postfix) with ESMTP id C9D101C0009 for ; Fri, 15 Nov 2024 08:47:52 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="K jYK9ER"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Csxz+lyZ; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.150 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731660379; a=rsa-sha256; cv=none; b=0rIrpozsz//kqswG22Spcsdp7ggGXrLljOQhGjD4lXVBDbSTtYuxyQKASck1k3BaRW5cAJ UJfQ0/Xagw4WiM6jhL1RZAGR2rOTItsklW+jcyd3XwoTRgPbKIfOsQMcFboeeKf4Z97MPJ ZsESuLPiuGR7eP3AnPKKZ3lj5hXVu9Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="K jYK9ER"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Csxz+lyZ; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.150 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731660379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iaji9P4Funvw7r0qArvkXpNAHznh5sdnkxmV7nx9XAk=; b=LP7bE002tB2IdllJ9a/Vvx1Jd2m3zjnWE8Xxh9rZ+RpIetTzrvC3GZesaYDljVJ1g/UJPO CgXzZG67kIHMvJPNaO4hrabGmTrBCObxCeA6di2/FEmh34qAjpQ5Kw36pS5riUoe4tC6mT D7x5ldKJ3qzaPVSEc4T+eI7X/2oF7/c= Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 37C651140151; Fri, 15 Nov 2024 03:49:17 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Fri, 15 Nov 2024 03:49:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1731660557; x= 1731746957; bh=Iaji9P4Funvw7r0qArvkXpNAHznh5sdnkxmV7nx9XAk=; b=K jYK9ERWo+b/9O9yWM3VYBPdlzRIhn/GsCwKz65L9HH8qqkP/wDYnJdej5Sdxv1Oa o8aUlQFMaz7EU1sF9bMNL93pUaR8lc5vGlkl/kHBzbDYhX/W8KUq/2PrmUUUemcY yTkCN0FFKazvuUGzbwLFLYtptvUP6sdbxrHR3v77ZtUSszCkxHYrkP7/OU2WT5I4 nl1N6gkhm2utCFaqm81/n6PbZ2bfMSwNaWfGwnqKamxndIqg9L+1b69Fe3+sdMNC giY1cuzGyy8BNhSrT76X/0rqWvMcrHe3dnxDFjCEtOiTxfqI9ScTEIE74ycflQZg DIcfFOaiABhUrBrcPyldg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731660557; x=1731746957; bh=Iaji9P4Funvw7r0qArvkXpNAHznh5sdnkxm V7nx9XAk=; b=Csxz+lyZaPEgendotkPPZbMtqk7t4iaGLW/c54YxIJJCdfFREiH KATPLJ0GRBSRF7oA5MJbIsoK2NBxFUBhKxZfCCHd7tb4oIT0mqpatlJZSl9vX0iK cwsuzTo0LfJ3xiKzJK0RGIJ+mF8GD6+ZQwZc7YHxR3Bvi13AcNh1giAei2goxWZ6 gtg7oHnlCfKKjEbgGGzjDURGzEMg0eZPEfIQX8tNwpLWhWXm3SWS1qmFJor4p5Bw +9qcmNZwVswh82WH0z2CYBccWyRRJNab8/HUy7753Z+H+KW+UfAuvS9FG1LDk9ip c56fRBrZ5g1o5LEsZ/hlI38UsHOtK6JlKfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdefgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtph htthhopegrgigsohgvsehkvghrnhgvlhdrughkpdhrtghpthhtoheplhhinhhugidqmhhm sehkvhgrtghkrdhorhhgpdhrtghpthhtoheplhhinhhugidqfhhsuggvvhgvlhesvhhgvg hrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehhrghnnhgvshestghmphigtghhghdr ohhrghdprhgtphhtthhopegtlhhmsehmvghtrgdrtghomhdprhgtphhtthhopehlihhnuh igqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopeifihhl lhihsehinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheplhhinhhugidqsghtrhhfsh esvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdgvgihtgees vhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Nov 2024 03:49:12 -0500 (EST) Date: Fri, 15 Nov 2024 10:49:08 +0200 From: "Kirill A. Shutemov" To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, bfoster@redhat.com Subject: Re: [PATCH 08/17] mm/filemap: add read support for RWF_UNCACHED Message-ID: <66q2ojkbzy2l7ozzc4ilputbgvdtwav4r4qdvnl7x32tuutums@zachqbvl7y3w> References: <20241114152743.2381672-2-axboe@kernel.dk> <20241114152743.2381672-10-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241114152743.2381672-10-axboe@kernel.dk> X-Stat-Signature: uhmzp1kiy4wi6enwprzh8m9sxop7enmf X-Rspamd-Queue-Id: C9D101C0009 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731660472-323562 X-HE-Meta: U2FsdGVkX1/+ujpysvgySip2dWy1M1ywEbzZlIoZdRBuqzfGfR4r5ATXzJAfwrwdY46Eog7fxYPFMQ+AG7fx+Am4izG5BmzehuWvn8IYmbfQw2nu6/Dnpl5gBMCoEkM6PA2mZQgGUQlrPxpdM1whFthzhW/WtV+f1u1hfHyg9YZGyuBtYD80eAOJbipmfBKcawHxZN/jxNj/NBm0Gewkb+LFRvQmR9XUe11UXaTQI+la587C9arnJWb0EkNGXfzrM0aD0ZYWHgQfAZiHW/Ki9kYVmHw3ok3CxZbLOYJtsdgIK3g8CHJ0AYm09crJAbkaqJq0BU4BfTj0S/FyI1xAXkZ7McoBESWZe1UVtR5BjY1yBMvDfaWpJVFR9ta3ER2LFsO0LITxrWwPkQiTYvZAqvS2E7/H2CgYilNbci4PaKeFzweXCYxUz/Gg1KgBRLILJd1ZpMgN9lIakQnsdZQx9zkU17KR7Xpbq/bS7mFA67lpUqZUmxWckPrD8/v35/1ecNIR/LfMzBaGjA+i1y+nnJe557zn7A377dXc2J0zsxSqt37e0HxTO6MV1NmvqMab+23FCKs4PAd3rr9BofIRnnrJXa71w9Vuy9MyLqLVQWYtPYJDmJBpuLYyBt1DhPUm1KNo8QsX3aIAirGl8aqIa3sT7DLSE2Qruyd/bVk+RXU3uN7txCnsNsAz0IeaNvI7LXzgR/+vJJ4CJX0tpuPA7SCd1OvFuRZbzlvARHM13uJak//ujQpQB/rVZc3ESMhCOY2GpqNPV6F3IQe7RvI1OlKxpozp6YKfQUO4iYMZFjuMeeiTS0jggzPks1Ee4BI79Q7mjstUCoNwgGytd3Ld7b+4les7TffqDwuyG2J23xnent6IGI9F4ZKXeSUG2sBOSr8wuKlWJhIel81q30tUx+K1soG1962UhGfszMBxn8r9EhCPWfOHs4jz1OkFFG7lZCbXPo8WvOUjlaAGo14 POPT3Vw1 YxBkquM+Zq8KMBK7QXVbf1aCgpzl2HM6FZQ4gRQ5tAzg96b3SI2qIHHSdG1CW6bXA6u0/T2kyvKvMAYVaCUHhyltdnTmuwgZ07cUqpShEtZYs50E6EWieRY1eZNIwbw2j6cWO+HgRDaQtflCQfYRl8qA9rSigsiBW7dRX6X0LSkNkb2NG8scuRMXrHyJxixc+oZ6Xx1HuTU+oKvumbUEh0RAzQV8z7D8e+syhmybqhHbSqEI+0UVd2yBPUUxkGFPAltanmrazdfWSWbns0oPLNHgwsDTkDB/GO6qBHjsNLJC4w6ZwHyS3VZ4StVBdgxANCV9HYKpF7XvoY0G0LXExn8boYmQ6+3KQNQLR1ehpMfJjBsnLHkJSSgZdT38JEH7pSpvQHPPqEFFteZSK7tFLgdshm2qOdiapDwsX0rV96CaEkoZLvuyFc+yuOE2Z7b4Lsaz3OUNvCrniCmY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 14, 2024 at 08:25:12AM -0700, Jens Axboe wrote: > @@ -2595,6 +2601,20 @@ static inline bool pos_same_folio(loff_t pos1, loff_t pos2, struct folio *folio) > return (pos1 >> shift == pos2 >> shift); > } > > +static void filemap_uncached_read(struct address_space *mapping, > + struct folio *folio) > +{ > + if (!folio_test_uncached(folio)) > + return; > + if (folio_test_writeback(folio)) > + return; Do we want to drop out here if the folio is dirty, but not yet under writeback? It is checked inside folio_unmap_invalidate(), but we will lose PG_uncached if we get there. > + if (folio_test_clear_uncached(folio)) { > + folio_lock(folio); > + folio_unmap_invalidate(mapping, folio, 0); > + folio_unlock(folio); > + } > +} > + > /** > * filemap_read - Read data from the page cache. > * @iocb: The iocb to read. -- Kiryl Shutsemau / Kirill A. Shutemov