From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5F6C3DA45 for ; Fri, 12 Jul 2024 02:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23B4A6B0093; Thu, 11 Jul 2024 22:29:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EC156B0095; Thu, 11 Jul 2024 22:29:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B3786B0096; Thu, 11 Jul 2024 22:29:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E1C646B0093 for ; Thu, 11 Jul 2024 22:29:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 78C3216089E for ; Fri, 12 Jul 2024 02:29:57 +0000 (UTC) X-FDA: 82329520434.28.736730D Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 4298480004 for ; Fri, 12 Jul 2024 02:29:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kcAxDQ5D; spf=pass (imf30.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720751378; a=rsa-sha256; cv=none; b=K603JrXoEQk8cj3CIJh15gg/unYhrLV6Ulgnga8xZDvnQH3QGmTouD5mNb0mnB6wf0h9PH ywtwMOhTnnF5zN5aGosBdnaaS0kxDKV30tGNvEmXvViz009S/EjvnYQdeQph9/XNLprBRN bIBTo3eK5gbscfTJGqifovVAQLARPsE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kcAxDQ5D; spf=pass (imf30.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720751378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cqGt6wfRotjMw1Rxo2bsfyZM2cjm85hVKvptBJmS+/g=; b=6xE1D929vUp1sailEprFAI6ERFFK/BkWhlS0b1ODkHUye9rFLQ32k2JuDq2qUDINxmo8RK 9YfMKb4iVTSWKke5HDuwguTT8ojo+82SeXs2fTIxhM6FUBkLamGbjVpt1r76pn6XNo+XAR mgG6YGhip02oaI2jE1+s/tBKTWGfNQA= X-Envelope-To: willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720751393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cqGt6wfRotjMw1Rxo2bsfyZM2cjm85hVKvptBJmS+/g=; b=kcAxDQ5DOfSEDmTkCsMONeCP8HRjaaAAIreIlMUx3/vu4XwgNFo6v7TVyhcKYnrHoZbKZB OlZV1UTILVmPTYDZQABulsGbdLecpFMNFMkLLfPFTZZ5mUccRVM6VqpTUOl0MgqJpi8qH/ W+jNLuxoaUK7eTSbpAqLatqmI5xB6LY= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: david@redhat.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org MIME-Version: 1.0 Date: Fri, 12 Jul 2024 02:29:50 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <66e43c92d3b4ecfff50e84bdaeedfad3aa477df6@linux.dev> TLS-Required: No Subject: Re: [PATCH] mm: unified folio_test_anon()/folio_anon_vma() and use them To: "Matthew Wilcox" Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20240711130351.2830-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: ynp95ybbuf97jyzgywjmnm799fs6rwm9 X-Rspamd-Queue-Id: 4298480004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720751395-633416 X-HE-Meta: U2FsdGVkX1/fVnziDHrxPVDmMPo5fJQU3i0Wa6m1bsg9ssyF60WbV8eVpnmf5epP7PxEclPEXJ+VQs7Sl2yOSiwMyyMYqvZhFuhymC2+LUU6mvOUIXzkNBEMA/aE/GU3NjSMq8i5TLzfXZbDcb/qSpTQ1cR/Xi24DOiIhkx8Dygk7lINiFtO/zmFM/XkNHp84YP1Df83WDhyVPdPAz1eaeGCBmJH/AXrwWscTJqfjJv0Z9gN75thkmyB50V2PmZn8mGFkjTvtdXIBnVcmpgmwUEQr0CQlANxLrOhcSGnrcP2XkFFirCOfffzcJ33iJcFd9TfTrjBzYIN1wrklXXTTgbXa+3urTn1PLzbYk1fXlkzyAtT973lNMyneuz6GIO7drEJiIm2zOETz82dsdvWUqdgEH1kkp4akibUrBKi4hrT5bzYHI7Ce3+3gUMWuNDaJ8es/WrcMqlUmWhS8h49xL8UbuotrJvilJwbBpPezTE8tATeU7hsLb+Io8xcc0JM3vfwwpN9roU4x6wcUu2PbrY/hySb23wumsIo2ijS7kdDvL1d2esgiPMgTvqx1bXdQV4dX4zTUbsc7cEZEJGwUF7eomIqKyKvrhOvZ1+3mziNOqAIvQDmp3IQfGAzltcqNch7Grkz+9ZgRjABS6QzKnD9YesbHFMkta4wscyw8s3mDviQVZJjVvvv2TaqLiHIf2IRE+2Zq9jHvkJ6FwfwGm4CFn7vMoV4HKucP/PuqdM+Js8so4g+KoGe6pXM5E9rVVRhjIkXjz5Xh9Z/bi/Cvl773SBKxLP01+jkfIC1Z52THYTPe7TEj8nifzKtNmYrYPHjtyeKVfQgWVPPIGhjWJHC0YC9gx2y7Q9/nPjjcBJkUTybajkH95gjewXNIswjmo6cnWKK4E1Hd2F3H+xcQUF1hsNBVWoY8tQGUPHs9Od6I66JNw79JuSnWVVxRWNiG0o50MMAWqheuI3Y3dz Jn/iOPY4 /UZSTMQYIa2S5NtouSd2zNNcQjSCQql2PPlp42Ce6FViCOZ9z4bNwtr+8sRNNdinNUawKj2tDB2+Y0mOjVIjHjftZAeSd3WZeNd5TaXMUUsxyylJLsWmwW+1CqZFadTaMgm/y+QSGyDS37lNFjWimT0nun65/VZmgF2thUr6XhJuK+Q24vnkNWY8C6tJzzNG7xF/bCwZEs8XpgJs6SSX2Lqz2r/VN4HywKWy4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: July 11, 2024 at 9:08 PM, "Matthew Wilcox" wrote: >=20 >=20On Thu, Jul 11, 2024 at 09:03:51PM +0800, Yajun Deng wrote: >=20 >=20>=20 >=20> +++ b/include/linux/page-flags.h > >=20 >=20> @@ -691,7 +691,8 @@ static __always_inline bool PageMappingFlags(c= onst struct page *page) > >=20 >=20>=20=20 >=20>=20 >=20> static __always_inline bool folio_test_anon(const struct folio *fo= lio) > >=20 >=20> { > >=20 >=20> - return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) !=3D = 0; > >=20 >=20> + return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) =3D= =3D > >=20 >=20> + PAGE_MAPPING_ANON; > >=20 >=20> } > >=20 >=20 > This is wrong. KSM pages are supposed to return true for >=20 >=20folio_test_anon(). I haven't looked any further at this patch, since >=20 >=20the premise appears to wrong and you clearly haven't tested. > Thank you for pointing this out. It was my mistake! I think I need to add a new helper function, like __folio_test_movable. e= .g. static __always_inline bool __folio_test_anon(const struct folio *folio) { return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) =3D= =3D PAGE_MAPPING_ANON; }