From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDBB3CDB465 for ; Thu, 19 Oct 2023 08:11:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49D896B00C5; Thu, 19 Oct 2023 04:11:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44BA76B00CA; Thu, 19 Oct 2023 04:11:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2546E6B00C8; Thu, 19 Oct 2023 04:11:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 11E506B00C0 for ; Thu, 19 Oct 2023 04:11:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D7978A11C8 for ; Thu, 19 Oct 2023 08:11:29 +0000 (UTC) X-FDA: 81361491498.27.10E4F22 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 7188880017 for ; Thu, 19 Oct 2023 08:11:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OTjL2npR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697703087; a=rsa-sha256; cv=none; b=jF6mgb0Tfke3AT5+I/pUyFcF1RWNSQOhoRIDr4XEk31fw0l5XdU/Ai0zJLNJazJh50JeuV 58GSO5c0lC8UxkR1x3Kz3dxnsVE9ckjd9uU/kAK/c/HtNFKAdoQd9xXLiSlb/qSHPNN3Y6 MxZ7T62r1wFgVOsm/h/7gIF9NkQJz9c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OTjL2npR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697703087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BCkMv6X2gPqMmuAauBxJmYYBwBl8zgId6nhnBK3V+jE=; b=iO3sASXrXLWPi/tdpdKY4q3PEG9G/vLc8MwC9y+x1vqmFoOwJDArzTEV4xQ1E2Vko1QNNX TGx6r6XVOK4GWlCqHWIg3mSwNAGyXY4B2lIOxjLOl9RbPJ6NBQ/+wHBdbd1nZ87RkhfrI0 5GYn4fukZYCkrR1yGnypM4MYDWSPYuY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697703086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BCkMv6X2gPqMmuAauBxJmYYBwBl8zgId6nhnBK3V+jE=; b=OTjL2npR2EPcBlW1+njF0sx750QNOWQPmi0FMkOqjUioXaA62xxedrERkrv9Kpu0O7uJnc BPSCzmTCaoi1Ma7N7s+uuo5g/zSYitf4ZZN8FkLA2NyLMyNFXYc09bO/ofjY3HRlFaEfc5 rk67D+yX6t7iM17HtPqRPEHMj1dOIXA= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-MkSfqTunMrOsXqmMJdQO9Q-1; Thu, 19 Oct 2023 04:11:23 -0400 X-MC-Unique: MkSfqTunMrOsXqmMJdQO9Q-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c54b040cf2so11992081fa.2 for ; Thu, 19 Oct 2023 01:11:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697703081; x=1698307881; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BCkMv6X2gPqMmuAauBxJmYYBwBl8zgId6nhnBK3V+jE=; b=h+TmkLc6U7zWb9jCU0FyCLyyxJNhXAuoEWKhOztQNvVDB2IfD+URj/kFfyGIU5sCtd YayKSM3KdXebZubVY5iRiQnQ8Tve0Y39QYBGnzmd00BH57Oy7bRruahZrHe5YZTRq4wn QY+J3KDm84ercNazxL0/zgqgou9dGq0nhuB8+ZZ8gorVvQqi4bk5f2yHydajiBLtOxrH cMm8UujFRwFo9VZX4fLfq0vQ9Wb55AZ5Bti1DC8E3WOcBm8LE7Yrgz7kMb3cA549vZ57 5durHi97uqw6ibhI8Bm/aAwBFpnZDxHDsPyK2JP/P7ARjN4gZL3DzK20CqRe15WMkyhC QHhQ== X-Gm-Message-State: AOJu0YzcHs4zHtXB+3tk659QmgNoq6tLEUnfwOTdl3I8yj2BlUxVU0Qu DQPZxpu1uqKdMYPuR58F36DojQw5OiEA2lcBkkY1BR4jRWmfyY9VCsJLsEqHNLeRkha/x+UJj1n Vx2kQ1RxfSss= X-Received: by 2002:a05:651c:a0f:b0:2c5:8a4:9e6f with SMTP id k15-20020a05651c0a0f00b002c508a49e6fmr1135937ljq.37.1697703081436; Thu, 19 Oct 2023 01:11:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+NKz/qzI3NYZ7mJdRl19yrUQQHHY4/yw/AekfOpMpT/yM/rYm/010H25SvOA81ZRAFqagZg== X-Received: by 2002:a05:651c:a0f:b0:2c5:8a4:9e6f with SMTP id k15-20020a05651c0a0f00b002c508a49e6fmr1135913ljq.37.1697703081014; Thu, 19 Oct 2023 01:11:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:500:6a06:17fc:810b:b054? (p200300cbc70b05006a0617fc810bb054.dip0.t-ipconnect.de. [2003:cb:c70b:500:6a06:17fc:810b:b054]) by smtp.gmail.com with ESMTPSA id k6-20020a05600c1c8600b0040839fcb217sm3818571wms.8.2023.10.19.01.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 01:11:20 -0700 (PDT) Message-ID: <66e16a28-2d04-4b2c-88a8-692edf587f02@redhat.com> Date: Thu, 19 Oct 2023 10:11:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: drop memoryless node from fallback lists To: Qi Zheng , akpm@linux-foundation.org, rppt@kernel.org, vbabka@suse.cz, mhocko@suse.com Cc: willy@infradead.org, mgorman@techsingularity.net, mingo@kernel.org, aneesh.kumar@linux.ibm.com, ying.huang@intel.com, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <32c12381941f347ebafb9cb5bc9f0a4a535ff646.1697687357.git.zhengqi.arch@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <32c12381941f347ebafb9cb5bc9f0a4a535ff646.1697687357.git.zhengqi.arch@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7188880017 X-Stat-Signature: 4b9jy1doytgfnmz7i7w5gc9biw7s9mg9 X-HE-Tag: 1697703087-673295 X-HE-Meta: U2FsdGVkX184sFldOKE4n8x8diCjOUV+dthrYctVbygoPW62AuoVmDCdpCNPOnQGxo3voSa8hFi8MX1nMtm25znGCrbba0tCa425TRnFmG5zhbPfh9RDCPrxMD9dHXiflt2RUOOpRMnplcwJApON8wa/ukvIIGL0jFW9ghH2eweRI2C/JO5kOIB8yiWEBnR55plgl/5DA6TRzWhnJ+hX7A2zS4arqVAZBt0DHkVtmTnQhzG5xhEy970zB+aiaQzbbSZMsfmYbn9MHanN8Uw1X4zM9X3ix05q8c5PFMSfdDWwuG7lfuDK3wR01T0VZmwtNajXRo3ZUrKGsptjOWirBCtAQ76FnLX+haqO8s/J4nfICthjIIT03sy06fiv0SdlektEIwByEqQyLfPIKW+Exk3aUTsx6UDCRT2kqskoTOzhTw8H6gXD6Kb5tdp/aRz0IKiCjYJC76wnVN+273MAXRuZWCOeYarQJpPyoCkHmTrDUiJwfqf88FI6fniDBD8wbdjBkqk87yYIPzqO+m3MAtV0ZynyvZlAzTQimRR9V+psEr2HhLsLky38RxeixiCzGvn5+3cVTT1hrthJVn84RY0+f5ME+WT4ofE3HllVrQLBr1y1WBpQWwpuIaEHe12Idf03kApqJ7cC4Vxs0rbpupGg6duxUAjroHxGjFEgYDfMy0H9hoezJ0MGqpvli7vvlRXl07RvmfFVYEMgYioyA/pwCdGQ+TMQi+DykqgWoxuG/IyXx6Q1hxv8klj50TdqAFq+8m/9KsrxHXTIJ2sc4Ouodahf34Yp/7t3nSUFr8hA+Ib6EJk5Oz6wFph9r+GwCIPpWfVpc94eEM7pFZVc2ggpyOfPOXDOWAc0KI56DhVUUyg7LZ0lhLe5Ddf6FYuUvhdF0Or2iHkLDv7kxqHdIG5RB8nDcHWgqunduIdtd9O01TJsWravN2Iqq3Q2D2kLBvmj7BiytCUiD/OXvO5 r3G6Dh0v La6Tn/TjBwsNvLBbm8Dtmbniv+midQU4DU0dQHAGKglxBfCVdZjXTl3iOAkHVTLAumZrv7V+bZbZWfyzHfcJ4NatLnwYPWWCjvw1YLemnvU7pe2KrvM4zVha5mWIQT7znsx8rnEToBtzsLCmZa7x8Fl9aWxQduG0rsEg5gqyKiZie8FmffENvNkyXyWaaCPreQtiaY0Ph7QMsqZhxTiCed/BSNA9BnkyErhoL/FpHZnAp3tWl8h0jV2N6hBfUFtoq9LUop8lnk/LlwHixka8ArlYwae/RMBSlkuD2hXcfcGslKLsCZhRIrCUkBIpxRiI3tvt63YpWZJKcBLn7gewHnoOsuXWZFmOUyjHTtwx+UsQQLomWaQWkjsK/xTsnxlBV+IdYFaw6MFLjXQ0HUViGKb41qFlphpxD86pXcxdYE9WhGTt9bq0pBNu2wMJAEQLHQJpACWtMMYDX7VRxduZtaZZuAg/nqWyxR1vWooWYhKPbj10tROpyHiqF6JZ2zVZUI6s2ZmdAN7QkyN/VEtodbBCETJHxQJn8Gbq5/fMVwhLLwuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.10.23 09:36, Qi Zheng wrote: > In offline_pages(), if a node becomes memoryless, we > will clear its N_MEMORY state by calling node_states_clear_node(). > But we do this after rebuilding the zonelists by calling > build_all_zonelists(), which will cause this memoryless node to > still be in the fallback list of other nodes. This will incur > some runtime overhead. > > To drop memoryless node from fallback lists in this case, just > call node_states_clear_node() before calling build_all_zonelists(). > > Signed-off-by: Qi Zheng > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index d4a364fdaf8f..18af399627f0 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2036,12 +2036,12 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > /* reinitialise watermarks and update pcp limits */ > init_per_zone_wmark_min(); > > + node_states_clear_node(node, &arg); > if (!populated_zone(zone)) { > zone_pcp_reset(zone); > build_all_zonelists(NULL); > } > > - node_states_clear_node(node, &arg); > if (arg.status_change_nid >= 0) { > kcompactd_stop(node); > kswapd_stop(node); Probably worth a comment. /* * Make sure to mark the node as memory-less before rebuilding the zone * list. Otherwise this node would still appear in the fallback lists. */ Acked-by: David Hildenbrand -- Cheers, David / dhildenb