From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C9ACA0ED3 for ; Mon, 2 Sep 2024 14:30:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 730868D00E2; Mon, 2 Sep 2024 10:30:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68FEA8D0065; Mon, 2 Sep 2024 10:30:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5322E8D00E2; Mon, 2 Sep 2024 10:30:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2E59D8D0065 for ; Mon, 2 Sep 2024 10:30:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C6F86A8367 for ; Mon, 2 Sep 2024 14:30:53 +0000 (UTC) X-FDA: 82520034786.04.F127490 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf21.hostedemail.com (Postfix) with ESMTP id D1BFD1C0029 for ; Mon, 2 Sep 2024 14:30:51 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fxF3Olih; spf=pass (imf21.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725287404; a=rsa-sha256; cv=none; b=wkb5LZ8iaTi01qYksEZq3qezvomJEuz3oBg6gsF+37zI/HJ5YRKpKov3gdtn4zPbEQ97yn f8//7u7w1DL7GklH2lZ+PzVdxOJw73cxqREnVBLxznxBuyDDBrsicCf+pVkcwjGDr98OyB mlWyC57JWdTQfa1g6J6SjMSTwUYeSys= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fxF3Olih; spf=pass (imf21.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725287404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWWTjaMW9Ko+2AruYroLKFk93sCipLt90Wh5KGJSmPQ=; b=yYIxg50d4myFGmIDLApD5daKLT4XmRGD61Xyqs7TpY/0vk/DXgGrlq5SlOn9x2y3AEh/Cc IXvhZk53EdrMV+VB4Y6QSjitQY1NKcGFeRmAnjJAfdfqsbIgjQgK/60kSLMlq2QPmBJTEu yGQVyjMB4inBMhYIRmD1/9ISywLYNfQ= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-457ce5fda1aso8589131cf.1 for ; Mon, 02 Sep 2024 07:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725287451; x=1725892251; darn=kvack.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nWWTjaMW9Ko+2AruYroLKFk93sCipLt90Wh5KGJSmPQ=; b=fxF3OlihhGOb9XcOp7EtrQ5GGZ+YtN4ssB/C/Zy0k6MF4Sau3HPyhUU7ct392fiEkj 89NNvsbC7JW7qldmzwI6Scpg+NLzw6deWwJ9k72e9uHBat/vNX8qYz5+AJkZy/AVdKg7 wEgq1j9rsQ6OKdzp/MJGJBWb1uXC9PP32QWrWnwWhDf7eqapYIk07ZoyzUESlk4VFaXH GLwd1EOed0xdMaRONq63DL7VGVvxAP8Oc7tqBO/Y5NmQlKb6SispucensZ4E2u0Qn+59 vNQ5VztQRqhgjsOuxS/Q24ABt0ewEZVtclM++J6WNdXP0fuQ8CQ6AgfVGOp8r8CSeLPz Fbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725287451; x=1725892251; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nWWTjaMW9Ko+2AruYroLKFk93sCipLt90Wh5KGJSmPQ=; b=VkP1z+EtsRxLzFbBx4xXSd815QvirWngQTMWnXS26tSh5hYZK7GSl6buzb5CT7Ev8B mpbP8OqjdilX+i9H9c0yiYsv6smncDmytqMRCnIe7fdSwRmk3Ypmvx4ObW03Lmc2jxyZ dG1lDMNklZzcMieMnlu2R3zZ3DAX8CpSZIsmCoqtlUzxa8hh0EQY3VDIzhd19R8Dpq18 t5hN/r+0GDBJUN2Re2lmkgd3/6YNrje0Hdh4bZXOVa6coG9FUkwvBEYUZ9HUs0vryTMh mQFQocT8dUfOHWF0w1G4ChZWvL9mYfpEr70KBZaAXnZ59SeHjJx8Hz6EKVWpdznAvo9z Vvfw== X-Forwarded-Encrypted: i=1; AJvYcCUC9M6z1OjevE6GiouAdX7VL2mnHtTRtNESgQq40z7xT/bidLc2G8Yjb4+rrSrtxRwIdOQQHyxG+w==@kvack.org X-Gm-Message-State: AOJu0YwpJC/McFYKXvvbThZd06YwJWBCZSGLj2KehPILDHxaJ0NCvZn/ kWsYVjw+bHsh8UK+gAWQM70acKJoIz5cNtziNEf97SeoYq/y4B3s X-Google-Smtp-Source: AGHT+IGv/l7eBJBzS0r0UAuzxt/6jjUp/xvP4dsSMZSBjT+uXKNWAJ1q1y5viRm6+kzthjCbx6pc/g== X-Received: by 2002:a05:622a:5cd:b0:457:c851:8b0f with SMTP id d75a77b69052e-457c8518f3amr91501291cf.53.1725287450619; Mon, 02 Sep 2024 07:30:50 -0700 (PDT) Received: from localhost (193.132.150.34.bc.googleusercontent.com. [34.150.132.193]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45682db8326sm39983191cf.95.2024.09.02.07.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 07:30:50 -0700 (PDT) Date: Mon, 02 Sep 2024 10:30:49 -0400 From: Willem de Bruijn To: Andy Shevchenko , Jakub Kicinski Cc: Hongbo Li , kees@kernel.org, willemdebruijn.kernel@gmail.com, jasowang@redhat.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Message-ID: <66d5cc19d34c6_613882942a@willemb.c.googlers.com.notmuch> In-Reply-To: References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: xhwdhtt85e9xh3ig5zr1b18g6ibm5pse X-Rspamd-Queue-Id: D1BFD1C0029 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725287451-278282 X-HE-Meta: U2FsdGVkX1/NetV7FKldlaSCO/B0cCae4G8mDGUTgEpo83U8gFs9ni1BJdMnhzBY/8K9iSWDtHqad+kOlhw8GeyCalWVHjR8PoDfKZ6Ae5lVVWI8iEiEX5e/TXP4kR+83Y1VtWQJiqIUmv3ezJgxEFAUL8Rs4e/ldU+4GEoedAS65KIEo3BnO7im3QfUIYW4pAOzQYMg/zuR6r9kO4EFHvHWda8kYzWaY3dGs7az5RhDM32baOhMVv9kEgP5iq05HG1a92WE3Pbp7TtactIQCaa9cB1ty7sS+NfdnPeqg67Q3Q3Nmz7zU+9YA0sotWYjhFhWr5ijwudNirFs7hFgHoevEKzBKfnvWPx96Zsx5u2OBSG5Uqj2OCfHpHZho8OBNfnEh8tL9RE9RzqXVXxNCQZj2Ab1La+3Jo5elCsiANeRh0qcFRXEvLRj3HG7cXE0CzshNs3IGV8Z7vEFeJwEi8tscrqel5/8+Y3MLP5udZs7xPg8Zm7z9/PrNXYkEtHyGogQJuFExgKguNosUKwvHHgOq6kvyb1hUWbQNJgMfZw7qzm79TkdPiawSYEju0xnHVh5YUHx4HMh+6R7lJBYzzJOTjkf6UQtNnzXnvW8hNfuo0DhrijVAqL9IQQFeuIHyhSacYCAuirDk+kWFfaFXMW3E7q0PVNPOnn7fVPZEbkido5jQlmQQiHhpQfERepAMi4a17DVtR18/tyBN7CE2uUDMv61HIWyVe7L+QkFfIH67J9Tje2VWa5d35InQlZEhEfV4md/Zy9Ue1kXrbd8nb/QmyRHUT2UgT8nNEIYH+dX+ecNkmiAv8X+DfpDnmy9dfi0uxZBjce1vBmhC8/kZplkO6bAdTIRbnbqidFBAQtPcbKWZWvAhVhbEQOnn0+vOrxNiHTautkU4R7Eo7IMFD6Ei61spYXnTah5Zlk/1a4pmwgYVYLg1X4SQy6ULzYCU5M7hTiSHtWRrhM7JwP S6v7Mk8U zkro7XsIt2tyxYfKtoaFUdUOj5GsLeSqEc764UCscHgMWtmsPi52s5Y4DpiOjyxndFyPV0KlkZRPfiky89+EVjnhlljITI6I+yWmXc9UrKLkBJzd9jzaVUflD76vEabNq8MdkciLIttbZx/hG8fQmtPiRSyVekClmHzDz//g21+JyhceSUwHIChPdoM5NOoTHpJ3GxnXLKOfv4+pwtv5/qSl9wuISkU4WSfm5Rd9IEbDNJcG7L2cITVFh60ydr+Wt9PXQ5kGM4heDXPV7XpwM/eu2v2lSRI3tS/U5RlJAX8F1QsQgbLIKMjincQG/E18Yl5UIeY595pyZRnvxtDYqqZpjxKk5uXvSmNDuyI/o58tAJz6Ps4JAPELi0d6tAU89hVkXsrTEQmw7do7PQfOaSYQHc9iAXWBa7okQTgY6HgJ7gAf9Z25VblyeT30VFb9ft3gQ6H/3oWyljvAf8bWXIeoC+EXJ4YoqK84AIRjdNzXzF4nJPkBsOBpoOqDnfamFDhAkFBg54bjZFHzc2vfqGXs0Nyij+67W152J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andy Shevchenko wrote: > On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote: > > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: > > > Use str_disabled_enabled() helper instead of open > > > coding the same. > > ... > > > > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", > > > - arg ? "disabled" : "enabled"); > > > + str_disabled_enabled(arg)); > > > > You don't explain the 'why'. How is this an improvement? > > nack on this and 2 similar networking changes you sent > > Side opinion: This makes the messages more unified and not prone to typos > and/or grammatical mistakes. Unification allows to shrink binary due to > linker efforts on string literals deduplication. This adds a layer of indirection. The original code is immediately obvious. When I see the new code I have to take a detour through cscope to figure out what it does. To me, in this case, the benefit is too marginal to justify that.