From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95684C3DA4A for ; Fri, 16 Aug 2024 05:01:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFB366B02BB; Fri, 16 Aug 2024 01:01:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAB916B02BC; Fri, 16 Aug 2024 01:01:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD6A76B02BD; Fri, 16 Aug 2024 01:01:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A96716B02BB for ; Fri, 16 Aug 2024 01:01:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2EEA71A1433 for ; Fri, 16 Aug 2024 05:01:19 +0000 (UTC) X-FDA: 82456909878.06.B845A0F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf18.hostedemail.com (Postfix) with ESMTP id 569DA1C001D for ; Fri, 16 Aug 2024 05:01:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SlvJSdYo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723784401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9DjrwtEn/r84lnrGlJOwmyQMmLCxRFrg2FlgpWL4lQ=; b=QjevxYqtwC7uBPnV1wwjgJ1OuHOMwWrm5foDbcX6gQFIwA4Coh6JziTGVXpQu5mBGCfuzf DXn08qovb2uB7VyJ6hLWPSQxKnLeuq/0YJUxwGss9UvQnyW5fsTUQWcuzEqyUq28AGGUtP HPaNR8ILvwpR1IAxvKqeWeA9PLJLyh0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723784401; a=rsa-sha256; cv=fail; b=8WHb19B29oAJQtnkerXTfvvP7FZHUATA0zfnIkN54rh/HtoiAvuGN/FCRZQ/yfb/tlrDWO WlrI73bmyPh1OVIC6Ii2rZLeDiNeg0cCHFNDAYg9+oU/ryi6z/SbY4B4IrN9HNnEtgJQtJ xOU+jLmCuNTfYOu+FB+qwzB09u5dtDI= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SlvJSdYo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723784474; x=1755320474; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0j3wMV9YiAA7LLiBls0Dv4GCmxUmRHoS2FP7j5jmARQ=; b=SlvJSdYoZtvmOjgtDTkXKehTp6ptyujdpFd6VMqaBIBNoc4RvCgN0swK F9QXfPvneT0C11wtnih+NUHps6v+ZzPUWd2pDtk53ylczgsWmAycf6Txs tNcYVji++7ClpbuEvSQrB1bx7KO52QZJy1RQAXxHaTYs9JBY0u1ds+RkD mqI25y3uLxdEJWAZgVMrBSzejIfliUGGzb6cVutDtM7zA58heqPlussrE IuB6ttQJrQtKlabKnurY9RTLfI3XHZYFRGRCI3+qlLX0JXTFpmZMvK6jd YgtC1n0jVE22/XSYzf5VeTR1twCv4B34swdod7ZJW+/ZfSJFrYEw1A68n A==; X-CSE-ConnectionGUID: MBakFjHEQRq5nlz/WAZtrw== X-CSE-MsgGUID: cchU2HGCTEGBlKNF0JhLrA== X-IronPort-AV: E=McAfee;i="6700,10204,11165"; a="33483268" X-IronPort-AV: E=Sophos;i="6.10,150,1719903600"; d="scan'208";a="33483268" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2024 22:01:12 -0700 X-CSE-ConnectionGUID: erDSir0cTsK2yTjrpRF1yQ== X-CSE-MsgGUID: qa1kK/M0QtqUcWrH0mbZyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,150,1719903600"; d="scan'208";a="63976065" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Aug 2024 22:01:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 15 Aug 2024 22:01:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 15 Aug 2024 22:01:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 15 Aug 2024 22:01:11 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 15 Aug 2024 22:01:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dpMyaqZV+y/jYA4f0OIAAsEjJWdPLp654nFCaEEgHbiXySEou4Y6ULFgqtgLS4dEhxMOC6KO9ZuXOZcKqS71G36gsaJoYtZ+NJSEtbjrXLc0sfKub/KMFp2ChG5O4MMvv04h0rvm75bFCKHdbBClK6JCgxpP0XOOEMHe/JejB3isOgqTpHTUP1xYH767BFxVftEv9zxwpZVpUvnpbQQaPRw+fuVWWVZgX+Q2gMRP/J2QESGyg74XIcKfpjtOU+sjZj+2yYAa8nmL1ZG+ojh3/zqat6RmR4HufMGQAoNyDnA2pVfzIh2ozKGmW4hLCzKNq76/h72O2g+fCEMOVFR4xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a9DjrwtEn/r84lnrGlJOwmyQMmLCxRFrg2FlgpWL4lQ=; b=oXYQ/as06W61Rz0qkTS5aCkwQEEVE8K3VKWv54u2FuA0nn52+usPd1kWtbkq/j/bo/IBmIbqeG1yCN9tkte/O1MOOpSa5KqSjUSCSbjCeH4QLrHgln+E8O4BvX8lrhzbfBNFyGkC7spXEpvHaGzFlKK+WhO9/OyzKzOlsib1zjNsL+975jn3BaKAeVOowZA7yghEmrDsRMcWh38Tr1yj7/SeDbS40Xr25K3DhzHfGJyEfJ3KFS7x5BWIAqONQb2E5Jx/ypGIoHhs3p83ogWlzgVIvfoVy6S46w1glThEl0Ik9KdQ8rbRvHUnnSGDTLRptDR9uVASUvttBiqEHTihLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by PH7PR11MB6355.namprd11.prod.outlook.com (2603:10b6:510:1fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Fri, 16 Aug 2024 05:01:07 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%4]) with mapi id 15.20.7875.016; Fri, 16 Aug 2024 05:01:06 +0000 Date: Thu, 15 Aug 2024 22:01:03 -0700 From: Dan Williams To: Huang Ying , Andrew Morton CC: , , , Huang Ying , Dan Williams , Davidlohr Bueso , "Jonathan Cameron" , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Andy Shevchenko , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH] Resource: fix region_intersects() for CXL memory Message-ID: <66bedd0f746ab_1c18294b5@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240816020723.771196-1-ying.huang@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240816020723.771196-1-ying.huang@intel.com> X-ClientProxiedBy: MW4P223CA0005.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::10) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|PH7PR11MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 44d934e8-aa92-4081-9d43-08dcbdb06fa9 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8646btPI3WJ9H+qa75iSMsiNI1O2zBB+8yo1RT94W8qMxh8xMfnotHob7YbN?= =?us-ascii?Q?R/L7igrO0Dfr5s04bWCn8RR8tbfABjejZTqjtYDnaqH0Xl0TFGpNWAi9eaYu?= =?us-ascii?Q?/rFifMYERLIoP7z5PzEH9U5Im8z2On7vGrwoH80B/ijV42oHU5/Ol0/3qy/6?= =?us-ascii?Q?uYk5qhrFM8KmZQ8QoQ2pW7xtBXXYZxmI63mlKlOqd8muPjejxSak2vP6jboB?= =?us-ascii?Q?bqfobZX7uoIJtGJxaBvNm+5bwxKeAlnWBNQpnGjL6ZkmZB0LYA0fO3tc1Y3W?= =?us-ascii?Q?KMpEpe6AGCfwJZxBwzmV296CG9Svf/Dwsfkkxt9vdF+ftSL7oFsZMMV363ff?= =?us-ascii?Q?smKYD9rCKA+LUJkcb6zMbxVVdFzlf8QXxaXLA3nK4mo5fR6fEi6kLyU6ArBf?= =?us-ascii?Q?PWUTmvXet5klHQ+DDTjsZOrMfJvgrY19IU4kLu8F3i7qwlyH/8HJq6P5g/ju?= =?us-ascii?Q?32D5A69A1DsvKHnU7JrcT9nwHQoNbfuyjiF0NRKaW3VAHrAu9swOfYfWO2RQ?= =?us-ascii?Q?4pM5JB5DE/O/QMxjylyThhnqMw2YTAD6hdjMFKBJzUFHXnJGm5YNvlquqTV0?= =?us-ascii?Q?o0ZtJWCWKY5lN1L2zX2Wo3Cgj3dx0n/gz+Yk/UXpWoBDILNGs6JgyqzKGnbC?= =?us-ascii?Q?zRi6t2bT5cvZgHW/9DRuEYPiibcpGdXdugRQbRGBALe+3ApRSvHNcBCn2891?= =?us-ascii?Q?cWLrQDnPb3CMVnwmCrUZEdrPZZTBy9TBAcRlTUixATTjsTnqyP0InIXW6oeN?= =?us-ascii?Q?1N6p7Q83LCUgyh9AtAzlxtlVrINCUbc6DrFKyWSPjQ6Te5I7wwgEoTCvct2p?= =?us-ascii?Q?UbjljVsIvUjST8Nchfj6jA/DU7OXmvCjQ2e02WBkKgj5Z6UZ87oAJ13TWVEk?= =?us-ascii?Q?ge8hvV0bqOvaT5bBWIgbI9UjTM7j4c9D6FcBq/QqvNRQQwJtzWGIlkGRaJRl?= =?us-ascii?Q?zEeuCm0drXOIq39FHuLDVeedPf4Nuj3pcpJqI7AGFk9tTcC3/5zScU+p7Zs4?= =?us-ascii?Q?0Wj7wyrKw/YONgQoUwfdtwBJpfektZ4QYdUhSqm3p0PDeeQJEaJzMhfv0taa?= =?us-ascii?Q?pudHpHzC2hv+VVH5n56a2AnKcPM/79Uvvz322ixZFMuiRobJ9iPTNUoFJagq?= =?us-ascii?Q?vTKIKGI3jNvbRJZ8WhmXJ4jg88APYQTHHJ2pAdPjBpz2egVfLmkGOmw40RYb?= =?us-ascii?Q?JuCkX+UQp+V4KUauiYcx3wOb8I3ipipz0Jhx8tZIK/eW9PqlmoK6ic/UVcPb?= =?us-ascii?Q?5nfadlmr84ZKqLSq4IVsKTGJ+l21SXB1rpTa157nuA0/r6MWmPPiF/OSdSyy?= =?us-ascii?Q?AoBJcCG56aAANpwF4c8MbAbFN22j54wv9Zy7ycVapgxafg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L/Al9HcAdA45+CoaPj8JsImTa1vj8pv6kAaCKs7z4HibtM3UQ0GZa2odGrpa?= =?us-ascii?Q?AIefnQTgWJOENhO3bcN4pcZTUlQcCjkd4KO5MF4zIgWtheEM1NljlouVyXrs?= =?us-ascii?Q?DtFlxvx5vma5frD2MDx9IgWN0CzbT1nqNshliz3R3QJES5ubzYbtJcQkL8pN?= =?us-ascii?Q?7bVwVB6T+14m4SYIAX5EN1eBDydnE+w2Cq7Uw2+cjNpHrSGRDirBByjrb9vk?= =?us-ascii?Q?yERUu+iO549PItRQeQlL/EOExYS3OOebB0ru1BxL6l4m8Oe4RQxympviKrvT?= =?us-ascii?Q?+Vhkap4xwJP/I16ymvbgPuD/T7aBGqXulyeGaD+eFnsHOBOiQlJUZcNUJlGk?= =?us-ascii?Q?ovsLQkGhSO5/klhxG+iite2UWqBg935X3hF/dHsAwGriI1kOgIvaHV5kRfLQ?= =?us-ascii?Q?LDyrkqjvIK4u09Dzuh+gEJ4fCUjtGt5uzBr+AfzcBrDSt0HBP6ccm8xdmSy5?= =?us-ascii?Q?A88zQ37OoXwX8IwM7NfNLxdDgN6vQh5W2OsYz2rO23NR6NHHEb5FiDi7ZlnS?= =?us-ascii?Q?6d7ZcxD2Mn8s02WsGhec9bgqwbKYjLNLyNTrPA/Bz3mGRf+J+niwsDhvJ02e?= =?us-ascii?Q?gTJLZUpfLt9GGMT3+mOdvIpmiiXs/tMZIuN+Z4d+EXeqaSJb9CJVOZSJpW3k?= =?us-ascii?Q?DAd+wTnnkZ9YAbwr/U6G/mxvSvz4VKfRs/syYFfqz1p0S4aNva+cd8hu7YIO?= =?us-ascii?Q?mJwr0b2mCLmjmaghwhCSj2RV7NDoA+tDTyr+aXSTueVKyiyU4i2najafW84Z?= =?us-ascii?Q?7Z1h7QXL1P4eXWpigYnd4njUDPQdbJ90t+niYNK70zVMYkSdxaYWizOMpfOv?= =?us-ascii?Q?bsCmVGh1JF4hIDzl3Z+8QX3yc1QPkuniyp1Lp7guvNGgZuaMcg09CIm5HSHL?= =?us-ascii?Q?EmhqHTClwbXjCgJIX2ckvda0mBhPUTgDPqW9I82Ks+ZzMBY3f+ddZcuAuSqh?= =?us-ascii?Q?Snz69A0XlFErvsJP/RgcYUG7pnTBd7rDGnaRVacdGjCwqIHmFsahuwxcO84l?= =?us-ascii?Q?mlV+kgpGF3l2yQrk/hFUBndGGQ5tgVfZLBugGWyMrTQlsVLDdGf7iB3nOoNV?= =?us-ascii?Q?EiBblhYIh2pYDM4RFKi1H1TdAMvRZuCjrYZ0lEvL1ZcVfHRbL1D158lBBF4Q?= =?us-ascii?Q?aNWCbMC8XVH7lnhf48jkjQ6rzw/uipGZrsYvxJlbH9j/O5Xy52OSZ1R8wKEE?= =?us-ascii?Q?16nWh6GhHHXB85/W1/WQYM0cgIjUfky4whCUWC4DTCvm0bxaOYv4uOqYlWum?= =?us-ascii?Q?pO0twCCmXCnwdUB0h9uSjbY9HPKV6OdyGsxYI8kC78MXI4d507C8TP7Y0bK/?= =?us-ascii?Q?wCjFcAV3rXEa0AYe/Y1AAU1PO5HarfD6KlGcPok1ZUOyxOgnh+dzS2ngf/DU?= =?us-ascii?Q?Nv38sj0KIhfbvm755bXyt3LbeEEY0RC0BCGLqimIaMvc7xrSGpjxyIN13Fro?= =?us-ascii?Q?umSp4V48An9oyXzn5GIi5y6AR0BEwpm2+h0p+URS9RJ+g9P31o6aTnHOJdp7?= =?us-ascii?Q?8JxRtv4+DRyblE/f74rFEbY1wf3eDqJCrBJRmDSfgHuiJfacoKhP9pcDihgo?= =?us-ascii?Q?Nfb5/vH72ypz+0qyji1t2Vb8FxOgi6yaEWEs0R0O7hVKZQ0vaJHvqJj/z+9K?= =?us-ascii?Q?6Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 44d934e8-aa92-4081-9d43-08dcbdb06fa9 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2024 05:01:06.6294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5HzAjKDuFkZkCSA095uqQY0yGbHVph+17OSex08hvQ0tX6vcp23hsR1h5d9ueNSzMPc66fpyw8/rBWAoRgoRTVXfsnNhR/6g307OeOacnDg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6355 X-OriginatorOrg: intel.com X-Stat-Signature: 61ofoxcsi8kry5pkue1cgiojfptby1ar X-Rspamd-Queue-Id: 569DA1C001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723784474-37767 X-HE-Meta: U2FsdGVkX18+WogNzXmaQXiSHCOzrwpzWNLPIlKt5fyCDCKmm5HkaLRIXq9PXOT9FaKaBTU76D59CdGsqO0WR9zw0nKeFPUO1tpMy/XWlMXUDtJOsGLrclnomRpCB4CNHARV4VOAVE4V31q3/KsJUmiw83S4zf0R5WN4NBM4q+5XMFn07UM3FFbZESfmZebbdtM+PbmsoKCJo2SQRkqOGneqCOumvhuhiu9LQPwnsJGnhPn1ssLJwV8dXBq64OKTMB9981qCvKW6MMFTDt7HJEoNPExy/GZY6nrdSz4w/L1PKE+xU55OuESpQegbLYSuOE0cDgxdF+uj5uLIzsq9p9uirRlDOVD01TP1+T0kpQn5+GJ8Qg7n/RqEu86PKobVQroOVMR9B/IluVqgNU2MjbHELjE9ESRSsYlf9NGyUW3mGMIArZUaOf2/De5c2LcranTu3d9qFYg484+JImj6Lu2RkpVCDME3wH3CODpIpDlVg7zbXQW/7DiSd2cifsf/tAoW87a0b2sGT8jzbLGfPJ44i7bgehU/NVbjF5dzLmdpHC/aKKa2k7ztAtegH7NcuCzlOzEGrte9POJ4ZU+1eB9XFYjDMh1yBI4elvqgKhJ1iysaUiyEFRLfpR+jol4/Opa0ldUAbA/NlkVSRQWI4ZhuDBWET0C93ULDUaFzcboCgcxyliUoRKnI/k/7XeVFd4gs6zy7lBfmJVjZSjliOXtZE/g7QVlzlP0QXxXbrTUVQxMpq5Fxka/fTYa9yUh5UkqPcjPq1aBkH+rdn83WznwssiRThf8ea116VAHp9qpKHfStYL5/zwdU2F5vc2/MGCiaGPWpye91H45neq4c4WcLkrSl4KCh1U+DLW5rwhn/czHzYj5RdcxWFRxDx8HZwOCVyPeC69dqz/19lj8EfhBAgNdj9hbTUBmx7jyk+zqR1ckqTYt0PPrlNXXjRfCKUUpmZNuc3+xCui2tzEM 7JDcouUS KtkyTpu0W1oYUyACj9anRhsdrjJjBIRfgkcHOG/411nxOhVTSNCQC7lrqYfOmfJ1hSw+kZlQMzkVKIiZSr67vYM9+zmyVrv8X0MtT9GfYJIRoY0DIjs5DezKW8XvOy505i6D0Mm4oz+qZ4iNVrw1V6Vy/oYk/PUicthTbz2s4oTAGRy/Zq5r29p8GOCxuodhGmHebUGtJtCCrVXCeUlHCrjh2q0lHEwfxMQ+7T4Nj8VYzqan1C3qPvL1aqzTHa/EPlqfyuWTiX1x/ENJcMRq+DorgYfXnkZj6UenU0DnnZb0Y+lPjao/isTS9QrIpmAkBNpPrn/LjxOzWFPhWPy8xAYFrGBVSTxf4xGIFK6WLkWhJagzoQu8EG5Y15ETJMAD17aevtp6bAOoMBFFnb1LXQT0VYVOIVnVUtys+2VFomIv9Jir0D0qbr7MvrptNcBScUvJ638X5E+ET3XFBHnzLV7FMeqICvlZNiK6K/pPQZSoZSoi/h+JukSD0cGiyL+FJimlMmQy4QaEkXSiWut5qaJFtiZHWhB4ndWQ8WW29ZAzv7TsCbPK3Y5+MqX/vB49IkmN/+x2pwS+FfJcimLW/tCHgM58Qdjp4aJA2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Huang Ying wrote: > On a system with CXL memory installed, the resource tree (/proc/iomem) > related to CXL memory looks like something as follows. > > 490000000-50fffffff : CXL Window 0 > 490000000-50fffffff : region0 > 490000000-50fffffff : dax0.0 > 490000000-50fffffff : System RAM (kmem) > > When the following command line is run to try writing some memory in > CXL memory range, > > $ dd if=data of=/dev/mem bs=1k seek=19136512 count=1 > dd: error writing '/dev/mem': Bad address > 1+0 records in > 0+0 records out > 0 bytes copied, 0.0283507 s, 0.0 kB/s > > the command fails as expected. However, the error code is wrong. It > should be "Operation not permitted" instead of "Bad address". And, > the following warning is reported in kernel log. > > ioremap on RAM at 0x0000000490000000 - 0x0000000490000fff > WARNING: CPU: 2 PID: 416 at arch/x86/mm/ioremap.c:216 __ioremap_caller.constprop.0+0x131/0x35d > Modules linked in: cxl_pmem libnvdimm cbc encrypted_keys cxl_pmu > CPU: 2 UID: 0 PID: 416 Comm: dd Not tainted 6.11.0-rc3-kvm #40 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014 > RIP: 0010:__ioremap_caller.constprop.0+0x131/0x35d > Code: 2d 80 3d 24 6a a1 02 00 75 c1 48 8d 54 24 70 48 8d b4 24 90 00 00 00 48 c7 c7 40 3a 05 8a c6 05 07 6a a1 02 01 e8 a3 a0 01 00 <0f> 0b eb 9d 48 8b 84 24 90 00 00 00 48 8d 4c 24 60 89 ea 48 bf 00 > RSP: 0018:ffff888105387bf0 EFLAGS: 00010282 > RAX: 0000000000000000 RBX: 0000000490000fff RCX: 0000000000000000 > RDX: 0000000000000001 RSI: 0000000000000003 RDI: ffffed1020a70f73 > RBP: 0000000000000000 R08: ffffed100d9fce92 R09: 0000000000000001 > R10: ffffffff892348e7 R11: ffffed100d9fce91 R12: 0000000490000000 > R13: 0000000000000001 R14: 0000000000000001 R15: ffff888105387ca0 > FS: 00007f86c438c740(0000) GS:ffff88806ce00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000055ba75b1b818 CR3: 0000000005231000 CR4: 0000000000350eb0 > Call Trace: > > ? __warn+0xd7/0x1b8 > ? __ioremap_caller.constprop.0+0x131/0x35d > ? report_bug+0x136/0x19e > ? __ioremap_caller.constprop.0+0x131/0x35d > ? handle_bug+0x3c/0x64 > ? exc_invalid_op+0x13/0x38 > ? asm_exc_invalid_op+0x16/0x20 > ? irq_work_claim+0x16/0x38 > ? __ioremap_caller.constprop.0+0x131/0x35d > ? tracer_hardirqs_off+0x18/0x16d > ? kmem_cache_debug_flags+0x16/0x23 > ? memremap+0xcb/0x184 > ? iounmap+0xfe/0xfe > ? lock_sync+0xc7/0xc7 > ? lock_sync+0xc7/0xc7 > ? rcu_is_watching+0x1c/0x38 > ? do_raw_read_unlock+0x37/0x42 > ? _raw_read_unlock+0x1f/0x2f > memremap+0xcb/0x184 > ? pfn_valid+0x159/0x159 > ? resource_is_exclusive+0xba/0xc5 > xlate_dev_mem_ptr+0x25/0x2f > write_mem+0x94/0xfb > vfs_write+0x128/0x26d > ? kernel_write+0x89/0x89 > ? rcu_is_watching+0x1c/0x38 > ? __might_fault+0x72/0xba > ? __might_fault+0x72/0xba > ? rcu_is_watching+0x1c/0x38 > ? lock_release+0xba/0x13e > ? files_lookup_fd_raw+0x40/0x4b > ? __fget_light+0x64/0x89 > ksys_write+0xac/0xfe > ? __ia32_sys_read+0x40/0x40 > ? tracer_hardirqs_off+0x18/0x16d > ? tracer_hardirqs_on+0x11/0x146 > do_syscall_64+0x9a/0xfd > entry_SYSCALL_64_after_hwframe+0x4b/0x53 > RIP: 0033:0x7f86c4487140 > Code: 40 00 48 8b 15 c1 9c 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 80 3d a1 24 0e 00 00 74 17 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 58 c3 0f 1f 80 00 00 00 00 48 83 ec 28 48 89 > RSP: 002b:00007ffca9f62af8 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000400 RCX: 00007f86c4487140 > RDX: 0000000000000400 RSI: 000055ba75b1a000 RDI: 0000000000000001 > RBP: 000055ba75b1a000 R08: 0000000000000000 R09: 00007f86c457c080 > R10: 00007f86c43a84d0 R11: 0000000000000202 R12: 0000000000000000 > R13: 0000000000000000 R14: 000055ba75b1a000 R15: 0000000000000400 > > irq event stamp: 0 > hardirqs last enabled at (0): [<0000000000000000>] 0x0 > hardirqs last disabled at (0): [] copy_process+0xb60/0x255f > softirqs last enabled at (0): [] copy_process+0xb60/0x255f > softirqs last disabled at (0): [<0000000000000000>] 0x0 > > After investigation, we found the following bug. > > In the above resource tree, "System RAM" is a descendant of "CXL > Window 0" instead of a top level resource. So, region_intersects() > will report no System RAM resources in the CXL memory region > incorrectly, because it only checks the top level resources. > Consequently, devmem_is_allowed() will return 1 (allow access via > /dev/mem) for CXL memory region incorrectly. Fortunately, ioremap() > doesn't allow to map System RAM and reject the access. > > However, region_intersects() needs to be fixed to work correctly with > the resources tree with CXL Window as above. To fix it, we will > search matched resources in the descendant resources too. So, we will > not miss any matched resources anymore. Thanks for this Ying! I think this needs an explanation of the expected semantics of region_intersects() and maybe a fixup to meet that expectation, see below. > Signed-off-by: "Huang, Ying" > Cc: Dan Williams > Cc: Davidlohr Bueso > Cc: Jonathan Cameron > Cc: Dave Jiang > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Alistair Popple > Cc: Andy Shevchenko > Cc: Bjorn Helgaas > Cc: Baoquan He > --- > kernel/resource.c | 44 +++++++++++++++++++++++++++++++++++++------- > 1 file changed, 37 insertions(+), 7 deletions(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 14777afb0a99..c97a5add9394 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -542,18 +542,48 @@ static int __region_intersects(struct resource *parent, resource_size_t start, > { > struct resource res; > int type = 0; int other = 0; > - struct resource *p; > + struct resource *p, *dp; > + resource_size_t ostart, oend; > + bool is_type; > > res.start = start; > res.end = start + size - 1; > > for (p = parent->child; p ; p = p->sibling) { > - bool is_type = (((p->flags & flags) == flags) && > - ((desc == IORES_DESC_NONE) || > - (desc == p->desc))); > - > - if (resource_overlaps(p, &res)) > - is_type ? type++ : other++; > + if (!resource_overlaps(p, &res)) > + continue; > + is_type = (((p->flags & flags) == flags) && > + ((desc == IORES_DESC_NONE) || (desc == p->desc))); > + if (is_type) { > + type++; > + continue; > + } > + /* > + * Continue to search in descendant resources. Unless > + * the matched descendant resources cover the whole > + * overlapped range, increase 'other', because it > + * overlaps with 'p' at least. > + */ > + other++; This results in REGION_MIXED whenever the target of the search is found as a descendant of @parent which I believe is unwanted. The semantics of region_intersects() has always been within a single sibling level to date. So, I don't think @other should be incremented until @is_type is non-zero. It follows that if @is_type is set and !resource_contains(p, &res) then there is no point in descending because it is known at that there are no descendants to worry about. I do note that with those changes region_intersects() will start reporting REGION_MIXED rather than REGION_INTERSECTS when the passed in range intersects a hole plus the target, but I am not aware of any code path that expects to ignore resource holes. I.e. better to report holes as occupied in that case. Lastly, it would probably also be useful to special case the "@flags == 0 && @desc == IORES_DESC_NONE" case because there is no point in descending the resource tree to look for additional holes. Those are all visible at the top of the resource tree.