From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B064C3DA60 for ; Wed, 17 Jul 2024 20:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F28456B0089; Wed, 17 Jul 2024 16:14:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB0636B00AC; Wed, 17 Jul 2024 16:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2B0E6B00BB; Wed, 17 Jul 2024 16:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B205B6B0089 for ; Wed, 17 Jul 2024 16:14:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 64392818A3 for ; Wed, 17 Jul 2024 20:14:20 +0000 (UTC) X-FDA: 82350346680.04.CF4E7C8 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 6C724100004 for ; Wed, 17 Jul 2024 20:14:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SfjSFlR9; spf=pass (imf14.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721247219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=daNuErFTSxwNgtYvkZnLX9Xo2Y1uZdZanNQORu0umVM=; b=CeBSvZ1ITdGBNVA2AZ1FDh5a3uBIDpIq527R7xtKic52+NVcwrz/lOj5VQ46+LRZxQKlGS fp5Jcj4ouMBdW9spTNq8yDBOmIhTtG9p+53ajWWxSK2MKeqhk4/GZVcd3VH8eacVkAtzil sTs2j17mM98cljrb9MdDo7qjJSngJIc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721247219; a=rsa-sha256; cv=none; b=ZvCOErmIhar9hoK09sZWZoFeL45y6WlYQ0ROOOLka+eep0t5AfKC/PmzqUB5hdehDVrwND MRuFfL4pRJAUJa2kRJiB3TWXjCi8f5TOQ/wRbKOQ0SvU/VHHzUMg1vGdywUUQqIaWl1Ijq 1qa+40uXxP8JpaGKDwPyO6jfHWDtmhU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SfjSFlR9; spf=pass (imf14.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70af5fbf0d5so31836b3a.1 for ; Wed, 17 Jul 2024 13:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721247257; x=1721852057; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:from:to:cc:subject:date:message-id:reply-to; bh=daNuErFTSxwNgtYvkZnLX9Xo2Y1uZdZanNQORu0umVM=; b=SfjSFlR99EcoruqkNj1a043oDadA+5MOnbVMqr7QIP4quR00juc+95CSxOvLBxs6bt xu7To7GChAE6LgnldMoR6JzBaUFjSW+NjmnOPk7G60eWXkyGmn9M2lmMs4bGkD7vwpM2 W9t7KwyYQhuZeR1sihWxd5j0GUALy2L78cnq1qotVCSsLN3tpbQXhMrIsQkG3y2YWPup hPZ87M/e2m4n0Ir/1sJuuNz3mvJJoJkwVveUXlSGwIQ4pAdd/wQj4df8ksfuJeJoBZuI XUJSbE6SyQRm4stctWtSu1EPrr4gHbBM5CvxqNFGZGsM2w/jafLEvOwnHhyvFIsaCVHR YdYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721247257; x=1721852057; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=daNuErFTSxwNgtYvkZnLX9Xo2Y1uZdZanNQORu0umVM=; b=TWAB+7LVqXvGQasm8Qwr0SDwMR1xuZrKgpvwow4ot40c20/+iKneGv02OD0vw4cDtx apzbzY02xMkbuf7tTPqupNaeg+RHEsx4xPzQfiENYsZVD6HbUGEoezu5VitpY/4v7nR4 hchdCuMQYLx6VlgBQ9fmV3rLgUIDB3EnWATlLfe2PDQVYOjXGWZHFxmXZOJ3TqWLODWg 91BG+m0+5k5BtoubIi3XIiW9OaySNHI9xU4Rr0y/InIKTxVdXeLgyE0c2tAmwROeFUAg nuR0zwaKDGQeInzFVJXkAgAbQZEZ8Mx7ibRSjjQMNKaA2gxY8I6BjM4oKhK03N6CwrqJ wELQ== X-Forwarded-Encrypted: i=1; AJvYcCUc6MTbPgmbn4+xP1KJk2cC9A7lOksMZfc7o8I/USWj83YuC3GrDERdhx0xwAdJmPv2LXi1hzm8HKTfwKYJ1QDxqiM= X-Gm-Message-State: AOJu0YwRAogPovniXBs5iRI6CB0PQP9CEuN0BizoCVuVr3yK8v7DIqiP RqSrcgHxAYyw2yfZqvYAjsbeq5ULTRLdIRUaF9fS34dPKJTgR3n2 X-Google-Smtp-Source: AGHT+IF5kHZANzfmOuN3NHMVCFtUNfv4eZvOTbdQnE/ovfd+OsiFk9AgplhBsKw31KkgMYYXs29mag== X-Received: by 2002:a05:6a00:1ace:b0:705:ade3:2e79 with SMTP id d2e1a72fcca58-70ceebbff83mr1025900b3a.13.1721247256867; Wed, 17 Jul 2024 13:14:16 -0700 (PDT) Received: from gpd. ([179.61.150.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7eb9c861sm8516650b3a.24.2024.07.17.13.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 13:14:16 -0700 (PDT) Message-ID: <66982618.050a0220.e9611.19eb@mx.google.com> X-Google-Original-Message-ID: From: nifan.cxl@gmail.com X-Google-Original-From: fan@gpd. Date: Wed, 17 Jul 2024 13:13:34 -0700 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v9 06/11] cxl/mbox: Add SET_FEATURE mailbox command References: <20240716150336.2042-1-shiju.jose@huawei.com> <20240716150336.2042-7-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716150336.2042-7-shiju.jose@huawei.com> X-Rspamd-Queue-Id: 6C724100004 X-Stat-Signature: c7yw4x618dkxnzgnx9gorifdnkkwxabi X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721247258-442110 X-HE-Meta: U2FsdGVkX1+B0S+90a52z3VT6UcPTzBW36DaZm0yU05DZWa6NhyIW0Gi4NB5Xcx13r5GyetxisyGSrOQFubztCOO7LjsxhTyG7Dyh+syGXoDMMP65cmE22fQs44M9PQ9ciQmDDwcjUhs/+lPBDQO7aRT5UCAjQ1lRv3gTdqhNJ6wJOMQ2kf37/axBr1DqCJyZgRJ1HnEBcb8KDUzRVdH4kJzVFL16VHezURpiKgE0VfPVkVPEzrmoxSzuHPSPyA2kzA81KoJ4TGMf7byVlXVh8SpbJMxLuFNwJ9JMF6al9j7ukoA9uA8wnj7CT0q21pznPF+YA9xYR9EPZFQdKyu/RzKp0XwHZB8Yx/o9RKmpfW5m1M7XiV/iVAY4sFdSSr8oa6Miqg4VCZn6nvyxBSmtRKJ+xyw0FZatAh2wiHJxgJC/hNagqj161duBrF2r48LTIscxDNFxYdQ01SkRYWxBhGVxhv6fdSSg5fUgUbNuIJfX6TgUBwl8SZ6KDmmLdyGGpBMWbdxs1X97dQbSC0uVrd+WruYO9iuV0EvQCCjQ22cu0n5NO5OPSLS/AAlSNy5g6LjAGPvwOPiVzkfW1ErdW+reRyaD2jnyptMQe80R1DU+51tryxapN3EmZXNm2efnbDX1A1eiqgmxPcd6dkboF4ev9lMm8FKN0A5xqc9qCTOyVRlH9huVc1eOTzvQE2zmUhphvn7AHyc+8mzzwetdNPSe1xJjGRSQ1vii63lxIg4U/IRzzam6TdmKl+sqq0/XuFrIgN7CxAtJABWoHp2x0cYBGk7z7gbnbzu9eTZU+23FLoVEdGZlzoKBQBo4GfH6tpl6C1CWqKzRDyM4lXZ1Qpjnz8Ellkmjj1jClGkzQlifYS+TGNQTA7a7ibSVVsMNcb2TlpnTGTEsb464VgFGp/QJmOYvkMRWm22LMvjL4d32TtgD1sTX7i1/cEldohGY0xP2KM+acLv1bDHZvE EpVFM46E IcDWfuJOpzdVNCp91bluSeEubh9poDRnd9fUu2OzFr8St6qmI5fbdapPq2RsVD6TIgu3Sl2xJlE/M28L3CWL2+p+2uICPzJmiRZMsSIQjSwGCOqlGMexpfzo85zlBDYqnjfj4vLRV67OYTRoVN/Fkfb+3xcDgLcDOn7rwkBt7TjRkZ4JFrfSVf01EvUzBhFbkqhWNp5j8YYqurim+xogi/g6DTCw5up9pioGgCrVv9g0Jc9L1IV2+tchZkWRFwRHB/IzS3AxcsuCs23Vj1LegfqaMqVuQxHO/mCNOS6l3yTDNCJHB0L5EWQQQAr4Ot1i90cdJKDnVd/fF6vLur/1e0mHRgQ1i4JP1e/rF46jwlmh6xSiOYA8Tgo39zPgoSgG1XConCBkg6ZnDCmhX7dwzCssm6cSBDRg8r5jFzSLTnvR/M6MxwIEnSt46pXMPA9Imv+P8SRJPHNzHTP7/0jlBy8f7oLBeQr+Vyy2ma3ri6Prw5Om5ccvRgkLdtdu3LoqYyeLK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 04:03:30PM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for SET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices supports features with changeable attributes. > The settings of a feature can be optionally modified using Set Feature > command. Add more specific spec reference to the command here: 8.2.9.6.3. The same suggestions for get supported features and get feature commands. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 71 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 33 +++++++++++++++++++ > 2 files changed, 104 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index b1eeed508459..50ecd2bd7372 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1388,6 +1388,77 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > > +/* > + * FEAT_DATA_MIN_PAYLOAD_SIZE - min extra number of bytes should be > + * available in the mailbox for storing the actual feature data so that > + * the feature data transfer would work as expected. > + */ > +#define FEAT_DATA_MIN_PAYLOAD_SIZE 10 > +int cxl_set_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag) > +{ > + struct cxl_memdev_set_feat_pi { > + struct cxl_mbox_set_feat_hdr hdr; > + u8 feat_data[]; > + } __packed; > + size_t data_in_size, data_sent_size = 0; > + struct cxl_mbox_cmd mbox_cmd; > + size_t hdr_size; > + int rc = 0; > + > + struct cxl_memdev_set_feat_pi *pi __free(kfree) = > + kmalloc(mds->payload_size, GFP_KERNEL); > + pi->hdr.uuid = feat_uuid; > + pi->hdr.version = feat_version; > + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; Although we may not support it yet, should we set bit[3] (saved across reset) since we already defined CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET and it is not used? Fan > + hdr_size = sizeof(pi->hdr); > + /* > + * Check minimum mbox payload size is available for > + * the feature data transfer. > + */ > + if (hdr_size + FEAT_DATA_MIN_PAYLOAD_SIZE > mds->payload_size) > + return -ENOMEM; > + > + if ((hdr_size + feat_data_size) <= mds->payload_size) { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); > + data_in_size = feat_data_size; > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); > + data_in_size = mds->payload_size - hdr_size; > + } > + > + do { > + pi->hdr.offset = cpu_to_le16(data_sent_size); > + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_SET_FEATURE, > + .size_in = hdr_size + data_in_size, > + .payload_in = pi, > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + data_sent_size += data_in_size; > + if (data_sent_size >= feat_data_size) > + return 0; > + > + if ((feat_data_size - data_sent_size) <= (mds->payload_size - hdr_size)) { > + data_in_size = feat_data_size - data_sent_size; > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); > + } > + } while (true); > +} > +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 25698a6fbe66..c3cb8e2736b5 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -532,6 +532,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_GET_FEATURE = 0x0501, > + CXL_MBOX_OP_SET_FEATURE = 0x0502, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -780,6 +781,34 @@ struct cxl_mbox_get_feat_in { > u8 selection; > } __packed; > > +/* > + * Set Feature CXL 3.1 Spec 8.2.9.6.3 > + */ > + > +/* > + * Set Feature input payload > + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 > + */ > +/* Set Feature : Payload in flags */ > +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) > +enum cxl_set_feat_flag_data_transfer { > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX > +}; > +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) > + > +struct cxl_mbox_set_feat_hdr { > + uuid_t uuid; > + __le32 flags; > + __le16 offset; > + u8 version; > + u8 rsvd[9]; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -918,6 +947,10 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, > const uuid_t feat_uuid, void *feat_out, > size_t feat_out_size, > enum cxl_get_feat_selection selection); > +int cxl_set_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >