From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D76C3DA60 for ; Wed, 17 Jul 2024 18:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7226B0088; Wed, 17 Jul 2024 14:08:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCDBF6B0089; Wed, 17 Jul 2024 14:08:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95986B0092; Wed, 17 Jul 2024 14:08:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99DAC6B0088 for ; Wed, 17 Jul 2024 14:08:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53271A142F for ; Wed, 17 Jul 2024 18:08:20 +0000 (UTC) X-FDA: 82350029160.08.9E63540 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 606EF160020 for ; Wed, 17 Jul 2024 18:08:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ifo6L2/Y"; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721239678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SM8B6LA4jj99Kbv5K8wStDsRnXQT55BhF1QFuulRqec=; b=8bICJk8UtSptRBm7Hq8U6tGB/5tHGFSqUrQKbNskFlL5NnAydOphxKmIfx8DqE/C3nGFyO djCKvKWBKf1Pl4Ko10FaUifKOIc4fNcgAmiXr4Awp3xCaqetT57sbroiq8DAidHTI6Zc0H a9LO/IYr7l08LNzEZPN2S269dHeGyMk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ifo6L2/Y"; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721239678; a=rsa-sha256; cv=none; b=pAZPyYeY3G02ix5LZrKvyLk/FuekfTv179uTT9qW4CoyJr7BmyoaJPI3VbHlNmiLEFWR+3 A0Pso5pgu4Y5RaelnuhRtNSFYRvLQ3+VJdxIaAbR6gY9eA/3lL6AsH+QPCLwDT8qCh3Q7H RdtHa1PVwXlQDf2ZPOcBkloK1rIdPEY= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-654cf0a069eso795317b3.1 for ; Wed, 17 Jul 2024 11:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721239697; x=1721844497; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:from:to:cc:subject:date:message-id:reply-to; bh=SM8B6LA4jj99Kbv5K8wStDsRnXQT55BhF1QFuulRqec=; b=ifo6L2/YWD2gqkvQnLOXL49TQnhdIW3MWYOoYGqgWUjviGCYzgAQhc3YQf2DMfbpfK ahj+d40HrT3t2u6lADfgxdRA4XcRb9tl1W8spkKKNJfIP4/rjiWH3+gaxHOI4Ub0LBOq VPghD+ja6De4fSBkYwNFwNOiPumhOHKk07/LaHTTL7SPnEgerYMebLcsh/zHpbEBnaeY YD0cMNNp2/7NLUC8c82DgDzFl2ko+SwKYLe2F6DeIFSKnH3guT0g/8RB53McJaOarfOX 2z6T3UM5MwU3vsAMKnhVidX+SSVzhyqMo5tf08FFRwO5iq3IUQDKk1JEisyozLTQfKT8 2rJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721239697; x=1721844497; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SM8B6LA4jj99Kbv5K8wStDsRnXQT55BhF1QFuulRqec=; b=PmNgqlRvEH+EOjftBcNHAnC6u/7wOD1r+dqdnbR+XTFngM29ZuOgKzzeFmSGSaeScU 2zFgeKs/YnGpvASbaSxzEQLOA72n5gS9h7RqA1sc/mZo+ZhEUmrHRCUXxtVV188zoLZR 2HHrgOotoradZE34akA7fTXlQ8yIMtjF49T40/fU5uhLoZDR2mSDetOL1ws+NcyB1JEF 79mBs1T/z6WOUqWjcJT9D8jNW6V5JklE+Zz/u7C/dAna6zVCd7clOh06iObyz6iD5ZXW aDcA8jqO4wJkK9tgC8tcJbsjDRYkflTvQBc2L68DBKPNl+28UI/rWyMiZfedUOPTEKQG Mrfg== X-Forwarded-Encrypted: i=1; AJvYcCUcIu4OLe4IjTVkkkWQIwN7WvDi0Mo5MigmtR3zR6U0lim6R3VmdQ2Jks+Pq+7mQ+31UDzZMhjl4+XMIB1F4Ahwpsk= X-Gm-Message-State: AOJu0YzXkiUunyzYcB9HMv6TwTnc413+G+xI+/uB1FBfLnBgQh1Ks/br MTx+hBZZh26E8w2VM309vBppfoQ3t8jNcG3feuQ7Tywk1LHBag7z X-Google-Smtp-Source: AGHT+IHQBEBVoCRtBjoPhAyhO3eQWipybCFEBSsjB0FYqh4mtyicuQyDqJ+jopQJCfhOPsbMPIA3aA== X-Received: by 2002:a05:690c:23c1:b0:61a:e4ef:51d with SMTP id 00721157ae682-664fde8015fmr36193407b3.9.1721239697207; Wed, 17 Jul 2024 11:08:17 -0700 (PDT) Received: from gpd. ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id 00721157ae682-66603ed22a1sm187567b3.120.2024.07.17.11.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 11:08:16 -0700 (PDT) Message-ID: <66980890.050a0220.163b98.0210@mx.google.com> X-Google-Original-Message-ID: From: nifan.cxl@gmail.com X-Google-Original-From: fan@gpd. Date: Wed, 17 Jul 2024 11:08:12 -0700 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v9 05/11] cxl/mbox: Add GET_FEATURE mailbox command References: <20240716150336.2042-1-shiju.jose@huawei.com> <20240716150336.2042-6-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716150336.2042-6-shiju.jose@huawei.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 606EF160020 X-Stat-Signature: j3fpa889uutxcgwt35jrh17ykx9iwpzn X-Rspam-User: X-HE-Tag: 1721239698-913494 X-HE-Meta: U2FsdGVkX1/smmCj65hfXGWLRJkoCeE+/Dp9/kjdsuXExeLvIhZFD9Xa9+kqRTXoByuPTX3+gJegfQ9jG2zZ7pz9u3Z2g9y7vIOKeSp6kL92FMNrlklLCZ4G1g1Z9Z9ZGNKA+zYmHj/sTCBfzdK/A0aIuqycEBCqZHLMZQPU0nlpep07e+C6ZG4GuMQ+9BDpeVyDquR8X94bs2gEMn3ZT84KjEEadkRQRDbFbDzQksGiYF/6erYxuaPEMkszcbzM8uHXgDgR7wpYo2BmKG8/5IVJf/ir/k+Pi78M+CWAB9wWKGVMEmavZH3lFtq44NRYs5cTOu9YtNU/eoL/SZQNqE/qCvtX40HE5ZHj6GO6NsH9G2NiU/iCdz29FG+qRPzPhGIaLgmNlQSeREYddlTvSOJ3byKV+DdaWQBGOkTjfP6oKSR0OpnZ2hpe63e9tBXZGCm3IuLl6tsqv7T9tQJtj/s2o/zd7f2s3oLh8g/XLmW1hpIJuiHabonsh2zRm2TRa765qhPc20CL49Gw8Jwkvx7SPO35TJLwrJfTxiJ+Gd70+rNqgsQ18dTx47QzAW+eCc2H1DRoHwRwJodCCJGiVtM/DIvlfzVJgESuW2x7YtvN/zuOjO1y93JsWgJG9SEv3Q9o/KY8Gqav1OdSBq3SnnBiC712XcycRH4oR/kg/d8vejeZ2wFXfFmEFGtiZun/WKzM7wtXHOhtbEOkM8wb/uIDt/EitIfpL+nHX11H28w9ql0GS1rqJ+RzWZvyWTbeZGoca6o14iaxq6MMsUKTI8q/mXL0/wcx8A3+bmOnt3idO+4Z2V1oS8YtNYWrB2JtRTrq99S4Qgcuhtqq2MN6Jn8/Lo3H2cdyhsC1Zh903GC08MUVM9fdYhSzPDd4ZNNRe0ZpCzGf3eFwhQexeRSJRVATB8qVf9YCBUvQHsOjqEs4cHpJ/HhFPm7h8NB+5lZLrAZFlENGQdKoIc5edW8 mHbRAB46 9G64psBq/dJ/0bD8Pg5arD78l42qxi+VI+hfhK0cTpJDehRw3ceJOGBkXFSz51G740kg+ruWJTmNyxUfysjDZmuNwIUKxH6sh/3hhrCDytgkIn70SFx+Ewno/S3GySeAGcSoZo6IvwUIr3b0tFSpt2/UKmmC+poPWpN2R40pCkRmcflbrGvzD14nd9S4VmVdYF0fCwvENu8Z494ca4BhLCAtKj8IAUr9gciB4Ak2wTuCr7FdYvgyRLGFQhGYjPjYsIgbvljy/QPaAuFf+jSNBCEaK9Ak5l9d/bpp+nZRmNpgAp5RMxeZwdTEHlylcsyHlO0awONVXYelifUnqKc7WyuIU5dPNHA+o1HJzl1g30oRSIPqGEjaVuNsC80ZiTfoEm2injEQzpWaqYmLU/K5vtEqvfQ5KE5sUjAnWaHaoH3ixivJwz5C25pXQ60QgnmfP7osBDFIfrE9iMXUW0X4jQHTeJdGyxhPHh+osSzRzHgBeZ2Qi+vti+G5LIJrXye46WUTU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 04:03:29PM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > The settings of a feature can be retrieved using Get Feature command. > > Signed-off-by: Shiju Jose > --- Minor comments inline. > drivers/cxl/core/mbox.c | 37 +++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 27 +++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 9b9b1d26454e..b1eeed508459 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1351,6 +1351,43 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); > > +size_t cxl_get_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, void *feat_out, > + size_t feat_out_size, > + enum cxl_get_feat_selection selection) feat_uuid and selection are both payload inputs, maybe more natural to put them together before feat_out. > +{ > + size_t data_to_rd_size, size_out; > + struct cxl_mbox_get_feat_in pi; > + struct cxl_mbox_cmd mbox_cmd; > + size_t data_rcvd_size = 0; > + int rc; > + > + size_out = min(feat_out_size, mds->payload_size); > + pi.uuid = feat_uuid; > + pi.selection = selection; > + do { > + data_to_rd_size = min(feat_out_size - data_rcvd_size, mds->payload_size); > + pi.offset = cpu_to_le16(data_rcvd_size); > + pi.count = cpu_to_le16(data_to_rd_size); > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_FEATURE, > + .size_in = sizeof(pi), > + .payload_in = &pi, > + .size_out = size_out, > + .payload_out = feat_out + data_rcvd_size, > + .min_out = data_to_rd_size, > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0 || mbox_cmd.size_out == 0) Is there other case when size_out will be 0 other than the feat_out_size is 0? If feat_out_size is 0, maybe we return directly, or we use while () {}, instead of do {} while. Anyway, if there is no other case that will return size_out as 0, we can avoid the check. Fan > + return 0; > + data_rcvd_size += mbox_cmd.size_out; > + } while (data_rcvd_size < feat_out_size); > + > + return data_rcvd_size; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index b0e1565b9d2e..25698a6fbe66 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -531,6 +531,7 @@ enum cxl_opcode { > CXL_MBOX_OP_CLEAR_LOG = 0x0403, > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > + CXL_MBOX_OP_GET_FEATURE = 0x0501, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -757,6 +758,28 @@ struct cxl_mbox_get_supp_feats_out { > struct cxl_mbox_supp_feat_entry feat_entries[]; > } __packed; > > +/* > + * Get Feature CXL 3.1 Spec 8.2.9.6.2 > + */ > + > +/* > + * Get Feature input payload > + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 > + */ > +enum cxl_get_feat_selection { > + CXL_GET_FEAT_SEL_CURRENT_VALUE, > + CXL_GET_FEAT_SEL_DEFAULT_VALUE, > + CXL_GET_FEAT_SEL_SAVED_VALUE, > + CXL_GET_FEAT_SEL_MAX > +}; > + > +struct cxl_mbox_get_feat_in { > + uuid_t uuid; > + __le16 offset; > + __le16 count; > + u8 selection; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -891,6 +914,10 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds); > int cxl_get_supported_features(struct cxl_memdev_state *mds, > u32 count, u16 start_index, > struct cxl_mbox_get_supp_feats_out *feats_out); > +size_t cxl_get_feature(struct cxl_memdev_state *mds, > + const uuid_t feat_uuid, void *feat_out, > + size_t feat_out_size, > + enum cxl_get_feat_selection selection); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >