From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E95C3DA62 for ; Wed, 17 Jul 2024 17:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 116266B0083; Wed, 17 Jul 2024 13:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5DA6B0085; Wed, 17 Jul 2024 13:28:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFBD6B0088; Wed, 17 Jul 2024 13:28:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D00896B0083 for ; Wed, 17 Jul 2024 13:28:14 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7974480B2E for ; Wed, 17 Jul 2024 17:28:14 +0000 (UTC) X-FDA: 82349928108.09.17AC5FF Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf18.hostedemail.com (Postfix) with ESMTP id 86EB91C0029 for ; Wed, 17 Jul 2024 17:28:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g7CVsiJt; spf=pass (imf18.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721237261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b4LfVWMiLU1Ai4rM/MAGdsvR9RjnBD07teo6F43vM9c=; b=Ct7RwzjSVc83gfwEPefUHRDg9U5ESZBDYA55FHfwGKOrp7Zgk7TcxGD5Ce2FkILg2DFlcv uI+dykbljuQAyxMybBHoqr8T9ThTzopruZXFw+gSVyUyAJHRJv6FnU6IhACeF+aVq2rYAD O9hjSs5yl2lLfuHXXH6P0/65YTSAURw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g7CVsiJt; spf=pass (imf18.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721237261; a=rsa-sha256; cv=none; b=2vwpSheEiQh7YEm2F1z4EEXzvTA70d0CioSIrrhsoXeHH+JvI4FxS8pXsGvhg6536Ijhum 4LBnThWJ6x341uNiCzG8zN4s3I3+6Ygh8vkFLZbR+SBxrcrtgUm6f81jN+FeQHRv9SB27O CK+bA9yPunc188VqE5IjE/Hf/iw3k7w= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-65fdfd7b3deso493047b3.0 for ; Wed, 17 Jul 2024 10:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721237291; x=1721842091; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:from:to:cc:subject:date:message-id:reply-to; bh=b4LfVWMiLU1Ai4rM/MAGdsvR9RjnBD07teo6F43vM9c=; b=g7CVsiJt3P+8Pjb/YMUYW+LQ8OWZa/+EXwz4cOuQMzI0+9fXmoVlFcMQsDfu7G/WJj YLWLFOZ0KLLXG237C2J4MoC+sjGz4BM7fXMhBUYjtZCFOBy3KfPRYHjUGNeDZGtrPpQ2 ci7YYqhuejPJ/B3ZfOrCK44aPUAuo1NhHhRr82w++jfjUeHAOZxuzf9fZB/AaEx60ET2 5X2+p6IrpJm3jIpKXTZdlJg46/3suTSBIrFbO3NCLtVPLQMgjZsrGTdMfTR3AAYoL9DP moad5PpP1Tlzh2alC3/hXjiOI9tpHjtnERaIEh6WnfVvYiv+zl3Swo2Ggwulv5J7IfmG 7t3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721237291; x=1721842091; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:date:from:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b4LfVWMiLU1Ai4rM/MAGdsvR9RjnBD07teo6F43vM9c=; b=VUKwd28N1TXL0THV+8e6L1bsTOxHSZBXVsCa2kES+W95ECN2KMpl031aOfywAdHz82 /LZJZ+peLAnM4wxNoKBabqdzGDPogstnsocndjLD9pvcocOUwBHf1Vpb/jhNBREIEdjX z+4IC5Rn18o1ZFiPySmUy9HtccdD5oJfOPyTrheelssPFuRY/9/3a8RCCyhTQp/koP5Q +2CJ0Q3g6cT+94qt9SkNs+Fz1hcKfHwb+8QtIYWJPE4V19q4EqwVJDFtaLbEyN6CZjWG 7+x+s6DlM4iKX/5N8jewIRx5GBu9vqqZRIkxA42jbLoYKSyDIYVCzWnBcAzSt6PpIBI6 d5hw== X-Forwarded-Encrypted: i=1; AJvYcCWuYaG4Ga2EwWaFtQn0vLRBvIy8gTA0mdjjmFEVZPCIZZfy3JmpOquiyAm4tjPbVXl1I7f/VIiR4bBFlaQQ9oj/c+I= X-Gm-Message-State: AOJu0Yw6mXIewAPBFf6OjE2asJWW5z1hUs7kkBXMJvEPr+ZqL4h8rebE vHD2rCIiBF6UUveOprhFf4Q2WOC9fDuyoG32B8j9sa4h57PPjkAc X-Google-Smtp-Source: AGHT+IF9LsvokS3eKYMuP4MogL69AZXjuMawpefSDoGGOn7fBRjbwOK8dFR1TEF4RXpvNJ2suRcGCA== X-Received: by 2002:a81:7c02:0:b0:61a:ccb0:7cdd with SMTP id 00721157ae682-66500573b1emr27793817b3.46.1721237291553; Wed, 17 Jul 2024 10:28:11 -0700 (PDT) Received: from gpd. ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6660249145dsm90517b3.60.2024.07.17.10.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 10:28:11 -0700 (PDT) Message-ID: <6697ff2b.050a0220.19cb8.00e1@mx.google.com> X-Google-Original-Message-ID: From: nifan.cxl@gmail.com X-Google-Original-From: fan@gpd. Date: Wed, 17 Jul 2024 10:28:07 -0700 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v9 04/11] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command References: <20240716150336.2042-1-shiju.jose@huawei.com> <20240716150336.2042-5-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716150336.2042-5-shiju.jose@huawei.com> X-Stat-Signature: pnmhyrmhgd81ynw4bs1yesee1yz7953y X-Rspam-User: X-Rspamd-Queue-Id: 86EB91C0029 X-Rspamd-Server: rspam02 X-HE-Tag: 1721237292-149537 X-HE-Meta: U2FsdGVkX18jLXkc/WOxpZCtX9MjJmb+vCqieG0sLMY5io7++jTHmENzEqrCTNC9ccelB2DfG3yhe6DXYilGcL5X920tCgVhxSrwcWeoiF4lG70cSwFpYDL6cZ1rVR0eDbgnq8ClSfMnT3yBiHzMJSnmp8qYVLaWkQ5X1UOHqIPupV+CipRwvpdIr75+PxD+efTUlgNcWAV4n6k4Q1ClG5iMhmxq4TR6VmKXPwOh1l1aHGlVzT9absYOZZDlQ+/Q790ugVKbmXrnxSGdL9UGDG+9VdqcfrGdRQqjrXas39H13l5ILgtiXygRySVwvtQZlnQ3btjETpHbbUQiMjDbihWOlmS5iCQHYdOEGSO3D5AoxNNkkQEuJGpkG4Dprd2KrVHOYS0xDowzKrfc49GIhCeLKQc2tuBVPmXty1IjBvhKBXFrX/4CaRgXnTYb8tBY+aIopKT4UTNRUW9vXrSVtFnii6tgme6Oer1vYgYmQ6iB8FoeUXZ+likgZmAsMmDV72Uhv7quABkYQabdbxZjX6uiW6wUtY9tAjn/r+6RKpYD48JL70KBlRz7OJm4PQitKL+p0RZRxoLsfTrHlQ87m3L7eSk+5/bDqjnDxlzNd8leCSgixLfeMrpP0G5NtJW1QtYl+lXSH8hlhD7CR//JcCMoZhdGfDJcbgXZlttH4vVQZGDL01j6kz0iQj8BguTcTNFGaaLMFIozQtCboMbKqPW+52KQFjJHLKFcHmCX4yFDJ3zi39wK4Iutj7z4JwJ7qjNdkuXuXYvOGDkwu2YD2p4asJNpYfmXNLCDENLneGmK538ZpQpn3hawRh6s4p272JcY8VE6ZJpg4u4NX7K7RwYpwFbU6iAUhvky6L7BHWTr8KDq1wxO2e3rfrgPM+lVHdgZVUQZ67UG3brEqNq5BDnIW3PMIc3JaDD0EJExk06qIR+SH4vQjAHUj4435HdP8fZHCYtPa7OIdu4+icB kDj9NG0W M82e7zmZ+FAC3J0ArWzXKVoPA/4ixKfvZYRmEUdDw0ZZPX40m0QabyQ48J1h/gecq3wRow7s5P0pvtgwCTmTG1ZWmnNFdk7xSyP1YJK0lXAW8rv00sfOtEuUiObUHdzSHc5OqNAk5KN+SzwZgiclEAnbHqsR+NAPGUM2pSrVSZgMQDZApxQA8KcNRSXWrjjdB5AnzhrDkPW1fXCYuPlKcs6tksFcUlpEiS2YN1aWhxMH+zHo8TU99cSnk9Pvb0GXz9qWB4RzRM5FCsTEtnWAILRmIeZBdWOnnc9BdbiDzPwhjLo//jaKH7pv2xP5ZRy1qFmedVEF5fLVL1TpA6MAK1Hl2DoGywpdYbY0FZ1ae83E0z2ubjh1i/Abm9L+Oo2jzvPI+O+PQJYZ5RvwBRbZaV/VHj+LXWN8c5uT+cFHLX9gVyFqeWMuz/dlvj9VYrnkFGhCdBJNmBrdXQuMZIn6s5TGufMWHSS7ZQhJCVTs1+aswrdncUpzDDZO8XDzmUv2lvvPq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 04:03:28PM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_SUPPORTED_FEATURES mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices supports features with changeable attributes. s/supports/support/ Fan > Get Supported Features retrieves the list of supported device specific > features. The settings of a feature can be retrieved using Get Feature > and optionally modified using Set Feature. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 27 ++++++++++++++++++ > drivers/cxl/cxlmem.h | 61 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 88 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 2626f3fff201..9b9b1d26454e 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1324,6 +1324,33 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds) > } > EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); > > +int cxl_get_supported_features(struct cxl_memdev_state *mds, > + u32 count, u16 start_index, > + struct cxl_mbox_get_supp_feats_out *feats_out) > +{ > + struct cxl_mbox_get_supp_feats_in pi; > + struct cxl_mbox_cmd mbox_cmd; > + int rc; > + > + pi.count = cpu_to_le32(count); > + pi.start_index = cpu_to_le16(start_index); > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_SUPPORTED_FEATURES, > + .size_in = sizeof(pi), > + .payload_in = &pi, > + .size_out = count, > + .payload_out = feats_out, > + .min_out = sizeof(*feats_out), > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + return 0; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 19aba81cdf13..b0e1565b9d2e 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -530,6 +530,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_LOG_CAPS = 0x0402, > CXL_MBOX_OP_CLEAR_LOG = 0x0403, > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -699,6 +700,63 @@ struct cxl_mbox_set_timestamp_in { > > } __packed; > > +/* > + * Get Supported Features CXL 3.1 Spec 8.2.9.6.1 > + */ > + > +/* > + * Get Supported Features input payload > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-95 > + */ > +struct cxl_mbox_get_supp_feats_in { > + __le32 count; > + __le16 start_index; > + u8 rsvd[2]; > +} __packed; > + > +/* > + * Get Supported Features Supported Feature Entry > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-97 > + */ > +/* Supported Feature Entry : Payload out attribute flags */ > +#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) > +#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK GENMASK(3, 1) > +#define CXL_FEAT_ENTRY_FLAG_PERSIST_ACROSS_FIRMWARE_UPDATE BIT(4) > +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_DEFAULT_SELECTION BIT(5) > +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_SAVED_SELECTION BIT(6) > + > +enum cxl_feat_attr_value_persistence { > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_NONE, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_CXL_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_HOT_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_WARM_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_COLD_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_MAX > +}; > + > +struct cxl_mbox_supp_feat_entry { > + uuid_t uuid; > + __le16 index; > + __le16 get_size; > + __le16 set_size; > + __le32 attr_flags; > + u8 get_version; > + u8 set_version; > + __le16 set_effects; > + u8 rsvd[18]; > +} __packed; > + > +/* > + * Get Supported Features output payload > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-96 > + */ > +struct cxl_mbox_get_supp_feats_out { > + __le16 nr_entries; > + __le16 nr_supported; > + u8 rsvd[4]; > + struct cxl_mbox_supp_feat_entry feat_entries[]; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -830,6 +888,9 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > enum cxl_event_type event_type, > const uuid_t *uuid, union cxl_event *evt); > int cxl_set_timestamp(struct cxl_memdev_state *mds); > +int cxl_get_supported_features(struct cxl_memdev_state *mds, > + u32 count, u16 start_index, > + struct cxl_mbox_get_supp_feats_out *feats_out); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >