From: Luiz Capitulino <luizcap@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
david@kernel.org, baolin.wang@linux.alibaba.com
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
lorenzo.stoakes@oracle.com
Subject: [PATCH v2 07/11] mm: shmem: drop has_transparent_hugepage() usage
Date: Mon, 9 Feb 2026 17:14:29 -0500 [thread overview]
Message-ID: <66846ee3aec32c04d20bc7e0e823ba21d4ef278c.1770675272.git.luizcap@redhat.com> (raw)
In-Reply-To: <cover.1770675272.git.luizcap@redhat.com>
Shmem performs two kinds of has_transparent_hugepage() usage:
1. shmem_parse_one() and shmem_init(): since the calls to
has_transparent_hugepage() are protected by #ifdef
CONFIG_TRANSPARENT_HUGEPAGE, this actually checks if the CPU supports
PMD-sized pages. This is irrelevant for shmem as it supports mTHP
2. shmem_parse_huge(): This is checking if THP is enabled and on
architectures that implement has_transparent_hugepage(), this also
checks if the CPU supports PMD-sized pages
While it's necessary to check if CONFIG_TRANSPARENT_HUGEPAGE is enabled,
shmem can determine mTHP size support at folio allocation time.
Therefore, drop has_transparent_hugepage() usage while keeping the
CONFIG_TRANSPARENT_HUGEPAGE checks.
Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
mm/shmem.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 79af5f9f8b90..32529586cd78 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -689,7 +689,7 @@ static int shmem_parse_huge(const char *str)
else
return -EINVAL;
- if (!has_transparent_hugepage() &&
+ if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
huge != SHMEM_HUGE_NEVER && huge != SHMEM_HUGE_DENY)
return -EINVAL;
@@ -4678,8 +4678,7 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param)
case Opt_huge:
ctx->huge = result.uint_32;
if (ctx->huge != SHMEM_HUGE_NEVER &&
- !(IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
- has_transparent_hugepage()))
+ !IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE))
goto unsupported_parameter;
ctx->seen |= SHMEM_SEEN_HUGE;
break;
@@ -5463,7 +5462,7 @@ void __init shmem_init(void)
#endif
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
- if (has_transparent_hugepage() && shmem_huge > SHMEM_HUGE_DENY)
+ if (shmem_huge > SHMEM_HUGE_DENY)
SHMEM_SB(shm_mnt->mnt_sb)->huge = shmem_huge;
else
shmem_huge = SHMEM_HUGE_NEVER; /* just in case it was patched */
--
2.53.0
next prev parent reply other threads:[~2026-02-09 22:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 22:14 [PATCH v2 00/11] mm: thp: always enable mTHP support Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 01/11] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 02/11] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2026-02-10 7:45 ` kernel test robot
2026-02-10 8:05 ` kernel test robot
2026-02-09 22:14 ` [PATCH v2 03/11] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 04/11] drivers: i915 selftest: " Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 05/11] drivers: nvdimm: " Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 06/11] mm: debug_vm_pgtable: " Luiz Capitulino
2026-02-09 22:14 ` Luiz Capitulino [this message]
2026-02-10 9:20 ` [PATCH v2 07/11] mm: shmem: drop has_transparent_hugepage() usage Baolin Wang
2026-02-09 22:14 ` [PATCH v2 08/11] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 09/11] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2026-02-09 22:14 ` [PATCH v2 10/11] mm: thp: always enable mTHP support Luiz Capitulino
2026-02-10 9:56 ` Baolin Wang
2026-02-10 13:28 ` Luiz Capitulino
2026-02-11 1:12 ` Baolin Wang
2026-02-09 22:14 ` [PATCH v2 11/11] mm: thp: x86: cleanup PSE feature bit usage Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66846ee3aec32c04d20bc7e0e823ba21d4ef278c.1770675272.git.luizcap@redhat.com \
--to=luizcap@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox