From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C05E6C3065A for ; Mon, 1 Jul 2024 19:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532706B0083; Mon, 1 Jul 2024 15:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E2E96B0088; Mon, 1 Jul 2024 15:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3825B6B00A9; Mon, 1 Jul 2024 15:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1894D6B0083 for ; Mon, 1 Jul 2024 15:16:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BA9FA1402C1 for ; Mon, 1 Jul 2024 19:16:58 +0000 (UTC) X-FDA: 82292141316.15.AC27867 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf14.hostedemail.com (Postfix) with ESMTP id CBC42100017 for ; Mon, 1 Jul 2024 19:16:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L4jYqdNX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719861392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UYgAL8UtwtVMQRblko/vWUwJ2u8kL0IKti8mph9r91c=; b=KqoTwpX6XNaMTQB2N/WE7aTGtx7Rp5lIIMEjUbbJHGx/z7PDJkq0uIt/ioJGrLe2jXsQvf dNd++RayOAnd649oiU3zxC7hhk9DNisjHz4TYbbFdaEvQx+cCjVWXezM52txgsXm7UId2U +iXuVc88uAR04O/cTPpogF1X+AGC6n0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719861392; a=rsa-sha256; cv=none; b=nZK4QQ/oTpAIX1EkZqKUKmeu1kEw/1goaTEjm0tBO886hlov7NMEwex+9ef1oz7DCkZfEx s3kQcN0bAXCVCyJRc7n8CSPwFlmSzRQTBfNaV4+yAUTJoptlTbQCXWJCWEEfc5CsRUK0+K uDYwaHuri32NjFwJi/5vWgDob+FCHT0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L4jYqdNX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f4a5344ec7so24153385ad.1 for ; Mon, 01 Jul 2024 12:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719861415; x=1720466215; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=UYgAL8UtwtVMQRblko/vWUwJ2u8kL0IKti8mph9r91c=; b=L4jYqdNXJjOKKBShVXL/ZfKLGWljP8BgHflD6AhD2JRpEKWKOKFsah3oTh0hDa5SG2 9vKNP4sTRSpu3ZX/7thliNHwg6BPJNjixtDsmQmQWSWNrYbb7piNar8GhHcpBiA8ZG74 xwsHqj7s8j3Ni3pmtORGBXRzflwmUu5H7b8pH0022bFIg8hbHFG1W2PhzCvZl1nydCJ5 eJievPdjJngF3UEK3wUOySdP/Z/Zuf025amUOYb/QQkZe4vcVEkoHj9mKmNuvfFJkfL8 qgwzFTTZE5UNAP6nzILexWYaPRg2OTQ8Q6cYLphkXgEK9cQJ+caq+EoY//X3kZ9VI/5a csrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719861415; x=1720466215; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UYgAL8UtwtVMQRblko/vWUwJ2u8kL0IKti8mph9r91c=; b=wvg45VNgkFRFxC1Xcu1ra1vTR7rvkvLYGwNonHTsUUm4sBuA7SfMG+2ZzvfsInUOEr RfqWZPGme/6QQT2fxqNDKYA4sRGg2yoiybkoQPEjVcd4OWFhOJykaplEm2ZSiqwG1zfV LlO7qvGAIhQ/aBs84EATEdEnIYqaZt9YbkDhL23oTGGkpmBkskhD34EbemIihppJp0Qe Yw/inHRqrszi5WOEQw/MOCbpvKYfL16Q0x49bfprS5JiCjzDF1RgYmhVrYWGO4OywTeV xLlxLW9l9UgnbXUGu3V+K6010DVNJMEiFOAlDWjvPR1O0dxF1Zzn7dtH4pivTcMAdeO0 KLmg== X-Forwarded-Encrypted: i=1; AJvYcCWQiKpgH8beJt9hNXPtuIDFos8/j5tsQZQFl0yKXOsWDLa4fEy8CU1osKl6PLdaYBZQPW449SXW+mhoCSbkGBnHszM= X-Gm-Message-State: AOJu0YzViZfuVROUyvcvORGX2RHOGfZotQI8B20n7EIt3ZySNMfy8Qxu 4Jy0tbTB1BPCt0pkuOd2W/cOjD+M3vof9i364AHKEx6jc7dMGqz0As27Cw== X-Google-Smtp-Source: AGHT+IFkTuG8/9oR/a/Iu5Ue22u3smgRX0lBB8ReYw4O5P9NRn1WwM7wviml+m7H11mOyuSoZTYBQA== X-Received: by 2002:a17:903:41cb:b0:1f9:dab3:b048 with SMTP id d9443c01a7336-1fadb4d189amr103254495ad.32.1719861415304; Mon, 01 Jul 2024 12:16:55 -0700 (PDT) Received: from DESKTOP-DUKSS9G. (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac1535cfbsm68829845ad.173.2024.07.01.12.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 12:16:54 -0700 (PDT) Message-ID: <668300a6.170a0220.cdc45.7372@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 1 Jul 2024 12:16:52 -0700 From: Vishal Moola To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Aristeu Rozanski , lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 7944/8232] mm/hugetlb.c:2677 gather_surplus_pages() error: uninitialized symbol 'folio'. References: <6d5e5b32-246e-4c56-84d7-f7c4f0a6212f@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d5e5b32-246e-4c56-84d7-f7c4f0a6212f@suswa.mountain> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CBC42100017 X-Stat-Signature: qc3yhrnxgixwh667jeocc4xr6zw1egc9 X-Rspam-User: X-HE-Tag: 1719861416-707697 X-HE-Meta: U2FsdGVkX18+t0+0QalRbL3FFxEDO7s8tPfx+iqtBG1sY+ihQrSOZQVYduqpEFjtAi6lu+hyOc3wzs1s8yEqaJIZ5kuo96bINPqm/eJt+sqADRFwpKfa4NWQTc//Sh3emywqOMpOwNEE53U5D/8oJCjuK6ylmmc+Mf+17IRh4MDhbTqCSOfn2H3S/QxvSQVEiyjIbXc/yRL3lx2+zNOud7YXZVuHWV5I4/A1GmEc/RYqLp25VthWQ8ZiI1UISqkQvMp1YzXnkHwlVXTfArpKUJaK9aEW57FBPwiibPf77S9pC1lJPkggP5gOuFYHWtHXK9DktJceoeABtVsngtuXuUbOi9hj6zt8OPTgPfwMPnsMbf1gKxGxAm0r1LF7Kk54wb4JaXks4cgwdX+XDK9Uw243zKo3pGz2RQpl9tRMXncCPg18nWNQuKCW2JrnlpoLChJSANJp6Bl0cgFipblaPfmpmJAlCooLVPwMn5QEmSL/j3cz3YNqL9B1k1G888SokS904E2J2zDBolqQ9/s1LNQVZupbjsSLXLRJtaU8zkxD8H8gq+lDxwOLAw6f2VPU0thI3Y0n/W6Q9+T/fSIQ2K6yZC7+ORiM8tVBjMzkgwaZAIosoFAhd1n+0mrRsYzOB8FCHeRc+jYPIQujomXdVs/QeNAehCBpQfpwSJTdyq43PDT12gY7WHg2Cy2ZoI+miGsmHAXro3JMSfc/KtsfHqUoAEdXyFlLNX8RNQ7DojqUfRJ/Nmj2AnoHRBomSsST6W0Qud4Cc/ItD+e5eNC/QPP2Olxnz2xcAdkC8EY/TEElVnacw1sZCWidqzaFx8r3h44dLe9nN7SzVO2EiMsHtPXmOjxyCW3/Eb4fjUtNngbltLB6mANkByFwCThSmwSAZT2jY/qhd7KcM/hPxhCP/MZvQOWGIMEoQVjdiPrhtAQkhwU+EiVZumVIc7BPFSTn1RwIw51kOJPcJZXc1fg +blSSj3Z IJfysaeOduCVDxf939oI9mXBv4esUuF/iMCMyCqGeP0fHZq9pCYGR9kSoOaL58D2MuS553um0yPJWObcMSKWUuFqbFQmYSmKzy9quyXJf7riapXS3XBJ+MMVdFLU8N38mupbqqZ8bUeSpI9wucD9l0OZjI3Q/kyVSxBXSh1qxy4A60eYFMJyMJ7VaCyU8bkoO60vyEmFZhMEqzPMCzSS/5SsSDsmpAIHgJ2yJ+4WRlhK0/K+OGvShZ5OGCtlOiZ5P4mNZKt8HdswPfOwlXbfFTh8xPwqS8P4aqZTC4zNN8d8IORaYcIedBQCd4a8AZKDKnKGqlJD+IIN7ZdMQdYtvv3uydfw50WT9Ur7gMtCFb6KOSzVT1+8bpKwz9fKSs2hD9x6X5nYQCA6hW/dph+MjGzzWWt2DbPiEz1Cuk7WS8LMIUxNRsBjxYxxVwpu0NgAefTSDq99OlPClgQXBTbvf/u+eyPzQi4gsqljHIVq7fP9Z6uV74AIb1MPt0V5AOV+F3Pi576GkVNwVdam/FocvSGSl2NKgfxz9vOCsn+cAOdIk+iBYIwCKcqQUxhyLEsnNupL4qOTNdLnvv80cd49ANVIUlii5ka8hoAmt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 05:49:34PM +0200, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: df9574a57d02b265322e77fb8628d4d33641dda9 > commit: 1cb6271d927cdb448a6a2794291c5405f1effa76 [7944/8232] hugetlb: force allocating surplus hugepages on mempolicy allowed nodes > config: i386-randconfig-141-20240627 (https://download.01.org/0day-ci/archive/20240627/202406270727.F4yNrBsh-lkp@intel.com/config) > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202406270727.F4yNrBsh-lkp@intel.com/ > > smatch warnings: > mm/hugetlb.c:2677 gather_surplus_pages() error: uninitialized symbol 'folio'. > > vim +/folio +2677 mm/hugetlb.c > > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2644 static int gather_surplus_pages(struct hstate *h, long delta) > 1b2a1e7bb9ce99 Jules Irenge 2020-04-06 2645 __must_hold(&hugetlb_lock) > e4e574b767ba63 Adam Litke 2007-10-16 2646 { > 3466534131b28e Miaohe Lin 2022-09-01 2647 LIST_HEAD(surplus_list); > 454a00c40a21c5 Matthew Wilcox (Oracle 2023-08-16 2648) struct folio *folio, *tmp; > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2649 int ret; > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2650 long i; > 0a4f3d1bb91cac Liu Xiang 2020-12-14 2651 long needed, allocated; > 28073b02bfaaed Hillf Danton 2012-03-21 2652 bool alloc_ok = true; > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2653 int node; > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2654 nodemask_t *mbind_nodemask = policy_mbind_nodemask(htlb_alloc_mask(h)); > e4e574b767ba63 Adam Litke 2007-10-16 2655 > 9487ca60fd7fa2 Mike Kravetz 2021-05-04 2656 lockdep_assert_held(&hugetlb_lock); > a5516438959d90 Andi Kleen 2008-07-23 2657 needed = (h->resv_huge_pages + delta) - h->free_huge_pages; > ac09b3a15154af Adam Litke 2008-03-04 2658 if (needed <= 0) { > a5516438959d90 Andi Kleen 2008-07-23 2659 h->resv_huge_pages += delta; > e4e574b767ba63 Adam Litke 2007-10-16 2660 return 0; > ac09b3a15154af Adam Litke 2008-03-04 2661 } > e4e574b767ba63 Adam Litke 2007-10-16 2662 > e4e574b767ba63 Adam Litke 2007-10-16 2663 allocated = 0; > e4e574b767ba63 Adam Litke 2007-10-16 2664 > e4e574b767ba63 Adam Litke 2007-10-16 2665 ret = -ENOMEM; > e4e574b767ba63 Adam Litke 2007-10-16 2666 retry: > db71ef79b59bb2 Mike Kravetz 2021-05-04 2667 spin_unlock_irq(&hugetlb_lock); > e4e574b767ba63 Adam Litke 2007-10-16 2668 for (i = 0; i < needed; i++) { > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2669 for_each_node_mask(node, cpuset_current_mems_allowed) { Smatch might be concerned about us skipping over this for_each_node_mask()? It appears to be possible if we have 1 non-empty Numa node. > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2670 if (!mbind_nodemask || node_isset(node, *mbind_nodemask)) { Alternatively it might be worried about us skipping the folio assignment during each iteration due to the if statement here. > 3a740e8bb56ef7 Sidhartha Kumar 2023-01-13 2671 folio = alloc_surplus_hugetlb_folio(h, htlb_alloc_mask(h), > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2672 node, NULL); > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2673 if (folio) > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2674 break; > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2675 } > > folio is uninitialized if everything is set, I guess. Not sure if that > is possible or not. I'm not familiar enough with NUMA to know whether its possible or not, but it shouldn't hurt much to initialize the folio. > 1cb6271d927cdb Aristeu Rozanski 2024-06-21 2676 } > 3a740e8bb56ef7 Sidhartha Kumar 2023-01-13 @2677 if (!folio) { > 28073b02bfaaed Hillf Danton 2012-03-21 2678 alloc_ok = false; > 28073b02bfaaed Hillf Danton 2012-03-21 2679 break; > 28073b02bfaaed Hillf Danton 2012-03-21 2680 } > 3a740e8bb56ef7 Sidhartha Kumar 2023-01-13 2681 list_add(&folio->lru, &surplus_list); If getting here with an uninitialized folio is possible, this could be bad. > 69ed779a1454d9 David Rientjes 2017-07-10 2682 cond_resched(); > e4e574b767ba63 Adam Litke 2007-10-16 2683 } > 28073b02bfaaed Hillf Danton 2012-03-21 2684 allocated += i; > e4e574b767ba63 Adam Litke 2007-10-16 2685 > e4e574b767ba63 Adam Litke 2007-10-16 2686 /* > e4e574b767ba63 Adam Litke 2007-10-16 2687 * After retaking hugetlb_lock, we need to recalculate 'needed' > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >