From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204DDC77B7F for ; Tue, 24 Jun 2025 15:46:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C20F6B00AB; Tue, 24 Jun 2025 11:46:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54B4D6B00AC; Tue, 24 Jun 2025 11:46:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F1E16B00AE; Tue, 24 Jun 2025 11:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 25B846B00AB for ; Tue, 24 Jun 2025 11:46:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 99F3C121D43 for ; Tue, 24 Jun 2025 15:46:12 +0000 (UTC) X-FDA: 83590720584.24.C0BF253 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf01.hostedemail.com (Postfix) with ESMTP id 3ACA440013 for ; Tue, 24 Jun 2025 15:46:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=agTe6CaT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Kc99u0sI; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750779969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lTAGLixXmfqsLoH+93AtHZchQ5ZviIOOC2uxccaM10s=; b=GnP9q18jaOMDx43EzUtfDJiQw7e/kD2+BL/4bqXbZfRjCXfxmxJZSQrCc2OJX6ZnyZOTj+ uMvhTwK28881RcfgrO4fd0qExPtz+C8oLd/roF1UmzbiVqTSGhLz8sIGWTTjIXB2vqfhE6 Ve1KzUVe4BwKDT8Is0dotC2zu6OLmQs= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750779969; a=rsa-sha256; cv=pass; b=AH0hHkZfeuJQfvR0KY0Y60NUg/V2gAb7zaEfCcQnANsmLIGWvZfMk6/X3+MrqOA1cKltaS sjgiBSuCaNw6mX+43LAV+cSpoWPCQOAnKmntoXQvkALz8e6dvXkXN1kSE3KDfgM79fIDQA lwB26Cp9f0ohR7dgxagZ4EpxjVXAgw0= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=agTe6CaT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Kc99u0sI; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OFMkiG007393; Tue, 24 Jun 2025 15:46:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=lTAGLixXmfqsLoH+93 AtHZchQ5ZviIOOC2uxccaM10s=; b=agTe6CaT6CJlxbwZ9ifky54DXqN6Yv4r3C crd6IgTaHBjWeQE2y8WIn4iobaNUvk8jUgvU3dfMTbxSphmFQJfx8N5vggnddc8u iZRvUu35pcJS3YMxnRGlywcpe0BBcXtJv+J3vrbFK0a1uM2i2dHe0tWfdFCGPqfC gpxRQMweA5Ul7PJVyv1giG/lqoJiwV0+yDQp7kmxsDgtxmhWPv77Ak3NqLbyH+3u wNjDQruBlxF7Rfn78DcxhurS4xzd28n5vkSj7uWVfvSuCQFs3gLcifofubQH1gO+ 2tBMvNfnh/w7TrZh3n+RRz4e43jXJrUh7CXaDiEa5QntTLxnGQaQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47egummdgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 15:46:01 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55OEVmch002571; Tue, 24 Jun 2025 15:46:01 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 47ehpda3mv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2025 15:46:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QBPh1/rBXHXCLz0CFOheKwS+zWVGd5nBwWsgarBENekFp3Ll5Om89pAOmk64o2R9PZVf3PpcHcHJd2i97+xgsouJq15at4dO3sj25XLnKHlhDt1YNT4zV+TfdEcHM1G7zD0McDdAlrd/mOmTVvkgQPMjbo4YGPWcyx8DP5RCqmnJ3uQ561l7P9r5fjy2nV3FVEjal+sGnXIJWFLv9DQ3/rZW/xdlhg0r5Wzf8xH5wEkz96UFuFNC0zGOzi0BvtCF8vbMF2r8YCKFef+5AHzqrojO4+IAWupAv4uwI9Ltn9VpMctD+KWTliyESsl+PJoYmTxukP/vTS7EuA42aD02Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTAGLixXmfqsLoH+93AtHZchQ5ZviIOOC2uxccaM10s=; b=BiHvlucn8IRxh/crdmtShLg4XoznZreNiYd8QkhjH89RSh93BhEgOYes/2rgU21UYkdA0/szEL8iTSVbKoKbH9fCLAj8PxKYTMp5JoctDPpDQJLAtqhX3GfM50/SwV9QLkMikioz14W9U/Ru1RHfDPRjz7KdkPGQGt2dXgqP/y1B+7VQQhxLLGZX8t0QH2Hoks/qsuxH1+a++91Utb9IDuzeUPSLg39FfcKz/sJGFnlgn9zrOngLZTzE5hxd+3LOYiz+hucrJXt/mEFv+99RaWxoqIoPfoT/NFmhr9O7tj6QJlyElw709EkH9DMpQegZBwUPD9W++MaoU1V1bHmIPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTAGLixXmfqsLoH+93AtHZchQ5ZviIOOC2uxccaM10s=; b=Kc99u0sIgqYwePmKNY0yxlirBAqOlC2VvkuF4Cc1RCbqHA2iJwtK5AA3NENyW7M5n8FRZTOq3hfIV6H/g6YPSzAv8U71SiNYPdAFZinsjqxdqzmHodXQ6zloc48m+Na7D3Wn9s6h2YqW/voNeobMJ3Bpq81jdorIISK1TVb9Zeg= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CH0PR10MB4860.namprd10.prod.outlook.com (2603:10b6:610:db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.30; Tue, 24 Jun 2025 15:45:57 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8857.026; Tue, 24 Jun 2025 15:45:57 +0000 Date: Tue, 24 Jun 2025 16:45:55 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Colin Cross , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] mm, madvise: use standard madvise locking in madvise_set_anon_name() Message-ID: <667e6631-8e2f-4154-8fcc-55fb5ab49a07@lucifer.local> References: <20250624-anon_name_cleanup-v2-0-600075462a11@suse.cz> <20250624-anon_name_cleanup-v2-4-600075462a11@suse.cz> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250624-anon_name_cleanup-v2-4-600075462a11@suse.cz> X-ClientProxiedBy: LO4P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::6) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CH0PR10MB4860:EE_ X-MS-Office365-Filtering-Correlation-Id: f4af56cb-2086-469a-2c2a-08ddb3363649 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DAtzreR9kMMEbAtx1hKz4WegI1dGwkj4bCTWpFO9dovM5fjQA+bgg6q7io7p?= =?us-ascii?Q?yNkkE2MHUVmS1SqcWlTGTGKUlxIgqHXlrC5GeKOTqwjGJ3XIT798DiwdaVst?= =?us-ascii?Q?+FFf5WHKrzLH7actLG0WOWfJwocvR53XlALAdgwOl3fdePYJUEUeC3gvjMj4?= =?us-ascii?Q?5cnTLsNwUkfK2sYiclOvkC5Q2zCkRDQF3s7YNJZH1wGZS2JR/a/zrWEfbUYZ?= =?us-ascii?Q?tjcLXbS0FxoeiuP124I5e9Hvv2yJtYv/sQKLCr4uyuToLSI8TCkP+V59l140?= =?us-ascii?Q?Vf5hfLpHbbn+sDwHfJt/xWqLJV29e0tdczpNXniIrocArRL4yHImJIQ9f9Dn?= =?us-ascii?Q?T58Vp7Sk2tupctlp71Z6jAABrjqhkbCL+2hThJOyOqakVxf8rMN3TcCh9qLs?= =?us-ascii?Q?sSlw6PcquFK2u6P6uFikeG2K7Wi6+pOIZy8sbQi8p/hnuPbhIMFa8vDQC2FG?= =?us-ascii?Q?UMh7SkaHB6YXf4GmLCHDTxqvti/B5FLyJlc+zP9XZmwB7ctlx/jWHlfpju6K?= =?us-ascii?Q?2RRlv0EzldPGXmsGDulyxT0fF26UAiTSl35mtth+T+xQ6/pAxFS1/HwMsIzK?= =?us-ascii?Q?rOQkQhuQrOozIRWF/ODSq4bn5iE6paUJictTLPv7lcmgblLyIYHSPdpOAw6r?= =?us-ascii?Q?HVaQYdbdb2rXFMLWrgJlzqCtRPjm6glk8mSL8pTzMNdz6NPMtCZKxxxi1UVh?= =?us-ascii?Q?3sGBZywp5ghkIIzxtkMujoDXyNZVSGCERkE3DjDkPnrOqHR7Wy3qpJP3pbO3?= =?us-ascii?Q?8WuWhlssNoHKLjLaCwxj9/7vsuMUrl6zq6XGDwZNYH5GF2msM9HSftRD3Ryx?= =?us-ascii?Q?u5VEViUaP6oJiLzBThPJ/t2ut7A47910HZO+2jQR8xcASfN4Eocq0ev/HdZ0?= =?us-ascii?Q?CL2mLKWbGdWrN/2HsNrWgD+qm3xtnRftddkKpNQCVgMST+X3k1PNwP2a7kYE?= =?us-ascii?Q?wTEBrkStm26XUUhYbe2U3c/wvNVC6CCS4DxaZlikYq17IthJ+VLmQ39AFek7?= =?us-ascii?Q?PU8CZo49/ikBU99lsmXRQgz2OCgYMf9luXv44yQEvbuZYiCXoXBbYJ6kdNsn?= =?us-ascii?Q?CwkAfqu9gcXFfab5w7DQ/eK/9jYGYUwAK12e+y0Ra7/AzJbq6moQv8bE9YmX?= =?us-ascii?Q?jKTSUAsoITa1lxv6TsVGq/HAGes/6fCcxHi47Q0ez7Zz9JkiFdaZncWtZr+2?= =?us-ascii?Q?G73NRdgmKW7E1s9+3wUgcicbfuLh+bJq0GxtbxWgt8UcR+X1ndYW+6T2/LbG?= =?us-ascii?Q?gabbKUdAbTqSxKhiVWYfQvtY0D8Yoi1qOuyGyicduTwyxB+1/GAJO1E/X/9a?= =?us-ascii?Q?TAqkpIxaHOYquZyOb4ZF1sztYt9sXk1szjZsxyP+u/Ot5QDqL9LDo6vgSxQq?= =?us-ascii?Q?jYT/HkPEf4cFrrqYXuo6EqBcd8CTfuBdbiZS6f4ENZZmrsRsUdjZviWme2G8?= =?us-ascii?Q?bR1ZHVKbEMQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J5w52+lZixIum4mP/zIMgYdYJaX6pb8Z91kmlDNhquW5M0vKXVj7+qY/bEeC?= =?us-ascii?Q?QGB3vfXHdJ8Bi2z7gvnmaUpf4jIXXOnv/cCOHpBysnSPEeLT/Gvt4Io8smv3?= =?us-ascii?Q?maNUyN5+b8fflmXKCBBHkxl3eXJhEf7fJLtM8rORhoW+mVXFhiOUlVigJhyi?= =?us-ascii?Q?EQZFMYbqHPHdfK3THaxZxULvvaMrWQIFfF7352Ac4kbm+MaVY9aQOQbTQIMh?= =?us-ascii?Q?HC5asY9lhLoWnWuO6YL6Jg6Irq2Nj/F3xxZW6s5VFKpXfZbPgDJp4ajtlO0h?= =?us-ascii?Q?VE8KOXdDxUSly0lGHta3wC7INowiZFVsKdBJOQuWvls2thpximK85IxiAI5F?= =?us-ascii?Q?ontxX9ihYCHoVAMBDsKW/33LjxtNBELFLqtFL5OfJO/tOz8iokzQR0iAl0nD?= =?us-ascii?Q?z9tTE1hBnDMc7ATyw7jOc1TT0OjSJo270N4uCtt7pIF5JFM37F2t6fow4+Vs?= =?us-ascii?Q?JbG/B0mWJvOtiAUjdjnYnylSQ3s4Bf2KU0GhuoJxBXQUJekuEstB2Qkv33FF?= =?us-ascii?Q?dm1BDEZqtvC8QLCxSD/W2Jvuc1/jFKI3o7g6bMs35CHEfuVh+vWMZCT1HUIu?= =?us-ascii?Q?BsiQCeUyM1VMYYtddSDSXovTunfdnQj2WW/9ysp7ZmTjZwE5ZpYRd3/eOVdK?= =?us-ascii?Q?GF5mBwfrj6iPdA7TyOLEDsKYzqjCxHpwozfS3C5vnF8wKaT4jn1hQeL5J8lh?= =?us-ascii?Q?iRcTxPPCwCYeDoG/ni+Nez0+bzhm8ji85gS1E5s4CR/7f264ZByUGs+mvEdv?= =?us-ascii?Q?xZC+0uDgMH8vSJqqv4vFb+70JSxybgVsObuM4tgudsy/qd3/lFqceVk/gA4q?= =?us-ascii?Q?qooAh04V0AaF6aeMHsmZt9bckCYPu7TC6JGzeIGkVtJlNNn3NsnmokL171bp?= =?us-ascii?Q?3HsyzsT9LZdAkf7RYwv/fVryLUiMztZDJrMaHgxvWMpO7/hp/Dfd7sksxzMI?= =?us-ascii?Q?ReSq39dUQoPXcS303zE/kcszwCjXz2Zo7QeyfUqXT5t4BC97DybJls2qufw/?= =?us-ascii?Q?McZVagipcnMApeNd7BPpAx6NAiDGlWGnKc3ogDRyXJSw0VfUSBlrmkdXZCpr?= =?us-ascii?Q?cb4nbS7QtjBaW75EA6dJUpQlwZA+jMTzkQfmhKm2EZDzxCiYsEwoZanGmWAX?= =?us-ascii?Q?LkxTKHH2dVyC5ELLE0I86kFh90Zvf1z1qEQmJx7uuBgJeexZXcUsuvKYj4LS?= =?us-ascii?Q?gGsM5DJ97IZcTj3SPGOP8hNiDpMgCiZN5y0Zm8PDj+d05t07SsheW7lfjLXz?= =?us-ascii?Q?hMcNZbt+ch70EC6dWTFg7NsWrzwEGWxJmsEFmtlJSbd4SgxtP0OummXjzzl3?= =?us-ascii?Q?KcCa9gJLXhGUT0LN41V+NZkHqRjHnPtc5nM/WgbmQFDpalCgGjT6FNuXR+Cc?= =?us-ascii?Q?EpqLYSt2bp6CsqKUAxiRSO6JvpDnHLd+9+8NUvEQvI9tenedVq9berPny+cR?= =?us-ascii?Q?dYQanKsNqYwb0IUQgiszgvMQVMzP71f6Zhpp7pUnaCdLKmRQV6XFQ+uGFePb?= =?us-ascii?Q?c/Wx/3nIdlVHbzFPU0IQQTdOzCEgs1xwNZ9LobP8FzO7z3Ryj4AdWWTTUH3y?= =?us-ascii?Q?eFZm6A8tBoCrMflkmUK1gx9nyYmeqn0C3DA/rWVCX4igstlBrPzUOjAcKNXM?= =?us-ascii?Q?jw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0GaNVJVpvc0M2ftD81wZ/uShvCEqgyO077qneO9RmU3lWGyo2VHdrjhDAsyEM79IbOmJAsCbtvtdksihDVLBauMyBSLLf2PQFc0VSv+Kg/nrBKiYYCvrJszqNnYo2LTieG9OrsuW49+SX+G0ZB1yL/qXB4iwb1DNcaxPzCkJgMksWUYu19vv2N+VDhE8KEh80dSISOIUsAHMcJQW/Qxyl9K5yN8mXNGZcLsLxZ85Rqu6xJzrJHmRvnrBcpXb8NJswi8DAlxAAL09LSH1XG6Fzp+STnKQ7vlFYQlvE1Di6Dftg3Oi4tnv8khOHp9i7DVJTGSrCfjMmn9ioA7AyOLxNP94GpE/Dr2As950tK/3oCKiDQOuua8sK7cGMfQeS93ljEBkPea1orjD5fVFGlHF5yLG/LCNPdAWR9cqw5OmN4HIsQuSpyfaIrtFhWe76Q/vBifatTsV+CYak6FllJUs2GZJyyvLwnR89bAzcsHXiCGMvrGzw0LV4QWsKox5SaeLJL4SqokK/46mcJnRGPZnRk/FBjch2KdotxO18VjiCvoW+vQKcQ0qA+q+RHE2RTuJOrekwC08EAoQfezkJifqKWiEuXcJwWYGepGKXr60ZPw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4af56cb-2086-469a-2c2a-08ddb3363649 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 15:45:57.7753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BYw3s3FkCHhFCe3sPaN2GgUQjQSBLnonD7NrJ0bS8qR5P05XXcepuhdqyeqd91ZKOfiVeqk9d46N9k4Crj86XE0QMsNwqAQ3cZQf911tJjg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4860 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_06,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506240132 X-Proofpoint-ORIG-GUID: 8VLbBst0y_zATkSGh3Kl36djCNjP62J0 X-Proofpoint-GUID: 8VLbBst0y_zATkSGh3Kl36djCNjP62J0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDEzMiBTYWx0ZWRfXyzpLtCFawRK8 4viKx6w3MV+b+Nv97ZGbNO28xFxD2yYHSdJCl+deGPkxXJUy+gjXIbxQ/Xp+BFmOaAeX3QTeNvF Y3gH7sSFQZHRzS/t/0eC2TXZ1DFcyPrYG7yzXDb4OJYrCnd2R3Sj4kTWyYkDpcITzVZTze5PVF6 ODa3jnWMjFuEC6mGVYpcnQdStu0Dc9/AP8BcQGoXO/K/1icgDnzPWQOxKCnjyToAzrw2BsUhqwv bKkh/rSV7RZMzlcF6sfgtORYgX4RDs8zyQ0LpLbHkmAyhagGL/3bj0MGk6zy7DU7FLaZw8kDDrM j45mCuu2KUDfKh4I4efM/7zyZ1d+NM86I1jaMLcoA6UiN4Si0aeAhwyMnYlt39VHyDHitopdEJ7 zOnO1kqY3F/DfgSCoPAjdVHaOW1Y7vazI1NDkk2WPHYQVyGrx0xOoLWWwFRkGmIgaodxv5E8 X-Authority-Analysis: v=2.4 cv=S5rZwJsP c=1 sm=1 tr=0 ts=685ac83a b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=Z5dEeDZ-bys1F5YNRK4A:9 a=CjuIK1q_8ugA:10 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3ACA440013 X-Stat-Signature: e7kdqbbjokut3yiecgaq8anz4ddhj98j X-Rspam-User: X-HE-Tag: 1750779969-226636 X-HE-Meta: U2FsdGVkX1+nlHCmJp/Ar/k6X87hK4MHpxJMfkh8EcAQRdH/Gknvx6k6L0wy2FXOjL/X8fQGe9iOW56e+4+3qUp6u8KbshkTZH4uBOMVTM/EWmwU1za9BVWfrDMmxMydSIHM1K0eFlJQnQFKACBVhz5c4r2BHHcsa2ynrAJ9fY6DY0KXr2CEvHiohmOS4RL8YsyRIN1VdaivAO3W9ee6D0QqEENMUQ4cKW9aDUbdltY20grHUhN7A2I66vRey412n+ugxSO2EqzUbgSKqI0YotjCJ/3JMZCWEolMNn3MKX7FhhsJZ6e0McHu8l2W3OXQJsbvCvWtEcmd/uxomaHxRHrFguJdW3ktnvC2s8OjzHnOYS3fCj1snlgVDgexpfyePfFQhrEi9pjSnguwavzL2Atr3rsCAD0hvfa3s40hSfmcsXSNbZ1yJAfSINZK0cCdtpaL/+aRmL2EjMhwVv6X0gl29fsrvvLeIFH7njP1wcNXgsDfsDDwOjbdwKyDUNdbJrAr0rX+xr6CvSbvgWU7JwevOVnAletcT99kSqtT0uVRLWUXZPVor3B9OG6E3FJCutRYiunMApHnhFM/6scxq4JRQcSljqQyh36c5tOjK9QKvHBOj93YcBMvBEPbMJ4SLLUCVLBEn2B01bbOkDlOvf7O52mBk4rvem72Wrq/HbfHREp8wqOjlw7KHDNe/lcrQFahfIBteIlqc2bOfoJfX8g6H1Z0/wEPZvq4G6XvGHz8ZxgCUuokMKwIBmHgUhFEQzrgZYT8hjx3mnIdX0j/Cyu0WkemQnjbs+n3McFLO8ro2sU8RDp6D0w1ugk9QxckJ6BKYkO64NdcLDgHb/paL9214axXlRLAJpTZwO80EhLAUxrcrKpXgvHVEX5XiVYEn35beY8EAlg7C/KFGbQjZWT0HXJ3s6SdSQQFq1USktkxYPmENCY/eeDr2WPVtnpSelmYYeyYJyEBfpfTGbQ 9/eziGfk RfgC1cNidj6ttt34oca9UQ2O0BuDS3FL7xJmb5YsqyrIVj/SBDP7iV9m7vLlRYVPHvrL7yQMVQmcte/c20HG3sGI5eceCBo79NE6SVYiSZxortryhaoSqJ6VQw2+PVAN5HSamP+VsBrJ4Zj5JPeF3C5rvTDQSp5bTCtczNRK7Rr6i1lFaYPNz9DY/Y+ZKJ0CF2M4+H0CHqo5/h/hf7wKcZMGAwtPyertdrGK+3Voq5pymajovoh2JCTLJIA4Wuxuu6YQlLWgW9KR/uSpVkM2GYCsdIIhx0jsRw/qUguz5EzCwVusWKINZCYu32D6fDZADnxrAPh+/j9D7iRrrwrukao3U8lm2Ys2n+3lPYt/WlccFoUySk63ZiXEUPteAmOxbn61qWeIcXfNKwhj4dDXMVaVe968kftvgFIRliOgFOSlwQxJxu0GlHmmEvqmzHDmUQQsC3WXITotRS3XfEsuZuPRNEdmsB74Gisb2wOPg7L4TDZq69K62Gn8rNvPUIMaulJk3MjuF1DBYSVHf+j334IEbkalkwBBTDgzW4vyNd+SimUzpVXL6ADJkKEog9sZ9DOhVk6zQDRCP95ojA/8qJPWBDs1qWdfrtanInhiI7x4cqS3yPdWyJqxhOo9g+cj9cjcG0o3ckfWIPUbMiCEdMdaETBYrum/2KwM9DugnQWq7cLomdm2mniFJMzqV94g4JT++iUHMoIU0UtkuJTIw0k6LHwo9xa6lDZde79enXV6JJD8mo0BH6714crzjdzLWKiYLiutDq9csWbAn5RxXPDwvyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 03:03:48PM +0200, Vlastimil Babka wrote: > Use madvise_lock()/madvise_unlock() in madvise_set_anon_name() in the > same way as in do_madvise(). This narrows the lock scope a bit and > reuses existing functionality. get_lock_mode() already picks the correct > MADVISE_MMAP_WRITE_LOCK mode for __MADV_SET_ANON_VMA_NAME so we can just > remove the explicit assignment. > > Signed-off-by: Vlastimil Babka Reviewed-by: Lorenzo Stoakes This is a nice idea, hadn't thought of it :) aren't we making anon vma name behave now :P I mean this is a _minor_ difference in functionality in that we will now use mmap_write_lock_killable() and could fail to lock on fatal signal whereas before we unconditionally lock but I think that's fine, and possibly even... desirable actually? At any rate this is all nice, thanks again! > --- > mm/madvise.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index cae064479cdf908707c45b941bd03d43d095eab6..ee02ccd0315a146cdb3001cd189e03be9e48a2ea 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -2082,10 +2082,10 @@ static int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > { > unsigned long end; > unsigned long len; > + int error; > struct madvise_behavior madv_behavior = { > .mm = mm, > .behavior = __MADV_SET_ANON_VMA_NAME, > - .lock_mode = MADVISE_MMAP_WRITE_LOCK, > .anon_name = anon_name, > }; > > @@ -2106,7 +2106,14 @@ static int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > > madv_behavior.range.start = start; > madv_behavior.range.end = end; > - return madvise_walk_vmas(&madv_behavior); > + > + error = madvise_lock(&madv_behavior); > + if (error) > + return error; > + error = madvise_walk_vmas(&madv_behavior); > + madvise_unlock(&madv_behavior); > + > + return error; > } > > int set_anon_vma_name(unsigned long addr, unsigned long size, > @@ -2136,9 +2143,7 @@ int set_anon_vma_name(unsigned long addr, unsigned long size, > return -ENOMEM; > } > > - mmap_write_lock(mm); > error = madvise_set_anon_name(mm, addr, size, anon_name); > - mmap_write_unlock(mm); > anon_vma_name_put(anon_name); > > return error; > > -- > 2.50.0 >