From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4D0C00140 for ; Thu, 18 Aug 2022 11:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271EC6B0073; Thu, 18 Aug 2022 07:18:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 221526B0074; Thu, 18 Aug 2022 07:18:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110B38D0001; Thu, 18 Aug 2022 07:18:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 017E16B0073 for ; Thu, 18 Aug 2022 07:18:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF05E1A09B7 for ; Thu, 18 Aug 2022 11:18:00 +0000 (UTC) X-FDA: 79812463920.30.1F76BDD Received: from out199-7.us.a.mail.aliyun.com (out199-7.us.a.mail.aliyun.com [47.90.199.7]) by imf18.hostedemail.com (Postfix) with ESMTP id BEFE01C0824 for ; Thu, 18 Aug 2022 11:14:38 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VMaUtiI_1660820771; Received: from 30.240.98.116(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VMaUtiI_1660820771) by smtp.aliyun-inc.com; Thu, 18 Aug 2022 19:06:12 +0800 Message-ID: <667ced2a-2724-265e-2019-cf97fa661b6a@linux.alibaba.com> Date: Thu, 18 Aug 2022 19:06:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH] mm/damon/lru_sort: Move target memory region check to head of func To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220818082538.67825-1-xhao@linux.alibaba.com> From: haoxin In-Reply-To: <20220818082538.67825-1-xhao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660821281; a=rsa-sha256; cv=none; b=dHzc6CcAKne4a7gVm+ZUIxY7RGuuXoa4FN1Obfuf0Ujkja1sSpr/ac4Q+9uxzAh5apb9ka SXLll00Yg3ZFRt/p7rN0kAn85wRNKiQJycqHyFfssEtJ+rs78uCq0EnDQgF1hP3byUyd8E +yCTHnfKVuPnrGRYYQaVvMXyGxen7lw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.90.199.7 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660821281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7oBcdDG5gMBma86WkLXs2+uRKHO/I4WzPST6pg4KvM=; b=UkhQTpJfaMJiQJsd9f691oJgYQRqscAUQHYUgANj6O9ZCqQsrXfPRpyKD9cI0JncVxsTH7 v6ba/WGBsGRFV/8iyTQ3Z5r0IBBPlEm0GzK8pcI9pRGqANGcd30yN6zDvqn8VddC9nk7n1 iZI5h7HNyowwbaIViFhNfFVEUU2689o= X-Stat-Signature: or65495ujh5i4zrc8mhwxz8b5czba6dc X-Rspamd-Queue-Id: BEFE01C0824 Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.90.199.7 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1660821278-187197 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi all, Please ignore this patch, i have send a  patch v2 in there: https://lore.kernel.org/damon/20220818105732.34492-1-xhao@linux.alibaba.com/ 在 2022/8/18 下午4:25, Xin Hao 写道: > In damon_lru_sort_apply_parameters(), if "monitor_region_start" > and "monitor_region_end" is not a valid physical address range, > There no need to run the remainder codes in it. > > Signed-off-by: Xin Hao > --- > mm/damon/lru_sort.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c > index 9de6f00a71c5..ac50dca026f9 100644 > --- a/mm/damon/lru_sort.c > +++ b/mm/damon/lru_sort.c > @@ -378,6 +378,13 @@ static int damon_lru_sort_apply_parameters(void) > unsigned int hot_thres, cold_thres; > int err = 0; > > + if (monitor_region_start > monitor_region_end) > + return -EINVAL; > + if (!monitor_region_start && !monitor_region_end && > + !get_monitoring_region(&monitor_region_start, > + &monitor_region_end)) > + return -EINVAL; > + > err = damon_set_attrs(ctx, sample_interval, aggr_interval, 0, > min_nr_regions, max_nr_regions); > if (err) > @@ -401,12 +408,6 @@ static int damon_lru_sort_apply_parameters(void) > return -ENOMEM; > damon_add_scheme(ctx, scheme); > > - if (monitor_region_start > monitor_region_end) > - return -EINVAL; > - if (!monitor_region_start && !monitor_region_end && > - !get_monitoring_region(&monitor_region_start, > - &monitor_region_end)) > - return -EINVAL; > addr_range.start = monitor_region_start; > addr_range.end = monitor_region_end; > return damon_set_regions(target, &addr_range, 1); > -- > 2.31.0