From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CCBC36010 for ; Mon, 7 Apr 2025 16:06:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F3626B000A; Mon, 7 Apr 2025 12:06:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A1F16B000C; Mon, 7 Apr 2025 12:06:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81A5D6B000D; Mon, 7 Apr 2025 12:06:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E2866B000A for ; Mon, 7 Apr 2025 12:06:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 33903121429 for ; Mon, 7 Apr 2025 16:06:57 +0000 (UTC) X-FDA: 83307726474.12.2B310F2 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55]) by imf28.hostedemail.com (Postfix) with ESMTP id 7200FC000C for ; Mon, 7 Apr 2025 16:06:53 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=EpbPh2OI; spf=pass (imf28.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.55 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744042014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJZBRrUQaj1/1hVsLF3rPV05KKS6vp0zkRmfTb0FHWg=; b=o5rDLP0yWtEhmkYN4W6WL/mqc4qdJSi9JAqdkoQHZgqxRtNCSs6wML4l+HcgYWrGTcURCl qLHXIvu0GqrcBthIUp+HSGouiDs/mPX15GdlobVf5oypYMElYnRW4NKV3Gu1YmLKN1OSMz T/KTv6i7WSiqyCJ/z/ICqVHHIc7jV1o= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=EpbPh2OI; spf=pass (imf28.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.55 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744042014; a=rsa-sha256; cv=pass; b=r8PiL4ae68+iyWmgMTg+gFr024gjiVJJjfWXc36WbXDwJlMsoDr+wbdRgT6FJY856YVgtq sQf5oS8ux0TvWLuxLBwr8hUDZgUaeyaRC3DGpRahLG1XdN9b/UFsb1LrtdiEySXYUlJNU4 ISKFr/AQmVpEIbtYV4bnZzZPCvwxqNw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O1GOR+ID6l6j0xHSpDCX/TDNFT966LUaE9IOzn2DimEeaXMEizxCh2Mw7G9szmO7VE4RM9zBbKlOm5inBJQqMbSVxOe8jKOp4J9CCqIUR/PzvkBFolg/LX9N5pd20R8zTxsSy39/gvVgGd0+3SqnHjALA8IXdY9p8OAkSy0BLeCcIC3l2fl1AvNuQndcsh8NoQyfgTzUljpoa7OmeVk9uaK1RpLP2ebHTY6snfMrI4Rtp0wg/LWAK8euGyWhn782cDARdAk+S7CgxlZp7qhinnCr+lhq5CgOtI+6sfAuZP06kaTjPU/bBvzlGDjIYyJ0i7iROrzRaeZqoF1baDqS3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bJZBRrUQaj1/1hVsLF3rPV05KKS6vp0zkRmfTb0FHWg=; b=PlskpKpUiZ0Bo6RG6JNb1R6IAtWZMPpNkZ/srbOlKg/sl4N4EtJtZLnVYQO0X02UI2Jh3Pp7ECHBegbUW6VMYzzFMvafbm8scXEkX22w7ytaGK1C6I1CZqU18DAMzktx/2F7YlnVAMOMns1m50cWw4k55nw0tXTY3Bfyk4SIfvuYLiQUK2K1U42vz61ySKDHlihHYGK3jhZRXH/72YgDdYXHhjNUSUll4becUUiZEnN1qmZ5N9jSTdWeQVUm0FeCEgx+bbb/rc9VgZsPESltFsRN0YuFmiwQDVOBE105VuiramOCHcUO22eps0QwhnMB0RTpN1JdIPCkOPCV/JrSaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJZBRrUQaj1/1hVsLF3rPV05KKS6vp0zkRmfTb0FHWg=; b=EpbPh2OIL4yZWHIRHRuq91Dkcy0RC+fyTX9uqGLpyfDNlVkdNOZDsKK8rTj0szZzJku0tRK5JkvWSj38CoB2y8CdUTKGAzKj9dNplnyHBT1Y3q4Z/WepZI8XOv7zj3FncOoseDrNCRohfBjclc2YFEEpoIkRvRc+uuBWv5PZoL4NmIJ8D9l4NU9g7YJo9pgtIywR8ZZ3lpHm0pw2/0BOyJTayvBFGzNn9qGntdEji3W821rsZbb2uHnz3m0Y7LPznpyvvSqpR5o8mW5U5RbOal4JiTVDy0m1teWxmx3aDGmlG5KkZhBbnVnoEaYuf8fszO6Fl9lbg8DFaQ4ahPbiKA== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM6PR12MB4482.namprd12.prod.outlook.com (2603:10b6:5:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Mon, 7 Apr 2025 16:06:50 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8583.041; Mon, 7 Apr 2025 16:06:50 +0000 From: Zi Yan To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jesper Dangaard Brouer , "David S. Miller" , Jakub Kicinski , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, kernel-team Subject: Re: [PATCH net-next v7 1/2] page_pool: Move pp_magic check into helper functions Date: Mon, 07 Apr 2025 12:06:47 -0400 X-Mailer: MailMate (2.0r6241) Message-ID: <66692A4A-5747-447A-A1E6-678EBB9A33E0@nvidia.com> In-Reply-To: <87plhovtx8.fsf@toke.dk> References: <20250404-page-pool-track-dma-v7-0-ad34f069bc18@redhat.com> <20250404-page-pool-track-dma-v7-1-ad34f069bc18@redhat.com> <87cydoxsgs.fsf@toke.dk> <87v7rgw1us.fsf@toke.dk> <893B4BFD-1FDA-46DE-82D5-9E5CBDD90068@nvidia.com> <4d35bda2-d032-49db-bb6e-b1d70f10d436@kernel.org> <4185FF99-160F-46A9-A5A4-4CA48CC086D1@nvidia.com> <87plhovtx8.fsf@toke.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN8PR15CA0002.namprd15.prod.outlook.com (2603:10b6:408:c0::15) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM6PR12MB4482:EE_ X-MS-Office365-Filtering-Correlation-Id: ce98ce8c-3c36-471d-8f45-08dd75ee34b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZW1JTC9KUitjd3lIcy8vVFc2ZTRMSzFLZGdGem1wTHhOL0U5bC9xVHpaU3pr?= =?utf-8?B?VE1meGhrRkZURXNIMTZzQ3pwZ1g5ZVF2RmlvNkExckFXcTlWM0ZqTGlaL1Bl?= =?utf-8?B?WmpVbzVmNmZ2Um5KdnZVNEcyQVRSZVVsanZwVmdtWGNNWGJBYklRRDYwSmZ1?= =?utf-8?B?MGY1NkJXWFB3RVpHNUQ2clB5eDJnWHBNYWdwZ284L1pYRVI5SmhMcEwvRTF6?= =?utf-8?B?N0VZS2dFRkI5bGorT0RDWE1QVm10aWhORllZVmVWOTEvdHRJaW1BTTBrQUZy?= =?utf-8?B?cDh6UWF3MG55VTEzOGswMmJUbDRlRzE4NXRHZ1lId2IwczJRS0NFUmtXWU9H?= =?utf-8?B?ZjQwV2lYSVhoV1R0UWJuYW5ZTXIxQXFIVHZiNTJZQ1J2ZTcvYTBkb21NVXF5?= =?utf-8?B?QnJMTFRyMzZUWGZJQWZqQy84eXo1MXdNZ0d2SWxURExnVFZQZWRqeVRwVHZv?= =?utf-8?B?UTZhbHZtNVE2L0xLQ0pnSEN6bTNvdS9mbWx3SE9BVmV6WnBiTUFxbmRReFFn?= =?utf-8?B?b3I2K1dUa202bWRXdzJsdXlwd3dRUUczSkwzaXBnSTZEb0l4TGhLWE9LSzZs?= =?utf-8?B?UWlBL0hMeEVkSjJYdDNUa2syUmVNTHNBdVBJZGtCOW5nSHRIaWhsVnRvRDBm?= =?utf-8?B?R3N6dzJ1Z2R2a3kwZnVqdXBUblV6NU05T3p1ZFFWdGlqa3BhVXp4MVA1Tk13?= =?utf-8?B?VGVQZGFVZkNLYm1yWERoN2VkQ0dsb1c4MTU1cTA0Z293aEtJV3lUQ053a1Js?= =?utf-8?B?WVM2aTE3em1VQWVuQmlTeExiaDJHV09hVVZ2U0dob0xQaXA2UVFUQWdtdW9u?= =?utf-8?B?T3RPcklTRVJjZUZRUE5xUWtUWi9kUDluc0gzYmk5TFZJK082VlZXTTFDWUZM?= =?utf-8?B?Y3kvVUJLWmxHWkR0R2RlMzZac1l5ZTdtcXhtS1JSRWI1Y3NxZkVLVU1uN255?= =?utf-8?B?WXMveXlZM1A2Q0YwSmRxMW9pbWZMQkZGS212S3RIa3RDRjEwYW9FZ1lGdlJh?= =?utf-8?B?blRJaHBuM0VjdW1IQkdjNlVVSVJqL2lIVjlNd0xZRlptVjhzZkVMaDh6bTdy?= =?utf-8?B?ZlRXZ0h3YnI1cHlZY0V2VHJ5bGUrN2NRcmZRYkVEYzBDYms4OWxFeDQ5aExr?= =?utf-8?B?bG55UlZzbUwyUFc5QW9hM0NLYXhRMm5MVXo3WktDRjZiYXNoYlk4ZTg3bnNa?= =?utf-8?B?bGdOMWxIaVZYcXdVLytyU082blVybFBuVjlNalhGME9SMk1ad3VRbUdBeUtD?= =?utf-8?B?V0FhaEdZbU9MQ0lkUVBJR0w5aUJEWUtidGhQU0E0RkxOYmpqcFlTTlAxYndr?= =?utf-8?B?OFZzWURBTGJDUHZLZkx3MzJOd05Ob3lmcDY2SWUxNnFBbkVZV1hvZlluRG9j?= =?utf-8?B?L3lnMG8ydXVyN2VFanRqZEhRamtOTzRCdGFoMDRneTJYKzFvR2I1RkROdGla?= =?utf-8?B?aHU3S2c4QVRWa2RLNDY2dkZRaUtUQ0lSRzdUQ0NEK0ZCM04yMkwyS2NjOENV?= =?utf-8?B?MGJFV2pIcnJ5MDVrL2UwSXNReDJnbFFLM2V3MER1dWo3RCtlRzdPTEtUdkRK?= =?utf-8?B?dWNHcHUwS05lTExCOVZrQmQ0SGZNQ1NIT3A1YW95V1pETnV2V3JIaE84SFhB?= =?utf-8?B?N1N5S3pSaW1OR29KT05Ud00yeksrV0I3NWZid0dyYVdtWmhTdm5GTFA2V2pO?= =?utf-8?B?ZHBJelhLa2haK2JyQ0RtNXdkRDFHNSs3QUdTd2RIRjk4T2VveHArdU0vaVZr?= =?utf-8?B?N1ZkcnoyVTZqcmY1R3kxVGNvRldoSzQyWVNGbkxZZ0k3RkREMU4waVhWdE4r?= =?utf-8?B?OW9mQUZFdmdaUGRpV2JkMFJJa1JacTZYakRLUDRjSlhwaWpEdGQvK1I4UWJo?= =?utf-8?B?T2ZHdDVOWUVsblR2Nnc2TUlvblIxdUFCazJmSlE3L05uREdneXNmOFd0Q1lC?= =?utf-8?Q?w4UITc64Tdk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmdqZXhtdzhacnJrcC9zU2Y4WkhjcHZFak1qbGNiaDJMaERtWDVzbmRDeU9j?= =?utf-8?B?MVdVcVFJbEJZSngyY2JuL1ZYRHQ1aHV4UVl2TVJNYlRibzgrYzlPb1ltMTVQ?= =?utf-8?B?TVMxazJqM1V2Z1FLSUlwdkQ1c1dEU0ZzU1NTMXMxZFZ5c0dFMmplMDZhQW9N?= =?utf-8?B?aHhLTVEwbEFieFBtWmx4SGpzQzFnK1J2dWZNYWNkSHNYY2tWYk8xMWtxRGky?= =?utf-8?B?QWZFZEw5MUF2V0NpMUJpM09ld083a0lTa2FFM1BrZ2E5dXdJb2ZiOC9idXh3?= =?utf-8?B?TTJCQTRQVUplTmFRWEZIbWR1T1k3eXVnalNWakNGZ0huRndkdjNKZXRqcWlO?= =?utf-8?B?OXRQRml2ZlJSWVIySkZtT0ZvVHROT3d2Y2RZb2picm9LaXdDSWw0WUNEOUZ5?= =?utf-8?B?UFRNR3JKRFEwbzFKQUgvekpBMjU2V3cvMCtjMUxlOTlFREg2cnhkSy90OVV1?= =?utf-8?B?QkYvTnlaZitib2ZobjJDWHNUNW5iM083eFBrQXFHMmlCK2ZGOVg1ak1uM3Fy?= =?utf-8?B?Ti9tWmQzQy9LWFAya2NsR05NTGphcld0dlhhNlJSNkV6RHZjWlJOT2FPOEt5?= =?utf-8?B?VU9XSlZ5K2RiUjVmUng2czYzUzM4ZHBNZXRsdHp6a01mQWttM0s5RXBuK1dL?= =?utf-8?B?VTlTdnZwVm1RTTFhcmNsVHk2bzFoNXFhSFk1RGsvb3hOL1dNNzlKdjZRd0gy?= =?utf-8?B?azRLVE93WjByVjh1M3FEc1hyRnFSOWt1MDUxR21xcTluMkMrYkQwRHluRzFC?= =?utf-8?B?TW9LS2RVNjh6UVV2MzRFSWNUbTQ1eUF3bHkrTGpPbFI0SWl4YmtmcFNMeFU0?= =?utf-8?B?S0RsMmgzRld2R3gvR09OaUhjblZVcGQxZ05nR3VhNlFEQ0VobG9udUtrQllM?= =?utf-8?B?Y21ETEVOb1IwdEJnU0Npbi9IaDlmMTZ6UHNoK2pwSmxUZ3pvbkUvWFI3OXVI?= =?utf-8?B?NHdEaGtDcm5Ib1lUek5Ga3ZTcjZRVEhiT0hUYjhMOHJHeTZXYndvb1BrNEs4?= =?utf-8?B?Wi9KQmkweEdISWhJRFg4blVOczl3d3AreVo3N3hVc0t3QjN3L1FueFd3QzBY?= =?utf-8?B?WDBhZEpDdS9Mbm5idDlTL1VMMGl6U0QwTGEzUk00WmhSZmh0aEdjY2ZUR2lu?= =?utf-8?B?ampldmszZU9JelA4MlBYNVhzeEVVbGQ0SnQwRDF0UWRoUFk0VGhYdERNa0wv?= =?utf-8?B?M09LY1Ywb3ZLNk5YN1cxQ0szUWVjcWFsK1BMNVM4VVdJWC9RUW9qem9rUEVH?= =?utf-8?B?RnV1a0xJTGhsOXpQVm5Ubms1Ny9LY3Y1QXozZm5sNi84NS9QTXU2d0FheUZJ?= =?utf-8?B?UXdZVDVDaW5SeHRRVGlwZHdvakRwQzl6S3plU1lSRlkxK09iaC9IckxLUzlt?= =?utf-8?B?MlVuVXJIbmhMcGdqVWNQYktXdW9URFZ3cUlYMVA3TDBTWm1QWFlxTmFaNTB0?= =?utf-8?B?cm9iNTJOSkZwZElzUnJmaHJ6Vk1kcHJFd1Vid29mSU00SmJIcm5reTkxUFo4?= =?utf-8?B?cVgyT2pCMU9WRTRJRHY0UDlZelpYUlF3ZzZFM0djOUhEb2NvM2ZWUFU2N1cy?= =?utf-8?B?UTZBM2FnL3NZZGh5U2RaS1dseEEwT0NrMmtYWHlqWWJqSmhjamtjdEZsR1JK?= =?utf-8?B?WmpYMjd3cUJvMlYzYVBOT0ljaGNhanpUcFdJSGhRTndvOFkxb05xdXhnd3hE?= =?utf-8?B?bDA1a3FzTk80ckZqRXMxSnNhRGtoRXAxNUx1TFpzbTcrZ3l0M3lIU0x3aHJl?= =?utf-8?B?NGhGa3lZOWxBc0tGaG5qZm9FQXliZXFjWXNWZmttQ1Bmd1JKT0ZkUnF4K1N6?= =?utf-8?B?OTNhWjFIU09KVVpUK1p0eXdvd0cvSHVYbjZTaVZhbGoxMU1kVWlNTXdhUlhJ?= =?utf-8?B?RjFxNStnWjdkYzNINnI0dEFxTXFoYmdqNFNqOVhnSWZpS1cxZ0hjNzByVCtm?= =?utf-8?B?VWN5MDVFcm1kc0xGUGJHdWI4V24yYTFHN2ZBM1owanN5WUJZeXpOZkdFcHlm?= =?utf-8?B?ZDVPR1U0VjNMVVJ0YXE2blk3K0ZhcHRMWkRzbnhMZGFVOXREUEc4YUwwYWVC?= =?utf-8?B?b001WVFMcFRYRTlCeTc2ckcrTUwrM2l0d21UR1ZFb0tJYlFTSEFIVFdMeUVy?= =?utf-8?Q?CrrLN+oLhCV53fq5YlFeFx0tc?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce98ce8c-3c36-471d-8f45-08dd75ee34b8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 16:06:50.5034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ECYNwxlRKZZEfwPmnzQGIjBAAG6av12UTVX84EeeVfcHKA0KendYninJ0UxqZvzT X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4482 X-Rspamd-Queue-Id: 7200FC000C X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: ujoehznrw65tktwmyhx949arxf6y5s58 X-HE-Tag: 1744042013-549141 X-HE-Meta: U2FsdGVkX19moROLxELLw1CakU6YJ8X2xBuxFQssX11LftY1wo/SiWDA/qV6dZ8L1Hgii5BRfKT2CEC0mXmjN3B/JBLyZk55paMAtA8ACwU8juFbIcQGq+XUj4nqFwJaYcvOmsY88fESZOoIxx04hcciy33fiDnxS2jnUrfwzsjDZwRyaCnSbZIMeMj+c18chS/g2Io/teJVlUjaYCSC1K/+yntd4/21hOCFbvc+j1SL0AWZTvAGu70PJMohr0ttYD2grAk1lIdYkneFTCfWdR0qL49UHBL9Fuok1fRP/W2OLMlojYrQGFGjixvi7Oh6LJqLyiQFWA6x9ihSKBdwJlIO/KRj9tpcSbsk9qRDThoEvYJHJhULuC1grZQJwwQhGTif1fszQwHq0cDaXSn9QvojeuRkKlX03Z6+eaAd4f6Ve3KGLeMcC2zIJly+Qe2daFSWQy+n7m40Dpu0cp9fedFvbOteQaCYM6IrzJOXbbiZjU/qRRxNsOh6w2N1y1DFvKADspGlDWcHb56edQtQBhSz3+xHtejm4p4brN+Muxy9MWaT+IgX4V2ZCEEm8nrq/1VNaXrj5hL7I+8Hp2307JPBmwbP4pzsjopBAgcZKtrZn1GmY5O5Eqq+aegfA1kSaj9vK5uvZ1OHAu2e8Oe/JppIAHVk8SqKQJxMpBVheumuLQqH+WsdMFzpc/9NuKhC9lb7TGoPAUVyl1BA5uJhSP2mUfVXEBVvEh4jLdQVsCyjBe46IhMtfq/EM8KwsrqFo8i+JPBXzDbJrPvQEYy8I7wBtjdeQrJATbhpalN0F5D/c3gx018UXiBxMEPztYg1NGYheZIOGqQpMnlUTz4Iif2VpWb/bQ4Mf7fe0QOu8Wz041xSlEWTwC+WAfuXuQerd+oNTLk0ovOMhbyW+/eyq9h/iB0JNLgJh+LuvzqC4tQF6mlu1JzDQf0+67HNeotj96VH5M6Btgf4G+Eowv/ Z9I5U5S3 6bAFSLQ13EAm3aHUTYzSPhy52gnG4kb76+Mxzaj1Fv+1KIvxaXSHT7qCorC5RyhFoABi9l4KL8po01LyX17Bw3qoKVM9iXygoaFbsRLFyBgm77WfKtm34SyAGt9cRTylB8ZyGNvnetVS77juzEUdxGdik7955of1l3hn2v9DBDcc9X33FDwHGDnE3ub++mMVzcbAF5deX2ePmtCA03ckg1hsx+CzN8r6KZKfmUtzXqeqHKH6eSx9urT/5kNSd7P0j1yeayJh7U56/tcoLnGf6prRjWUbi7ckGz0aaeh2N2iqePR3txWWAOAtKQLFoSEMlxWGoy0FTkvwIXP8JLcHceWBjPGcQeT4pxFZltOtbAcsp8ceq7n/xWgkkdwQ1SbMkjZKcfiJ5ZhYva0//hCDOBsmbUDzUcwzmwbJOSONhIZxDlaNKRScBt64zNrtYqWty0tnUF+SYfOJnYk3+/r7EMUkV7S3NOnqBrjlmiv29NabbmTNKAc+f+hQcptfgEo41FPxvSEmqOF5QRhm/6gPqiZfrLK8nxoBvjQ/4Y06+T8Iz/NTUTRVDF0XfYVi8c9uLEtpesrHiebFMgSW3VgYEdu6YKV4iyPQcXm5k0sT9GRwW/LGWVQAXrWDwCviMfcGecKxZ0BUVaVShH+U2YrlVbmB7vvxr+6IEg6OWB95BTZTV6W8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7 Apr 2025, at 12:05, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Zi Yan writes: > >> On 7 Apr 2025, at 10:43, Jesper Dangaard Brouer wrote: >> >>> On 07/04/2025 16.15, Zi Yan wrote: >>>> On 7 Apr 2025, at 9:36, Zi Yan wrote: >>>> >>>>> On 7 Apr 2025, at 9:14, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>> >>>>>> Zi Yan writes: >>>>>> >>>>>>> Resend to fix my signature. >>>>>>> >>>>>>> On 7 Apr 2025, at 4:53, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>>> >>>>>>>> "Zi Yan" writes: >>>>>>>> >>>>>>>>> On Fri Apr 4, 2025 at 6:18 AM EDT, Toke H=C3=B8iland-J=C3=B8rgens= en wrote: >>>>>>>>>> Since we are about to stash some more information into the pp_ma= gic >>>>>>>>>> field, let's move the magic signature checks into a pair of help= er >>>>>>>>>> functions so it can be changed in one place. >>>>>>>>>> >>>>>>>>>> Reviewed-by: Mina Almasry >>>>>>>>>> Tested-by: Yonglong Liu >>>>>>>>>> Acked-by: Jesper Dangaard Brouer >>>>>>>>>> Reviewed-by: Ilias Apalodimas >>>>>>>>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>>>>>>>> --- >>>>>>>>>> drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- >>>>>>>>>> include/net/page_pool/types.h | 18 ++++++++= ++++++++++ >>>>>>>>>> mm/page_alloc.c | 9 +++-----= - >>>>>>>>>> net/core/netmem_priv.h | 5 +++++ >>>>>>>>>> net/core/skbuff.c | 16 ++------= -------- >>>>>>>>>> net/core/xdp.c | 4 ++-- >>>>>>>>>> 6 files changed, 32 insertions(+), 24 deletions(-) >>>>>>>>>> >>>>>>>>> >>> [...] >>> >>>>>>>>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>>>>>>>>> index f51aa6051a99867d2d7d8c70aa7c30e523629951..347a3cc2c188f4a9= ced85e0d198947be7c503526 100644 >>>>>>>>>> --- a/mm/page_alloc.c >>>>>>>>>> +++ b/mm/page_alloc.c >>>>>>>>>> @@ -55,6 +55,7 @@ >>>>>>>>>> #include >>>>>>>>>> #include >>>>>>>>>> #include >>>>>>>>>> +#include >>>>>>>>>> #include >>>>>>>>>> #include "internal.h" >>>>>>>>>> #include "shuffle.h" >>>>>>>>>> @@ -897,9 +898,7 @@ static inline bool page_expected_state(struc= t page *page, >>>>>>>>>> #ifdef CONFIG_MEMCG >>>>>>>>>> page->memcg_data | >>>>>>>>>> #endif >>>>>>>>>> -#ifdef CONFIG_PAGE_POOL >>>>>>>>>> - ((page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE) | >>>>>>>>>> -#endif >>>>>>>>>> + page_pool_page_is_pp(page) | >>>>>>>>>> (page->flags & check_flags))) >>>>>>>>>> return false; >>>>>>>>>> >>>>>>>>>> @@ -926,10 +925,8 @@ static const char *page_bad_reason(struct p= age *page, unsigned long flags) >>>>>>>>>> if (unlikely(page->memcg_data)) >>>>>>>>>> bad_reason =3D "page still charged to cgroup"; >>>>>>>>>> #endif >>>>>>>>>> -#ifdef CONFIG_PAGE_POOL >>>>>>>>>> - if (unlikely((page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE)) >>>>>>>>>> + if (unlikely(page_pool_page_is_pp(page))) >>>>>>>>>> bad_reason =3D "page_pool leak"; >>>>>>>>>> -#endif >>>>>>>>>> return bad_reason; >>>>>>>>>> } >>>>>>>>>> >>>>>>>>> I wonder if it is OK to make page allocation depend on page_pool = from >>>>>>>>> net/page_pool. >>>>>>>> Why? It's not really a dependency, just a header include with a st= atic >>>>>>>> inline function... >>>>>>> The function is checking, not even modifying, an core mm data struc= ture, >>>>>>> struct page, which is also used by almost all subsystems. I do not = get >>>>>>> why the function is in net subsystem. >>>>>> Well, because it's using details of the PP definitions, so keeping i= t >>>>>> there nicely encapsulates things. I mean, that's the whole point of >>>>>> defining a wrapper function - encapsulating the logic =F0=9F=99=82 >>>>>> >>>>>>>>> Would linux/mm.h be a better place for page_pool_page_is_pp()? >>>>>>>> That would require moving all the definitions introduced in patch = 2, >>>>>>>> which I don't think is appropriate. >> >> The patch at the bottom moves page_pool_page_is_pp() to mm.h and compile= s. >> The macros and the function use mm=E2=80=99s page->pp_magic, so I am not= sure >> why it is appropriate, especially the user of the macros, net/core/page_= pool.c, >> has already included mm.h. > > Well, I kinda considered those details page_pool-internal. But okay, I > can move them if you prefer to have them in mm.h. Thanks. Best Regards, Yan, Zi