From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Mark Brown <broonie@kernel.org>
Cc: jeffxu@chromium.org, akpm@linux-foundation.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
linux-hardening@vger.kernel.org, pedro.falcato@gmail.com,
rientjes@google.com, keescook@chromium.org
Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests
Date: Thu, 29 Aug 2024 17:32:29 +0100 [thread overview]
Message-ID: <6667ec01-d379-4c4f-a04f-b64ca0e87de8@lucifer.local> (raw)
In-Reply-To: <293ce8ff-10c3-46b8-a56b-a1bddc7aa37c@sirena.org.uk>
On Thu, Aug 29, 2024 at 05:16:50PM GMT, Mark Brown wrote:
> On Wed, Aug 28, 2024 at 10:55:22PM +0000, jeffxu@chromium.org wrote:
>
> > Add more testcases and increase test coverage, e.g. add
> > get_vma_size to check VMA size and prot bits.
>
> I think this needs to be split into multiple patches, for example the
> new test cases done separately to the additions to the existing ones,
> possibly as multiple patches (eg, should the size changes be split from
> the prot ones?).
Agree wholeheartedly.
next prev parent reply other threads:[~2024-08-29 16:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 22:55 [PATCH v1 1/2] mseal: fix mmap(FIXED) error code jeffxu
2024-08-28 22:55 ` [PATCH v1 2/2] selftests/mm: mseal_test add more tests jeffxu
2024-08-29 14:45 ` Jeff Xu
2024-08-29 15:14 ` Lorenzo Stoakes
2024-08-29 15:30 ` Jeff Xu
2024-08-29 15:44 ` Lorenzo Stoakes
2024-08-29 19:54 ` Jeff Xu
2024-08-29 19:58 ` Matthew Wilcox
2024-08-29 21:34 ` Jeff Xu
2024-08-29 16:16 ` Mark Brown
2024-08-29 16:32 ` Lorenzo Stoakes [this message]
2024-08-29 19:40 ` Jeff Xu
2024-08-28 23:38 ` [PATCH v1 1/2] mseal: fix mmap(FIXED) error code Pedro Falcato
2024-08-29 14:03 ` Liam R. Howlett
2024-08-29 14:36 ` Jeff Xu
2024-08-29 14:32 ` Jeff Xu
2024-08-29 12:09 ` Lorenzo Stoakes
2024-08-29 14:34 ` Jeff Xu
2024-08-31 1:15 ` Andrew Morton
2024-08-31 10:14 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6667ec01-d379-4c4f-a04f-b64ca0e87de8@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jeffxu@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pedro.falcato@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox