From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9ACFC369BD for ; Thu, 17 Apr 2025 01:29:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE866B00A7; Wed, 16 Apr 2025 21:29:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87166B00A9; Wed, 16 Apr 2025 21:29:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D8C6B00AA; Wed, 16 Apr 2025 21:29:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A57546B00A7 for ; Wed, 16 Apr 2025 21:29:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9B1245D738 for ; Thu, 17 Apr 2025 01:29:36 +0000 (UTC) X-FDA: 83341803552.20.166402F Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf12.hostedemail.com (Postfix) with ESMTP id B1AE740005 for ; Thu, 17 Apr 2025 01:29:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N1cHkyiM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744853375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L0gLeQVBA/1TN3OHnR2dfCZ1PPm9waoie4D5AdMGKf4=; b=7PzcEXHi5Lrq2MkJzRwS0DCcPFT3Dr8bdcCg9vz88WH51NNROV6cN2LSUKL/OwIuuNa3lz /bN2tuMTJ5vhY/F7u+NjeY7EFdjdfqAafPIgW2hp1PCQwemcR7A70IPWcxhbPonSIzelkn NFblGTjiYPGu9F0/FjTPQiSEoGJWVhA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N1cHkyiM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744853375; a=rsa-sha256; cv=none; b=7nqruiQy1QEaXHF46aZJLNndvIs617DbZwYC1ku/TFD0O/3byUyP2RTTr8HxpVFLybPDNp JjCbPwE20imHZJn0eii+L7f4Abv5OHXfqlxXBjCqcc85CnHv0w5cE5Xaq6D5BlURLbOE7W SN57iGyKzROJWISJC5JewxhIfJ2wmzw= Message-ID: <665652ac-2e94-48b4-bf47-32870b823464@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744853372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L0gLeQVBA/1TN3OHnR2dfCZ1PPm9waoie4D5AdMGKf4=; b=N1cHkyiMXLR7vMguTWELg9BfjiIi0zSwEppi4YHck13tnQjhoTnwyYaEipVrO+TdbGv13g R2SdWUpFNt20o/7l57O5Lsf/22qE2xhmhgCpv89sRVZ1KckOtpXshr/3MLA0t4C5gC9Dei Nht/vCEsl6z7QxDjdqTaDnEy2sdrG1Y= Date: Thu, 17 Apr 2025 09:29:23 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] tools/drgn: Add script to display page state for a given PID and VADDR To: paulmck@kernel.org, Sweet Tea Dorminy , Andrew Morton Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, linux-mm@kvack.org, Ye Liu , Omar Sandoval References: <20250415075024.248232-1-ye.liu@linux.dev> <20250415191414.a64de2d228ab5f43a5390acf@linux-foundation.org> <42f50a48-10da-4739-9e51-f865fbf04bdd@linux.dev> <098e977c-55cd-498b-bd36-725333c06210@dorminy.me> <7e45afc8-dde0-481a-b0bf-0237f551ebe0@paulmck-laptop> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <7e45afc8-dde0-481a-b0bf-0237f551ebe0@paulmck-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: xc5azgni9s3rmf1tkoyucgq7yyo3wpmd X-Rspamd-Queue-Id: B1AE740005 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744853374-689453 X-HE-Meta: U2FsdGVkX1+4BNGJHP1emg3eHJLAT4X8yD0k5CxD0iMuKKHkgYK9PUOgj8170Fqz08gNcxqDXlpjD5yOsB5y3f9w1K1CtqK2omH6jc8/8wi8asRBE8cxfBjNUYpPAJGWMMZyS+Cor0nmufh4GK1dlQzTMFEh4LqPER8a0EsweszDNy+8/EwM1RAldIr7JDUMZkXQn/Y4aiWv2usrylPXWPg4CBOSfzZ/Zu8Rj+610P+C6dzOKoLYHW/0uGLEWYuSACp+57VKbgaF3qP77Zn6k4gViiij8Ftv5w0kjU+nKuFEu4Z6qdtbdtCBbchj9+z/oXnBY9Zvu9afqvrjGXaF1nXM2mGUc8PRO7W9nAPRgMG33K+7LAEf0GwTCOwnfHh5l+IjwSSBZcEc+rhTywzpwFB4iYyqPDZvAw2hgkT2DXEqw5UAgfHVPa7WT/cqpIcBIVll+IjF/zsplerjB15Iu7yCNWHBoWxkn+4jv4DqbGmM5RcaaoZmybx3Ty3ruNotqFs9Ws9vY7/N/6WH8Kp2u8PWcDqUCRU4fC7QXZHkM9UmL3SvfE4Bdj80a4Hhemi6zU6t/vS89idZ79RtYs62wYxWxHCpkhD9uMJNzGHVnM3iG4OG7i5aUhVuQ5S8cTgcq0jLIooQSjl7KUX9+fnqkhXt7HhNIw/u/CoQTwkktiQhEC8uVoF2YOttgrHXtFaYF6/cqu8OQmKHJo77xxZrHbuy2yUJGUJ+f2ZM6SRcwJSKwCNzhs7aAlx8ZnAY7lRqarUlbXZQX8upo1D41atrode9R5BaMvN3kgISsk6hKcrhu9ESnVuECIXQXiDVje4w+GY2WceYvKc5OsDWvgpxg0avUzpw1w5DFX8MeBKe3FlI8rXWVR2hRjmYUOzpLmsoXt0NJdIdt6xcFB6qVZR6VbAsdYZKGnAiBxRgmw2Oa2IZ2nUXRBSUooILZ0WS2RnImHgTbafDIYx+Jhzugz4 QENLNyqc Fiedk63spDtnSmNlNwW4DTPyTACycoAWr0mrZiocirrgRP4nZMFzpj3NNHpGHb4dwh2iK+hSfc/tC+IgcTDLvTVCQJFxAy+1/kamxoQePAMveii11RJWCSHflbEu+wiEt4h2qZrDpAi7vhGRQAT8Q0Zc08vfkdxchC/dxmRlFrpEJL6E1KZKmCS/AVNi8lFuHqovuDEPBNN3Tj3tG4rXYj9VjdJBqLwW/uGqj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/4/16 12:02, Paul E. McKenney 写道: > On Tue, Apr 15, 2025 at 11:28:41PM -0400, Sweet Tea Dorminy wrote: >> >> On 4/15/25 10:46 PM, Ye Liu wrote: >>> 在 2025/4/16 10:14, Andrew Morton 写道: >>>> On Tue, 15 Apr 2025 15:50:24 +0800 Ye Liu wrote: >>>> >>>>> From: Ye Liu >>>>> >>>>> Introduces a new drgn script, `show_page_info.py`, which allows users >>>>> to analyze the state of a page given a process ID (PID) and a virtual >>>>> address (VADDR). This can help kernel developers or debuggers easily >>>>> inspect page-related information in a live kernel or vmcore. >>>>> >>>>> The script extracts information such as the page flags, mapping, and >>>>> other metadata relevant to diagnosing memory issues. >>>>> >>>>> Currently, there is no specific maintainer entry for `tools/drgn/` in the >>>>> MAINTAINERS file. Therefore, this patch is sent to the general kernel and >>>>> tools mailing lists for review. >>>> Help. My copy of linux has no tools/drgn/ >>> I noticed that the current upstream Linux tree doesn't contain a >>> `tools/drgn/` directory. >>> >>> I'm interested in contributing a drgn script tool as well. >>> Given that this directory does not yet exist in mainline, where would >>> be the appropriate place to add new drgn scripts? Would it make sense >>> to create a new `tools/drgn/` directory, or is there a preferred >>> location for such debugging scripts? >>> >>> Thanks, >>> Ye >> I believe the traditional thing to do with new drgn scripts is to add them >> to the contrib directory in drgn via pull request: >> https://github.com/osandov/drgn/blob/main/contrib/README.rst > I have an RCU-related drgn script in tools/rcu, so maybe this one should > go in tools/mm. To determine the most appropriate place to submit this script, I looked into existing drgn-based tooling in the kernel tree. Several drgn scripts have already been added under `tools/`, such as: - `tools/sched_ext/scx_show_state.py` - `tools/cgroup/iocost_monitor.py` - `tools/cgroup/memcg_slabinfo.py` - `tools/writeback/wb_monitor.py` - `tools/rcu/rcu-cbs.py` - `tools/workqueue/wq_dump.py` - `tools/workqueue/wq_monitor.py` Given this precedent, I believe it would be reasonable to place `show_page_info.py` under `tools/mm/`, since it's focused on memory subsystem internals and would follow a similar organizational pattern to the above. I'd appreciate any input on whether this is a suitable direction. I'm happy to send the script for review once the location is agreed upon. Thanks,   Ye Liu