From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A44C5478C for ; Fri, 1 Mar 2024 14:23:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2F176B007D; Fri, 1 Mar 2024 09:23:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADF7E6B007E; Fri, 1 Mar 2024 09:23:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CFBF6B0080; Fri, 1 Mar 2024 09:23:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C3AE6B007D for ; Fri, 1 Mar 2024 09:23:28 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 387CAA11AA for ; Fri, 1 Mar 2024 14:23:28 +0000 (UTC) X-FDA: 81848688096.18.DD5402A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 6BDD3A0024 for ; Fri, 1 Mar 2024 14:23:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709303006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Co1iJdeLbS98PLK3qESI+pRqwydcMmdsnr76v5BgbE=; b=hjxgovy9n5xIszeijYWIGvpqbfhPTXxl5sro+R06lrik2XE25JdQRO9TSWhvi5dBjBLTMZ MzL48RzZ0XZUEIsWCZu9Ejh5iSlutrgU3cx0BGaIA51+H3e9t2hCS4UVszbXQCgvjruFD5 2schfPgdA78QygS2gKPc8gASkozXpyc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709303006; a=rsa-sha256; cv=none; b=PkX0i2zszKnszDKZJ2LAXGaSpjvkalLYg17z9wewAWqhEvrEyeQ9oeTHwJjKhQFbEKA9xo 6Nh9ezY+Oi6Af2F9pXWaGRTgZ0Vsx917LvoFcly8Uc7qMDUcrg4V9hRrTWwW6PMy1gmz5L sjliWvJQ58hpb1j6L2/p/d/2+3hKiM4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7E271FB; Fri, 1 Mar 2024 06:24:03 -0800 (PST) Received: from [10.57.68.58] (unknown [10.57.68.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DA013F73F; Fri, 1 Mar 2024 06:23:22 -0800 (PST) Message-ID: <6645287e-d069-4c37-823b-d1b814ec0efe@arm.com> Date: Fri, 1 Mar 2024 14:23:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order. Content-Language: en-GB To: Zi Yan , Aishwarya TCV Cc: "Pankaj Raghav (Samsung)" , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Luis Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown References: <20240226205534.1603748-1-zi.yan@sent.com> <20240226205534.1603748-9-zi.yan@sent.com> <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com> <2ED5C25C-FDB2-490F-B740-E413E8186C12@nvidia.com> From: Ryan Roberts In-Reply-To: <2ED5C25C-FDB2-490F-B740-E413E8186C12@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6BDD3A0024 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7atr6zaiwon5tjxtmmburnnekct3t4g7 X-HE-Tag: 1709303006-939881 X-HE-Meta: U2FsdGVkX1+dwz60nhGsNMIp1WQzRGbkQHD2edk+cb6wwy3+XOb5+ZbGpHoRPJiYrrwLCbxoO3HftnmPkOmEBGddPuv86Kq/rpbfN6e51esm1MnkTFdJmgbW5m6Qy1vc/IZKN+Xzfi4N78NoetBVRGU+Wn8M1Zs69MVWf43T4bwLxbk4NqIhL64maj7nv0xKJrdsb5hk8Rx5QJfl7P2RKY2qFoBuSnuwjMkwNzzcPclZMnvRkTRqEHHle1rwNg3x8uW6BVqMUbJYDtzj0Op/d6S7KvVy6TkfxGZm2DVjztrYUh+bLpHW2PLg4q9nWfz2gWM2ZohnB8UMyTT3BTmKNgoswFv9EH4k50YkVrsWcxfK0659AnLUVjAOkCZIj0EwIgJZhAbIls0OHDTpxFPPJ/+bfKGAl/Uk3yiLfusjM/cF4HsX1H5ixPW5FXnuL0GWr/kyL6bEagZsYmk257uyzsgLTYahiRBYrcLW39QHWxRLsv3sQABWIrDjSMY6Jt33c+nBdKuxehMQu8WXV8cTdmxeV7g2ZH8bR0HlwqVbs619DkECCx7cHafe/Dikubs8qBFvl4nn3cF+eV8mofvUD0D1gmfxVtV7v/0f4l84RTkU+jBRS+NOizD8LRuqQ/5fKMzxRr1eYJvuBPfl5oZa6rjoPWdRLOmRUtJIlr/NBwwR83BdaLKnTAnOCjhcRzDOizKH1tLXrfAYRdPryPPhgZnn+xVfF3yQhARP3qW1PzAwlMaiPlQXHG7yFFQst31DXB4K7WNp2wC7Lzt2IGqp3QTwBiX5C4a33RA3cIUIx10HHHCC/BWqAOH55pJKCSKrZEo8DxdmG89og+/IGgtDGo8/D5W1yvHH7xcwToldAMG3T7e+1mio0CRy3+FnQwHP7j3N9oZxSHQAPA6xlAEHJxSp6UbrS9dbozLNF8/b4s6mWmFnLubtHxga815k21GOdG/m6wNoKRqooI0LWIC GITfq/P7 aDRULFwPTN/MxJ8H8avOWz6NhZtUXs4O5DYmAbIjS/gyl/Y9iaFKg/k7jMzjxP1QOX3h3sVxsJMxcizdp455x9wnUmnc8aKAWbhQFgvTdSAYgTdbkvzRPZUL6Qu0KiI39O4ftIfamxCNKZek3IB0KPOX8Cpbw7gDfskUjhYd7yL6KLEY6UZHMaX4O+JJ0Z2XKqzjar34H2lxDr3pTQQR3xeXERY2X7IxoBGXk/bGV5tM+JGi1h7UIvDKcyzWhKvy3NxbfNYwVpLN+4a+co8TP/WDEdtoU/evJ1PBXg02UdVIEU7wgRJY+50WOfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/03/2024 14:00, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via both >>> debugfs. >>> >>> Signed-off-by: Zi Yan >>> --- >>> mm/huge_memory.c | 34 ++++-- >>> .../selftests/mm/split_huge_page_test.c | 115 +++++++++++++++++- >>> 2 files changed, 131 insertions(+), 18 deletions(-) >>> >> >> Hi Zi, >> >> When booting the kernel against next-master(20240228)with Arm64 on >> Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page_test' >> is failing in our CI (with rootfs over NFS). I can send the full logs if >> required. >> >> A bisect (full log below) identified this patch as introducing the >> failure. Bisected it on the tag "next-20240228" at repo >> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git". >> >> This works fine on Linux version 6.8.0-rc6 > > Hi Aishwarya, > > I am trying to fix the issue. When I am compiling selftests/mm, I encountered > the error below when I run make under the folder. Am I missing any configuration? > Since you are able to run the test, I assume you know what is happening. Thanks. for what its worth, I usually compile from the top level directory with: # make headers_install # make -C tools/testing/selftests TARGETS=mm install INSTALL_PATH=~/kself Perhaps the below is due to the headers not being exported properly. Bad things definitely happen if you omit the headers_install step. > > vm_util.c: In function ‘__pagemap_scan_get_categories’: > vm_util.c:34:28: error: storage size of ‘arg’ isn’t known > 34 | struct pm_scan_arg arg; > | ^~~ > vm_util.c:41:27: error: invalid application of ‘sizeof’ to incomplete type ‘struct pm_scan_arg’ > 41 | arg.size = sizeof(struct pm_scan_arg); > | ^~~~~~ > vm_util.c:45:35: error: ‘PAGE_IS_WPALLOWED’ undeclared (first use in this function) > 45 | arg.category_anyof_mask = PAGE_IS_WPALLOWED | PAGE_IS_WRITTEN | PAGE_IS_FILE | > | ^~~~~~~~~~~~~~~~~ > vm_util.c:45:35: note: each undeclared identifier is reported only once for each function it appears in > vm_util.c:45:55: error: ‘PAGE_IS_WRITTEN’ undeclared (first use in this function) > 45 | arg.category_anyof_mask = PAGE_IS_WPALLOWED | PAGE_IS_WRITTEN | PAGE_IS_FILE | > | ^~~~~~~~~~~~~~~ > vm_util.c:45:73: error: ‘PAGE_IS_FILE’ undeclared (first use in this function) > 45 | arg.category_anyof_mask = PAGE_IS_WPALLOWED | PAGE_IS_WRITTEN | PAGE_IS_FILE | > | ^~~~~~~~~~~~ > vm_util.c:46:35: error: ‘PAGE_IS_PRESENT’ undeclared (first use in this function); did you mean ‘PAGEMAP_PRESENT’? > 46 | PAGE_IS_PRESENT | PAGE_IS_SWAPPED | PAGE_IS_PFNZERO | > | ^~~~~~~~~~~~~~~ > | PAGEMAP_PRESENT > vm_util.c:46:53: error: ‘PAGE_IS_SWAPPED’ undeclared (first use in this function) > 46 | PAGE_IS_PRESENT | PAGE_IS_SWAPPED | PAGE_IS_PFNZERO | > | ^~~~~~~~~~~~~~~ > vm_util.c:46:71: error: ‘PAGE_IS_PFNZERO’ undeclared (first use in this function) > 46 | PAGE_IS_PRESENT | PAGE_IS_SWAPPED | PAGE_IS_PFNZERO | > | ^~~~~~~~~~~~~~~ > vm_util.c:47:35: error: ‘PAGE_IS_HUGE’ undeclared (first use in this function) > 47 | PAGE_IS_HUGE | PAGE_IS_SOFT_DIRTY; > | ^~~~~~~~~~~~ > vm_util.c:47:50: error: ‘PAGE_IS_SOFT_DIRTY’ undeclared (first use in this function); did you mean ‘PM_SOFT_DIRTY’? > 47 | PAGE_IS_HUGE | PAGE_IS_SOFT_DIRTY; > | ^~~~~~~~~~~~~~~~~~ > | PM_SOFT_DIRTY > vm_util.c:50:26: error: ‘PAGEMAP_SCAN’ undeclared (first use in this function); did you mean ‘PAGEMAP_PFN’? > 50 | return ioctl(fd, PAGEMAP_SCAN, &arg); > | ^~~~~~~~~~~~ > | PAGEMAP_PFN > > -- > Best Regards, > Yan, Zi