From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C73C38A2D for ; Mon, 24 Oct 2022 17:14:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61DB8940008; Mon, 24 Oct 2022 13:14:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CE26940007; Mon, 24 Oct 2022 13:14:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E5C940008; Mon, 24 Oct 2022 13:14:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 372B2940007 for ; Mon, 24 Oct 2022 13:14:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E77F1AB1A7 for ; Mon, 24 Oct 2022 17:13:59 +0000 (UTC) X-FDA: 80056490598.24.28D8394 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2087.outbound.protection.outlook.com [40.107.103.87]) by imf25.hostedemail.com (Postfix) with ESMTP id 031F9A0011 for ; Mon, 24 Oct 2022 17:13:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hueKXxtx85Uqi1TkT5NTSC1Bfc2fEnTWw4tU1JNZompCT/T5Qzr0NUDXNpM4CZB7Thx6GoIf7ntoqJtG5OB+++YQdXXUeNiuuoAt2sgyM5f6a796A5IBtc5pPj7o/S96LuTC0x3oJiS4NC8pNiTcHUgHfvnUraDkQJyb6L9tdEf4fj4uFezSmjZ6wk13oms/LSRnO8eH0rGrIGSFYc+Ogx94P/DFvZQDxOx3p2Ngm8r+ZEJFt6UGftZ3ExRIqudW511J0ZIZNkp1y1C1zsTc9Jvyx3ClScaNzSFh18k7e2K3r3umW1ojH3waZNPiB2WDFH75F+rkw5vPjx3PSLRMJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XULSDJ9h1W8a8HXUk4otvP23CLIwoASuWJF1mKX338=; b=bykHEp/GFm3zxnwQstLtn8pP/6ahLq/PPrTuQpH8DWoaXmX+OYvd1dbcGw3if9IhEf3B3ocTb0+aUV3OGAPMZ+dA1JLHf64NzmAHfWh4x0UA3nID6Xw/QpFSKM2aQGcUf7+wiaa0KCE01Ib0sb8NBg1yMWZiTDSx+/T8XEvBTRYX5fKKKoyOwhtF8XP08hhrT3CehNyRGz/9jGFin1Xy5AWZ38C329TVQAVCpsa5UyBWxaH7jHa7cNz+fcrLKxGU8mASZZfjau8EwI2+ek50iqTuYAmIes1XoWSuo3hGND/wdh/Bm1sx8Zs6mauwxaAMYSUWUVvL4o2vtX0wWvs1OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XULSDJ9h1W8a8HXUk4otvP23CLIwoASuWJF1mKX338=; b=WCpWPdjGudBjBWXcYAcvxUs6dWC0EOxzD+9itLtIhduIf3ok5EEPxg3/fA+VxRgI+hSyhLL1sv8ZN9OrTaOPwHqNEV6UpquRjrrrJyEmMcrzPgf9nNrRk7agzwhP5XlzKIlg7Cfq5wxJi5xPQXNuNbzfXxhYaGwpKPbrJfOts8DTGonYAOwSztugI8MG9TilqWBkWJOfRXyTPd1/t4D8WOn1BFPI7cKIZD7sKasIqlYiAWEPQJm+JFQXiDh9Zuj3D3yrC9B4BBzU3p9+NWclkdTNwUKZ7JuHVrfo4DB2mtVZk5yzd19chb5ByA4kcZyfSCr7VBFUxKBZ9NE9gQIgzw== Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by PA4PR03MB6765.eurprd03.prod.outlook.com (2603:10a6:102:e9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Mon, 24 Oct 2022 17:13:55 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d%6]) with mapi id 15.20.5723.034; Mon, 24 Oct 2022 17:13:55 +0000 Message-ID: <6644de0b-dcab-9a9c-563b-1725090240d2@seco.com> Date: Mon, 24 Oct 2022 13:13:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [linux-next:master 2112/3285] drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) Content-Language: en-US To: Dan Carpenter , kbuild@lists.01.org, "Russell King (Oracle)" Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List References: <202210242228.KXXNz0bU-lkp@intel.com> From: Sean Anderson In-Reply-To: <202210242228.KXXNz0bU-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0403.namprd13.prod.outlook.com (2603:10b6:208:2c2::18) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR03MB4972:EE_|PA4PR03MB6765:EE_ X-MS-Office365-Filtering-Correlation-Id: d7e0293b-7f95-427b-d5fd-08dab5e321a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ygranLRHW2CQpHlhij98OqRFGo1iOorYKrZr9A1nVRlrVMffP5wNwqrNEa+Z0HgryB7BfSMw5x27mwej06D/GCkxRMZSntG5PBI+epNEjMNlec51RDrcdA3i1PVcHoBpMAz2DQ5Ng6vZv+oGo7p6zUK9tW1Zrcc5t7egxmOYsy6JW/4OYHvFAvug/ii7TocvCuSoq4B51e5iFZwKg8ivQhucUouFwFSUingIo4AwREtfp/8h8vwtY0raym6rge6KQkcS6YRjhebPNYQEiJ0c2M/SsT0MRHFm0mLuQYKvPsoEshOYUMMwxNrltbDH3DmxZR7KRivvEnftnrDm+iAVR7ocV7sd6gk4A2m9R8LyTx2LDXjk96LOSSsYO3vfqyRO8vHYgOavCalzqiMkkkjJ9O2i2oVu6yUz4HYfbRx1qDCF5jXbTWi02cRi2Ptn+mVxX0mf2FvdN5YVGshZW0CsV0HahnARKINIa8OttsgxI0uzTb/jJC+kgOQJ6TO8W/1kaI+fsAMG8JngYAr3lWNPXrTRMiB7jgmJzVSTzmzlof5fLKQL/GG6dTB0D7OR01fIAIYXUbGAbYd4rDLFwhgrh9pnHOubFn8IoqUWpkIUYBNi7UWAqWh87zVD2OSkPj0Atn4lHH9jm3gtJOBR6Sq4rMlQ7iBGvC6tRn9bLJzkuLXem7hnoreCZWIz1p/R6/HEhuD3ruAppz0dRbT9GmqIbbp+u97g6YZtuxtn9fxuW5+Rq8YoLGRRjbnHeTjBeItLqzE5KkHnZO/ih2fY+2D9Xk1y6vqbe3W8oYVvKtpFY7BeKT3xeDrubVq4qioDQItCkAjkJBN0cFXIOZ6AOlkElg47k4e/ZFfX9LPXNV8Nvns= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR03MB4972.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(39850400004)(366004)(346002)(451199015)(4001150100001)(110136005)(36756003)(44832011)(4326008)(2906002)(5660300002)(8936002)(66476007)(66946007)(66556008)(31696002)(41300700001)(86362001)(8676002)(316002)(6506007)(53546011)(6512007)(26005)(52116002)(83380400001)(2616005)(186003)(38100700002)(38350700002)(6666004)(478600001)(6486002)(966005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnBWTzhySUdacFg4aU9VUk1vRGpBNmliR1BkcEJKa0Y5d0RCWkxVQ3BmZHpF?= =?utf-8?B?dWdTejBtQ0liWjFxMW51WEhjNDNGVUlQWVg5QWp0bk1DRnY4cDVPVkRyN1h5?= =?utf-8?B?SlN5Z2V2MFI0RjZoaTFFZDUranNGODRQaTNWbTMyMW00UWFseElnci9zUVFC?= =?utf-8?B?RUx1Vy92ejRQWldKWmRvYjRnL1BQb0VQb0ZWc296UEFBSjMvZkFsQXA5ZTNo?= =?utf-8?B?VHhuZGxhTDI1cXczaGhvYVRZMzZPM2o1SDE0bk83dTVLMnp2cUtLcEZvNFdu?= =?utf-8?B?aTBlM2p6YUFUVDhBQnNlbU1Rcng2Tmo0a3dBc1J6a1YvNFl6RzlkeUpSK1c2?= =?utf-8?B?TkRKU2dLVGxPc3lhVld5MHIwdnRMWDR2OEFRVFZUdnBxa2tOSW1ibFNuaWh2?= =?utf-8?B?QzNOVTlxY1Q2SjRBY1VsRnJRVlFuOWltUHYxVXFQL0FrVk5LUzNTZDNrR3Rw?= =?utf-8?B?MGpXWC84ais1Lzg1NVpSMjF4amRqVkdoNEhHVnNzODIzeWwxbmkrckJRSFhX?= =?utf-8?B?b284VTduQWk3THdxa1ptYnczZGJMcExTSzlBdXhIVmJna05MUlFuM3liQWV3?= =?utf-8?B?TE96N2FNakxmbmkwSUtobElRNXVheXJlOFdielc1VSs3NGI0NS84S2tzcnMv?= =?utf-8?B?Q1VOTlJGdXNnZ0ZZNkx2cXVBb0N6cllGaFRQV1p0SVkzWVJlOVk4QUtaNDVM?= =?utf-8?B?RGFRQnQ1V0VKbUlyNGZXZXRPZldHRU5nYVh1bGZUR2VRWFltSFR5b2ZpZS9E?= =?utf-8?B?alNZRFpuUitBVkVLNTdFbVh2d0FwV2cvYlNyakhoakVZcUpyZmxFRkpBNEFB?= =?utf-8?B?YkVmeTU3TjkyRkZROE1QenJMR1AxVTlkNEJKRTlKYmh0QUJqUFkxTjhvdml6?= =?utf-8?B?UVVJcHVMdWJqSTlsTnBZVHQ3ZWxLRTJFMkM4OVROZWNxb3h4S0ZYQlVFOENP?= =?utf-8?B?WlVqSE9GQ1QvNzdHRXEwLzhlMkdWcmw1Ky9uV3JYQURDRVB4dVFjYVEraEV0?= =?utf-8?B?Z0RoZGdxM0dZbEpYdjlFUmtMZUJhNitDTW9wSDZLRW9pckpyWFJqcjZmazZJ?= =?utf-8?B?ejZoSDV2ejVBNmZRTmRhZmhCRFNIdzRaZVVvUDlMTEpKRksrd25vMFp5bFpp?= =?utf-8?B?OFFRZUE4K0FkTVZBMGFrVExVc1pGZi9tMDZLbzhkRHpoeU53VU1lMndFWUVW?= =?utf-8?B?M0pPbnpEaWZhWjY5SHFTZkRFY2lQNDhLSlFTd3lDTjErT0ZaWWhLUVplQUxl?= =?utf-8?B?WGo2WW1vMW42a3VJU09vR1BIQURMcm11SGlOeFF3SzFybGRqZHVXWVNCemxr?= =?utf-8?B?STYwcTNJbWVRZHJnM0Urb1lINnNpMU83b3BPcFRMN2piOVE1dW5UVCtSUGJH?= =?utf-8?B?RE16a0tMMWtQQUdXWEdpZDFSRCtWeHJWOWROZWU2TUx1VEsxYytjTHJ5emVN?= =?utf-8?B?RjFVVzN3aTdyNW5LV1RUZGhLd25TK2JJOGViSE96dHRZZDNlRGVmN2tSVmth?= =?utf-8?B?YjBndGdLSVIwWXdZbW1yWkVtZmtRZDNDUEUyOEVWRERHOFp2T2FndnRyNXdH?= =?utf-8?B?S3M3dmtEeVZwSzg4d1ZQYUVXWGlBeWlQTWNUYSsxcFhOcjUzYnZaWG1SLzdO?= =?utf-8?B?ckU3eGhqd0plRWFNN1EzN0JnQnZsNjVTcGhnT3RBak13N0dxK0VMQVZRUDBh?= =?utf-8?B?L1hOZXhjZS96TGRZQ28vWm9CUnN6MWVHekpBQ2dRVmxFQnc1SmdEejBwT2VH?= =?utf-8?B?RmZPeThnQ2tjVHFkSVprcHpHZ1JlR0hjVkk1U0E3TUtnUHZ1QUZjTk9NcVRH?= =?utf-8?B?TFdkRzZkMi9yUlpzMjNpSVExSllsQXJ4RHJySVl1SlRmWlBtWjhyWWh0Q0Mv?= =?utf-8?B?MFoybjFTdkMyL09ZWTluY0MrTVF6ektVeGRhUG50NVFqazM1cjMxY1RmRHdL?= =?utf-8?B?TGJnNmJnZnE2TWJhSGV6QUpwVm9oQ2s2Zm9HSzJCQTRXR3BNSWR4Um1aYXFO?= =?utf-8?B?VkJLSXFqMG1DNUR2bnQzdkFTVnVoZjNzQ1BEKzIzRld3aHdpZ2svN1VpY2Zh?= =?utf-8?B?RVJCemE3ZzNTSzVUWUdtcFhrN05Dcm5EOU9VRExiVnVqbjY2NGw2K2N1N3h6?= =?utf-8?B?dVZvQ0ZJRDBEakdXV2FEVldKMHczUHU1Q2VoNmw0RjhYaWZNUzdlaVVPSllm?= =?utf-8?B?V1E9PQ==?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e0293b-7f95-427b-d5fd-08dab5e321a0 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 17:13:55.5082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 16KkJbc1ESqacV1QWCgmCpLZhkRJ3s6np8CvLO1uGd7WqLBjFMbVBO3m0JUtdkedD3b+L00rSUZRHAsSv43umQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6765 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1666631639; a=rsa-sha256; cv=pass; b=3oQwof3OcK9pbzJneswHaOAUUVHl0m/SywEgd56mSXRJXgx2IkV7NinEkG1y+/yEzz0agW +IyO3QyyrBdpdkI8SR2XRgjCWvmN4+OglbrRhnJKX9YzWZ0FnSntho1Xadpa+QCTJP7yKz 84e1pXHUNatiRDV9Qun1n+ascGbLPlI= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=seco.com header.s=selector1 header.b=WCpWPdjG; spf=pass (imf25.hostedemail.com: domain of sean.anderson@seco.com designates 40.107.103.87 as permitted sender) smtp.mailfrom=sean.anderson@seco.com; dmarc=pass (policy=reject) header.from=seco.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666631639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0XULSDJ9h1W8a8HXUk4otvP23CLIwoASuWJF1mKX338=; b=EryLpz0WTfolelCXFpgchpoJkBcL2x47tRewuGrQ3iNYo7hVMosDfXyyfH0mwvD4uXQB2i jCyIwmhQKQl9fiY0fZAlBkjp8uwE7+ZZben1Be+aRjEGmFsCldhSjJEt7SC2Dvnm6P8EGP xzQ5+3yYmHadXPoSh1DkkBYFEdjKhSA= X-Rspamd-Queue-Id: 031F9A0011 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=seco.com header.s=selector1 header.b=WCpWPdjG; spf=pass (imf25.hostedemail.com: domain of sean.anderson@seco.com designates 40.107.103.87 as permitted sender) smtp.mailfrom=sean.anderson@seco.com; dmarc=pass (policy=reject) header.from=seco.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Server: rspam04 X-Stat-Signature: jbqbi5sspti7urns7dhca1hewgmeu6ar X-HE-Tag: 1666631638-840301 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/24/22 10:30, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 76cf65d1377f733af1e2a55233e3353ffa577f54 > commit: f392a1846489720fc2e063d1210633b6cf4ec5a4 [2112/3285] net: phylink: provide phylink_validate_mask_caps() helper > config: microblaze-randconfig-m031-20221023 > compiler: microblaze-linux-gcc (GCC) 12.1.0 > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > > New smatch warnings: > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) > > Old smatch warnings: > drivers/net/phy/phylink.c:1104 phylink_change_inband_advert() error: we previously assumed 'pl->pcs' could be null (see line 1087) > > vim +/state +588 drivers/net/phy/phylink.c > > f392a184648972 Russell King (Oracle 2022-10-17 574) void phylink_validate_mask_caps(unsigned long *supported, > f392a184648972 Russell King (Oracle 2022-10-17 575) struct phylink_link_state *state, > f392a184648972 Russell King (Oracle 2022-10-17 576) unsigned long mac_capabilities) > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 577) { > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 578) __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; > 3e6eab8f3ef93c Sean Anderson 2022-09-20 579 unsigned long caps; > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 580) > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 581) phylink_set_port_modes(mask); > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 582) phylink_set(mask, Autoneg); > f392a184648972 Russell King (Oracle 2022-10-17 @583) caps = phylink_get_capabilities(state->interface, mac_capabilities, > ^^^^^^^^^^^^^^^^ > b7e9294885b610 Sean Anderson 2022-09-20 584 state->rate_matching); > ^^^^^^^^^^^^^^^^^^^^ > Unchecked dereferences > > 3e6eab8f3ef93c Sean Anderson 2022-09-20 585 phylink_caps_to_linkmodes(mask, caps); > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 586) > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 587) linkmode_and(supported, supported, mask); > f392a184648972 Russell King (Oracle 2022-10-17 @588) if (state) > ^^^^^ > Check for NULL > > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 589) linkmode_and(state->advertising, state->advertising, mask); > 34ae2c09d46a2d Russell King (Oracle 2021-11-15 590) } > Hm, looks like I missed this during my conversion, but no existing codepath depends on this behavior. Russell, should I send a follow-up fixing this, or do you want to do that when you submit [1]? --Sean [1] http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=ca5662f375de2a44fabcba644a4368c838e1bb22