From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB10C4345F for ; Tue, 30 Apr 2024 05:26:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA4AB6B007B; Tue, 30 Apr 2024 01:26:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2C7C6B0083; Tue, 30 Apr 2024 01:26:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857DA6B0085; Tue, 30 Apr 2024 01:26:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 648076B007B for ; Tue, 30 Apr 2024 01:26:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8C8FA0377 for ; Tue, 30 Apr 2024 05:26:09 +0000 (UTC) X-FDA: 82065062058.26.33C1EF9 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf23.hostedemail.com (Postfix) with ESMTP id 37BF714000C for ; Tue, 30 Apr 2024 05:26:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=npXcTIg+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf23.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714454766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nn2Kx5/j1T80vUc7OUqa7YcL21oQYPW5JIOjxgVkaFU=; b=ZFEoO80Eam+fE00KvEAFFSgA9DYiUkdybpkIet7vPsbGCtZPr4BMq/mlA9SA70MVU0TUtS 84T1hsBSj2e2NJffISMxnDBIu/VKRciHJZ6ImKEgEQy96js+AfJ/PuvnnwBWMHJsnwql/F i8CeNd3loEQllPjeqmbB5x/0JLyOtIU= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=npXcTIg+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf23.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1714454766; a=rsa-sha256; cv=fail; b=n5In9YfiHNExr3zO2H+fQLE9ngYhXRSxE92q1nyhj0Hf+bvIPrPm1KwyOWbjHdVW8Z3cuQ TG4sTscbTMXNp+W4PnKVyYubq94+ohGh9g54XdiYt4ee/3dtaSqCsuXySBZJcrpkAvnOGM avjul5FysyCUo3zlcrF45w69UnQ60o0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714454765; x=1745990765; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Ov5oH2I44ITX+UuD03/feA3QUahhSxZSMCeuW8yRM1M=; b=npXcTIg+kL5BJi42VT56n6a/p7iHc1uSqfWWM8f9bb8fib+1Q+83Psxh irLzPx/VryNkXXR4FGtiCep4Tt/6okO6Uqz8BRAiVRrjsA0TKNfLyXHyx 2NfzSSYs01HdphZL+pSwZQX5EY3XF9gD27s161OPeVkGbjJ4eUNX/DLaz Vin1jzNaqV4kxTCulKMWsON56rJyqdMHjEj1FTRNaMWtZOA4HabqdVD5T ssu7a/dAn36dtHhkiZoT96AqsbF24Op7WPU4juniSKW9vsvjXMaaBjbR8 wY25AO9fxNaq8V86axtyeahg1Gl0TTqeNsYC3uBP7yvGOS6EheS1DRJNy g==; X-CSE-ConnectionGUID: j6KF/Ux3SbuiMi/qTrkjeA== X-CSE-MsgGUID: iSvGPfkjSROX114NcBFvXw== X-IronPort-AV: E=McAfee;i="6600,9927,11059"; a="13935821" X-IronPort-AV: E=Sophos;i="6.07,241,1708416000"; d="scan'208";a="13935821" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 22:26:03 -0700 X-CSE-ConnectionGUID: 21nMgj7mQ3KSZUvIeIJNNg== X-CSE-MsgGUID: iM+v/WDxStWlyjBrJydy7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,241,1708416000"; d="scan'208";a="30792731" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Apr 2024 22:26:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Apr 2024 22:26:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Apr 2024 22:26:02 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 29 Apr 2024 22:26:02 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 29 Apr 2024 22:26:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mugQcrQoJvXhkBSySnFMKLzn7WzOqbMs5BfQxAtl0l6phNZSHkT3ATuRP5z6RENT7q0uVvZRaMl1tx1LM3iwPegd3Hk1twfP0IW8YJ130/5CI4tAIhOx97DvVKrt0iDaMYv9TzhFEAiW/8FhnOPXY0xPRLYi5b4HmIHBvd9ffWpmRUhQ8yPBBbg7cwx02aYBNcnqfBoWg8kOIndcrYJwxAdnNQyE+tPNbXhopF8oNwYY95UORr7D3rBWxdREMWdruiBWTCgwYjabr32EdcN0f3v2gTYaW47GN9C3RIdHhQni4t1O56Y0NYXkl+p6vXORTJudU/ouAGSztMPSJvf84w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+up84rqQ/h/pFpsQi9SCKLQyF4tuWdF9k+zsOMpBwk=; b=fYgBBHrnfKUtI40OECb/rGgki2lcCX/80vjMZYOYUZXUfskSrx2yaBd2TscaXt6yFs5t2peLTibXJXnHoDf76fAJHeJP9mywOGbnhose9oWddpT1y6kWqDZgCt5O4ZaeEW7iGMh5bOlxpJN01Gl5qpoeCuwz55eJevjKZCDcrQV+Cy2KHZrHsswO9Of5EEJTs2Law63b07fTLJY3KxLc6BbSBQKI6eNH0Z4fUCtfANkAK/E95w5Fb37NT2wYSDhaBPJx8SWMlffTxpcQAv8RBFTm2Ji+YFieEKDBABpWwNfP6X1zYn2lanVa7zr9hKbbOyZ+mNdRH2lQ2mcxFjsUyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by CH0PR11MB5218.namprd11.prod.outlook.com (2603:10b6:610:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Tue, 30 Apr 2024 05:26:00 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%5]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 05:26:00 +0000 Date: Mon, 29 Apr 2024 22:25:57 -0700 From: Dan Williams To: "Verma, Vishal L" , "Williams, Dan J" , "Jiang, Dave" , "Schofield, Alison" , "akpm@linux-foundation.org" CC: "linux-mm@kvack.org" , "linux-cxl@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/4] dax/bus.c: fix locking for unregister_dax_dev / unregister_dax_mapping paths Message-ID: <663080e5be58_148729453@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240416-vv-dax_abi_fixes-v2-0-d5f0c8ec162e@intel.com> <20240416-vv-dax_abi_fixes-v2-2-d5f0c8ec162e@intel.com> <6630487879c61_148729427@dwillia2-mobl3.amr.corp.intel.com.notmuch> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MW4PR04CA0211.namprd04.prod.outlook.com (2603:10b6:303:87::6) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|CH0PR11MB5218:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e834071-af41-41f3-d1c6-08dc68d60510 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?GBYykBo+nsXFPsbThqvY7q2hEbNjL/uTzOgfXLTI5q+tWKJ17DtJz/bY0d?= =?iso-8859-1?Q?MICjBZLXEBahGTf1lmBOcYKXe13xGbzk05dk4xdsTjYyxhNq4v8QuRcCy4?= =?iso-8859-1?Q?+Stdkg8mHiBFbSA5Sy7IvMkywHMRFxpzNhJPBXAXe9T+9iLMrv5vAYm7Np?= =?iso-8859-1?Q?Y86t8I0sGqM6l8J+iTd6gANT8JL9bWYcbUiQ0rMeRya5mFuBdJTnKCwUmj?= =?iso-8859-1?Q?uzH/jQcOXg/Ka8AmAkMiHTSQ4QMKdOryCnH2yHhM8vY6AkUDlL+ZLzmTwE?= =?iso-8859-1?Q?ilYeqee/IebMfLSWgRuTnsJ6iPa5onT2ZPZzh1EQNs12hdpj7imFPpcikZ?= =?iso-8859-1?Q?sOdawXUQJ0YMSxhcuceJHP9705a2UrYXxLraqb7R0AhS8TcVPKZpCY7YB6?= =?iso-8859-1?Q?RP3w47u/RS6yk3xQVWsGH2QejmiaB2mW//yI8Sryi+17PnEy0yOkHyCnIh?= =?iso-8859-1?Q?ChOvJD7gJmid8E+RTKrK/xKgH8oAwAaL37gSQxkyc5FxgZ2/EpEhKXHtPP?= =?iso-8859-1?Q?bHbxbfkOccAJjuOFjwyXULR5nJep4G9xiFPlby0s1xipsk+kBm8AhAbBty?= =?iso-8859-1?Q?jFGWIcd6UnZ69DCPnVHyRBU7zl5PhHZpP1x8rH0Fs/CnuDy3DhmY9+JMDF?= =?iso-8859-1?Q?5w5MUyC8AOIL2XDYC7piZ3fFIASxDL2nj/+GjBimFKvkHpTCZO3D+uz/lD?= =?iso-8859-1?Q?vu9qHIFBFHb7h/YXQTVGMovhqeDE4bytQlUXAyvvwciSHlXtCDfs81rL8P?= =?iso-8859-1?Q?3lvx0z0WlwuLSCmk2se2CUhtvFPdgDfJBO+F/wyL3yar0U5O3+aescJCWL?= =?iso-8859-1?Q?oAFNXXvZh47BiAEIYW4WbC+wxkJIi7Hf3Om7LEcrx/b6qy+E/yTpiOmHZK?= =?iso-8859-1?Q?zgGtN+oeU92sqyFS7/y41ALOCyejzD3bpoc0e5hJbVTfhofntNwA6IqvbJ?= =?iso-8859-1?Q?LGuz5c793DE42rF48m/9q6jqH6Ubg9euxlfJgU9YcVPWUQq10AvhqeutqB?= =?iso-8859-1?Q?4drjHj+Dck87cZnvyEkE2di52JEJxmtbIbpXnHGqW2Cn3pQ7jbPnfshodn?= =?iso-8859-1?Q?4veMOfVb06n6kr5l+F+LBR/fINfG60w/encHH7ISnRWqbkbs8qwzK9YWqy?= =?iso-8859-1?Q?Q+spE5cznT2znC4hZP3GzNLmIYL3Q3c7SOHFJ8LOaF7ramLrwy6690wsdj?= =?iso-8859-1?Q?KMMW3a+W/PBuM3GD/tFAvGZ/6KrZYDmSEmioIMZz8wslm+bF5HNkmUzJxL?= =?iso-8859-1?Q?KgCYCvp93+XEcWJu+MtpQTalaLM4/Uh5l6eHoXpN/TDlOCRiDKWF4NJVIQ?= =?iso-8859-1?Q?aF2ickmzW2MTEZ+1r4HK0EYwgA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?C77XKp9k0qdnbiXFOp+ZGdlrl3xpgrlFto3Rk6rRqzsZNbQJgP69fu7ZSM?= =?iso-8859-1?Q?oGobuqx5BahsKN+Uh6vrvjKhATGe/0ATsVkaG46ainIfI/QTXs0dvhuvNT?= =?iso-8859-1?Q?vhEQeGvsoeGdldasDOmhKBu+2j73NiZkof+UUjPTGGLaeza7w350+bbaGQ?= =?iso-8859-1?Q?4H1X6hPEyDqDapl+S6OZyWH6XFVjx/Y4KCKfF4kbzoOzCTlR6byeMKvpLe?= =?iso-8859-1?Q?115DN40Ml4RpgU+9CFRzOq3CWA2MEfPv2fubJhW2KY4rhdo5ij76Zt/k1o?= =?iso-8859-1?Q?prjOQ8qGzG+pJ1ZEKU3s1kdf9hicJD6tzufohPu5uDx1TjB7VpnEhD+ZPA?= =?iso-8859-1?Q?0ebvRtdnma7uVij7RvfsntVWb/2GZe9BSBrFZQNzO5Ui7kL/FiErzhu2p9?= =?iso-8859-1?Q?6cRRAWUTpGr6Gf4juVsWhPSupZBdDHXpL1XDTKQCNTUP19y58/qdnbruBW?= =?iso-8859-1?Q?D3svGXfrTFoWLKMb8OYbJwLfyIVmiSCKYRRy2fq38bQgk87fYC0bXF02xu?= =?iso-8859-1?Q?7Ej1EACFModta1x1rHnA561vL8NsMwbzhqXoYPBSgpanFi6uK2AWxfCbJg?= =?iso-8859-1?Q?ZxqjQhQtZ8mnXf0WVAinxlD1vluhh5p1MYKGQD9b9Aa6ZUu0vB0ENn8Qpx?= =?iso-8859-1?Q?HG+X4+oiwCXmxnl8FMcKCMiniDNEcOe9keQVhrfZCr1CJA/cHNI1mowv15?= =?iso-8859-1?Q?J6had9cZiwTIxdLbqfvqhmokLr0lHr9LxPIMRNHrJ7dRm2WZdfleFxNcGf?= =?iso-8859-1?Q?1/5Gsrc9eNNg5dDG7Gsvl2LCMYpoKBgSVDdjWoN2ezi/g+BU0e7DS64smF?= =?iso-8859-1?Q?1d8ZgGEvH5MQiB+X1btjbKWbXtSYd7nApDLfjtbtObsYEmcK5u/4g10xKq?= =?iso-8859-1?Q?m/JpmR5EwRek5eWUSPhOfQ3n4xhaBCxs/rJ1IY48yfNy+cgMMH6VJnnxeT?= =?iso-8859-1?Q?8FsTrNS94HkqezPr0pWrfSXhX3jjmTcHa+vb+8zue3aa9ClN6JU1k6KsI8?= =?iso-8859-1?Q?LLlxGPGj7hwyZ6L2iAqlvc+RUC1ScnwcwtiGqK1XZzCV/6MdDICWRblKhg?= =?iso-8859-1?Q?WKxMvUiOHeM5AaseoQMYPps6JWTfgACTWfYGPa8rbIvHohMQhbkIJh0j2x?= =?iso-8859-1?Q?dgYaHH2R8rBvdGRj1hqvSj83KbcSs5iXiu0z8shjtrZZzg60qwTZNrdbge?= =?iso-8859-1?Q?OQahDm/IjegbljI3OOHJfsQbaJuhfEtHBynwKhybajQUzTlWjLdM146a3d?= =?iso-8859-1?Q?3/jiDP+0mNCGANrW4Sney2H5AeJNhAWq2k33fTSxTSBFX+8Sdie9Vx0rec?= =?iso-8859-1?Q?uHfhkwLgnumpbLJb94fRhom3ObqnjjLpulS0LUbH8WA6HbDcbtx6r3shsf?= =?iso-8859-1?Q?ief0BZhAMymYxfKGPKNMi5EaJqZf7+5Xtqd3Qn2UA1l7YwZTxXuBcuyEHf?= =?iso-8859-1?Q?xCLsSA47VBDMSTpj+XZb2z71VitX8d8o81N1t0UbmFE0Jdh3jaEuY9Qlea?= =?iso-8859-1?Q?mu7HHaBXNsxKUsFYbZ3N6mZEuVWhViwXpLA4sH5s29asu+MbSL42ww8VcF?= =?iso-8859-1?Q?IXZt6XfyB7KNNLCJ62BAd4lrWOeLzgrVgjF3whLBxB1f5A/bHtwsPJhRXn?= =?iso-8859-1?Q?I+JRaGF5gD+zeYF0fEF57heT2kjsQ3V86J8RjkxQi0zW02SK+7eEVkzg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3e834071-af41-41f3-d1c6-08dc68d60510 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 05:26:00.3317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7bAb57sGG0aZndMUxpR4lMLNfRctrx4tVkxpFAyEucdo9pFwNkYvW52KXG5HDqdETEbP/eLPgZmICTemhHMCzqp36jsR9uIp8q4MLOxkQNg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5218 X-OriginatorOrg: intel.com X-Stat-Signature: jax6brcrwr71w19ung7sp6oozkfzrej6 X-Rspam-User: X-Rspamd-Queue-Id: 37BF714000C X-Rspamd-Server: rspam05 X-HE-Tag: 1714454765-334282 X-HE-Meta: U2FsdGVkX1/+BOTceHzuerjwDQUDEgwd4bgBITn1SqIJI0gu797xbzy5fJLPenz4fZ8Jw//9F94EN7CfmdxtQBvgEdp9YOoW/kdP6ODdCIHkA3xfQtlIAOM0/P9ZnHBi2YfEVENki/PLggU3eBGQ2vDZtzPDpo6Src4SfB6Y4aU2u+hODcIv9yd+BZs7ngURbM+Y1lXCvr6Gmm09JAKRNlw6GkUnqNq/20RHu2R+v0bO3mU3gSKhJhW2g1lNaWF/u8PiguzaQ9Pz8+vwuzg9/7AQ8RkpS2HXYx/tQdbsSdquG2tV+rv3/LllGMr0c+gY15JNNqfpCpQkFxlLPV4rx5v2PcAis9RSIrnSDGkfotfLK7KDRumZramj21ugZ+LuTyRI/bVoRBYK4g+upN+bJU8st6rXD1cOvYmcLXt5AdXuPIOfsIr4VC7J86WpZF/brreQVnXI/UDqVijfmDPgBsNcFLFIfYVJ9R4rVOIWJMvFZ4edetqyN4j3sqjzIqmWkDM9jCWcsxFIAIsvOhCt7Hn7QKx1fKOjpwgHMnPQCGY9WOSiuSmXyqFkF7olKcHfaoCUykXB3n8Hg0B3aOk7Ry2UV7UIN3BzV/kp0bQ1RqtOIAy8sqw0IB2Bc/SSDaMTbZ6sArwltBTTQeJ/MpMhLI9S9Ln//cwGHRfWISo/SgP0PGycrLtOcmcCtC0NgS+JW31LJxV2+OHn/9ZiMcRrsx3cR4MbvD/xHyyKo9xDe2Lxt1K6P2N4e+D0Z14LSLqSwX+/RU87OIOxhMV4lIh/hy7s4/8Fj0a3+NgLxTzfiRG3n+BRsgN3BI1sXeS/qTJe2is2RIeVDos+NT43PhST2lbA6gm6JRqwCYxwUb6/5awTuQ4CLcrsHp4rC8nH9yN0dFJRcvZ5r9CEPAn0GuEJeL5CTrSOVkIP1ewUSH+sRgDnFJ7rYiBz3ykaOQfGWFIGwDYg7J8CvGsTETRydZW u8R3gx9H 8PINL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Verma, Vishal L wrote: > > > @@ -560,15 +551,12 @@ static ssize_t delete_store(struct device *dev, struct device_attribute *attr, > > >   if (!victim) > > >   return -ENXIO; > > >   > > > - rc = down_write_killable(&dax_region_rwsem); > > > - if (rc) > > > - return rc; > > > - rc = down_write_killable(&dax_dev_rwsem); > > > - if (rc) { > > > - up_write(&dax_region_rwsem); > > > - return rc; > > > - } > > > + device_lock(dev); > > > + device_lock(victim); > > >   dev_dax = to_dev_dax(victim); > > > + rc = down_write_killable(&dax_dev_rwsem); > > > > This begs the question, why down_write_killable(), but not > > device_lock_interruptible()? > > Do you mean change the device_lock()s to device_lock_interruptible() in > addition to the taking the rwsem (i.e. not instead of the rwsem..)? I mean convert the rwsem to drop _killable. > I guess I just restored what was there previously - but the > interruptible variant makes sense, I can make that change. So the original code did device_lock(), then the rework added killable rwsem (deleted device_lock()), and now the fixes add device_lock() back. So now that there is a mix of killable/interruptible lock usage all the locks should agree. Since there really is no risk of these operations being long running there is no driving need to make them killable/interruptible, so go with the simple option.