From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03001C3601A for ; Mon, 7 Apr 2025 07:49:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 729636B0007; Mon, 7 Apr 2025 03:49:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D8D26B0008; Mon, 7 Apr 2025 03:49:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52A536B000A; Mon, 7 Apr 2025 03:49:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 324F26B0007 for ; Mon, 7 Apr 2025 03:49:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A168159E61 for ; Mon, 7 Apr 2025 07:49:34 +0000 (UTC) X-FDA: 83306473068.21.D39A96F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 3844E8000E for ; Mon, 7 Apr 2025 07:49:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PlBT0VdV; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744012172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJDG8HeQmppAHEwc4ioqpzaFR7IYOXt5Zxb5p3GrAuo=; b=r8YCbhsOlWn/TpUAHMbbrdpNvM0Wjw9yAZrk+unJhm5Y3AibDvDPtV8ZODdp5jablKzsZL +BuqBqQu6LKQDLD4vJXz9ahm9aZIEzP68mXALX6tuMNpYuAFz5fzt/SlMvumvk8HwuPQcb m2hftwlT2k7ibmU6lBu0VHh53poS8rw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744012172; a=rsa-sha256; cv=none; b=NwJ8lxNN/nCFHsJGaurpm0i393LmEQp3JbTNy6/0qPO1tiC3/DcUw2NNovsLfLjzdR9QGP llWeBV5+TjgyVw6KFcpSWKeIfObQX3NTOrLUhMpUQYfXroPfiksUzutPgo+3cv1LUNTh92 UrInRRMQtVBfQHmEgp1R+3G26EnJG/o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PlBT0VdV; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744012171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yJDG8HeQmppAHEwc4ioqpzaFR7IYOXt5Zxb5p3GrAuo=; b=PlBT0VdVGyPBgfO0u5lnZU3tYxLFet4lxXGrphyrKdYpuzIPIn7eymsu+YPFOFyKReLfXp kVNUnRJWAGhJRbaPVRTShWYCzSFtl/aO75AoU9fIvarwtnVS54I14djX5QpL3fX7DhXhPn 7Pz2tpvQ2xJSs6atoDiIY0jng6jg1pc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-X14wTq8WM66meAcBv8Nf2A-1; Mon, 07 Apr 2025 03:49:30 -0400 X-MC-Unique: X14wTq8WM66meAcBv8Nf2A-1 X-Mimecast-MFC-AGG-ID: X14wTq8WM66meAcBv8Nf2A_1744012169 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3912fc9861cso1624381f8f.1 for ; Mon, 07 Apr 2025 00:49:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744012169; x=1744616969; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yJDG8HeQmppAHEwc4ioqpzaFR7IYOXt5Zxb5p3GrAuo=; b=Q0WzJ8D8OPlKDr+5nFkWrCVfuvfEj0YRRLo2eO6DXWqRCHC6nr+YkwITz1tYNEwR8K oiHcm0Y1xkddBDa8/RUM9sVvn6ejjqePQu01eHGiLtOIC6rZE5OA9nd2ZL+QhhzJmjHa uSNIYdq73H7HfICXeS8sR9ACBLowEact7GDrEWJIkKBOvZfG2rY73PwA7IsIm0M05Ghb MKSdCx8M/ROrBYSUolYVmjVZxP1TXR+UPiSWJKb8XSLYjJWfbywQfB4ChppPaatxupYm yJhzJMfkx0PStgACOaiWKQkoQmbBnSzPhUXZ1lsJ1UJcI5q1tBvsulWMqpHOoZy+Qycv 3a7Q== X-Forwarded-Encrypted: i=1; AJvYcCVdMrxa8xw8CRgpWvN77qw9ynJtK+2mWfvrAhg6SM28kyQo5rAOsqb0ncbCTI4EjCKH4QEDBN27Ig==@kvack.org X-Gm-Message-State: AOJu0YyOmhwzeIc2akKoDpEd1W2kKtK2I3UaHFaLHBocT1tJF5pgKmgR Gn3AV5M5hKRoEUYKzImDvT/NryDvCetCrHGAXlU4ZxBd5X4AINxfXC1GJwh2YIUTueoLPydTNAe J+p5pGFHQav3/BONMFbGxLGWIxVpJVIcDqreweau7jqitebSK X-Gm-Gg: ASbGncv/2y072ouONqndtNAhVHxC935WvNFgCly/SRvvCODEYTWlRhsGaLjIw4hbQoJ swc9luY5K52bn6wNVJ783mgIneqnHG0KZ+IxIACleCGpHWvKbmfRN6fQQ/kLcFVV0eR3wPNlJnU 2XBwxJASyvaiF/LwBTWlsVwqlQ5+Y+8oU5SyGjCHdE2XdtNjbJlwLzIv18dLXnH9zF/MB+EYKaC KXSilgQSUmiiTlp6c1yFvF0G/yfHUsRuFoSM0n3RAVx2yD+0IYMS+ZGD3UtfHQKfF5BGYQuk6oB 8SgfUZk5i4x+Vq+P2psHNhhBvvZ4u1QUxFdPz/hc5bElEkNX/V42UfIeIN0XM6RJQhV/bLfPAQ9 4euQlF4eg3zw6AV1RbeQQfrtKRoykDjpiCVDcefvYkEY= X-Received: by 2002:a05:6000:178d:b0:38f:503a:d93f with SMTP id ffacd0b85a97d-39d0de6285fmr7737108f8f.40.1744012169206; Mon, 07 Apr 2025 00:49:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkm+tulOb5ASAkgNNphvd4C9BTz8ynNupsAVHvrmjUIX1fSowZZvqz0hqigr4tdQObDH5ilA== X-Received: by 2002:a05:6000:178d:b0:38f:503a:d93f with SMTP id ffacd0b85a97d-39d0de6285fmr7737090f8f.40.1744012168854; Mon, 07 Apr 2025 00:49:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:3c00:8b01:4fd9:b833:e1e9? (p200300cbc7383c008b014fd9b833e1e9.dip0.t-ipconnect.de. [2003:cb:c738:3c00:8b01:4fd9:b833:e1e9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec169b8a3sm123957385e9.19.2025.04.07.00.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Apr 2025 00:49:28 -0700 (PDT) Message-ID: <662ad650-8c68-40ef-a109-2e489658880d@redhat.com> Date: Mon, 7 Apr 2025 09:49:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests: mincore: fix tmpfs mincore test failure To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <99a3e190d38b08a2b96ede952a29893bffdb3432.1742960003.git.baolin.wang@linux.alibaba.com> <9000c5c1-34be-4bc9-b1c0-11548264eaa6@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ll4olVtmhtRysi6s5xbPUOmxel0WzO4jfWmvmlGmisI_1744012169 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3844E8000E X-Stat-Signature: 16u7zz9r1ydcs1gxfo4wtb44i6xdu3yj X-HE-Tag: 1744012172-199339 X-HE-Meta: U2FsdGVkX19oDYb7wW9+wMR0Fv1LmOcRCXZ5Tpa9L3qxyreE9iRXo6l89u0Sp39OFf3YBErkCYD5/UN2NcsFWJByojyqIXdsSE0mxzJLv1XbAnT8Xl9MXFwu2II37XAHAVhe6f36cVfh4FGmgJOwLMimmTSN274mtNPzVw66vl93lIdz7wgMEs8Pw7RbzhRA/IVw1oSPQFRdoxq9J5H9dF3Lg6PlIWaMV0jG81reJnshLk+prdB81e4HW9AAUDBZyRCmCBboqkYWmGg3lsXCOpBBH4LHZXPNTSutNFR+S9KgINoqFTHoIuPC2IWAqozBJzH2v94UBrML5dxW0nG2wHsoltteTfo10twJUqEi7umnL1lfEWOXtKcmJbFDis8bpMXo1wAEXJ28J/jUc63W6LW7WGMiX3OXuJkWKdG6NkPh17ALdSZEZ3uIDso9Vilig2uQWynHMaFrR+0nAZyhw4EYI53s2mnMu/i4HXI5Pu+Vpg/rT5KTE8dWtgscIlaApo/nkxdLxNMVu6rzo9tyBTO1JaYezKNHNiLDYcfOl70vltiFwcCEqXPuYINqs5x8QG2uRntyxbahHhS5SERlz4OM8xFqnwXpymrRW7p8+ymIlL+MBZ68XeiPMjd0mcHn4fr7Bwe86gRCMILqNJ/kNCIjWKbUpWlJuCs6RrAsd5W9wA54R08vv74BLZmNlqfl4+8kuKK0CId2OSwYIQt2XRhiioaZNYPpAfj8Mi55+U7yKYO7zlS7YFRLwEZkKZXbTjjUepv98IUH6f92AvLOVL8zCh8k3aidui2FoN+8v7ZDl5J4GOXU3HAgdlJcly1arK6XwqLJf2WbRPJ+0EEAgqqubeAJlVVYCopKGVZ7Ah9OCrTWcpRwOdB4kQgMpQsLSP8jIyeDxioxDc+vuihwg9HtoCOP+j+JoDDeZeuNLj9bKX12KOv5M0srQ/hacLy/6u4QH9ldXaovMfQbC8L XogTg5Pf FXOTSLcmsHBd+POFc4QUipxP8wG9/rHTd2+SFcSn9eA32BKyzPlXvWbywrs0YDjixonz4bXi1OvFM4Y/my9+5ZW3zJfZzGdUAHDwF6Y8vjELtp71gCODNwMNlmaRFjInTu8+dREe42YZleg+Ps67OJMI4OHo8OsAYTw818NELZwxlMUTCXq9YOCf+QWIDc+1cWDOiOaOjKduvvsy8MSNKmo3eZlMpP/18DahmmrwZgJ56xUdk8vv0FgVz3C6/kp5+IpiEem/LtrgNyTayFZk8w6GmRNXapNP8qTKYHW7K8jGzvWDArJT9b8grCGsBJsMMWuW6iVbAc1DwcXqy3tTffYznCcZdQho4A7ZjcF5gJD8Q8XuUN8IgEQydYCyRzi3L1vJMzBx449tSA6uRBsyRk6isYM2Pxf3pMlol2R96BO3CvFyRLHyLhi2J1tnZYjzwhLdgnJyoe6+1S3Fa+JiXvsFVMyBSPphEQ4o+oDCTfiPuABQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.04.25 05:49, Baolin Wang wrote: > > > On 2025/4/1 20:54, David Hildenbrand wrote: >> On 26.03.25 04:38, Baolin Wang wrote: >>> When running mincore test cases, I encountered the following failures: >>> >>> " >>> mincore_selftest.c:359:check_tmpfs_mmap:Expected ra_pages (511) == 0 (0) >>> mincore_selftest.c:360:check_tmpfs_mmap:Read-ahead pages found in memory >>> check_tmpfs_mmap: Test terminated by assertion >>>            FAIL  global.check_tmpfs_mmap >>> not ok 5 global.check_tmpfs_mmap >>> FAILED: 4 / 5 tests passed >>> " >>> >>> The reason for the test case failure is that my system automatically >>> enabled >>> tmpfs large folio allocation by adding the >>> 'transparent_hugepage_tmpfs=always' >>> cmdline. However, the test case still expects the tmpfs mounted on >>> /dev/shm to >>> allocate small folios, which leads to assertion failures when >>> verifying readahead >>> pages. >>> >>> To fix this issue, remount tmpfs to a new test directory and set the >>> 'huge=never' >>> parameter to avoid allocating large folios, which can pass the test. >>> >>> Signed-off-by: Baolin Wang >>> --- >>>   .../selftests/mincore/mincore_selftest.c      | 25 +++++++++++++++++-- >>>   1 file changed, 23 insertions(+), 2 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mincore/mincore_selftest.c >>> b/tools/testing/selftests/mincore/mincore_selftest.c >>> index e949a43a6145..e8d7a3a4739f 100644 >>> --- a/tools/testing/selftests/mincore/mincore_selftest.c >>> +++ b/tools/testing/selftests/mincore/mincore_selftest.c >>> @@ -12,6 +12,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>> @@ -283,7 +284,7 @@ TEST(check_file_mmap) >>>       free(vec); >>>   } >>> - >>> +#define INPUT_MAX 80 >>>   /* >>>    * Test mincore() behavior on a page backed by a tmpfs file.  This test >>>    * performs the same steps as the previous one. However, we don't >>> expect >>> @@ -291,6 +292,9 @@ TEST(check_file_mmap) >>>    */ >>>   TEST(check_tmpfs_mmap) >>>   { >>> +    char tmpfs_template[] = "/tmp/check_tmpfs_XXXXXX"; >>> +    const char *tmpfs_loc = mkdtemp(tmpfs_template); >>> +    char testfile[INPUT_MAX]; >>>       unsigned char *vec; >>>       int vec_size; >>>       char *addr; >>> @@ -300,6 +304,10 @@ TEST(check_tmpfs_mmap) >>>       int i; >>>       int ra_pages = 0; >>> +    ASSERT_NE(NULL, tmpfs_loc) { >>> +        TH_LOG("Can't mkdir tmpfs dentry\n"); >>> +    } >>> + >>>       page_size = sysconf(_SC_PAGESIZE); >>>       vec_size = FILE_SIZE / page_size; >>>       if (FILE_SIZE % page_size) >>> @@ -311,7 +319,18 @@ TEST(check_tmpfs_mmap) >>>       } >>>       errno = 0; >>> -    fd = open("/dev/shm", O_TMPFILE | O_RDWR, 0600); >>> +    /* Do not use large folios for tmpfs mincore testing */ >>> +    retval = mount("tmpfs", tmpfs_loc, "tmpfs", 0, >>> "huge=never,size=4M"); >>> +    ASSERT_EQ(0, retval) { >>> +        TH_LOG("Unable to mount tmpfs for testing\n"); >>> +    } >>> + >>> +    retval = snprintf(testfile, INPUT_MAX, "%s/test_file", tmpfs_loc); >>> +    ASSERT_GE(INPUT_MAX, retval) { >>> +        TH_LOG("Unable to create a tmpfs for testing\n"); >>> +    } >>> + >>> +    fd = open(testfile, O_CREAT|O_RDWR, 0664); >>>       ASSERT_NE(-1, fd) { >>>           TH_LOG("Can't create temporary file: %s", >>>               strerror(errno)); >>> @@ -363,6 +382,8 @@ TEST(check_tmpfs_mmap) >>>       munmap(addr, FILE_SIZE); >>>       close(fd); >>>       free(vec); >>> +    umount(tmpfs_loc); >>> +    rmdir(tmpfs_loc); >>>   } >>>   TEST_HARNESS_MAIN >> >> Is there anything that cleans up the mount in case something goes wrong >> (we run into an assertion), or will the directory+mount stick around >> forever? > > Good point, will cleanup the mount in the next version. > >> >> But I also wonder whether check_tmpfs_mmap() should be changed to live >> with the fact that readahead ("faultaround") could now happen. What's >> the reason for not doing that? > > From this test case's description, it doesn't expect any readahead. Yes, but why are we testing for that *at all*? We don't make such assumptions/tests for anon memmory ("no faultaround happened"). Why not simply remove the "We expect only that page to be fetched into memory." documentation + checking? -- Cheers, David / dhildenb