From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0B0EB64DC for ; Fri, 30 Jun 2023 16:00:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C358A8E002F; Fri, 30 Jun 2023 12:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6328E000F; Fri, 30 Jun 2023 12:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD5AF8E002F; Fri, 30 Jun 2023 12:00:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C70D8E000F for ; Fri, 30 Jun 2023 12:00:40 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DEA0E1402F8 for ; Fri, 30 Jun 2023 16:00:39 +0000 (UTC) X-FDA: 80959876998.23.70E3D32 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 2BA0A1A0004 for ; Fri, 30 Jun 2023 16:00:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QfkLlsX3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688140827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bGGz8DiANSWoI5a6kGLb5e94iILUQVr5jzEPV3uc4I0=; b=Z1mhLyyqZe39M3y8ORrkwR/hfQAW/7I6VkZvxzghQffMbDV+LAn+Lh1zjOBFSawN0BhfFC 6NSIql6KP9QvRrUma8qIAQaJBCuLoRWem1yw/7cch+FG4ii/eahC63zmpcpxE9c8eB7hb3 8+7WumYL/5+wAJmB2EnZl17Tf5cvoVQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QfkLlsX3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688140827; a=rsa-sha256; cv=none; b=sNhKSryMZPUxwO+NFaC5vw9xHB9CuuOSox4CfLafCZhLWFJyAA/gJKi6F3QrSTAWqCUEAZ TETnz1EHGo/PZdp6kn38FGN6IuDj/vDwIOC11U7x9rYE93BLe+lRxTqMCno+A+sXXNOAKm eMA07iFMGDi8avg2fEy2RueptktYNJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688140826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bGGz8DiANSWoI5a6kGLb5e94iILUQVr5jzEPV3uc4I0=; b=QfkLlsX3+QPuc6GJ2uO/ithTcb6A8wpCYiaUs3gkXmBUN99wCoz9VYDN1+Wd0C2pnV7Et6 I/DZgqjaeoXSBmZq/Pn8FKywU73h6uSs1CuxG6urp5ygLErheMujmb9Q1LSESf7s9lNcMH 3HDXtITedYpH/zz/8F1JNCTc5TK3naQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-6IJV-npHPyCrw__XkncbgA-1; Fri, 30 Jun 2023 12:00:23 -0400 X-MC-Unique: 6IJV-npHPyCrw__XkncbgA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8911138035A6; Fri, 30 Jun 2023 16:00:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A5BE2166B2D; Fri, 30 Jun 2023 16:00:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <36eda01e-502e-b93d-9098-77ed5a16f33c@kernel.dk> References: <36eda01e-502e-b93d-9098-77ed5a16f33c@kernel.dk> <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-4-dhowells@redhat.com> To: Jens Axboe Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Christian Brauner Subject: Re: [RFC PATCH 03/11] vfs: Use init_kiocb() to initialise new IOCBs MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <662383.1688140818.1@warthog.procyon.org.uk> Date: Fri, 30 Jun 2023 17:00:18 +0100 Message-ID: <662384.1688140818@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2BA0A1A0004 X-Stat-Signature: uok1ddsmybujyts65sxqoy897t4o7x9x X-Rspam-User: X-HE-Tag: 1688140826-983716 X-HE-Meta: U2FsdGVkX18s0oje8ae6ig+Oes1CmbFWCiOPSnDpC0mAFzNglb5/b2f9IUzmvOSH2/XYV2q1b7sRLPm4qGb8moRc3SxSbzxZIWfh+xJxG3+X2VXPkrq7zBEfL/fIuBc4SVlXrcfK+GNc+amAncVBJRjChKY0YI0vj/9ueLkYTKrQMDtDtX0GqHHb9m8oMRKcZDzh3CKy2LFUZBhUemV3QRkulEjDmxScVzIeNWJqweNTx1DeEkdREwWEEUWbF+FNp2PVSvDah6eNKgWA3ES5bkR4M/PSfUdAvu5MBVZGk6YE2qAXvz0YzxfRWsj5rtIxTGfUEyEModSx/6E2tw2hdDXqibyu6IWECb0BBAT3Ze0lYquqUJkmP2ZoFU7Y+VfKaOwCzXokuuGu0anBuLKQRVmol7/5NWViPbRnwbAP2G0ekWJhMul5DWLrUcMNPydumipkveC0763KGJokvkcermi+HMn+hyxLne825vk5O3m+L1I5qK72t7/99NPE7mJmvd1iOt1ShFXObUbCKbHctrV3B6qJps0vdv5uPElxkR8tXbQ0DFwHtTEl4xcxRyEKkNR8gzHIbkABNfm686uqmK5Ws/zPEmRrby01+LXoulYfvoe5PeARBZdAPbChQ23+s7EULGznGUseo1ZRqEZkKCzvH2MKOl/W4YuOatfLi61SLlMKWelWVuAGnTVSWzekMJrTPyrPThm2T9jmfX45rstSPiMSdXUUgIMd1zP8IdhPlvY7ayuB0uQ708ElrKgKi5QdMx9nXXNhb4EkhWtzlPL+N35BAXXKuma7mL2i1WdQighfg7R5tc1k2A1FeELrNevmD7xXanxvenoPvzv1V/BdFVz7x+/6W9taHxzsFHaa0R+ZDYBNztqQ/CK5V2Np4B/nqxW4MXe9XxRRuOKPymjEFuqW7e8ZheR63BoPKySCWiz2igZBxEKZXFTjcSzPf+ws5i17aFvHLCb6SGu 4dsFULOS L7fzTiYB55I6A6A1Wv8/8yGmlNsTcNhWOAKjO+FSmV5XbP3GZI4FCuuPfCEGCkh16OISZ3sxyHMe1GkeEFXTQS6bdhohpF1IhaGYwxy0VecrEAFbX+6VBS6x8hJNPX6Pc96g9Y0au0vYp/SUKBTBeTrp5f17F6JifEs052dXw7a27fY97FVrflHZ7o+VjkeWhvmlpEmfwrM1yIZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jens Axboe wrote: > One concern here is that we're using IOCB_WRITE here to tell if > sb_start_write() has been done or not, and hence whether > kiocb_end_write() needs to be called. You know set it earlier, which > means if we get a failure if we need to setup async data, then we know > have IOCB_WRITE set at that point even though we did not call > sb_start_write(). Hmmm... It's set earlier in a number of places anyway - __cachefiles_write() for example. Btw, can you please put some comments on the IOCB_* constants? I have to guess at what they mean and how they're meant to be used. Or better still, get Christoph to write Documentation/core-api/iocb.rst describing the API? ;-) David