From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C63C5B543 for ; Thu, 5 Jun 2025 16:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 330456B0480; Thu, 5 Jun 2025 12:43:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E1206B0482; Thu, 5 Jun 2025 12:43:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21E0E6B0485; Thu, 5 Jun 2025 12:43:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 09FE86B0480 for ; Thu, 5 Jun 2025 12:43:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5D2A160F70 for ; Thu, 5 Jun 2025 16:43:02 +0000 (UTC) X-FDA: 83521916604.30.8E633CA Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id F091740004 for ; Thu, 5 Jun 2025 16:43:00 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hDizo1rU; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749141781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dDOqLEjANGHua4a7ATBm26tmFSRb86ga03iUw29lQRQ=; b=sLv5cnbmJ3bt3rGl2Zv0nZRoEeXPor2TRbd/ff/f/dpNSx8S7Uog9tq0WOneRdxpqqj0D/ OOGDPE9C8LadwsE+Se6P/C5Fpc4sk2Yxoevd6bui21TBpqoSs9ePJ4BD08gbsI4mFnn/8c R1SRIzFoolKSPloUJwJBgXTmeObtiMg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hDizo1rU; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749141781; a=rsa-sha256; cv=none; b=z1dg6Eqk8uc+6ZqCmuV6XSfWR+lzxwGUJUQOtVlr8H/NwOfUgWjI1UcPvw4hpUobdbtpH6 NMDwJ3iG+XENh3KilOpGQnfsbAzEOafi3ZPsl/732cplT9Qk5tjspqCV1u9Ldd3qPv2jRV WDreiJy1W4u9fwjPGAEl5GjU/7cdmBU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2C5E7A50922; Thu, 5 Jun 2025 16:43:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CD65C4CEEB; Thu, 5 Jun 2025 16:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749141779; bh=0r+aNnLmFMS7mdz7HvIsS99vO/nRpRQLOXs1kYWCUKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hDizo1rUZ9KLPEX+dPsq23BvqaU8uk/lkHpdNMqJByU5gntxauyNzO/QKk4H2RCbc JqfucZjpD5dMBCz6ucakaWsjwIk6moVA1w+s7wlFuTXAxqpSSwcWm1U9i3J37wNqXL tFAe5yBup5MT5KIb6OEMmy/+zW2vrxjo4dkl0Kn4D242A77sf3Z4QYMj4iooh4D2mv 6ZSrij3YjQdz4J63xsBF4i8B/8HlFl1MShRn3pXRVqnh/LiMPOD7uV+Fox4I6zjfdQ WrXJWwT+6sk8AvJ+M+EesADr/ogdBM9vxLTMb3wxeiRmqtbsfH9yi+jcALajjEBfzm Ri1/SVs5xPOGw== Date: Thu, 5 Jun 2025 17:42:55 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: Andrew Morton , Shuah Khan , David Hildenbrand , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm Message-ID: <661fc4ce-839f-4c47-bc3a-0c864e846324@sirena.org.uk> References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> <66db3d9e-73a6-4fcd-8abd-db65cfff49ab@lucifer.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1KSTMtpuZmSO6oKM" Content-Disposition: inline In-Reply-To: <66db3d9e-73a6-4fcd-8abd-db65cfff49ab@lucifer.local> X-Cookie: That's no moon... X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F091740004 X-Stat-Signature: t58zm9eqhbyxd7t78iu8hyiqbe8o588a X-Rspam-User: X-HE-Tag: 1749141780-953876 X-HE-Meta: U2FsdGVkX1+xXEbMJA1gxKVaPid6AmJ1igiAlQsaqH2LltP5xphDVM+M2LnauHN5YNTQGb01stq9fYqOgntqAbv8p56toUe4hu6NE3JthrztJ2UANg5BkEOylemHXEw3bf5uC+bVnUrtrYSpwlCQcc56XMy5gQ6BHbgREljpkvdJZ7RrRjwOb0UGscyg1gjzqsNeDrsB5cDLUe/TeW6xjL9+OzZErwzr1eEQRn1GZV5Igtd35qKvlmtwYcVKXUpzvRpjdioU5FBdSbABktpE+n+rTBMBU1TTNd5pmk572AVSg6RlvKYP7NkEs3fcPLct6n3qGCRrvIIfxaMCBry1KEzkkrVFMigcrx+fAId4gTBkqi5WYqSeuowQY385WrTKeRhXeqT5HT13/5PjeCCCdgsMvqMVrBxOzZBH0jn0uZQmIaY84mmwm0ZF3vLk/z6s+nZc6WSc+v8yDHmqMzB1Onz+AtKlN5eJChP+O7Lp+vH6Ab9XXHqcVmoCLh9r+16NtSU7d0K+bxH3fLP8uVT1uc1V2bg8wHjOJcT2KR0FY9ge2cKnpM1MVLAC40wcHqNoFeCm/XCAWvGJKScpYE53iHIqg0XyynFVIt61HMuCX9S3V3v7bCA/iijJ5pr73aHU3X+qBuVDsSHyhTWhKoTp+B0AfSF2Raoww2b/JEwsVkJ8WCihPHiOAQ+ugKRwIFCuVWNlNRp61jW9BR3DLFu25UHNwn1aoLevZUD0zu8TjYi1saV/8SGt54TEae7V/Xwv5GGUYUitLBW0H7mA5gh1X8dj3qEjcXaEToPYkB6GST7stVtGm8BEz+bpqsnASSR2nSdt6B4Pkj9ddt/gGejuTlQp+9tJIFsJxAVOXtkoZskNyd0bQq56tIbW2b77X3rGkBoXFjxBt98PCeEVannM7hgc1HLqo0HbOzl/G4+NReJcO0oPZjbVMoPVjHMWgjRmuqzHXVOnDnebrek1zwt 7KtOgnTp plqz3WNLXQmsqu5jDtf4Y09vAbSGhZNixrMDEoYzN2EjdKqGeXWH14pO2lsOvS7avvCb9eN95mMac4gY4mMG8sL7l2MhWW9C6lHOO8ptNOqf8mNA7jkgwZaGC2+sgyhhwZ1DuTxVwI8Q1wVOADymeY2EuB51PO+QHQHnMX88lAVCuyIvhKcXjoJZQ8XNSJB8QR99k4+vIVOlMdeBY75TOiyYYxeq8axA5IXB7kF3mQDA9kFj3pJfPRdV7rCCu7KoU4PeNfJ0tZZFjPzmeqJPnU6QEPCBVtqkygfW7Y2Uea6rZEKdUoTw7ODX6b2ePu37Ffji5tqgfx1Mi8WesROLua5BxYuGW5EFaq9H7rLBtKRlcTYg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --1KSTMtpuZmSO6oKM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 05, 2025 at 05:26:05PM +0100, Lorenzo Stoakes wrote: > On Thu, Jun 05, 2025 at 05:15:51PM +0100, Mark Brown wrote: > > That's the thing with memfd being special and skipping on setup failure > > that David mentioned, I've got a patch as part of the formatting series > > I was going to send after the merge window. > where did he mention this? I can't remember off hand, sorry. > I mean I'd argue that making a test that previously worked now fail due to how > somebody's set up their system is a reason not to merge that patch. Well, it's a bit late now given that this is in Linus' tree and actually it turns out this was the only update for gup_longterm so I just rebased it onto Linus' tree and kicked off my tests. > Better to do all of these formating fixes and maintain the _same behaviour_ then > separately tackle whether or not we should skip. I'm confused, that's generally the opposite of the standard advice for the kernel - usually it's fixes first, then deal with anything cosmetic or new? > Obviously the better option would be to somehow determine if hugetlb is > available in advance (of course, theoretically somebody could come in and > reserve pages but that's not veyr likely). The tests do enumerate the set of available hugepage sizes at runtime (see the loop in run_test_case()) but detect_hugetlb_page_sizes() just looks in /sys/kernel/mm/hugepages/ for subdirectories and doesn't look inside those directories to see if there are actually any huge pages available for the huge page sizes advertised. There's probably utility in at least a version of that function that checks. --1KSTMtpuZmSO6oKM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhByQ8ACgkQJNaLcl1U h9BaaQf9Hw7ugDXjeBvmEjND8ygIlFU2ID3I+VGXxWjM46ulNGznstKqLR52VpTF GyHa6iyZko7UJM+m7zi8vKjKJFHcqXMwfCOmR/Tmh/sHl0f1Q6jYGALQcW8YnbHL LE8EluuAiV4x0UkVomonbTFIkQhDkGYQ79Qbv3RA+24r3CVaSy1qJ7CW2HxnEUlK FP6PeVrQN+8/qNM+716nC3wIHLrBPKfaw7yyLADeTsww3I/eCYOa2YZ94/0FSqQl L0k/L8EG1WE1Hid187NCuYfGTVw/EmYA6cRAu4MYrbGjxV17Hj3n41owD8YEgCa0 ZhzMYim72uAG2J7a2SAfx0Pa+z446w== =amh2 -----END PGP SIGNATURE----- --1KSTMtpuZmSO6oKM--