From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BFFC3DA63 for ; Wed, 24 Jul 2024 01:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD9C96B0092; Tue, 23 Jul 2024 21:23:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8A806B0093; Tue, 23 Jul 2024 21:23:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 951B16B0096; Tue, 23 Jul 2024 21:23:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 776C26B0092 for ; Tue, 23 Jul 2024 21:23:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 24349C057C for ; Wed, 24 Jul 2024 01:23:00 +0000 (UTC) X-FDA: 82372897320.17.54181D8 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 211D1A0007 for ; Wed, 24 Jul 2024 01:22:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721784155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E3GgPYfCGom5VQpNkYXnMsNKBxd1uzwR9zHynCAYM2A=; b=heAw6+CJizNgCzNznNPk9erCEqAVqg4O2MWjHd8Suvq425FFQV71RaxjyU7qpfScqInwOo z/f1Bds7YjEGh7a8ZTb/dapJqqiOJuqb32sHcmnHYb8STWu5SvAozzoqXBwz9bsgtUltmc twZ8V5N6H/6cuCw/AxW/65pyCjQaqZo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721784155; a=rsa-sha256; cv=none; b=DA031iEu4ClsD6QCul9ugmtDLrCgNb25/cBgrQy3EDE+A15C8rzghvHMXmRBxrgrEhmJS+ 3Edoyh2JaSqlRvmPXs2bK2xsIJTx6YCCc8rsbPbLTvUqpSNDPA3mokI2pPt7fm7EnFR7mj KZe5tn/yVAie8ohv/P+2TXVbpqfdz80= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4WTGPF3V5vzQms7; Wed, 24 Jul 2024 09:18:41 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 472D31800A2; Wed, 24 Jul 2024 09:22:52 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 24 Jul 2024 09:22:51 +0800 Message-ID: <661e85d3-e2ce-4238-8c3b-077b8980a822@huawei.com> Date: Wed, 24 Jul 2024 09:22:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. Content-Language: en-US To: Zi Yan , David Hildenbrand , Andrew Morton , CC: "Huang, Ying" , Baolin Wang , References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-3-ziy@nvidia.com> <5230d72e-81fa-4ef1-b386-90bd3b06bf0e@huawei.com> <1621fcbd-38b5-46a8-8b68-911f2920d52e@redhat.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 211D1A0007 X-Stat-Signature: h3u3uxhinjsnqrjny3nzxx4tdyyrsx3d X-HE-Tag: 1721784175-164315 X-HE-Meta: U2FsdGVkX1/MbTsMlwFuz4ken9vrCvwPAxMw0cfnDbttHTx1rhDmJBlFmuavMtkkGjABCQqqTn5hj9kYlMk+Ts6so1ZAbRPGAyfiewFU5p7mVYU0xsoWiibW7QQnfKcHNWSP/w3jOPVQ0Mu+/M2T/Jq0qe99P+D9lXSMEXwGgUEa+AEZD7jhQL/wUKkN6uYHdmIvUgoj0jQf4Q9quTebMc2zWOygiwHuSJppAE7fGCEIx/pYZlDh68ODIdRFl1qQ2MOpEm4y53eQKZiIYMYYkAiIz8o0YSy7LvgRTyIegLN1Q8MWW9NCUXeWwsfsWK5sR++dMzLHVJn/+/oan6e2C5wHFg6khmUHbKaoFmzv4AW5QtnGigDrrQOdVNmLXbjAB6zzkYFjvv/LYyirByno+QIHK4T8BaDWvY/k0BEuHI+rjacUHVBKQPIovrwaQJuXkWATmbjkzQNLG2rR6rFtvV073oY+8OusNkqO900jSi+Xvdlk3Lz/UfpVJlr2JYbAj0+fkKlmTYuWuIxQrZOkqTjRnzlDV5Q0cquIC9pnD8Kek8TD/5fme7C6m9M7SehzQCV23Oi3sRATv0PoH/U01YVogzcj7vQtUe8oCw8WtZV7B0DJzKy2deztvlJgAS2jDQk3BvQDz0w9cGgahoek2Gy5eX6VPzbaChOI2OpJHd4w4p/J2GsxpE4MeMACx3BwfcmKWjJ2gZxgqYC70s7hefHlySGwDKqie3O3e/eKGNQZLsfNEYn5bziqf7WM/xNx5NuRVS3HiLBSls+KjzwsiL3xE+ypvY5JAGOKM84+PQiSDPjNMGKtj6xBFlTlrHfRCtNnMfRiDEpgPo+Rt6HpYuqZbASgJEBrYtLhU6W5aolfWY3bztfshsjgRv/SiQgMIIYB2Ef6+X7ufnN4wXQ4stO/oenOJrsIYF8HyblHPXTZe4+W0fGL80qAY6Ooxfnj7QXptUZAj59us9Kxl8A pTuScUir 27UqrTh+M2jrTkk5cX65JkTnTNgeUyehq1+pNyNshL+E18uuQ8avv3mQ5qDCC3cYLLWNNJegxYPaB007IWUWEvfQ6emVxr1NKonZ+P+B2l6cngTZEdshf6ZrVXp+ei6NQOYGsumyXXisV6PRt/OROVhgUCBlCw6TNgNztS9vv38cZ1iqB0jpiRi4tlLRsf+DIq15r8VZLBZ5xHcSkJPChz5siz978+JUwd5Q0HbpE+b/zzuwxMFlbd7/c31QMPYJinGAZNusBtvcf1cWJDXQnFC6WNHSZ2hFZxM6r/X8b9yvY9g69g9B2g+DMOgT+lh9cgkBe8nW3KvEeVAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/23 21:03, Zi Yan wrote: > On Tue Jul 23, 2024 at 6:17 AM EDT, David Hildenbrand wrote: >> On 23.07.24 05:24, Kefeng Wang wrote: >>> >>> >>> On 2024/7/23 9:54, Zi Yan wrote: >>>> On Mon Jul 22, 2024 at 9:48 PM EDT, Kefeng Wang wrote: >>>>> >>>>> >>>>> On 2024/7/23 1:29, Zi Yan wrote: >>>>>> memory tiering can be enabled/disabled at runtime and >>>>>> sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check >>>>>> it. In migrate_misplaced_folio(), the check is missing when >>>>>> PGPROMOTE_SUCCESS is incremented. Add the missing check. >>>>>> >>>>>> Reported-by: Kefeng Wang >>>>>> Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ >>>>>> Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") >>>>>> Signed-off-by: Zi Yan >>>>> >>>>> Reviewed-by: Kefeng Wang >>>>> >>>> Thanks. >>>> >>>>>> --- >>>>>> mm/migrate.c | 4 +++- >>>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/mm/migrate.c b/mm/migrate.c >>>>>> index bdbb5bb04c91..b819809da470 100644 >>>>>> --- a/mm/migrate.c >>>>>> +++ b/mm/migrate.c >>>>>> @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, >>>>>> putback_movable_pages(&migratepages); >>>>>> if (nr_succeeded) { >>>>>> count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); >>>>>> - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) >>>>>> + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) >>>>>> + && !node_is_toptier(folio_nid(folio)) >>>>>> + && node_is_toptier(node)) >>>>>> mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, >>>>>> nr_succeeded); >>>>> >>>>> The should be in advance of patch2, and change above to use >>>>> folio_has_cpupid() helper() too. >>>> >>>> It shares the same logic of !folio_has_cpupid() but it might be confusing to >>>> put !folio_has_cpupid(folio) && node_is_toptier(node) here. folio's >>>> cpupid has nothing to do with the stats here, thus I did not use the >>>> function. >>> >>> If folio don't include access time, we do migrate it but it isn't a >>> promotion, so don't count it, other comments? >>> >>> PS: Could we rename folio_has_cpupid() to folio_has_access_time(), even >>> without memory_tiering, we still have cpupid in folio, right? > > folio_has_access_time() would be the opposite of folio_has_cpupid(). > If memory tiering is off (either at compile time or dynamically), a > folio has cpupid all the time. > >> >> Maybe call it "folio_use_cpupid()" or sth like that? The "has" is a bit >> misleading, because the folio has a cpuid in any case, no? > > The folio's cpupid field is reused to record page access time, when the folio > is !node_is_toptier() and memory tiering mode is on. > > In sum, using folio_use_access_time() as !folio_has_cpupid() seems > better to me, since it covers the special use of folio's cpupid field. > It sounds good, thanks. > Let me know your thoughts. >