From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by rv-out-0708.google.com with SMTP id f25so819390rvb.26 for ; Thu, 11 Dec 2008 06:00:46 -0800 (PST) Message-ID: <661de9470812110600i6097ca0q7a2d7250f6c493dc@mail.gmail.com> Date: Thu, 11 Dec 2008 19:30:46 +0530 From: "Balbir Singh" Subject: Re: [RFC][PATCH] memcg: show real limit under hierarchy In-Reply-To: <20081211122237.4FF7.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081211121135.e00f6a2d.kamezawa.hiroyu@jp.fujitsu.com> <20081211122237.4FF7.KOSAKI.MOTOHIRO@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: KAMEZAWA Hiroyuki , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" List-ID: On Thu, Dec 11, 2008 at 8:54 AM, KOSAKI Motohiro wrote: >> I wonder other people who debugs memcg's hierarchy may use similar patches. >> this is my one. >> comments ? >> == >> From:KAMEZAWA Hiroyuki >> >> Show "real" limit of memcg. >> This helps my debugging and maybe useful for users. >> >> While testing hierarchy like this >> >> mount -t cgroup none /cgroup -t memory >> mkdir /cgroup/A >> set use_hierarchy==1 to "A" >> mkdir /cgroup/A/01 >> mkdir /cgroup/A/01/02 >> mkdir /cgroup/A/01/03 >> mkdir /cgroup/A/01/03/04 >> mkdir /cgroup/A/08 >> mkdir /cgroup/A/08/01 >> .... >> and set each own limit to them, "real" limit of each memcg is unclear. >> This patch shows real limit by checking all ancestors in memory.stat. >> >> Signed-off-by: KAMEZAWA Hiroyuki > > Great! > > I hoped to use this patch at hierarchy inactive_ratio debugging ;) I like this very much too I would prefer to use min_limit = min(tmp, min_limit); and similarly for min_memsw_limit Acked-by: Balbir Singh Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org