From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by wa-out-1112.google.com with SMTP id m28so1792857wag.8 for ; Tue, 23 Sep 2008 19:09:58 -0700 (PDT) Message-ID: <661de9470809231909h24ca4a39k470e322f2c1019dc@mail.gmail.com> Date: Wed, 24 Sep 2008 07:39:58 +0530 From: "Balbir Singh" Subject: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page) In-Reply-To: <20080924084839.f5901719.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080922195159.41a9d2bc.kamezawa.hiroyu@jp.fujitsu.com> <20080922201206.e73d9ce6.kamezawa.hiroyu@jp.fujitsu.com> <20080924084839.f5901719.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "nishimura@mxp.nes.nec.co.jp" , "xemul@openvz.org" , LKML List-ID: On Wed, Sep 24, 2008 at 5:18 AM, KAMEZAWA Hiroyuki wrote: > > After sleeping all day, I changed my mind and decided to drop this. > It seems no one like this. > I've not yet looked at the patch in detail, I just got back from a long travel. > I'll add FLATMEM/DISCONTIGMEM/SPARSEMEM support directly. > I already have wasted a month on this not-interesting work and want to fix > this soon. > Let's look at the basic requirement, make memory resource controller not suck with 32 bit systems. I have been thinking of about removing page_cgroup from struct page only for 32 bit systems (use radix tree), 32 bit systems can have a maximum of 64GB if PAE is enabled, I suspect radix tree should work there and let the 64 bit systems work as is. If performance is an issue, I would recommend the 32 bit folks upgrade to 64 bit :) Can we build consensus around this approach? > I'm glad if people help me to test FLATMEM/DISCONTIGMEM/SPARSEMEM because > there are various kinds of memory map. I have only x86-64 box. I can help test your patches on powerpc 64 bit and find a 32 bit system to test it as well. What do you think about the points above? Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org