linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Balbir Singh" <bsingharora@gmail.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch 1/3] radix tree: RCU lockless read-side
Date: Sat, 11 Mar 2006 13:52:45 +0530	[thread overview]
Message-ID: <661de9470603110022i25baba63w4a79eb543c5db626@mail.gmail.com> (raw)
In-Reply-To: <20060207021831.10002.84268.sendpatchset@linux.site>

<snip>

>                 if (slot->slots[i]) {
> -                       results[nr_found++] = slot->slots[i];
> +                       results[nr_found++] = &slot->slots[i];
>                         if (nr_found == max_items)
>                                 goto out;
>                 }

A quick clarification - Shouldn't accesses to slot->slots[i] above be
protected using rcu_derefence()?

Warm Regards,
Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-03-11  8:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10 15:18 A lockless pagecache for Linux Nick Piggin
2006-03-10 15:18 ` [patch 1/3] radix tree: RCU lockless read-side Nick Piggin
2006-03-11  8:22   ` Balbir Singh [this message]
2006-03-11  8:48     ` Nick Piggin
2006-03-13  3:04       ` Balbir Singh
2006-03-13  3:11         ` Nick Piggin
2006-03-13 15:24           ` Balbir Singh
2006-03-13 22:37             ` Nick Piggin
2006-03-14  3:32               ` Balbir Singh
2006-03-14  5:16                 ` Nick Piggin
2006-03-13  6:40         ` Nick Piggin
2006-03-10 15:18 ` [patch 2/3] mm: speculative get_page Nick Piggin
2006-03-10 15:18 ` [patch 3/3] mm: lockless pagecache lookups Nick Piggin
2006-03-10 15:18 ` [patch 4/3] mm: lockless optimisations Nick Piggin
2006-03-10 15:18 ` [patch 5/3] mm: spinlock tree_lock Nick Piggin
2006-03-13 23:35 ` A lockless pagecache for Linux Christoph Lameter
2006-03-14  4:14   ` Nick Piggin
2006-03-14 12:59     ` Wu Fengguang
2006-04-04  9:31 [patch 0/3] lockless pagecache Nick Piggin
2006-04-04  9:31 ` [patch 1/3] radix tree: RCU lockless read-side Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=661de9470603110022i25baba63w4a79eb543c5db626@mail.gmail.com \
    --to=bsingharora@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox