From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C56C83F1A for ; Sat, 12 Jul 2025 02:23:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 231A28D0003; Fri, 11 Jul 2025 22:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E2EB8D0001; Fri, 11 Jul 2025 22:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1308D0003; Fri, 11 Jul 2025 22:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F00718D0001 for ; Fri, 11 Jul 2025 22:23:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BCB488014F for ; Sat, 12 Jul 2025 02:23:56 +0000 (UTC) X-FDA: 83654017272.13.D354C87 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by imf19.hostedemail.com (Postfix) with ESMTP id 690871A000F for ; Sat, 12 Jul 2025 02:23:53 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=av1TVmsw; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf19.hostedemail.com: domain of chizhiling@163.com designates 117.135.210.5 as permitted sender) smtp.mailfrom=chizhiling@163.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752287035; a=rsa-sha256; cv=none; b=q8T58EbNz3+/1a2zXlFcuYx7FKJGr28Et3E67RYneyTvozPlu8VSLoTxZUYr3Ctf3urtr4 +xtFS/BSzWNbjWKV/lL1KXqnWglVgdNCbFyB/2LgqSsu6PdmFwx/e6LjBa1jGGSWBmV2fC Lr6vlbrJx5lLT/tDlidyxOLW38SdWXY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=av1TVmsw; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf19.hostedemail.com: domain of chizhiling@163.com designates 117.135.210.5 as permitted sender) smtp.mailfrom=chizhiling@163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752287035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wPO8Xs4Ept5FLbMOvFJphq0xBYZ+N64aVMADpTngs70=; b=CSOEw+otNf/fluAtDFeF4Tmzrs3uQxNU+fopNbkFGj2TLZ+UAF9WLtNf0YwRp+elXiXY1L 8i2Ro2mDyF2sV2RZrH4l77wnZbCNLhLm+7Omnr6kCXJmTU0wCtJVl09JuLhQVsMsjQkMr7 Ze9uWylwnxlkFlk6WKaXbcZVb7HRVpc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; bh=wPO8Xs4Ept5FLbMOvFJphq0xBYZ+N64aVMADpTngs70=; b=av1TVmswuDHTkJHp/SrcJInub1m4E5hmHgvp110jWjOYqC51q0ighkaNVwAHce 63yLoxXf44Q9a2P93JBZMbUZAJZJoGPd/Wa/ZqbFWm8mx3WbrCeU5LGRMAvIQY79 D7b2KYiBl+s5CX5LmS6yWETMeMUqXaZQMdBljCoine5eY= Received: from [10.42.12.6] (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDX96Ykx3Fo9tMsEQ--.9104S2; Sat, 12 Jul 2025 10:23:33 +0800 (CST) Message-ID: <661ccfa4-a5ad-4370-a7f5-e17968d8a46e@163.com> Date: Sat, 12 Jul 2025 10:23:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation To: David Hildenbrand , willy@infradead.org, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling , Ryan Roberts References: <20250710060451.3535957-1-chizhiling@163.com> <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> Content-Language: en-US From: Chi Zhiling In-Reply-To: <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wDX96Ykx3Fo9tMsEQ--.9104S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruFWUurW8Ary3Gw1UJFWDJwb_yoWDWrb_WF 40yrn29F4UWF4Sga15GFZ3GFZYgws5CryUXrWDZryIq3yrWas7Z3Z0vr1Svr1DJr1akr43 Jwn3XFWDuF13ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUj3fH5UUUUU== X-Originating-IP: [116.128.244.169] X-CM-SenderInfo: hfkl6xxlol0wi6rwjhhfrp/1tbiTxCInWhxvFTGRgAAs7 X-Rspamd-Server: rspam04 X-Rspam-User: X-Rspamd-Queue-Id: 690871A000F X-Stat-Signature: j1u9f8wrzgyfwejqawgg1ewa61s38isu X-HE-Tag: 1752287033-886060 X-HE-Meta: U2FsdGVkX19dOWh8HMcaR4sIghe9WcUQBxG6bZYrA1gamJaw2DnSs73QW3IMP7tcRBeTl1Eg2DAkV1MdouLDzVYEwMEbgasbVPmLUCH1mgGgt+6KQQG95lUe7mQtaNTsiY/IOUfSuZ2/6IF/Q/s6wQ1SWW/czQIKMJLcaqhW5XW+WT2E5DQzQkCukd/O/M1RMb/xp0P3d+xc0JuPFr6XT2zCBjj/Z6S9iwGq+NSgpYPR1WyzJ0mZe6aZddNCQus5D3KiXI/IzAMwUBsZCvFml3/oSULHlHwaZIJ4Li6SsyiarwnRlyXT5gSMPnFPEQc48q99BQ1ptalqX3yEODjEcY2IrxxuDuO/Z9gLFe/Ei0g6HcNqmWz5LFgwSEgpiX4ApIhVtlk2pHVDOS3Z+psB93MtWentTAnz3YzLSdxK6VLwwABkseVMFGRH3IDEBdY3c3ggwsNTLAnpSxdwFbobe1yfIcWvX+pngBabkQA4i24EN6tJCXdlcJ3BOfoOih1DObJQkN+w2adID+uQZt0zPUChRSnEFCw7/qNp1PZXh9SAu60ID3ZozzBenqE/qVPnMTRJZk03feBWlD330atxKm1+wGBOL7ZzQMQHtpblPFf+pS8nA/wy9c6idqg0jRneuojJ9gfbZZkAyI0v7RCyjYQgUxjH8RUkVINAXtQmdaybD7xUfNGwvcUm8p1zHC5bXc7Fd+LaifYDmrwf4551Z9cVCe49IAAlyRa+WXfX3dzk3Hjqja8gAuFYURBG+xlj/Px0DLiTe8nRubTayZiv+tMnIcxDdXHfaxfEZOsbtZtFYG9PNgcWa0fQhM53Elb1dZM/Y+DYE6KmusF31uY8nttZ3wiTr8rfeqz1+fwQhEoBDTun9czjs2ONbjqz6rX2RPAuXOUuIpRFdReK34bOyrVRnpR0t3ntAf6hpH0e7zJdOV/WFm0gQ/SZ7Jo1gs0q0mrFtyVLSMui/LTKvF9 Kw1YoiQ8 pAbPaS/PCw6sJBczFA7xd/AIbon2IFcs5IgGRZLaMK9e3HtSAFtnfORmVrUxHFIjUZ1+/FgnO0vx1ZHuw9vHoZ5OM2FjTH1jc8lc8M9f1XC/UqIqPgTz30rFfFLzByuYnJQwtC/f/MGrsO9K8CYv7JUaenqffs0WaAqRT1bAAkLV6dEH2SeNtzH/4sZbjICb9OEeC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/12 00:15, David Hildenbrand wrote: > On 10.07.25 08:04, Chi Zhiling wrote: >> From: Chi Zhiling >> >> folio_nr_pages() is faster helper function to get the number of pages >> when NR_PAGES_IN_LARGE_FOLIO is enabled. >> >> Signed-off-by: Chi Zhiling >> --- >>   mm/readahead.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/readahead.c b/mm/readahead.c >> index 95a24f12d1e7..406756d34309 100644 >> --- a/mm/readahead.c >> +++ b/mm/readahead.c >> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control >> *ractl, >>        * Ramp up sizes, and push forward the readahead window. >>        */ >>       expected = round_down(ra->start + ra->size - ra->async_size, >> -            1UL << folio_order(folio)); >> +            folio_nr_pages(folio)); >>       if (index == expected) { >>           ra->start += ra->size; >>           /* > > This should probably get squashed in Ryans commit? I have no objection, it's up to Ryan. > > LGTM Thanks, >