From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720C9C4345F for ; Fri, 12 Apr 2024 17:32:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 097056B009A; Fri, 12 Apr 2024 13:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047556B009B; Fri, 12 Apr 2024 13:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E02D16B009C; Fri, 12 Apr 2024 13:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C292F6B009A for ; Fri, 12 Apr 2024 13:32:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 55F4680FA9 for ; Fri, 12 Apr 2024 17:32:56 +0000 (UTC) X-FDA: 82001575152.22.F1D1E7C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf18.hostedemail.com (Postfix) with ESMTP id BDACA1C0022 for ; Fri, 12 Apr 2024 17:32:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="b2XL4L/F"; spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712943173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ocJCAro1U/KdCjJUIaTkOSoMHe44WEaTJcT0qygFLJM=; b=uPdfaTpgEZT9urbIzZjcPtOYBbQzNELXcjxZg3AJg6r1/QdpQkhPN8um1I0a6qXQb0ED+x jNr+l+RyMih8u+QKTkGH4nVwt5/iS4XSTIU5Gd3SzdtVItOFH2sp8tOMY6KROSRBi9SPsm jhNUbXp33/yX7YYFM0HrJ7PjdZ9mIMU= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712943173; a=rsa-sha256; cv=fail; b=dFGfAEt52yF/t4ZGbuhEY1OZEDCxhqB5d/UdSXvNcxuk1x0AMsJtZgGf3jG99w8mSjHefg z8SxMjRvPgd3lq7zMsU7v3zi4oE/RH+znIYl4e7LYy5muKWbYxwFnaZmvBzFJQPNfxE0TK TcVITJpzyqyAi0WTLZZZP78Ov9c14g8= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="b2XL4L/F"; spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712943174; x=1744479174; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=lsL7cBieAgaJPlkr3q8ciB9WIMrga/7OFdYnLJmjnew=; b=b2XL4L/F7IMbHMgJAUpeUsebTBKm6lSO2YiT5BOXYu330VCHvj2oc3tV VwpRE/IeBYQ0kVFnozKCwq/+/BQn8XJnG3CgYTMYj6aPtfI3rdzCNEVDJ DemZVBOMCqcfzeB54F9HX387rFrJ0sbklYe9GQz++L3PthOSGlMwpd1rt l5TT1bpImD+9JnA2sz4yXwJ2Jej58rVGhiYid4rpUUP5Z1Fu8Ur4MbeFq xXv7cvjRo/EAhPojXE5slGk4x1+N/9NSKNrEWuiV9zQfEaSoK172rJ2OI QauCD+32Y+ffT3jq2Mj/nj67Ivn1IwIbb8nVcYEQpu71BXv5itvOEjqTy g==; X-CSE-ConnectionGUID: PR0G5GTQTfCs8IsM1+NsiA== X-CSE-MsgGUID: cW0jyjOrSeWPKb0oPJeAvQ== X-IronPort-AV: E=McAfee;i="6600,9927,11042"; a="18966176" X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="18966176" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 10:32:52 -0700 X-CSE-ConnectionGUID: Z6y3e5X2SM+85a9/ED4TMw== X-CSE-MsgGUID: 3nRWq5+NRJ2hl1RNVpD8Ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="21207082" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Apr 2024 10:32:51 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 10:32:50 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 10:32:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 12 Apr 2024 10:32:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 12 Apr 2024 10:32:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bwp34lCgheold++/evNpMjvnM07VgFF3i9xoLczd6PmsVB9Xr6jldRUzO1RoxKblCzQYlqEiLXGDMn9wSXLpZd3tYqWnDV4QoTMHAxeNbj5R3EoBIgBRL3SvscSs8aXsEzswaG/eJpT7Py0TnPL/ZMQYR5ukKDvERR8gel58oadl6nhsxTY2C9OscJ3OmWpM2scHdnLWz0h2LTqmgMWMCst0ldeOMXZ5u/z4ivKDkYARWdqgw1v0UAJEwLktYNIj/gkKndSbq8taHi11NpIOOWtKH2I4t1c1MOIh2ck//4vEkLTqW5I0RFqPvfq/4mmbPGf2LPOSdFg9QZ2zAU/kGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ocJCAro1U/KdCjJUIaTkOSoMHe44WEaTJcT0qygFLJM=; b=C6YyS5BU3YfX7e+duXHIsMRJI75Z64iMvmp+eaTyt9oegqkAcsMyJ8GpFAZ9/Jc1urgk/SgmjMvfzLILZMShDkQpTpRKaDCajBMDNlI+TiYOk1oWaB88pvZOXX0/pA8bQIMhLx+yvWKsXdgPEJqyTqANT5140GBCsgb0cbCQrmF4jpkW9GWowxf7Ub6xsGZEcg/tW2usFFZQCO75DPaglNt90gyqdjeZLOvrHM3GGwY5OvQmrHUW10PZsHi7cx6/7Fu2pEhtTu1uNCMv4aPC3FsXtNVD1hz+EZaz//IqAykhHwpV0Jtq5A1x6Zfv0yzusz2inDBrvpB24Q+qWnwwvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SA1PR11MB8350.namprd11.prod.outlook.com (2603:10b6:806:387::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Fri, 12 Apr 2024 17:32:47 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71%4]) with mapi id 15.20.7430.045; Fri, 12 Apr 2024 17:32:47 +0000 Date: Fri, 12 Apr 2024 10:32:44 -0700 From: Dan Williams To: Jason Gunthorpe , Alistair Popple CC: Dan Williams , , , , , , , , , , , , , , , Subject: Re: [RFC 00/10] fs/dax: Fix FS DAX page reference counts Message-ID: <6619703c781e4_36222e294f1@dwillia2-xfh.jf.intel.com.notmuch> References: <66181dd83f74e_15786294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch> <87frvr5has.fsf@nvdebian.thelocal> <877ch35ahu.fsf@nvdebian.thelocal> <20240412115352.GY5383@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240412115352.GY5383@nvidia.com> X-ClientProxiedBy: MW4PR04CA0346.namprd04.prod.outlook.com (2603:10b6:303:8a::21) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SA1PR11MB8350:EE_ X-MS-Office365-Filtering-Correlation-Id: d159644d-d84b-4655-e837-08dc5b1691af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RcHQNCsXTbJbCxotdQ4Y5Hakxq0GgKy+sxNml6fR5tP7+P6I4kutdqOEppw/Tv6OxY7t3F69uzNpeXSniN9ymSXZkH/FTf2fBbDMNB/iGn6AGrN8JmDCVJiJQEdal0+jUB0oeBaMyeWcSqv5tpNWP5uHKdiZPV+dlUXfPC8NRae3dOHgckGa7UP6scvNToeFEfS81GF/oMUbImMzM7beO2iI1So68GKwrnh+/6Y5MVRe9/vOeU7cqPOVEuHZ4eH6LLEW01hMRmDawEXX7LfDIJx/dq/jlO5mzGr5kbKVE6s8J8tbSUVtxyDhcepK+jIl7rL2SpfHSoW87ihMc0K42qbJ6lqWnQ44g19Y3pKGRtnSyJ3C/FTYFQR5E6i3qL8Fk/W5cm+KZufg/8qyk680XTtK28N5BxX28dzoRcAsM9amTlyG0fZDHxHErXFXZ48iGSZ9gjixj33Cz+dC12+m1TdZFC7HqSXms/2Mc7rjvBYDD5Qqnw6geQDhgH1iCliEWrKB+QQybDo3GDbXwCY9p8oguDP8N9uXRJXh9vI7X1Bae34OZyPsfNLKnOZgN/pAcmqj9c1mIV2OvTzHtDIU+oMipv6Lad3F2ECJ29woUFXpMywM9JPz18uAIB3Icfvuk2deUAJPk5YN5V/S03R32m4RuJgTld+FnUuUTmgp2XU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mhwejgf1I+jatneDts8L9OabCk7hEYEx4TUcKNPhRoRa0Ym0/m4n4DULp1oR?= =?us-ascii?Q?/dIqtSyfg4C0F1ahMfzOuIpiZNNHUuNFNxtZeZWgh0T4BqK+89h9Kd+seoKb?= =?us-ascii?Q?TjtWjhJy7HPB1/2G6qLg+ypbS6oxlDEn0BbwK8hEx6Sk9PD9DygQgWCbPd3B?= =?us-ascii?Q?cGXFvrrpCD4wNDWLkzpnKyu49f8y8yMGqf7jyEywa/iJfjDEDeQShObkewxE?= =?us-ascii?Q?cGfnyuhqcYuE8FsXw3TQLWzmzkNa8fudv7UUCBb6/PTVzy73uAGg4SxOZQ6o?= =?us-ascii?Q?+ndt7UVjlZIuHwcEAEnbk+kytNx9fBny0F0q8Uy8GQZ+x4ekvuGdO3Kjg/U7?= =?us-ascii?Q?s4jNVShREsex6FP3xbQNLGw5iB7wOCqFnJUm8rKsVN05auuVvRqSIXfFZv50?= =?us-ascii?Q?fT2cOzVrqp2MqVttXM7t/M7vhA/fuWehicuqb3u6kL2yi+zM+8JQLDECkP1F?= =?us-ascii?Q?jDHm/dzupi9TpdDK2V5oyuw3Bpmh8+TH/v3jEZnLn1gpu3ldD5oUveoUGsA3?= =?us-ascii?Q?5oqXylVBKcy00RU05Secysvx209knLjV0mLLpDuYCnJC+jPOtZx/OhDEuTzd?= =?us-ascii?Q?dQ6SPqSkIGzDU6fsMp1mgxprnf09+b0KPREyGe+EPe10vs6KvozN7TibrpQk?= =?us-ascii?Q?DHDIxXklecNkZcDFhfgKdlxEXYDtUI1RI9B5Z3vjKNB/fq3o9YcJB9hT49TZ?= =?us-ascii?Q?G5VdSNj3RxS5MlOVzdCcyDNiamytS6NtW0m8bzqNqicSFQafwjmMayFEMJw7?= =?us-ascii?Q?uUgqQFPij4m3dTXwtH1kU5Z7Brfdhhfq3GKQX/T75I4NmLjJL33fbx1NGab6?= =?us-ascii?Q?ME6zmfcwevRpO/SqZ7BsaV1p5cEl4UPBFw2SaNirjcrj3t6an6H7vFUJXWEP?= =?us-ascii?Q?eC9FQor8pCx6D5UIt7HxHXG/yVJr5zeK0jfmUWZfN+mptV/+XbkzF1sRqGzB?= =?us-ascii?Q?zqEWwb66Zx1hXT2DlSxNCTz4TS48plxEjsEFw3fGYGmpyz7O3PzCvqyVUJGG?= =?us-ascii?Q?0jLs+6TovpCl5t9I9/d1vHPyQgxp9YNGWCoAnlRB/jAko73wKAwzH4tokH3M?= =?us-ascii?Q?j5a6C1RD87vHoeUTI4qI/AFiJ6BfNGdJqiOflmvU4P72NbGXmV1jET82EaJr?= =?us-ascii?Q?N/tx+Yhrjadujp9dxJyEokYblAK+wm5eiql8PUhugRlAHt++Ywxw6wUgGP3+?= =?us-ascii?Q?kiPMTt6s0h3bK9XMI2zWtCCwd73BugnsawEG71K+cxg6f/6UrVw4LMRS6Nmr?= =?us-ascii?Q?eDwLU4CoSeZ8TLwj4ows819iqp6qjOBOI/LwkBRvcpza4J6C1Xp1B68S1bcK?= =?us-ascii?Q?g0SlZNIVWChrQha5s5l9LpRu/ry92GDP+VS4RcGAKoY+s3fa0NJdLx5fT7M+?= =?us-ascii?Q?cwhQnfywRJE5iG7X6p7kjV1HwO044K5VgwILeKmxrfJGF67I/3IQzJ2WLrLn?= =?us-ascii?Q?mrXcXTlklTRlGIHomgscRggMf2DQYCfpdUfRWYkudn7zJXg/W8oLlauqeJGB?= =?us-ascii?Q?jAvvjEbgKBWP1NKLxRBa8BXk8gAzjEPdP4mxGlR2g188zuIcAUWEZooAJJxe?= =?us-ascii?Q?j9q8q/FZrtgIkVZNQ//N/hKn6IHPc/QanfZMlrIPnPE1yDfuBIwIHwaAuoRb?= =?us-ascii?Q?6w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d159644d-d84b-4655-e837-08dc5b1691af X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 17:32:47.2452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kfny2RppeUhQlyT47Vx23BfvjBlvcHmWLoYwL3rWAXQs/m2IyBBBSMIz+Ay51+dLmAMrGsCvddQ+xFFjzVIAHUlcwoqslO35QSNUpm6dyRU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8350 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: BDACA1C0022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3hr1857t3opbhftfbdzqfwfntpnspqgx X-HE-Tag: 1712943172-409310 X-HE-Meta: U2FsdGVkX1/bLYJT53SIQ+Plje0Cua5zh9NVM5WH4odAFlikaSG1m0SYAIqU0Sa1EB+3yliNM/p4i9jdjKfokF+pqoeLWA7AlRgkW1foPoJ0cGgy6/aQX8noBkzbt1NmeIyyakZvRB6Sq3HmR8kgb8JVg5J0VSRzNv/lmJCbBEPyNgEohauJk+sA7UKer/jZMey3GnefY2K2yXekhOgZYH9EMic5KDmW4vPcKCnOmGVwh0NEW6MmdebkdLPHtv9LZUmwlNr7dghyNgO1fjaLEQWSWft4otSnwEhtrdhiumuzID5OfOax8Ux0sxgUqBzE6X09TgGJvDN7buVK5y2aHeL2oB4+bPy9kTacOmZV6I/Ez+xOQ9mMdqOHyQwisXyABTa7GR4nIVDFkiikSAPq2JckE2zZm/UgiT6aprf5DcJOYOd+hBg7UTdYjILJgz71m3BwE93a9mRlCQ1a2RHyjaqycPo85W/i12l/S8Pmj7omf35SrTRGVVW5I1qTe1M/TXp+6fldiQhZ/bMoTdVTLKDglUtG8k7iKrJiuadkAP6u2zMk7QzrGseWnmnN9eyy8f9vVkM2u9WYSVkocR4N7GAnaYG54QkMLXsUiV/xxiDkNAA7EVXBG/fzI1Gxl8QZ9V/qWtwsGFUhY52iznwBC9EkoRvE10yISDezw631KjR2DSaxzsJJfvVyrCNVexvRLDERXMoR6EAU1iou05XPSiWrSOgdC/1YUUAYTdei8qL6Aec66sWNM9steLSRPFtI3hQQyXS5iyP1edjrEh3IoBzFHyR6VZyo1M1DZHZjOKPRNZ9zMPMvHPenbLbfqGkAguAOkWWbO7gXvzv1xtzTHszYsetdRmRdYfe6CSYBAGQwXTS9KtwtXGIT0j4wJwdmeCFT9ZJw3FdBmLonrqgtEiI1RkxuohMQEhthuHZVgK29Sh15zPvS19dDRIo3wg5tfMXMyUs9vLotNNF2LOF q9R6hbRL ymVy95dffT5pHvLItByxZ7san/qrpcmMUO1Ia7bqAXC22nL6AH8warCdBAi9pv3yyoe29BvNIXXcvQ7ZN8/Godl0FKpzlHixmPNHClEs18OR962l6lDkcFB/N84tptB+nMTss2PI6KFZlY6r3zxAlCjdedTjZQQhizRJnbAjvv70daGlSESiGh9gn5MMmVbfGBhlkyXY9tlm0lSDCuU6S8XGfjAckXCIt3gQ2Y0mJh7Rw+8s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jason Gunthorpe wrote: > On Fri, Apr 12, 2024 at 04:55:31PM +1000, Alistair Popple wrote: > > > Ok, I think I found the dragons you were talking about earlier for > > device-dax. I completely broke that because as you've already pointed > > out pmd_trans_huge() won't filter out DAX pages. That's fine for FS DAX > > (because the pages are essentially normal pages now anyway), but we > > don't have a PMD equivalent of vm_normal_page() which leads to all sorts > > of issues for DEVDAX. > > What about vm_normal_page() depends on the radix level ? > > Doesn't DEVDAX memory have struct page too? Yes. > > So I will probably have to add something like that unless we only need > > to support large (pmd/pud) mappings of DEVDAX pages on systems with > > CONFIG_ARCH_HAS_PTE_SPECIAL in which case I guess we could just filter > > based on pte_special(). > > pte_special should only be used by memory without a struct page, is > that what DEVDAX is? Right, I don't think pte_special is applicable for any DAX pages.