From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311CBCD128A for ; Thu, 4 Apr 2024 02:33:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B15F6B0088; Wed, 3 Apr 2024 22:33:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 739536B0089; Wed, 3 Apr 2024 22:33:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C0C6B008A; Wed, 3 Apr 2024 22:33:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 37DC56B0088 for ; Wed, 3 Apr 2024 22:33:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B89F480DE7 for ; Thu, 4 Apr 2024 02:33:20 +0000 (UTC) X-FDA: 81970277760.16.2EEDF77 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf12.hostedemail.com (Postfix) with ESMTP id 3FE4E40003 for ; Thu, 4 Apr 2024 02:33:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Oo15LNZl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712197997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fzl1dJJV9/MYbdL2RKGbp/SQeh77AGxxVeSRY0xiE3U=; b=q5vnLl7yhopnXnURTQ+OX7lwPUZSnnMpBvPWiGkJoy2EMFxqv3Gata7FqOwnKRGf3J6c24 rKBcaP/3Rj/L9TMV1mP4XmJouBz3McZlAqNni+GEraWUzLAWBGl4IdvA6MCfu0+Qm5uVwu NGWMNrbF2aQMr4AxcHDrDY1J4GVRrqs= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Oo15LNZl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712197997; a=rsa-sha256; cv=fail; b=soW9P79QCvB4UMnUqIrpi5AeaC0rWVZGLyFJHChuNibvYC9hzjQEHFS8X3KiCUKEk7kHJe +gVUJiCnIWCXuarCiEkHwQUUiWPsywBJcZbEJ1s4TSxt6UQEHxCXwIlMATTA7DVoPwQPXK RMpY6r5OItYYQCiC08xNjsudUbk2Gyc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712197997; x=1743733997; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=qUcIE5d2JnVvMow/U80qtWcfZHcuh2NlkTJDHYBRlFU=; b=Oo15LNZlykQk9DabCN2mMpfPDEE4k3/MqkZOgLB9SgBvMmmVAPdxpif6 V8Kh412/zbJ0V8uwMLUwImHaOpxje0JYhkLb59ejAyT3a/aFJqcB+0kXB Wl5XesleiQ6EyNhgXr9/yhUfbswewFanjY8Uu+qIgiAYHq5q5871mgh19 wM3CgrvKlVWX1ceO88ofOHp+KwqJ3tQP6tt+2Q6AB8/Dzxa/ds5EvPU4L qei9clolrdoHtZoPcnYitv2DSu8lCMhpnkwREh5E2vuxon9zs2G3tMUd+ OW8pvXehifA8XLjm1WnP8++CY/isE8SY0d5oZTZ2p9UxD/baPtcwk9vtC Q==; X-CSE-ConnectionGUID: 0zRK/wBqTXOM06cnFb+PnQ== X-CSE-MsgGUID: snK3o2ciQTuxVtPl9b5C1Q== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="7384282" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="7384282" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 19:33:14 -0700 X-CSE-ConnectionGUID: MGZQWqNkSzyK5FbLnim0ig== X-CSE-MsgGUID: kRtXpjvOTIKDjKu1Xb1jfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="18668499" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Apr 2024 19:33:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 3 Apr 2024 19:33:13 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 3 Apr 2024 19:33:13 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 3 Apr 2024 19:33:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BoVVI63q29cN5xCwKCQejxNZRIPN3TcgBDgG6lUoXNUX41eFOcXo2YKFCwVm0as5zmKHcED1os95IlxfoP8+WCF7ULIcIQpXD6C9OjqosIDRIs+ZfDs16oB5Wh9x3h4zUInBAORedRYt5TSXNOj7s0KFx9GWalNdt+LCp9B+luNVWciE5kMAkoT7qhjAXXPmXg6h7yKuCrSPmMdl84bin8uJGmt2t/6XR/Ha5tSzi7HCXLB/6DFptuoi9zHSEgLokt3CDtNbfHhpYtwc454LijqXTEE6Drt2Aji/6J5Txg1jIzzShXC+ZMBiU21aNX/OW3BWxSygHKNb0ZJ4y+FvZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fzl1dJJV9/MYbdL2RKGbp/SQeh77AGxxVeSRY0xiE3U=; b=Yh8YpgrnW+wrEgRe/YiaHZUSkwGNK6h4wSnE67La//EEtvPzfZw05kclAqyhs72ElBnoRf0AMpNyRwIK4+Axcf9kovnft3FcC/eEqeaVVVXOii4Q+gRoiMzkh21YPneCJW9dGlhZ9gasw+i70PrLNQLO/zMFB/kesRcZoy2DR7TBpYwJs4ybqwchBlcB92//OaFgjusFAAvEJe2kM2V73FpHJ5HU1hWYNPr2xpGmAqf1Y1fwFZ/0WR0mKL6B5fuosYS7esh+rfatiy78Wv5eKczJSkJYPqpA4SMqtUnvNiQOdwuQ0KPkSlwX0lovIyJjQ3GzA62mT18lhSTaTvvArA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by DS7PR11MB7737.namprd11.prod.outlook.com (2603:10b6:8:e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Thu, 4 Apr 2024 02:33:06 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71%4]) with mapi id 15.20.7409.031; Thu, 4 Apr 2024 02:33:06 +0000 Date: Wed, 3 Apr 2024 19:33:04 -0700 From: Dan Williams To: Vishal Verma , Dan Williams , Dave Jiang , "Alison Schofield" , Andrew Morton CC: , , , , Vishal Verma Subject: Re: [PATCH] dax/bus.c: replace WARN_ON_ONCE() with lockdep asserts Message-ID: <660e116027bf6_24596294ba@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240402-vv-dax_abi_fixes-v1-1-c3e0fdbafba5@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240402-vv-dax_abi_fixes-v1-1-c3e0fdbafba5@intel.com> X-ClientProxiedBy: MW2PR16CA0070.namprd16.prod.outlook.com (2603:10b6:907:1::47) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|DS7PR11MB7737:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pvkMIjXygfHCzPOi4i8ib9M2hLrKT9RT02N3OhA34v4qVCirse0b8h5rtCIRHbJNTTOMoJFZNhoxzCitApqjqXW8R9DDvnZYv6viSSvh5tOKh0g/52JqDjzw0jzquGYMWmMo4UtDwsT5IeI16Fk7f/rySF/lokqfowGgIjwdOCNRTRDMV8wXmS0qU7juFNl4mn20WZYg9KUvqpsCDwzMRMyCzFr8/MLI0VxrOBiZEuiZU0OifHhjSkTjaHWkrEYqxFbjjbEujWlajIGEfptY1m59FextuwPrly2pgpi7T1BX+7TtWCVWH2Ypl5CH14eTArYvMzMPVWpqaaI24G2F/ygbN6MVf+onEOv1vzdAfBbgPEpdqyb4u2DvO5y6AHv1ddxODZj77OtVM9pJfdcjSWZ68Dj+fKCqjUKB89nB+5QFsJzGWaCIfAYtPiRqxa4GvucQEBr3ltbXWgt9CUr4Shj1Zm9vsbG+SxQoycvyQm7fGm8RqEezht2ICez9onw/LZudNx0SNHuiBwvjm2w6y0IJ7EGMIkvEzYa8FbGOlLAtCBaH6Lo12HuSnsJl1ISy0A38F9UZ5+yr+OMTdH4rcrMZTOU3ZTdWYp7lwnREXKY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HVgr02F+itSUfqlvh/z8q/MinH54dxtPHkZVBbhvgCLR24Fp4qQUnEUNfkO7?= =?us-ascii?Q?PWIaOuRHkkJwBUYRG+xZv4daQfak9IYQMSj+Hv/ihawvBMlUb/pLRnnWC3xg?= =?us-ascii?Q?6CuixuyO7VGBU6AgiGXTycy1atilK2YXcZMFBEM5VYPBvqIzJjs1771NLwQ6?= =?us-ascii?Q?NzuRE0C5ccZZADKILeVLEAkKyEfum+z21qPIP0NR1l7qbkloySinxe6hxy5F?= =?us-ascii?Q?S2CuZ0HJSfhYJ1gxmiX05EouaBNwPOdzP1vsSTxyMgndFAXEF6nUT6vcCDKL?= =?us-ascii?Q?Sj0ETtOUgmlFzBdfkElB33hUJEYMB9a0ZczvlIpMoVTJC3PNNhlr70bWS6z0?= =?us-ascii?Q?gEhKyNqLRYAHLEBnu7xyvLwtKze2An9Q2Je1YaaffWOTfxfrPhaMzGGKdBAC?= =?us-ascii?Q?y7Ydv6aVx7p52ZkoG4d3bkdHgdh8OgFiWxNrC0NuLNJ2BS92aAXy166BHAHs?= =?us-ascii?Q?68m2b+U3p9QtjuaSf+JdyFwjFb5qJ/tieKDdwIEO09o9vmyxMfqcVOXfzSTf?= =?us-ascii?Q?PCf6OI6DGeMFLOvSPaxmpY2/KgImXqkpIYf53jwHK4aDwn8sXTyC/oNfT+5e?= =?us-ascii?Q?MjgL4Vd5j3NKI8PtxfQVssNzPSJWfQGFA3gFdUTAhkjUp7BSalsST5RefkyS?= =?us-ascii?Q?0Zjzr9P6ZKekS6nZHuEOilqLvQQlwWInMfgdaRWKXEFLlHhQohm7GocDkek3?= =?us-ascii?Q?uaAi0P3GapLy6V0nKh17/JsOriyK/ToCgssrzjoh5b4lppUBRUVnBAKJfJZO?= =?us-ascii?Q?Z6hbZxxKernVBbPDgrPUZveQ7tolZLVODH9rZNm22BzZ1bFWuIOzSWp2N+dT?= =?us-ascii?Q?7RU9xASOW7cvBrkES29rNgwP3MRvW36RK+ZtFVzitL5Jgc1WmxTIELC+VOvK?= =?us-ascii?Q?EGa9bdJBeFdHOY2vG+rJutvEmqxQvCm0wJg/12ANmClhfV597X+ZsIgygB56?= =?us-ascii?Q?Rgrxi8YGXuEdL77rRYznUdV8HkXec/lRJZmYYnu7YMwX4MedjSWdHKdBgAz2?= =?us-ascii?Q?IrTUiI1qFesBagVwsPE+iW8wmGcRzvZ76KolqYIS6842eXu4seVYluL41Xon?= =?us-ascii?Q?hOqm69w4i4W0t59djcy5lhhJA3qCmt8Yl1leV3CCxtUPU4HK09/dH5jhyHaX?= =?us-ascii?Q?CzvgrgVkqu3g0JQMUZbeud+ygxLGDKZRV1xN1+O9VtxEbTnmd95ihsXRlvGF?= =?us-ascii?Q?ucbgdJsWtBewISHNYaFtQ7Wo0cBSkYwzSoY/OtjdPC5ZpJVAf2W29WnC3v/V?= =?us-ascii?Q?Nk1jmdc+6sZuiBUWLmb8U1knIIMeVVxvUjGO5RSvCADczRWwzJlS+NXaDHWg?= =?us-ascii?Q?VmpSN9BYfxSA82mdHGpnKaNBzmLdwiW8MoqOuUcKqEpwoyjkXL5et7hfqpgX?= =?us-ascii?Q?Utn/IRmF9SauUacw/wZ5J+5PYJL6z4is/CY5KGatUykZPd4ZT2L5g+55RZHZ?= =?us-ascii?Q?H7DlDuAkU6WIoyfD7S1Uq0IvZ+UUhRezwyjnkSpmq+CJ35g/c8Wfa3OQ8Umc?= =?us-ascii?Q?d+kdsjE6c6s/l4FbnekJytW1NkRhBUfnH/ZuB+5Dx4hEm5BzJiEg4NLdFpx/?= =?us-ascii?Q?NAZCswncOg3SRdYnAkk/xPuvm84e9BK/ZrfZK27V0p3F1QkMQ3GH3Zxqwj1J?= =?us-ascii?Q?ZA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ac027ca-81af-4b26-162b-08dc544f8f72 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 02:33:06.6859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nWmJJspzewh1K6qZX5eQ5HO3UihY7Y2K+NK8/BFaHb2+uiMflJwQcOQXllQJ714lPvMyFa1FbIjArnf5JuBvcvIpKMAzfOKuDpAoiz9wlw0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7737 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 3FE4E40003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jkokb6zicnxspgt65zfqnq7ckhrsoa38 X-HE-Tag: 1712197995-82196 X-HE-Meta: U2FsdGVkX19qZVun13OQh52Ou5Gbll0PPy7fsyEOF+bU/VfN8ITKtKSqZEPeUdTyJygqfYoqskCQgTSxUkl7PGJG84ST38xpGrdVp7g7N1tg3CIBmBmbkJJgdy3wFi4qRuzTquXtIpsS570v77/AzlcNEVAUBtOxfJ7fd+82ZWtnNbX6pCcqKUC++4KFeVC0G7/DLficnde8Tw2YM6pkrmtOlW8Sgy3xYDot7pJn2uc+A1kzbdPiTjAtpcBPRsjuTaV3AOYR98hcePTFfqhcRyo7DecwKKTvVZ7FaiXqCLp6ezk0DTBXrHUabsyoLFHrqZFLVk6lh0j46jcLTeig9rimUGGo3QYZj7mZSq4iFk2AJ6P+20C4t49mhh7EqZ5K9QyMcN8zh2j2oF4o6SmkgLDTa1oTK4XEsIg2kbynRYGQ2FyxHPYm5ZIF69swSYYai9d/3U+XB5bckzbkdkpjtWkA1UvINEedilnx/Utx7BH30zb6THlTvCQme6K9MCS1vf5uR97ywmcwFZPRz3Mh/BcW3d7D5sanJIKpl+N81k8p8Jz5IPKYhYltPsIPwCUAsCdAtbaThz8ufWYXSKbGL48LKworIYm8MojMiigdbqGb46kqBmE5Tc+iDP6Z0vUuCIJZ7nJ18MuPtNdhjf5L1UjGCyB7iwkhTAHRdfH4fSr3fioaFIwCxW+tlxUXu4Wd8CTjCY2QbXJzNSkeooP1L0d3jytMCXNDKxi/TlI9lY3Y86CqobqsooMBPIHFXl0KJUcDR1IbOLN06tPoGvs1ugsf0YtaxjfkmlyOH1OeObbWw5fOUxmOL8Mz4gv+u/R94MX6+UDz8ez1yQWW+U/+wKDwWjD6/fQPnIUnWrLT/nBK/olIZmZ46wZhttkUi6ViYFmzPonEP0G+6X2VXpfb1hpl1ykuOhefcf7EbOWw8VcvfGHL/6nMDWbtEResPwBQ7kDRlxshJZgLTvurLxM x4PisOp5 A52TbShRcdsM/We6ZQT8hAEu1qFUZ3Lp4PaRbmEn+U2mFFv5LcUYPaP4OYGBmxrC+6WOCzLEmZ7QvE82VjmAe2W4HpspZWyipVZ6H08PC3IHpJkCN8BS71cSOwCfJaeE+7Sh0NTQfpWAVZ/MEYU0NYdDGAlBPiJjLQgRyMW/+Nc5hyO3n3uNLXOIhOeGILiTyYd23NJj8hI1qeosmUEtGks1LYVoC80ON/aCFUKzg7u6rhnEn9/uDTdXrHx91G0vM0J5oWWxd6G7D2Nd9v1HC5kQZF7SJQGk7wMMmYMLhqHc0sjHsSn3+6V/zGiSgm9TSwjPgT6u7JC3hy1kboEN4Mewe2vmQB9OMni1H4hhI/rjMy5WXuPfSfLf1FGdf4Iz0dyQr9aVgU+UA73Y6fYbyOJhpDCJTNAa95S68affqdOa+XCk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Vishal Verma wrote: > In [1], Dan points out that all of the WARN_ON_ONCE() usage in the > referenced patch should be replaced with lockdep_assert_held(_write)(). > > Replace those, and additionally, replace a couple of other > WARN_ON_ONCE() introduced in the same patch for actual failure > cases (i.e. when acquiring a semaphore fails in a remove / unregister > path) with dev_WARN_ONCE() as is the precedent here. /me goes to look why failures are warned vs bubbling up the error... > > Recall that previously, unregistration paths was implicitly protected by > overloading the device lock, which the patch in [1] sought to remove. > This meant adding a semaphore acquisition in these unregistration paths. > Since that can fail, and it doesn't make sense to return errors from > these paths, retain the two instances of (now) dev_WARN_ONCE(). > > Link: https://lore.kernel.org/r/65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch [1] > Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem") > Cc: Andrew Morton > Reported-by: Dan Williams > Signed-off-by: Vishal Verma > --- > drivers/dax/bus.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index 797e1ebff299..d89c8c3b62f7 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c [..] > @@ -726,7 +728,8 @@ static void unregister_dax_mapping(void *data) ...and realizes that is hunk is confused. > if (rwsem_is_locked(&dax_region_rwsem)) > return __unregister_dax_mapping(data); This is bug. Either it is safe to call this without the lock held, or it must be safe to always acquire the lock. Anything else means the caller needs to be refactored. Conditional locking is an indicator of a deeper problem with code organization. Yes, this was not part of the fixup, but the changelog led me here because no WARNs should remain at the end of this effort. I think the confusion results from replace *all* device_lock() when some device_lock() is still needed. > - if (WARN_ON_ONCE(down_write_killable(&dax_region_rwsem) != 0)) > + if (dev_WARN_ONCE(data, down_write_killable(&dax_region_rwsem) != 0, > + "unable to acquire region rwsem\n")) In a context like this that cannot return an error directly to the user process making the request, like in a sysfs operation handler, then the locking cannot worry about signals. This would become an uncoditional down_write() lock. So down_write_killable() is typically for request contexts where there is a user process waiting for a result. For contexts like async driver probing where we might be in a kernel thread, and definitely in functions that return 'void', it is a bug to use fallible locks.