From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528D7C43334 for ; Tue, 14 Jun 2022 18:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC3836B0071; Tue, 14 Jun 2022 14:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C72CB6B0072; Tue, 14 Jun 2022 14:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3B376B0073; Tue, 14 Jun 2022 14:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A4F496B0071 for ; Tue, 14 Jun 2022 14:32:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7BF1560F4F for ; Tue, 14 Jun 2022 18:32:06 +0000 (UTC) X-FDA: 79577685852.04.C12A785 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf24.hostedemail.com (Postfix) with ESMTP id 7411318008C for ; Tue, 14 Jun 2022 18:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655231525; x=1686767525; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wi8ayFRbx9Ksq00eyCq1dWkx7m9yxMHGCIRouwUtegg=; b=QffsIfBXhMLDx78/HORzR4xG/RKk/b+8SvlB4HRjCoQ6DdC49bSqv9XY ijZILTUe8v/j0mdrHsMKC41UdUK3bmss4r4OMcfJRR3mYhcJJBQtfsEc2 fs2yTbTrq8fOufRdxK28neeFlx2J+iaEleB8AdsvaD6CSfi77jPK66fr6 gHEkzR0EWAfXfbvvOQbwFFz3Hlf0bQu3dj2EL8qzZWoGmrCJ2O6JbzI03 etf6hiUVKUcF0/l2vk++Vl3fYzK3MOV8wb0l2LfbqaEELU1F7sVoW5AZa Yk9T6vgGgGtCVnd6u07xBkSxolmozenN95yG5si/d8DgDkzyf0+01gUHO A==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="279423652" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="279423652" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 11:31:53 -0700 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="686819827" Received: from ijdsacor-mobl.amr.corp.intel.com (HELO [10.212.201.22]) ([10.212.201.22]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 11:31:49 -0700 Message-ID: <660a5c93-e8cb-1c2f-5b27-c5e341de0bcd@intel.com> Date: Tue, 14 Jun 2022 11:31:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC 1/2] x86/mm/cpa: always fail when user address is passed Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Dan Williams , Paolo Bonzini , Jane Chu , "Aneesh Kumar K . V" , Sean Christopherson , Tianyu Lan , Mike Rapoport , Rick Edgecombe , linux-mm@kvack.org Cc: Borislav Petkov , x86@kernel.org References: <20220614063933.13030-1-42.hyeyoo@gmail.com> <20220614063933.13030-2-42.hyeyoo@gmail.com> From: Dave Hansen In-Reply-To: <20220614063933.13030-2-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655231525; a=rsa-sha256; cv=none; b=zxx3hZM2w0RaAyk10xsAGfMyFNP9T4nchqX0aa2AX3nVknJtS3ggRtBSrNxNE2JaTWWNVs laRpA6qH6m4i8FQIcDY5LJZ+P7kifyDWIdRvJW3U+5Jx0gVC7cdVw55NLcQcnATnWNPQu1 0KTl7txKS9DaiZ4dCipWJ//iGTgxQSs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QffsIfBX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655231525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3i+2JHktOXX5I0KeIv+ro7KeMfjxynaCxiHGb9PSops=; b=FK6A4Eiw9GeogagYvycTCbpOEdld/aOehv85gFnyBrp1k/pbnPMpRwnMDkZMnKUGqwe6eb ASJuQSwav6cEhiR3XXXL0tRdLOCUBDGt8z+XKyYFa5jMI8YwEFkfN2NVWXHjd0hQ3/n9vZ MawpjK1bckkpIzfzxsG1xIh2/EYL7K0= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7411318008C X-Stat-Signature: kcz54tdtuirkr944ma451wuifthpdg4w Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QffsIfBX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=dave.hansen@intel.com X-Rspam-User: X-HE-Tag: 1655231525-328988 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/13/22 23:39, Hyeonggon Yoo wrote: > @@ -1514,6 +1515,11 @@ static int __change_page_attr(struct cpa_data *cpa, int primary) > pte_t *kpte, old_pte; > > address = __cpa_addr(cpa, cpa->curpage); > + > + if (WARN((IS_ENABLED(CONFIG_EFI) ? cpa->pgd != efi_mm.pgd : true) > + && address <= TASK_SIZE_MAX, > + KERN_WARNING "CPA: Got a user address")) > + return -EINVAL; I was expecting this to actually go after _PAGE_USER, not necessarily userspace addresses themselves. What does and should happen with the VDSO, for instance? It's a _PAGE_USER mapping, but it's >TASK_SIZE. Should set_page_attr() work on it?