From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674C3C54E64 for ; Mon, 25 Mar 2024 19:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1536B0088; Mon, 25 Mar 2024 15:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7AE06B0089; Mon, 25 Mar 2024 15:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCCE96B008A; Mon, 25 Mar 2024 15:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B69D76B0088 for ; Mon, 25 Mar 2024 15:01:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7A00B1C0414 for ; Mon, 25 Mar 2024 19:01:01 +0000 (UTC) X-FDA: 81936478722.23.257336A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf03.hostedemail.com (Postfix) with ESMTP id E45AF2002B for ; Mon, 25 Mar 2024 19:00:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ru5arjOP; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf03.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711393257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FPvXlSTN5p6jBkjXmyT6TWNbMFmRWluz4SX1qAS4cac=; b=VLqpP6g7ZdpfapEQHbeIv76m/DE9OFHJYALBIhhYiHeNK4q4MKwLQNNzYI0ZdzE+qMk+AH O5ym1/fIGHDe8UM2jUVWo1Niu9V7N/hH+2h7RrH4e4/bzPr5F6yyC/wX2HmKidE4e6Q3JB sqSA0X2L2pWFxxNMXIJ8YKQsBuq3J0w= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ru5arjOP; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf03.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711393257; a=rsa-sha256; cv=fail; b=ewRJQ8ABV16Mj16oic3jcLih8StVE6K0fgJo4Z684kT/at/TPhxgZW4M3t4vZAFy+aqK3l fQA32R0mVImKF5/YEIoum6bZrKdPdXioEoniYybXoV2RBY+2BlfZjwMVD/JVJO2jYHx8aP J8jOTcEnsTLt9XmUfipUpK9W5FxcK90= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711393257; x=1742929257; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mgB6BCBU9aayva8OqvM6VVzb2DJoQiQaagYBVf+GcDE=; b=Ru5arjOPTU79c0iMnPGcY0ocAVxrPMZ0v791FkhPnZvnkn9M+3jd0AJX H50WrP7utV9enrI83Gg68TQkBvLcgg+jkcNVZhYMDgq5sc/leDSAGuAhf 7Z+p9fmcDuFv8OeTqR0du08tkf1Qo3IQUgJsLhQE6OIKCCavE8ib/lLSF iBFvwceUcFxNUCjlyobu3WwOaObcPue9RuTdW80+O3PDMNJq4B49p0yei hiyDZH9fyKd0S7U/xtvZFv31t9TRpR25NOtWdmIfgN51ZznVVRXLBWkrX a+MJXOEkIiGY5TelKidG/iXyKaqQuoLcHZnEYyZYZu3wkr1sntH48RNKc Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11024"; a="6527064" X-IronPort-AV: E=Sophos;i="6.07,154,1708416000"; d="scan'208";a="6527064" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 12:00:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,154,1708416000"; d="scan'208";a="15607412" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Mar 2024 12:00:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 12:00:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Mar 2024 12:00:54 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Mar 2024 12:00:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpSSMm7PS3kO5TYxrvjQc5s35iF0nmjrkgC3fOf4mM11DFtT15YPSto3rELQgaidcDQMs12V0DK6YabzoAEU43JQ8SYbmKePtW+oQPAi558GzwRltCkWdOwQMJUoYYS9oBPDufoJ3ibxZn13VtHHv3cmV0VtgNEx4x4rR94gQXGs3tkCO84OJwZ2MRj1ac34NVk9wZ/RbAkyWccx10uv+nGOJ59C5GwXQeHYBEktkkA0AEsn9wNsjfannTY+DPoNWyItf0tQvfnUV4ZCHe8Kt+9tTkO4oPu95ZVd8LvLDMA1Cv9yK46P4DiXk1k6+5ul5d7qpOAzkue1IYs3qxmV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FPvXlSTN5p6jBkjXmyT6TWNbMFmRWluz4SX1qAS4cac=; b=WXe/BdVequTzdTgaQyixggGMxZBdP418dYxITHTfUAZ6lOipjuhb7xTxxk0tcdHm0rA7oQw1engEhhge6P6uOzsuEhXnv+UDErC+1fRcaJnkYw44YLiqNUWD0NaYdpdFXagm0UyIi/GFb8J7LjuvCmDY0sp/hfhdojXUpMY8Pl49KxoHZlWgHIG1SV+5yPaI3JHEskrFXPufM4LtGqNWbGpwteBd25aV6jiRkXv37zYAqS1lqCqPhQzSgidoo/lOLWpdKi+NkXd7WG7xEIR3QF7mKRvLTg6kvvrsnku/KgUiGtJcWFQELuX46I6YFnH2cZXTgHZLiekP6mfyOd9g0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by PH0PR11MB4855.namprd11.prod.outlook.com (2603:10b6:510:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 19:00:52 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71%4]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 19:00:52 +0000 Date: Mon, 25 Mar 2024 12:00:49 -0700 From: Dan Williams To: Przemek Kitszel , CC: <42.hyeyoo@gmail.com>, , , , , , , , , , , , Subject: Re: Re [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed allocation macro Message-ID: <6601c9e161df3_2690d294e5@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240315132249.2515468-1-jiri@resnulli.us> <20240321162648.23693-1-przemyslaw.kitszel@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240321162648.23693-1-przemyslaw.kitszel@intel.com> X-ClientProxiedBy: MW4PR04CA0075.namprd04.prod.outlook.com (2603:10b6:303:6b::20) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|PH0PR11MB4855:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NIFQYswMv7DsxqfF9kgnc63uaPm2nmq7KCR1SCnEn/9Qnha0SXIrW/yQN3WabP2XDt4/5AU0GeDAsVDdmq9zKJ1R9zD1PGRQ+pXH4UrrDKLjQBu6dW5CcfSbhKW1J+EQFD93OV2+jmn/U7407+irGPigndbPHeAf8lqOT6WzNTJ7qUypjxPfHnDcSYCx+n2lq2bPntml2I58BsKumUJmP7ueqpVfM2O6jJgId6J0ttMQZlTRn+85HKAprHniRJS0ajJSvNp+wIn0vET2+dDSO/HkehJST5bNea5Zuam5H5xwMr9R9VwbZ1bL+00kTGY14wfanS4PFRhHMc4T/edaTMBwQgWal6ICFlFxBo1dKpaBXxU7ay/19MksxOEILNINiP7H3tYjt0srmc+z+zBH1yp4/IrNAVVfkzMFpLpn5hWVFNUykiwt6Q8pMSPZa4kR9ZyxxErmYVotZzkCLbzNd+GQQkwhRHYBWO6vpd/LsklUM/4op8e1QspQkxavpDuRIvjfoaKJc3TEGVG2ykm5U2h1SClocAYCQamMIrt5MmOSMWwYp+Hbm/TltBZMbzvvWhJp78BTfoPsOCjMH5FgLuClDvqvCJ3R2h/Rtn+uMAE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k32hxxinQV9zeRTir7+hGmmbdQB4VOyC4ZByMl8q9fEz9RUEQwOT+/NrA6s0?= =?us-ascii?Q?ZUaOzQ1HEQIodRegXeo9P6/AMKk/iZMnvCJRic65mTnHceCewMVNAkLaWSt+?= =?us-ascii?Q?oO0pB8vqvvcS6YU9SRso10+AIJCHX7HqBpHwXme2ge0x1xGDEMw2XrPLflyn?= =?us-ascii?Q?cDVkWQIb2rj+4IJ3dbm4zFFbDS8dpPQJuJ5Xs10/GwGVXJNW8MKyFNDeSNxi?= =?us-ascii?Q?QCptwPtV9MDg3do4oFaEQNK3tmTOyyNRsO0nTufusAhSd31E44rhrXajl7pY?= =?us-ascii?Q?MgB9wzz3GF4MKfwrNbYpL7VbUQPt8vPYDJnKHu9FQibIFpCBDZpFokwVgKV6?= =?us-ascii?Q?vS5X2SER0nYMzw767OFy/GZhDjvtNfGW3X+Uvx27hj5DLpFsnwzHEzyD4u8n?= =?us-ascii?Q?GTtQN07cTdiCfMZnchbmEUe/Yu0iPN0FGpD0s+zftW81xJE4yv3qFW+2TFMj?= =?us-ascii?Q?mHOIpHoRqAfDiDIVeYWM1pZayMr4iq/dEUaXbP0fwONlhlnKxKdYNlGTOoC8?= =?us-ascii?Q?FTFdkLeOurBcMrR7/sgQXyZJPkYHR1MrTzwqhWSUXNAMenG7d4d27vgBLWRO?= =?us-ascii?Q?Qe8H9WGMpoAbRhXdr+TIp6mDnjt0OVozjmZ59xpysnN+Rq4JVIugHSncP0a8?= =?us-ascii?Q?kyhC/8cT3CBsDOR5oGgalnyzHfhYlmRyG7o0ExgcLWWhgeoxpmp/N/fuzK8g?= =?us-ascii?Q?B4laat3xWPZ+a3q6aTAnyTFe2gWd4bDLft6DsqgvZ6/L2pd4m9ezhHRjKuR0?= =?us-ascii?Q?RBxRpY3G9ztc5vY774ltPkgucX01sOgbV9EbNC9VMbkLo7650qse14IjIVxJ?= =?us-ascii?Q?p3s264Bl09BiPJIju0iZZWs22DGI1sXDKNZMBHgbPljHrgAfIXngCrFsXbRU?= =?us-ascii?Q?q+P/UaUoXAsczJe5QlkD+46OGEIJITJQTGMODnU1M4EyrepwB/+o/WqZeOKz?= =?us-ascii?Q?3D994P9myVwuIjZArI8Qox1hvNjB0oA77bDby4SrwhmTfg88/UQ7XXd956DN?= =?us-ascii?Q?ViXUFwzf54gZXxP+sy5NrTgMsKEE/U5c+Vv/0fnrHizcC0gfFiSncKUcUhb7?= =?us-ascii?Q?ZDV5du5fSxKgY7tP0iZhCFUtc2bDkULY4nMnqvdBGpa9brsxXEcXx8Um4RO4?= =?us-ascii?Q?52T4iLct6R9ODT8lQvhYnl0Q0q1f9X1l/75Ws4te66i7z0iKpJ6309xebHHF?= =?us-ascii?Q?/8s9UbtysDpavz22P4Jb/yJYspAxOw6OsOdBGThPKVylUAHPSMjBi0Juu1Hq?= =?us-ascii?Q?Pb7MQtyAbh5lgd/HcCxQnRJsWMDLDzA/OsshQRgTqNLz7ZVZDTD4Jai/8vaD?= =?us-ascii?Q?PhWYJo7xy24c2BhoKcz2pz3yZKjPT6GJpv7NLOy5nxCwG3F2SlDv+1VmQYPe?= =?us-ascii?Q?pCly3mtmxo3PnXEGFQeRV64BeZZ5Oe7fq7fKwKhaIFiBHowqmMaRHD25yS61?= =?us-ascii?Q?oIkNlcmvM+JSbHdDLBrfkHz+ZqfRxPqLJuUasGMzb5FKVcNyhLSzq5xzSSS6?= =?us-ascii?Q?Igczb9GikyKbjbRlWvSY5yVsbt9kfP/7lWefDmrMvAYmKlMh+M8Aq27YOgqJ?= =?us-ascii?Q?jNLMqc/KW4iQWR/w8oQ/f+UsqIT3deRkdf2Kh6FFTjFf6mSS4GTu00a6Buqt?= =?us-ascii?Q?ew=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5620f0be-a4ba-4e62-d08a-08dc4cfde451 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 19:00:52.2263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lBhSXWuYEp75K2vNchKgyu9y9nKndrtD5xqHfYyig+LU+IIvkXkq7F8/5fqAACLARkkyCLKcum8V8kEOLgmkJMtMkSdwW9vRfLb5Q1VX5m8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4855 X-OriginatorOrg: intel.com X-Rspam-User: X-Stat-Signature: uwymcjmgmysjw5nu8eanp1jshz3jmji1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E45AF2002B X-HE-Tag: 1711393256-296341 X-HE-Meta: U2FsdGVkX195ZQJVdZgFTYsCZ0iHUWoybCQ3GaTxeufc+yhDlorTc9a6/Va9TpuMCgLn6zj8nXzgd3gTeVVab62u7hH0yaDJvfDoPFKLOM8UgqXtO3aty1esG8mQ9hWCGxLOlLb0QBPPHus+kvQyQLzLXDBefaHwTK32zF5z8L39Bu4D/cJJVblil+MCBFkx2fXKNgj7aUlzuSYMifcli5IgOz0+KlayMby/X1M7kTGfrsTyWtmJy026qagJOm4Ey1AhD1dCUcozZtMxMz0yXvyC2/fAbMSp8aymB1S+QOK2tDn35ixJfl32sQumQnj3hWEuNF1Cj7Jn0coYyZ5f7LCoNg5Qrmj4qlxZB2/NUuBSpyeltg70KDN9QxIp2CiSvDfGUrCb+GWc5MmXtCBcujYRmBU4PafJyAEyMoC9QsIvItOGTAXV4sNWj44WELDjfgGvzbYEmqqCJt8IHddFPCWkpLUQYM+ORPJWxfFF8zJRBppAQFx4EyTPI9n6Wfrs4x1EERI+6IK44wKz/7rbADfGN9ckXEco9rBkTqozcn56TBwH2mMa0lCjAE/uchSnyRxNp7e8uX7l1yNmeR4BGW3TiYPo87J6lFh29SpSYw3o6pTOxU0fp+mhQnX3r+68ki9xOhtJPGL3cVaCyE4Z8rk58BC569grev+mzE0PUrDYtHg8rydtOIuOqv//k7pH1BKN/CYeEsxpMzH4IZWydPRyXmsFZde4MSxgpAw/+1Kp6iWpAdiiwYiWMuDdpyadqFlJpLtjLs6jUGNhhJDAxHSBD8l6Z4peT5UHxI2afKFslQ9bxLRswjJ7ioRYJYHn/3J+iA5I37VLQCQATbjE0vFlOdCwuyDMZVOt3sImikYL3hsP+Nn+i0atf2SxSJkkp2NnmPrCYQ72qfjaOW2dVDjnnzQcMsZ7qqsGJO/qMyQsONDgC96p4RCGW9xQW+9XvWABaCL99TXDDqg6n4k tJOR+p7w y0joHOAYq1qjT0fIv2ck8hb4y7Z1BAzz+zVmL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Przemek Kitszel wrote: > > From: Jiri Pirko > > > > With introduction of __free() macro using cleanup infrastructure, it > > will very likely become quite common to see following pattern: > > type *var __free(kfree) = kzalloc(sizeof(*var), GFP_KERNEL); > > > > To follow the CLASS() flow from cleanup.h, introduce a simple macro > > KZALLOC_FREE() to wrap this over and allow the same flow. > > > > Show an example usage in gpio-sim driver. > > > > Signed-off-by: Jiri Pirko > > --- > > drivers/gpio/gpio-sim.c | 3 +-- > > include/linux/slab.h | 3 +++ > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c > > index c4106e37e6db..997237b3d80c 100644 > > --- a/drivers/gpio/gpio-sim.c > > +++ b/drivers/gpio/gpio-sim.c > > @@ -1496,8 +1496,7 @@ gpio_sim_config_make_device_group(struct config_group *group, const char *name) > > { > > int id; > > > > - struct gpio_sim_device *dev __free(kfree) = kzalloc(sizeof(*dev), > > - GFP_KERNEL); > > + KZALLOC_FREE(struct gpio_sim_device *, dev, GFP_KERNEL); > > if (!dev) > > return ERR_PTR(-ENOMEM); > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index b5f5ee8308d0..baee6acd58d3 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -711,6 +711,9 @@ static inline __alloc_size(1) void *kzalloc(size_t size, gfp_t flags) > > return kmalloc(size, flags | __GFP_ZERO); > > } > > > > +#define KZALLOC_FREE(_type, var, _gfp_t) \ > > + _type var __free(kfree) = kzalloc(sizeof(*var), _gfp_t) > > + > > Nice, but I would rather see this wrapper in the cleanup.h file, that have all > of the rest of related stuff. > > On top of that, I want to propose also a wrapper that is simpler in that it > does not allocate but just assigns null, with that in mind `_FREE` part of your > proposed name does not sound right. No, do not hide assignments within macros http://lore.kernel.org/r/CAHk-=whYxkfLVtBW_B-PgNqhKOAThTbfoH5CxtOTkwOB6VOt6w@mail.gmail.com I.e. the amount of incremenal cleverness that include/linux/cleanup.h will tolerate is low. Any helper should look like typical C.