From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EA1C87FC9 for ; Tue, 29 Jul 2025 13:45:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400096B008A; Tue, 29 Jul 2025 09:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B0EE6B008C; Tue, 29 Jul 2025 09:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 278886B0092; Tue, 29 Jul 2025 09:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 172D66B008A for ; Tue, 29 Jul 2025 09:45:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B3A81340EC for ; Tue, 29 Jul 2025 13:45:30 +0000 (UTC) X-FDA: 83717424420.30.F9D32D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 2B9C5100002 for ; Tue, 29 Jul 2025 13:45:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrlvDl9m; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753796728; a=rsa-sha256; cv=none; b=gWJ9d5tCUjt1OzSLx1vZdzm88P2xA5LCKBg4pcXT6xv40KtQXg8wKryRPo6AYFsvCGPLe2 /OVH82Z8gLvw8QU6uetvY+JxK5eHjYavnY159oup3XJ/rQPc+UoETIsFRS8Bli8LH32AOE aYw1IsCDyJ/EDWUhr4wJJ6Ka+/MBzqI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrlvDl9m; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753796728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snLcLONdi0upi5CF0jgStE2Ip17xSpNY+k3DJ56V7T4=; b=7iwh+dTtI5ZjTeg4NWdhgqrTI+w5lYUUMO+rMmSAD/v69bT5mRQt25c4yKvdGvKnK3ZRof +0CufR5ZsLfBHbIETLQHyf+9/JfJHhSkhLQ8/sg9/jBo3l+9c/Ul60jR2qBxnZC8cTp+rE j/kpAMyN66cWz+7r9aI30omc6F4H/kU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753796727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=snLcLONdi0upi5CF0jgStE2Ip17xSpNY+k3DJ56V7T4=; b=OrlvDl9mmc6f/dzFLeHfsrd1mjlD808LWl3tQ67H65/KuuDWBpxmtLL89000Nvy/jKs6Os nM3yZ+OSFCVvSjhSf8mcNM7nGsjOi2FV3kxBkB9nCas0jYHotxyRi64XRQkpHhocApsbK6 C/rUkqynoAzPrDASzQ7CHcXp/CkSgdQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-0M-tTfMgNN2Hl2QH0Lre1Q-1; Tue, 29 Jul 2025 09:45:22 -0400 X-MC-Unique: 0M-tTfMgNN2Hl2QH0Lre1Q-1 X-Mimecast-MFC-AGG-ID: 0M-tTfMgNN2Hl2QH0Lre1Q_1753796721 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d30992bcso33877065e9.2 for ; Tue, 29 Jul 2025 06:45:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753796721; x=1754401521; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=snLcLONdi0upi5CF0jgStE2Ip17xSpNY+k3DJ56V7T4=; b=xPQBeWKpeniXjlUlNjNXoDDT06Hw2TlSIqVQpQ8oK84A7pJbVtrasLfED2GYkM3LBZ 4G5lA8hXKeImEXxKnoD/lPhVIyM3wctx8Bvxf6eBq+o/sgvhkVMhVw1vhmaB/3vE5kvs w7YMfk4mgcHqIKsUs4PazoLLGz8+p44V94grmuOFBq7evtTx4Xr2NDPKl/RA4M8GRCKQ zneHgyOXJtDDuihR1RHSPxWogl0Cj6yK/hS6z7GbtVfHiPbPgrQIpWZqgo3XNKxNXZ3F XkTC7uET3ZsXT71qmUQCLeuC9XVZxmiu9Y1RQcmlxsqr7jFCSLsF6pcwAt5WlUmBnK2U uiVA== X-Forwarded-Encrypted: i=1; AJvYcCUJtzm9qXaMKcOAoNKtV45sv+0WmzpVxdyzB1+4Mgt9s5KOEAvSLu9+1gN+uToWXMUEl9FAzgMZQg==@kvack.org X-Gm-Message-State: AOJu0YwhQBOoPiQktkJ6uYjDJbE2XpnZC7UwIc3+Ga/oIqafNHom1v3J N4MiZv/vkCof6FDvotgc/5kur11J6zeuDXzfr3jqLJicuHENfRRqiLK8M2tSB0F/UAnQAWM8u1j Hbyi/qC0grUr46BHmm0+/VQEeauFRRSjWV7AbTdckaN1ZRmiWNE+G X-Gm-Gg: ASbGnct645VxG31r0/cUplKQgRkLiNWePqLh9csmGhh+PaIYjiXPQ6BL9H7z6WmXxwq KwnjM1okzFsv3X3kf42ycUKdeleWb/t/D0AtppadeWg/PGLX2UaKq97AAub6FIxlnpIgTLMnjO6 /cTvawjtImrIkey0FGXT+04r1Q6NLh4jS9/UsElYlEpSfQ2NuFKOMK+82q1eXWgekGZfZ5J7WPl c2zAWNuWrAJHiVHFZ2FDKdji0scerhYQ19qDwCHVAzIq5YdkAldjwcMrzbOxij88prBrv4jepW0 LgEK6QIGCv5J6m8DYtd/i5YJt9xXokZ4X2/DCkwAehOP13Kpz+vL/TomWE/4ILu2g3Jx5wMV X-Received: by 2002:a05:600c:1911:b0:456:1204:e7e6 with SMTP id 5b1f17b1804b1-4587bdf5b22mr90789565e9.11.1753796720932; Tue, 29 Jul 2025 06:45:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5wUcahpAHtevk+2TYP7Lul+w0qfC1wUVnwzKy3IbVbmkxmaqURJFORcVMZCT/hAO72QUIJA== X-Received: by 2002:a05:600c:1911:b0:456:1204:e7e6 with SMTP id 5b1f17b1804b1-4587bdf5b22mr90789345e9.11.1753796720489; Tue, 29 Jul 2025 06:45:20 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4587054f338sm192950705e9.13.2025.07.29.06.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jul 2025 06:45:19 -0700 (PDT) Message-ID: <65f5081b-f493-465f-9198-8a16c9b69ff1@redhat.com> Date: Tue, 29 Jul 2025 15:45:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: correct type for vmalloc vm_flags fields To: Lorenzo Stoakes , Andrew Morton Cc: Mike Rapoport , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Harry Yoo , Uladzislau Rezki References: <20250729114906.55347-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: buxUQpLxTfomQR-7m4IEYxTWWUSDpr3_KmizB6n_CDQ_1753796721 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2B9C5100002 X-Stat-Signature: yesihgxunng5qwihwrwwyoksx3bjemeb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1753796727-825592 X-HE-Meta: U2FsdGVkX18gadKV7WhVccu1ODSrkodKidQ4OqPFLFJisYc2DlwbYR0D8SOzzz93KgLYfzgkZPD4GWdddEBBFENmrmOAJJju967X2evpowXN4m/2J4RrxWLCGKXgKQFwF6zGH/lBGHUwSxZEilFAXOl/8cN1UpiI5VH43Jy59O3lberORrsojjw0UBhfMtGt0wldG2zxuYrniXvxK8BXE12n4Fehof9QPvtP0DksYam2nqTP6KXvKRUlg759WilJREqi6RfKIRufWvHKSFnezgDyjm/Wkmr0T96B7mfgzQExsStyenSoiRk1tnQ0SSax+CfgcA++5KjgYEERXiwLq3dgcqsVKRplYw/x0O+pbL5gqNa/ua4L+7XDSNZrPt6Z6Ce+tp0C55DfNv85KbzdAYdloF3rpVOuIw7m55ytZpK1Ng9+0m+iw2jJzgrz2vc5AXPm100gR5oa6G9926JDTBYwdrR1/+Hn5Qh9L3o3o4G+PxkjEywMZ137GTiqF+YFraQr1zu4qIeejOWgWdVnZmsMJ/BI0fFkZIUvlSvo0AwU/nkKuUV754pfw4xrEV9zEwRF5c+0R15+i2CQmL44GtJgSyUCxANXlluW6vr9APVUXsP4bqMsXMY6YZs7VOYqvGmD+XwXOLJSnVE0u7+Mg9izRuTjne5UdMFOu/0CwaE54QVEyXPjp5znb7JIlnLIqCzLoSOdOJo7rhPRJI5gpfuviO/RI3WWmWE2rLeR132ulmE32Thfj3rKX9PO0KxnvQYejlI7ngrSm+/+tExOO/R1lh/FDYjL5cYhm0dDCo7gwpxejo4jR2vseSsZzpuvkNUfr2oexrkUITjkXnqo3Pnx1aW0YLmhuHrvDai87WDjOs7X/3ifLBPO+fhYPTBVubEv5Z1VIoE5SG05hc5hVVQFoUgxlCKLlBp6MQc+6J3BDYaqx4z3Tp51q66hJ4+Asq+hFAYYD2n+NWxfOVv ik8fQfZj 83YcldCW5HOBn0PL4oMRuo2Jvn1CLDiv9T+YBf+Ho0cthLtnBlvldqTOtN6odtGPV9Da68mwGmACkWZHKVV0rUpyntCAqS20a2FEtZcmHo5Z1Oa/xFO3Cr/rBAn7YZ+ebisx6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.07.25 14:54, Lorenzo Stoakes wrote: > Hi Andrew, > > Please apply the below to this series. > > Again to re-emphasise, there's no _actual_ issue here (using a typedef for > unsigned long vs unsigned long), it's just fixing up things in preparation > for later changes where this will matter. > > Thanks, > Lorenzo > > ----8<---- > From 94ccb0c9e49bf3f9a5a31e2f1da4a722b0a2de50 Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Tue, 29 Jul 2025 13:48:50 +0100 > Subject: [PATCH] mm: fixup very disguised vmalloc flags parameter > > The declare_vma() function in arm64 arch code liberally mixes the concepts > of VMAs and near-identically named vmalloc data structures, so I > accidentally changed the 'vm_flags' field' that is assigned to a 'vma' > thinking it was... the vm_flags field of a vma, which it turns out, it > isn't. > > Revert the type from vm_flags_t to unsigned long. > > Given vm_flags_t == unsigned long, there is no change in any behaviour > before or after this patch, but in future this will matter. > > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 20a89ab97dc5..34e5d78af076 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -721,7 +721,7 @@ void mark_rodata_ro(void) > > static void __init declare_vma(struct vm_struct *vma, > void *va_start, void *va_end, > - vm_flags_t vm_flags) > + unsigned long vm_flags) > { > phys_addr_t pa_start = __pa_symbol(va_start); > unsigned long size = va_end - va_start; > -- > 2.50.1 > For both (however they may or may not get sqashed) Acked-by: David Hildenbrand -- Cheers, David / dhildenb