From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1899FC5478C for ; Mon, 4 Mar 2024 20:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BE0D6B0080; Mon, 4 Mar 2024 15:40:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86E186B0081; Mon, 4 Mar 2024 15:40:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8A66B0082; Mon, 4 Mar 2024 15:40:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5C4DC6B0080 for ; Mon, 4 Mar 2024 15:40:02 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0EB7A1A0CB7 for ; Mon, 4 Mar 2024 20:40:02 +0000 (UTC) X-FDA: 81860523444.03.0DAB152 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf12.hostedemail.com (Postfix) with ESMTP id 3FF5540019 for ; Mon, 4 Mar 2024 20:39:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mHM+xErS; spf=pass (imf12.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709584799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KJVNo/H6euE24p4LbCMOfq6c754QiQocLlwhTY0ZvYM=; b=53NQSaSwVQ6re5K+jso/ZycaO0h/z0L0XvARbq3Ms+ZMAa+100L+0iQVs0WS71dOwsWo6w aGzOpLm7St/yGGp0lpsI5FBXrn/EUkbVDVI7aWIynW8liyjin+DkXfUshTFj/5e7Dy8cpZ 08SgdGpvC34U3x0ngd+R9BKZqdkEx14= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709584799; a=rsa-sha256; cv=fail; b=8G8G3qqFxOGl+K7E4iPjA/jN2/X5oMUu9yKRMSyjdrq0+0juTSCS+m6BQj0U2b+QKUraRJ AmOln0wRq4FM20sI0O14FvmB3Ss+1ZIG0GjSC+PfHbCB/CQhldO4fs8WUnkT6TtVPZJvsk AgjLJPNicgLz2wXlUcyDS79l3yPQ534= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mHM+xErS; spf=pass (imf12.hostedemail.com: domain of dan.j.williams@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709584798; x=1741120798; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=7u1c59EaGUlgkb3b3p/SkQJ0Q7s1nPck4n/ze0sozxE=; b=mHM+xErSD2lqqqEZAtmLKOgHsTjsaSTfZOzfhoiqKV0pE5IJG6MqqU0V c4zJ/vTU98sCXGHZT5qBPn/uLkZl+MfxDlp995j6srxOKehxJzGAVSyT3 vslBq1pIT6CPnWJenPIJUkKFsXoAdnTWtzLDeFDskRlwJ8gpmRm5aSp/R 5Ny9f5nK/mcysv/cC4kioZ9DzGkXNpnhZMmrAgne7VSbpcPbyZwPGeUE3 GAtBxX/Ms7LMPzi2boCF3ONVrrgj6p3GxUlaUq0BqwEITdu1So36ljGcB 7u0sDJGcvdv2Ye/Vk05SfT/ib6/xFkIKhuJo1YThXVCBRIzEE2BaJ/Gce g==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="3956311" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="3956311" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 12:39:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="13782296" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Mar 2024 12:39:57 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 12:39:56 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 12:39:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 12:39:55 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 12:39:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f3KZbvrTb9xJ6lMmDQsGyrAvNvBEZOFapUV/9TDKrZLrFfhzpHnqydgjCxjU+wMwCPsGMJIITdVLg4+zo1vumJSbWC3uSZh/HGHqeFQhGeMngGEjfB4o+HEG338TRcYlNOCx438b9QTrUTpuWGYbXgspf5wAl4lQHYqh5tcv82CKWHxjSLKtq2wmQuKSdejNd0fMFi+/iuGkYQUAsMGlOWQByDVI5MKkhxcmrwtcKfTpCiTTb5UZDD8bGALUCV50WY481dvMsODNSwzc5v3pEnJIfYwDQBa0UBnK7C5KiYepB7ya8djBc2lWJ43vrg3M9J1cRevWgYQ6Ch9is80i8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJVNo/H6euE24p4LbCMOfq6c754QiQocLlwhTY0ZvYM=; b=aRPctHBD+mTLEfOfeiaFO95IlD+Tv3t9rnov1yEQjHONmOkXmQgprKnyEN7dk+BHfDBk98JM8ly/EYYJ47Sb1wNY2yDX8US47p6zFKKdLLDYF9exV1zbSzYHFi/Yu8O4829/WWVKQYbKhe7TJZS3MoS692saUcoKJWOfhJUbqAM6CTwmVAAGKpQzi0GR6KCbJsJaoVy3eyCh5HgeR16j+kQKOeA+pU2iuNa2ZcFQS0QQCbOWD18svlNhru2UJCQ7XQJjLzEgFWHVqpwpgOn8exbqn30Vt7Nf30c8+4O2gDRS2OBSQPnHm7QZghOALp94MQ6kUf/B3Iqp3P1sYDX9KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SN7PR11MB7996.namprd11.prod.outlook.com (2603:10b6:806:2e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.18; Mon, 4 Mar 2024 20:39:51 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::82fd:75df:40d7:ed71%4]) with mapi id 15.20.7362.019; Mon, 4 Mar 2024 20:39:51 +0000 Date: Mon, 4 Mar 2024 12:39:49 -0800 From: Dan Williams To: , , CC: , , , , , , Subject: Re: [PATCH v2 0/2] Add log related mailbox commands Message-ID: <65e631951ff61_b62b294e1@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240222172350.512-1-sthanneeru.opensrc@micron.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240222172350.512-1-sthanneeru.opensrc@micron.com> X-ClientProxiedBy: MW3PR06CA0015.namprd06.prod.outlook.com (2603:10b6:303:2a::20) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SN7PR11MB7996:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d793c29-1587-437d-7022-08dc3c8b3da0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DrAuIe+5dRz1vy72E3lORrBrZMQ0MUHhmSHdO9UCdkZEfvzONe9qTRLCF8N+pw2djKblSJCROLbvN/ZKISQML/T6s2uT8YJhrRx+JpWxlWZmQSOJfMVJRhZ18gltoRyMI4D8q2Bez9BCfuTp6lrh9Mp7qWoFF9lLM1JeuTTmD64yhRf+4I+e8Zqmj4iIypaQOk4judB+u7GdR3SfcA84KQMd+HBIs078wKajxsTq6L9hyZXZRJCN+v6YQF0F7rcbn/DmlomvPnsyW7elEO34wVshVzruXJGz0fgjuojViB09F43o8pr/Fm7dABNTLORmXQXYZMbV1MlK3Cr6n5yy4S2D1OzrkcQmxZu52Y5JV+UTu8jex6/jZ0DLgN2DUPsvE9BVen5fL/i1Rp79yK0XAEIOtdYXkGtjDDUbxlBgCBfvISakr3xx576foeUeV04dpkkvzDEQXJ2Jpl+iMg7QLUdWul3/R3IzpDH9OAfRJHt2onhRWYlpmlTxomsOmbrgJepgaDAH5uZ2jOLjjjS906C5q4rBlpI54ryFa6Cva0k3C/6TB3jsOx13yjbPfks1Vnebx8fpA2qqLGBZpiN9d8W21CGjgvvx0MvgeVCS8oG5OAU8ULlSTIAHfESKZQ+HI63mAfRv+XfGwEMFcwNQbvLh2IE5ABLCJ8y1mU2GQBk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rqfOSuO5WtR8Xouvruz2KkvECkbSHwb494mY53cNrEAkQaX0R7cTj/EVEDHO?= =?us-ascii?Q?MDBVdtnzwowXU+FtSLRc/KsdRRoPWRWFx3kNS4QihmFW19eokivkfTOVajY4?= =?us-ascii?Q?9RQoe2a+YbPOYU5ono3NDJjp7j3nYrRpfOmIcTtWzWaQOPdQTBXf2fAje0ef?= =?us-ascii?Q?2l8HGTp/lQ32F/o9sLkk1y4bsSHCWm4klyOMYC5j5lrWvqm7X/Ho18hFHZCR?= =?us-ascii?Q?vZW/K7XCuTXj8foAJuPeLnN51ZQiCH8t+amUljq57wUEVTYRp19qIPsfavxJ?= =?us-ascii?Q?5LAbPp/kOLmvYXItNrlPHs9vV9HGrQ9S/0CtMZu1GtAnFILqJcsq5I3jCAGv?= =?us-ascii?Q?yTEzGI2kgAFkxmZR5oJ9bRNOjbVINd+ux6XlmKZQaaoYt4zWXkToEsailODZ?= =?us-ascii?Q?Ko1JbfhHZN1e6RWLHLZYbEnbNXiU+igezrAsO+LXEhEkGsvqKLMCW+4xXXiY?= =?us-ascii?Q?JEqKn+0kxKPhnug+530MWsRJQOcnoioN+96jKV9WrX4p/Bgwgtb3HZUr7R09?= =?us-ascii?Q?W6u/GXiBVVFKKAU8yjt0KIJ+l/Wop0w+pYJgvr9ShYszGDoqAsJAI7Oj6KJD?= =?us-ascii?Q?9XO3aKtCcAafRIEyxikh9Q/bgh0dnCLPidazHF7UboDHDErMmZCmZUaRVs3k?= =?us-ascii?Q?SR4TAnD1cfc+3xb/iFPPXvUMulUhqL5raHpA/reWWs8Ghk46NDgJo0Drwu7V?= =?us-ascii?Q?6aY+wK6VtmEhhkGu65RkR1K3WPdNThIaR/8k5DFVSaLern6UBoYDkvTbN0xa?= =?us-ascii?Q?wX0PK4TBRm6LmCf6piVn3QFXZC8zSqsABsnx442ppYzzm9Gir0aAeytYDbCJ?= =?us-ascii?Q?ERSLzbRD8KrC7FABDziLeXBswwtsYNCHbdCmEWwQTJ68/OcO8X/Z6lKzkH8x?= =?us-ascii?Q?fNxRd7afLDiO6itc4xXpDr+Y5mm1Gfn+s9vPNXxO9MoG3j9vwyzd+UfMacRS?= =?us-ascii?Q?SI6z5u7IOz5WSuK8EyqFo17BGoQZgusobkYKkEScCn4gSzXB78CiAj7+wPiT?= =?us-ascii?Q?We6byc2h5rY5Zeqf+FOane8zsDeVCBJn7wPTixlPijMWsjPHAhYeNERkHFf4?= =?us-ascii?Q?ygNeVZxfU9MdZ7QWoLMN6/4zC5HdxnjcG6Oa2WEg+kql+IrPqottThYD2CLQ?= =?us-ascii?Q?LH2IvPFH9Dingb4tws8+ZqOvEzEvvjMsfwhEi+NT7CsuFVZYROoxxZctWBQz?= =?us-ascii?Q?oqn7cWRQtvWAVyRNGoKgP3buX6N41Im3btESoSQf6NCYv65MWmxOhmNbB6aU?= =?us-ascii?Q?HoIG6FJO/VRxncHAjxDDqoRvhDfvyMuGBSRVrJ17QMpRpik3PVA0S3JszPmO?= =?us-ascii?Q?1KbUX1fhmTKnc0HWoreOfy5XUSGmJgobGNuDaSybrqTq7JkCfa7uDW2w38dS?= =?us-ascii?Q?3OV+Rmby6vIAtGKo6YA10KBoOk9tdudTckVcbgrROCytblLVsaRUc56AWPXO?= =?us-ascii?Q?4csmGzr01XvR/7ronJoP4Ik+yY/aZaa2HKrAD987yBjV68fggNv/DP/ucDg2?= =?us-ascii?Q?Nm5y2WxKKOwXI7QLoAtH1DKsGeIBZ89ckBxEkSz5FkSWd8l0TgNRloGI1TCr?= =?us-ascii?Q?/h5n3ai6H8ifq1Iqware6W8UJAsv9A4LPbyNxSD6xdFg+Jw+HpHdUhLwi0dY?= =?us-ascii?Q?zg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2d793c29-1587-437d-7022-08dc3c8b3da0 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 20:39:51.4469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i9sWS8slWQ/t+syFI67569s3Nw/IlQ7RBEFSviVzP8f+N3PW4wHtYmy8qNeVFlielFkPNs86bIqleJsiH5C3tz9M0G0r8u03sRz5mZv4Bvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7996 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 3FF5540019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3e9gdgwoot5t8xbmn4f3kfqxz8cx8rke X-HE-Tag: 1709584797-602202 X-HE-Meta: U2FsdGVkX19y9Cugrib3oibtHack97twqkrinNvo7VCTWgaM5f4/l4GCcV1XUVxcXOnqs/mI2or4dWC0LIy7W3rJBtUyxuxIJNqigZDnq32qV2zO2RznePdaUxq8M8w6sm7kRvfoiAFa1olktM98kXYP9JwdAhnMqBnrAfsSkWSj5BhEITqRDZt6r4JRDm1NnWQrAW07Dmv8EzaPxhgng5vVPhvUxz9Ksd450ulOzFB8GQ5PGugC1I6wwFPFrT78go53jcdl4tCcLzDob4jmHBg5ohDZxdbWNCjIjBWoOfNVjb740TeB0tuJlCSpyLYC5n5w77So/1FL2Q4UXtS59TXp7MT7eCUxz/xHvnDyp4L0supnnLOVihtYhRrkXPxak3UxS27ovGR7gLNLuVnBarmqkCGSgp7BlFB2lP3LiYOOrvp7KZ802kqQuVu2c6DsY8aorF+nOEO1z8y5OyAy1r50wV9lR9tifSrSjTmwVNplAS1T19oYGZ3r0dmfeRW9GIfqoiperfvjDUKhW9bs5J3QI/Ht4Aa2sZORHL148nLiES4upSa0SFqv5b+7WBmoqDbexPR+XXAdDvFHse2NYuNepkRfbBMWWt8XHbtXHPbQ33+P10o9pYfShtWjh+gdpzizJl20YFlWDn688qKDESOxvxrOJfaAhvIZdbxL7dVqXAM0hvR8iP/sVWv3X+T8xV8yJuqP5zZa03wCeEa0CdYS92e+KTXxSF8ge35TJPyMZn4XDSyR4motlOyUH3fJ3P1Joly2pNqilqHBfyym04lCZz4vxddZGehjcSUZNlXJrzbXHsRfPSyYy427/tLr2TBnll/Y5c8gLSksfr+2EapK6xiuL9efXSDPqCita5AtDYIK9QOXc5m/ZHiSpcANlEyj6WIctb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Any specific reason to include linux-mm on this enabling? I suspect this topic is only of interest to linux-cxl. Lets drop linux-mm from a v3 posting. sthanneeru.opensrc@ wrote: > From: Srinivasulu Thanneeru > > Add support to expose following mailbox commands to userspace > for clearing and populating the Vendor debug log and > Component State dump log in certain scenarios, > allowing for the aggregation of results over time. What is missing for me here is why the ioctl() ABI is suitable for both of these. The Vendor Debug Log seems straightforward to enable via ioctl() since there is no background operation entanglement, no population complexity, and no reference to other payloads. The Component State Dump has several caveats in my mind for ioctl() not being a suitable ABI: 1/ Populate Log has an unreasonable expectation that the submitter can monopolize the mailbox indefinitely. At least that can be solved by Linux only supporting automatically populated Component State Dump logs. 2/ Automatic log population requires the caller to handle races with auto-population. The kernel need not export that complexity to userspace. This is not fatal to the proposal, but it has interactions with caveat 3. 3/ The Component State Dump format wants to reference events in the Event Log, if the Event Log has been cleared then, per the spec, the Component State Dump must not reference the Event Handle. To me that implies that the code that clears event records must be careful to not destroy linkage to component state information. That suggests that the proper place to dump the component state log is an addendum to the current trace events, before that code clears the event record. Something roughly like this: diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 9adda4795eb7..498b2a0b3e76 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -941,7 +941,8 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds, } static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, - enum cxl_event_log_type type) + enum cxl_event_log_type type, + struct cxl_component_state_dump *csd) { struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; struct device *dev = mds->cxlds.dev; @@ -977,9 +978,12 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, if (!nr_rec) break; - for (i = 0; i < nr_rec; i++) + for (i = 0; i < nr_rec; i++) { __cxl_event_trace_record(cxlmd, type, &payload->records[i]); + if (is_event_referenced(csd, type, &payload->records[i])) + trace_csd(csd, ...); + } if (payload->flags & CXL_GET_EVENT_FLAG_OVERFLOW) trace_cxl_overflow(cxlmd, type, payload); ...but in general this cover letter needs to comment on the long term suitability of the ABI.