From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AEA6C021AA for ; Wed, 19 Feb 2025 16:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18E58280243; Wed, 19 Feb 2025 11:23:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13EAD280242; Wed, 19 Feb 2025 11:23:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F230B280243; Wed, 19 Feb 2025 11:23:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D47F4280242 for ; Wed, 19 Feb 2025 11:23:07 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5876F1A1281 for ; Wed, 19 Feb 2025 16:23:07 +0000 (UTC) X-FDA: 83137213614.16.E71E569 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf22.hostedemail.com (Postfix) with ESMTP id 9799BC0020 for ; Wed, 19 Feb 2025 16:23:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="SqCLT/s1"; spf=pass (imf22.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.174 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739982184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67TYMpkqxY5mExKnmZVTE77hxJr9qVBfzvrOMIP8NRY=; b=r93BEsladgKnxGk7rkJpXFAKNSIqfo/NY0S/LUX+Tb2Y6Tbj5xd8/T3K3PbPgsv+olrO7b SDvrC09xvSsyVhB6ZpEE4e9aJkU3Uhvz4vYU0SqP19pENFZcCxMpTj2TEa6cICtTp6zlrk lSFJ90GnK1a4AefftNP26Z3+C884u/Y= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="SqCLT/s1"; spf=pass (imf22.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.174 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739982184; a=rsa-sha256; cv=none; b=OCA7mdgfieiAWO2g3fZIaRsQ9c2HFk39A7eq8JGpSLQq/qdM/fPL+1uXCwd2fby84vAnWN mm52IMXfonoQB4i/6d5MKGzf3fb4Po9GsbI5T0TTVgYCXCTdKra6jds61aUET6+IW+nbtz rfRvj5ekv0sUDnSaXosMYnwygUAYil4= Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3ce87d31480so22658115ab.2 for ; Wed, 19 Feb 2025 08:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1739982183; x=1740586983; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=67TYMpkqxY5mExKnmZVTE77hxJr9qVBfzvrOMIP8NRY=; b=SqCLT/s1FgZZVFa+aJZBh96405gSuC5TH38kdOWs50ZF4r7BhRdD+ra2QWGf9o+Cwt XUvPhq9RvbqoaOrt1NkW9/L4PVq5Lx2CuFaZksPxtgCh1eUryyMMbrJRnAsuLPynMQ7k ZRzE5YhJZTQxx6je1XS9vMJtdbzrJu189l1nzFdPVF0foVJPANArh7dbRhZX8NYpzFIC +YfanA1QhArsICEU3kFkDMA4iLLn4ZhzIMrCFYlxR9nGGO4HodR0QqHHzPzl+JAMVKe7 OoaopQQcQsSkkmoa60mAd0uYx0Dtqyh12f/GSCTOfvpfARybkTH5DjopJYNF/BTIYLUN JELw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739982183; x=1740586983; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=67TYMpkqxY5mExKnmZVTE77hxJr9qVBfzvrOMIP8NRY=; b=i+k9ui7qJVtqtEnvTRaSqrAT2A+X0tldjy+kPNs9rBSH5sQJBqPwzV2dLjkoA92z2D jX2+tDpr84EGhO0iYcixsw1sBlqfGH4IZQ7jkAL7+W6zwWvKNaA73rqiKHzLOKBbmIi9 pRG4XsB47Nlv8mZJbu1EzczwzTcEyogKFIXfG1U1TFSs5kV/o2g4t7F3FHzUgWfm+EJ9 dlbp9seOP2dvnnWTbz7sA4DtNv0KS1xdxWsIo6mXu/GuTQX3N1UQJZCb76nbQe0CLFIX /cHrf/vUblnaBrj7gxHntBPnbBVgPMFTS1iuU8f44avGQHuMgEXph6Zf2rQpWYdnOL8c /4BQ== X-Forwarded-Encrypted: i=1; AJvYcCVhrZ2RgjXNfYrtFZFTVU6T7cPjuNotP3TeyqlEsYRCmfmHHIGvKgZUFEGHMSAf20oK4v11PVoltw==@kvack.org X-Gm-Message-State: AOJu0YzzAgev3/IiXIqTfTdi7rt0p78FnT6y4aq0i6IEAqRjobklJg6G 7dZ09XhOAsJtgulUkizCLlI35GzCXYxKVVG3cL78tM3TQNF6dAL8a1aGR4M98YI= X-Gm-Gg: ASbGncve5ekQ6Gq4+7hKviKioK7s0GC4sPZ5vfpQv8ZLL5An/pSan922olMJUs9bsJy fb3f9YC+Ft/xQ1ypMDDA8oONRov1lMqvUs7o6UUDv8iFwdcRo9O1glDv+2lLJEXjmIFTtWC16qW e/h4DUMuml80TIZ99nsDl5FBd36zGuw2FOYCa6rUJWD4st1CYh2WSbX91jzPAe4lpnv7S8MK9bg 2xGMgRkIABQjUWdPA98fkpyJky71kBeROKFeZvyXCc00ypJlRkszzPTW+7lzOpHhhzkFoPhPLRY 2ARuIiiOr8k= X-Google-Smtp-Source: AGHT+IGsP9WAlYtkUYVoWjhz3+vnzS72BFbKRaFhdh7G4oojUtLjlV/F9FheozGc1GxCuDhK7ilFlw== X-Received: by 2002:a05:6e02:1d85:b0:3d1:a75e:65dd with SMTP id e9e14a558f8ab-3d2807905e3mr162742745ab.10.1739982183443; Wed, 19 Feb 2025 08:23:03 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ee8809c5d1sm2144921173.38.2025.02.19.08.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 08:23:02 -0800 (PST) Message-ID: <65e5ddcd-642b-4671-b814-d4a66b2039d3@kernel.dk> Date: Wed, 19 Feb 2025 09:23:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/truncate: don't skip dirty page in folio_unmap_invalidate() To: Jingbo Xu , "Kirill A. Shutemov" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, brauner@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk References: <20250218120209.88093-1-jefflexu@linux.alibaba.com> <20250218120209.88093-3-jefflexu@linux.alibaba.com> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9799BC0020 X-Stat-Signature: rd13q9ee5u6x7bzuxhdoreiy5icaejfk X-Rspam-User: X-HE-Tag: 1739982184-336038 X-HE-Meta: U2FsdGVkX1+YklRwx6RQU7J3mGbT7GHd1nGCkHJK/nTf9C9Nzjschfj/AEUu1qFOHiAtw/SBGD4gYX53uC5drLMo9ABy1WeENbrlICGv5c46Wwvj/SmyWdQxsQgHcOyvtbPRR7Cqt1r2vPfQ0PVOnpR2kkAKQrocBMYe3V4oFN1kl0u+fa7vc25q3jxolGLKALMpR9v6QVXkMRVQ9xPjy1pt/JHnIgmrGpw2onFemrzCKyuvARWlABf2QHouVObm63MNAQ2PKJhTher+pWVr2N7uG+x64nLwg00axhnuxkKj6A21v2gtX6m5suDeHmJjhjhKAQ6CTqCZaLkYFUta0hyL619rTOUX8rVsDLnQqDxZDSHhQoabInsxLU6PIenmSTvzlLEVx7h7/rmfc4g0csaLzsLwN/CCTHhQrkTJQTh3dAznKcjtuhCbLtCh+SgN8zwSHwroTmUbGkxd5BtNsgfZlLOpwEQmBwYLArylPARkJ/QjeGyK+j/fSQg625OsEjC6OxrzlAnVUvcUVP4Bz4nfd7s1oyxS5hE1qJSMEhS1BNuVBUWIZsho6viDe7mlGm5fFfY4hY0jIcVmGEbTDEDcMO8vx+Tar0IHHnP5JK3ydLwP5qUWi+3bysMIFsegC5nTjExfQmPOtroF204LL6N55VHCFZeNbpTTkBnLCGrhip9bri0FG4LhASiI1GqWTclovPxhy3EAZoD35+qMgAi+yPrz/49w1tur8KZcDTP38lbq0D0DmrFJZmDtuSuU93DrVOGu/1gIcTae+P87M8R6AKSq1KsQ6qCxhQG5Z6BRjiaVx2TQly/PiIc33rxUTjalEXAd9IFJ2IyGaeoWfqBEgus2pRr5N/XtcIppNLNNmKxK7TDZnX28GrXjmUV9DYej0FMBMcLqYNciiAg0kAnKusp+1vRLBrUsOH45xUG2G9RSTXrodc30aDnDG3YFZxcyl82lSNnPZY8T96m zgzFrMf2 em9FCIQjIoC7POFFdXpugQk/7gfmQ/Ah/oug55JiCrKSdLMxCPO91y1UhraCshj0rWx8xZBcKRSwZ914qJ6vxDWUsrF/S8GS5EbbxeC95z0w4j184IYiwQrlBZX7dCzBbeft7Scx+fEikhb/iirG7Lu6NXt5Mo6JwWPw37ObVp9Eo6ARLqyhsmcVoiSa2etu04ApXAumeNTt9/04odgrsWgV+cGA6ei8SeYagfumffXl9Tce/QAma2b/edcBsfQwcb3zhFdgwtVLAp1Jn2jUv6aiBa0oJ9GbQZpIHeShQgfkJpik/bfuGrB0T9725PtWGZ20E9flSnGdqqk+1QLQWioFEhcEWkxpC8o3uyRQF3tK0ykUINKT8MJEefGxom37AAVPQdNH3xALBYjlMDYgBKlXrGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.026482, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 6:23 PM, Jingbo Xu wrote: > > > On 2/18/25 8:32 PM, Kirill A. Shutemov wrote: >> On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote: >>> ... otherwise this is a behavior change for the previous callers of >>> invalidate_complete_folio2(), e.g. the page invalidation routine. >> >> Hm. Shouldn't the check be moved to caller of the helper in mm/filemap.c? >> >> Otherwise we would drop pages without writing them back. And lose user's >> data. >> > > IMHO this check is not needed as the following folio_launder() called > inside folio_unmap_invalidate() will write back the dirty page. > > Hi Jens, > > What do you think about it? Yep agree on that. -- Jens Axboe