From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9175DC433DF for ; Tue, 23 Jun 2020 16:40:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F8F420780 for ; Tue, 23 Jun 2020 16:40:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8F420780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F6E86B0007; Tue, 23 Jun 2020 12:40:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6E66B000A; Tue, 23 Jun 2020 12:40:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695E36B000C; Tue, 23 Jun 2020 12:40:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 52ECE6B0007 for ; Tue, 23 Jun 2020 12:40:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E3D58D2E8F for ; Tue, 23 Jun 2020 16:40:57 +0000 (UTC) X-FDA: 76961040954.04.fang07_161715726e3d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id BE7418031FCF for ; Tue, 23 Jun 2020 16:40:57 +0000 (UTC) X-HE-Tag: fang07_161715726e3d X-Filterd-Recvd-Size: 2258 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 16:40:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B40B1F1; Tue, 23 Jun 2020 09:40:56 -0700 (PDT) Received: from [10.57.9.128] (unknown [10.57.9.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B11243F73C; Tue, 23 Jun 2020 09:40:54 -0700 (PDT) Subject: Re: [PATCH] arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs To: Anshuman Khandual , kernel test robot , linux-mm@kvack.org Cc: Mark Rutland , Barry Song , kbuild-all@lists.01.org, Catalin Marinas , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org, Mike Kravetz References: <1592893296-22040-1-git-send-email-anshuman.khandual@arm.com> <202006231703.DC6xDVaw%lkp@intel.com> From: Robin Murphy Message-ID: <65df396e-1345-eb86-48cf-ee9bbd3881f4@arm.com> Date: Tue, 23 Jun 2020 17:40:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BE7418031FCF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-06-23 13:48, Anshuman Khandual wrote: > > On 06/23/2020 02:54 PM, kernel test robot wrote: >> 423 /* >> 424 * must be done after arm64_numa_init() which calls numa_init() to >> 425 * initialize node_online_map that gets used in hugetlb_cma_reserve() >> 426 * while allocating required CMA size across online nodes. >> 427 */ >> > 428 arm64_hugetlb_cma_reserve(); > > Wrapping this call site with CONFIG_HUGETLB_PAGE solves the problem. ...although it might be nicer to include asm/hugetlb.h directly so that you can pick up the stub definition reliably. Robin.