From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15FC1E7719C for ; Fri, 10 Jan 2025 16:37:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4648D0005; Fri, 10 Jan 2025 11:37:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 884798D0003; Fri, 10 Jan 2025 11:37:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C428D0005; Fri, 10 Jan 2025 11:37:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5753C8D0003 for ; Fri, 10 Jan 2025 11:37:21 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 093631C7CE0 for ; Fri, 10 Jan 2025 16:37:21 +0000 (UTC) X-FDA: 82992097482.25.CE45585 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf23.hostedemail.com (Postfix) with ESMTP id 65A3A14000D for ; Fri, 10 Jan 2025 16:37:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736527039; a=rsa-sha256; cv=none; b=uQ+r1nY8Aep5wfXDHeEekdQo8n1osw1TDoYQUoIkN8Tupw7MqYvYtFEBGXTYY6cl017FXc R1WkERtngw6S/wD+S8rBYGhwMYN70HBvbEXPwIx6+pgUpjIA4i6kFoldBf/yOLzScMzUlh WUlqE7ZEfYqVj7Fxr7htiPVrgm6HYkE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736527039; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjdJgpU7/yLzgkAP4j/OIatMDtzi+BHjv7io64j8Qug=; b=KXtfEgClhe9+bDwGL08w4G5OfBI3W6YVQXwL98YzegVlI3Pr46ODzcb5LIYWLytn+ot4i8 4hG9zvntbPmyd08wPqA+LhEpC0uWkTC5FDWNbL6fWQuT9amEdkr+IDgQwnqiMsnPZUvedD 0qkEdhE2TO4Tu8XFktm89wa8erZH548= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tWHzp-0000000042J-1JcC; Fri, 10 Jan 2025 11:36:29 -0500 Message-ID: <65c9fa727810df986c4e576799af430c35b9d40e.camel@surriel.com> Subject: Re: [PATCH 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Dave Hansen , Nadav Amit Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" Date: Fri, 10 Jan 2025 11:36:29 -0500 In-Reply-To: <5f099cc0-b5e0-4d15-95dd-7f4e9f3df5eb@intel.com> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-7-riel@surriel.com> <855298e6e981378c3afeab93b8c3cb821a7a5b88.camel@surriel.com> <426011a9-1fbc-415c-bac7-df5d67417df3@intel.com> <915c9c4e-75a7-4c4e-90a5-9a3de93bec1d@intel.com> <5f099cc0-b5e0-4d15-95dd-7f4e9f3df5eb@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 65A3A14000D X-Stat-Signature: uw7jg7wg7hfdmjyjo8srdn8x4nafx76h X-Rspam-User: X-HE-Tag: 1736527039-600180 X-HE-Meta: U2FsdGVkX18sEHKNRa7HoQbZLWN93dwMqsYlDv78CyugVByZhlYkhK+M1WjZiCpNVEXZO8ySUI4pN4kR+2VS2ffzk9dz+6qX2NbbVth20+y+wOTHMqPnH7g1jNki1H8difS10anTZx6e1BHGH0zAOP2lisZbIlq+jCjtVI+9A7jNLlQXx88H72LoZeG1gwvCMBH043fNZvC6rl3yCqGosJZcgD4QN7IMuUYHKnu8dao7XsOxizZHmSi+JugF1eGOepp7KOscBpEOdIcgMSFfrxgXRDSboIe58QH6fDJNI/LQidDkywcRlYOJcKXvmz6K8T44q1m4Aw0PoADXkJs4RtaQ7BTlm7AtwhGwtf72/t9pt9Q/Ep7AHj7PnrKFuOmqY77BQezD8pQc2T/kDWGA48st7hciPmXsPTjvWZeZAjNWOFwAG4HWqUzvwkUszrWtyJ7MVlsolkv11CHZQeaH4VmKy20TXQENzb16DQkC9suJVWA9Jc0cQN+sqVuK6NvsNRBEjRvR7A0wISlcEHewarJQIfqZNTa8GrcL0gtuZYD6Ef9rPSTEhwBSY2oO3Df2WlEVhRCU5rGs/7OKAMiqAGoNtbu6IGuMMiWpmMpTKff49WtjrUtanISceU5nGqNIUtt8MfeNlv5nnbeQCJUsLvXIOUnqps7tDJxB5wdXxUltR11GP8fiimleWIQ5HzJN2UWv+grQL3fV1wndVgdQbGXyyV32LGxzKiKFGq6lluu0oV1DVg6aqubuOK5kzGjLGMjEx4ZYpx7nRRjPaMbT9lgwBgQdpbShPdRDef1f3RqIYxNHlY0+uZnQxaeGbA54qpfj1fZq+yXU/OcRiM76QC9y9+Y+8Mmz3p4kvSKwmjYDV+qSYiCXOs1gjJOm3eaq4pBa/B2/pB1nSraSm/REnTfq01gletU9Lm81ygUKN9VwrC4Wr+lNbxdxvUl0R55Jo+g4J8kb5s6STVBtpgY lXMXjfyO OqJ6me2PnfNf/GSC0Jz5MUbKE1p1l1TWBJCvO41gE6uIQT/sz278yvnScjwrXbpUXLXOGMMg1R2asYl6zMtAoD0MKhClGVzo+ru/gCaqQERUO5pzbP1YefaqkDpS3IBWFRvdtR4NNAbseRacK/Zb8q9M33iXCh16M1YXUOZp+fVrjWy/XdChnoumSXHwQd9VCgS9d0at7UZd/rZCNlQvrWIrkR0nPYbNMYF3NsZyyF85QyMp6YAR+oc6qln5Vzneb4cDbExwbjTHTpfwj67Pv1Rc4+YGRXC00GuVTugF6q0ErJ2D0rzs5VAmw8LDEs1FDygR9Rl2CoZOy0Uv3eyPE1sftLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-01-10 at 08:29 -0800, Dave Hansen wrote: > > about. >=20 > IIRC, the "big" invalidation modes are pretty cheap to execute. Most > of > the cost comes from the TLB refill, not the flush itself. >=20 > But there's no substitute for actually measuring it. There's some > wonky > stuff out there. The last time Andy L. went and looked at it, there > were > oddities like INVPCID's "Individual-address invalidation" and INVLPG > having surprisingly different performance. >=20 Agreed on all points. If you guys don't mind, I'm going to keep this on the back burner, while I work my way through all the suggested code cleanups and improvements first. --=20 All Rights Reversed.