From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9555C46CA2 for ; Sat, 16 Dec 2023 19:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2583B6B007B; Sat, 16 Dec 2023 14:10:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E11D6B007E; Sat, 16 Dec 2023 14:10:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0320E6B0080; Sat, 16 Dec 2023 14:10:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E23866B007B for ; Sat, 16 Dec 2023 14:10:09 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BD2AD160673 for ; Sat, 16 Dec 2023 19:10:09 +0000 (UTC) X-FDA: 81573621738.24.16656CF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 43516180011 for ; Sat, 16 Dec 2023 19:10:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s0t50G3l; spf=none (imf16.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702753808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ktnvyamH7pIEdUhebfwu9eUsYoWrjCwsREAxL8GiTW8=; b=1rK2DrL4yGGnN7LC4ZmTKSShXUkesraHHVxpEdJnZjc2vwlWrEBJGg7ch6fb2U3i3VuSzh FVkeKTrTkVDjo0ut/6aZsPTiGZ7eV7ivV7urgP1Vj7AIIx5l7Thwq/Vzh1qQRyVsOGkJUR txjbn59UIvIsGM5Sxjd0M7WsPwXyn5c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702753808; a=rsa-sha256; cv=none; b=77UDIlLGr/s7t3f1CK6LiE9vUiyaKMfHb0GmRHOHZ/MS0+39/IWZu+xmDFEJDNR9Zabh9H phRBRTAE2xQUmZF+2bJi1EYqasgf1wAq9LrVkFuCERXlNTnaeDzw32V3LEWmYK7ylB+ydq 84NxLdz/2CAQF1CHLcSugGK6/LNSztI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s0t50G3l; spf=none (imf16.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=ktnvyamH7pIEdUhebfwu9eUsYoWrjCwsREAxL8GiTW8=; b=s0t50G3lVcBEdsaGSAkuW2sn17 Ql9TV8WbXeJ11fYrIszd76ejd67Jwc6l/qM64/5+AvyshCJNCOakjuzAiew42G55TYh46sh7sQHgk EMzWa3we4SXtR2Jz35Ls1aOBmhmCqMLhaGxhllee/lIEcnFrhTjobnUcbNFIs0XT71H0ogULAUK0z jeG0jv48VNBi0tUFgaWNkmNinfMRpxYMJXMDX4YZUMF0Fb0q6q3oGzIuPvPMMM3Ylp3rGyzjBXxhs 53/nPWmbDIrXx2znJAkv+RkkuNLS3mwQP5vVUkiGcB4VaJrgtpir/kj5N9B6RS/JzDZ0bTNwNFCy3 TprQ7Fyg==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEa32-006b40-1L; Sat, 16 Dec 2023 19:10:04 +0000 Message-ID: <65c68bf8-c577-4103-ae7e-7871ae276c22@infradead.org> Date: Sat, 16 Dec 2023 11:10:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h Content-Language: en-US From: Randy Dunlap To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032957.3553313-1-kent.overstreet@linux.dev> <20231216032957.3553313-5-kent.overstreet@linux.dev> <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> In-Reply-To: <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 43516180011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qui68dfpwedd695dk18iw5y3a4hgj9c4 X-HE-Tag: 1702753808-851059 X-HE-Meta: U2FsdGVkX1+YT44UIiZTcLDRg+ZcYSxptk46eIHmJsKHCYsVYHmNK2fQdw9mDXIAHeI1VQti3N1fayVlAYcGorwbGOkSLSr7q4vZ3uZGHkL43e96ISS1h5WrNwHyT2fVMwBSPTwonqcEPjWP0z2Mq6OevZ7kuMmgwaYrZcQqaFX64jnU5Urg428klwrnfWxG5+QhCHKxdLoBInwHw7TX6pEffQWHQvV1iZSjF9dkS9xJ6+qf5tzQacgmPO/S0tBjx/rilO1sshjo10o79Z59ypclmaXftMJVZRI8L65191CytXr/KaYh/4CfKmMArO21IQPsp3s88TtuErx3Ch0IAqpC0BdcOxJmH9ntPBY3n0RKLXgNRG9gfEOnEKcB5+4oeudd9FmDYPvBoTZC/BZuPewmAUjZozzr7tGiyQA0jQJUpNB+lspD/iHjnf18ZVvP0BPBSyl+u0VBe65zz8fOVqZoUayFz5emyGDo3ADNFeixIYy8HBaD8tznv4l0PnvmyMuoHo7jVP0MyJDe2zbL324poHOfCqXe6UgPn+prgMiFn0AJdHU7Irp/nt5Fi/MD4LWCdAAJ52mhPOg42UOH+sfDgy9nSY7t3pXhG7Ak/MiZVA1K7kpXPJkMon85ZToEmh0I5L8sEBYKva0jj/QIPIn5pZ1EYZq01SZGNQGSkIIz4vr25hKix3TnguyPEeNjGY0r2qrKqfnAi/uLeZ7VWWE/kjKHwaLy4uH4XZbDTAZLxr+jdMDZXmRxxZIXLe3PiDswKzvLmvcCmkzViUCIOG9xik7fyduKyrUdISRmMjYz9ujI/FpKv6ZTcgNWzI2N5uJu07yR0IL/hs2B3fQEHCBytGjJ+ddSzD30dMysanXoZBlEv3x02Ys7x4qsI9QvlTgsmQ+h3vuwNwhUUw6Rczdp35fGjn8zBep4pSjWROq6WPV2sybDfYxrHdhH6/mEQnELrNavapy+bqSF6X7 Vjk/uKHF iE8IpqVSwsYIRe40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/16/23 11:05, Randy Dunlap wrote: > > > On 12/15/23 19:29, Kent Overstreet wrote: >> list_head is defined in types.h, not list.h - this kills a sched.h >> dependency. >> >> Signed-off-by: Kent Overstreet >> --- >> include/linux/rslib.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/rslib.h b/include/linux/rslib.h >> index 238bb85243d3..a04dacbdc8ae 100644 >> --- a/include/linux/rslib.h >> +++ b/include/linux/rslib.h >> @@ -10,7 +10,6 @@ >> #ifndef _RSLIB_H_ >> #define _RSLIB_H_ >> >> -#include >> #include /* for gfp_t */ >> #include /* for GFP_KERNEL */ >> > > What about line 47? > > 47 struct list_head list; > I see. :) it's in types.h, not list.h, as you explained! -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html