From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B06FFC48260 for ; Thu, 8 Feb 2024 21:37:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A2556B0095; Thu, 8 Feb 2024 16:37:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4521A6B0096; Thu, 8 Feb 2024 16:37:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287B76B0098; Thu, 8 Feb 2024 16:37:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 13B566B0095 for ; Thu, 8 Feb 2024 16:37:57 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C796C1A03AF for ; Thu, 8 Feb 2024 21:37:56 +0000 (UTC) X-FDA: 81769949352.08.362B917 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf24.hostedemail.com (Postfix) with ESMTP id 80AB118000D for ; Thu, 8 Feb 2024 21:37:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LG90n0Jg; spf=pass (imf24.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707428273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=poEo0ltpYdoDxI1G9ZBivjHiPzfpz1mq1AuWxclYSqE=; b=5erlFaSD5qsqRGvaOEceFx7JSD5ZfQ9LBqjX48f4P2UWQHxlFAltDeJ8wfM+lat/PPShxC uuQ7/9Ven0ddLU6NjvXTxX/+oks5QFrYy4CXYEJQq05BgRYLotXA5TUUnE8S9fJqOuf7EK 6MphNzcjHXjcpR0J1TyYfQ2KAtXtnc8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1707428273; a=rsa-sha256; cv=fail; b=L9VPs8F0MphmqPRkYSSmfykhZLU7ecLjfrNKTIQ3W/xTBx7+eWKfSN+9fDL0dOEPATGT9E v64DlHnXlfgZkHF5rCKGIrsXdo8VqTLkBxVr0vKmH0g1UwheLPxg13RuZeIkkJlO0/mfJ6 9JdshGJL6oz8jkKoCUpYY2XEy9qVK2Y= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LG90n0Jg; spf=pass (imf24.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707428273; x=1738964273; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FO38my4m3MNo0nqERvvKqRbFW4pKi6a55LnVMFIUBRk=; b=LG90n0Jg9kT86Hwr0uVSFo2Wh8FDGltYBCaVylI+L2lTy/KxECiu3ZLs D9Es7aYFPoh3vws5qcMXro6EFvaaT0v/D+oFWCEzZ9X2Y38SPZLr8/nwx tWikPitW2om0FleJQjVi13kWIA7cVfUDc4j+oBUSOQYfUFrpKQEQ8ep6V i2hBp9n5dl5gRT6jWKPJx9V+1Ebp5FP13XO0z2ukde3KBSWHwwBxLTy+F Te9oTgLnqzFToo5V6Iq+kfgZAZ7198wdRn7+K63Dxs+UOgOL5Qcw/MwML lAcbnFBPMkwtiJLLVrn7Ebn+7ci3LXxjXaxZ5znfKSJUjyDYWjHlD9dS5 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1620539" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1620539" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 13:37:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="6387644" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Feb 2024 13:37:52 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 13:37:51 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 8 Feb 2024 13:37:51 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 8 Feb 2024 13:37:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WgDEZraJrQ1VAEh+902Ro7WKUL7c5UQdaDIfRTaCxD7KRvdymIDR1DzjqS4iCPEJtVN70gjfBR33Wrq18D4MsOJHHIgu5sDdnWfi/f1pdwq0TxD4UWbShLDVypsDYNdxk5ypbgDQYBNVuSKF9jLLNm3V7PwIiFUjaAydUOtDXuA5PeElhxxyVnUl/Jy76gwg890/th8VDaxl/0kSfkaCm8NMAg/ybw8LeHZWv/mHtVf70K+zYDM0s21Ytw5nYGGVkLT1rKg12tplEqWfwz1FUoUCzSjmmDBIaemnQ7EYRK1HO8UbngedFCIWChDmNRaURasC5r0iBOWblejk4Uu0IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=poEo0ltpYdoDxI1G9ZBivjHiPzfpz1mq1AuWxclYSqE=; b=dI09JqhqcMTFA2gV4iJzWTvJycoAcg8BrxqCtrM2c81xEV/C5YE1qvpoEOW+xtnc/uv16zZV2p9qQcqWhBDloggNCTehN92Z+w2dfVkWN59A0EukEHvqUWhlbxmunD/DIhmTIYEpzjeZ08igCZuZLt8pPaPhExVThHpaIw6YaQUCslhOe6c+rEj1YnNvD6q4jvtozLEpzCMx20bHuu2skTYNf5++fy10/Eo1YU9Ss7PvrrZUfzMxRRCSzH8AT0q26YjYWMO0FBQkwvv/po+BZ6a1KzTwrAWvUxy5/qi5kAcf+GZhMP8L6km9QEdMHkee6yO74IHp/58y114n4f4zwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by DM4PR11MB5567.namprd11.prod.outlook.com (2603:10b6:5:39a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.39; Thu, 8 Feb 2024 21:37:49 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2%4]) with mapi id 15.20.7270.024; Thu, 8 Feb 2024 21:37:49 +0000 Date: Thu, 8 Feb 2024 13:37:46 -0800 From: Dan Williams To: Mathieu Desnoyers , Dan Williams , Arnd Bergmann , Dave Chinner CC: , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , , , , , , , , , Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: RE: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Message-ID: <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch> References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-6-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240208184913.484340-6-mathieu.desnoyers@efficios.com> X-ClientProxiedBy: MW4PR04CA0197.namprd04.prod.outlook.com (2603:10b6:303:86::22) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|DM4PR11MB5567:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c080037-6626-4b2c-b158-08dc28ee328d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2+AeLm8L71hvh40J9MTFmferGjzrKZ5Ti6Dq3Mx59DmGLByJY6i84PZ0cv3OpRjoxhZkXFThHDiRdMX6ww41gElnHEmsCFm7xjI+DEO7xSj9BLp1U2xRNwrdAJy1VaD8bwVfr9rNqhSsQGvSOIUyZED6kgS/FTGf04aoArAA3SXQ1YDmciwdrrqfAvBydcukuywEPHculfKBCKfWjaGO8frvnmm2JQQXaR/KSI8/8PFHPnepD+kXq//gr6sOovj2T6pXBnN8Kt0OePhjrhk1vrLgOCSOFadGfPvzccR+Ww7T9PEG9doByS0wnxReHo5FObl0nztmmfteI7B8St51tuxkI8UvlZfMPpx1jW7mSaytH5f6LQsgedTPnhjjcvOS9RFAbBl+RyAGKtJ/D3eoC0cWkO9WB7TkIV8Pv9QfA031DotFEPa4wIKoUYmmC89/I7WoJ9/p1jSPkiCpzsCmiO8RnFYhMAK3Ptc+FJwx0eY1eXxFt5GY4bq7+0XP5bHJQonQVHvsk82MibEJcrv5566Ovka1ST0HeAS6xchO/IAB4nPc8f3hZtHISLlaw7GF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(396003)(136003)(346002)(39860400002)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(6486002)(478600001)(9686003)(6512007)(26005)(2906002)(66946007)(5660300002)(7416002)(110136005)(66556008)(54906003)(83380400001)(66476007)(8676002)(8936002)(316002)(86362001)(4326008)(82960400001)(38100700002)(6666004)(6506007)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PxebArmx3FaRa8AEFKB4ae6QibrEI73EJPI8j5kOA3sOkcQZTyfLcc8wgChS?= =?us-ascii?Q?WnxqkngjUIbQD0XKNlQvLs7B69jv1+w7KPJTvmfU3OZE331SPSMC5ID2QOpO?= =?us-ascii?Q?DGRbbVKjbusS/G8ga3EgEqq+YuIfYTUlTm8vR+OtdZ0Xrkc/cSk2GxTjn9kW?= =?us-ascii?Q?EI0PgSwteme0GzCI201y/zDrc4INqQ7F/R45XhBUc82wvEYgISH4ReFSXCpk?= =?us-ascii?Q?Y1qeUoWt4Jn+HtlXhJMEfyC52kePRCH1hDcQ2Xvw+JBMBGSLb2jtmPYYf4C+?= =?us-ascii?Q?ZeIF9HOjSeJ2dfZACX9HMu14ChRZQXNFFwREWiJ0Z3N1f0MGA17NzAfOskJw?= =?us-ascii?Q?Np+nOw1Y9uG5G5Guiqxr0AHwbY3rN+1W1i9Lthz+AEj3GgIrz7ws8I15cT2C?= =?us-ascii?Q?DyyKb8Gf/+kz86jP2azKW6G0S4GBt9Z30yXHHSMy3G3hXw3RHyRC90j6dFMi?= =?us-ascii?Q?46/JWPo/rXkvFe+YQQweNkX0BKU6JgVxAjjkiZOfH0Pbnz6zYXLcR3X/t8pL?= =?us-ascii?Q?0xD9GSRHKQQ5RFJPOc+g4XH257bjQ2L/EkKQVKrW+XQuG8oHIPysY4JEVnsf?= =?us-ascii?Q?utvhWsuf/0CkDIX2S42iB31yPAx1z/jG6Jm+bg2sb/Kh2KoMRunm1i3BZ7hi?= =?us-ascii?Q?0RgImjYQ+brthKvJ67BRnd3rkPeNTSh7IAju2zCfo+izlTjMBeBYRBzjSrBu?= =?us-ascii?Q?jjzJr7YEMLsrxGBQdbO6kbvXX2VJwAJXZziKp9+jH6UYZedRLc+VYaEuD56j?= =?us-ascii?Q?IO1YUmdnKDuaogRNXkVqiu1l0lDGGp/DuhBu4XqUi5PGCCBXlBQ96L5fJS5W?= =?us-ascii?Q?M2DMdbCv98FPZlI1VfRxF0pZb5dGeEskx9q5mhM9yKHVohlSJzpmp3DVngea?= =?us-ascii?Q?xwNwhCb6Cs2tS0zlYwmr5q4TJ+lmoHctcNQLr0XZwL2CVI84jbzpN6Az+tvb?= =?us-ascii?Q?UD9AbQ9Uykdpgt3rVV+8fgZH6HwZz+HI5pERVLTxlp2U3DrRXnz1qIi1rwnY?= =?us-ascii?Q?2D+kZHy0xHajTXSLT00B4reixVgS95q/BvQ6Ny2ODLlUrQVzGEmShkK8/9UQ?= =?us-ascii?Q?IjcaXH80qm8zr5tF75deBgPG0Oi466xe2S74b4/fOi6UczAHBFo4cR4ot7Ch?= =?us-ascii?Q?q+nc23ro9fPAcXSOGz1dsNZxkSg0Vq01g91fjmJyScYCkig6lwBtCzuh18bu?= =?us-ascii?Q?MjT6cH4h3ncQS8sRClVA3UbrzjfI7rpKaqfkDfC1wrtmX3sxLb5DlupPYCVz?= =?us-ascii?Q?fLWbN21KF+Pd2cpt0wNaoDzei5R7bjzWFZC8vuL2N1iJnMF4tJdcI1S9C339?= =?us-ascii?Q?ZcZ26CP8MI6Au2CqMBFRvJBhRYh8GGJGmTlZNSWRB8cdcTok3qxQPMcldrLS?= =?us-ascii?Q?Ep8l+dotmeXXbMdL1QQtIhTa+H8b2/dzmNwH1ax4J33xTQjb0zuF/x6CRJm2?= =?us-ascii?Q?IE1JOnaLz7oHHHyKCamjdUHBu5QFtlUrtdg+/mhlcJ1tP+2ovaRl0T2OgPqO?= =?us-ascii?Q?AgLAThVqzLSZRYyOaZGPm1E8kBf0kapXTn7tQlufMt2vpieCrZ0kNPurnHLo?= =?us-ascii?Q?pSmjanaNMKhLGIuv4S/9l68dB7Svtu5pArKxvRqmYpUstRAc+cTR1a3v5hOm?= =?us-ascii?Q?SQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8c080037-6626-4b2c-b158-08dc28ee328d X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:37:49.6424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZRCDhrFc+cmfPRXT/OwsfIflxsixqxAlO0F4NPAceWmVbu3S6l1UtYyupUcNqKmWy3CXC8diP3q6XMl8Vmstzt8u1lzYzFLeXt0jfH22JYg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 80AB118000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9ct5oq7ikmacdywk4zbihnuu6wpjrwht X-HE-Tag: 1707428273-469680 X-HE-Meta: U2FsdGVkX1/G6CyuocQt5pIK/LeHIy0EKeuR/KOpSkuTxDO8tvfzajj/NDJJukgI2YmYc0Z2EJT6VU4+jleotUFL/DtEJ6hhTLM6kXRO+EfhDKu15hvtKX+ha5nD9koYS2Wf5L2afmW4Bxz6BIfOjxiPCczGOGygpkFpTlkcEgm2B8x4Aks/xz8mzRRJe9c0DikBlEgxJj5phW5NTBUKwfUEgASyRPYyDtZf6YY3KEaMyr40TlqMWTTPmmsVPhXK00ITdfWQfPWlipOrt6H46j5WxrS46CQIaRwOdRcFcQpgWUIs5F6fL/Dz49t4Ed2HBox9NHt1Vb4LoaczwqH4QZmwAjB8xot/8qld57xRuOpAiWkJnovGETJsTJZnjD/QAriJuISZ5HTTueeeX15Px+7xcCITfrY2kKRmJbG8HngeI22I4f98Z+LAaylPyF79j3XTGjjPhUh4oTZGuLRqhj3aYl9QkZFoZYKlYLJ11rUGq8vYlq84M5x+8LgTrTZ/fZkNYKnK4diLd+2u+KR4U9dqWKR2K9/nsvAEw490X+/fKXVkFtHCYUtnktp1U5MVQG9VBcp/bK9z/R5rIrDTFOfd/6Ge+JnTWZczpvChfHU28EKJqqB5M3LBj8Au4UcMw5pU/2tLBJ6fKJzYHqi4u20afHaQ7KOgjaRH7/V9DKL72kc0n79C3iighiqsC4zaAR17UbPGmWbyw74kgqHjzcESeRkdTl2743v7XJFrgjJ7BOyp2MNCYEt7j5YaMWEl9tW920Bbm+9WrrIWsFPiN4SRQr9Ooh6qq9+TtBiXlkEF3aYytWAVL28+dwAicxHQTJiqxjqIXsHENZWK2s8WU1P/XrqJBelixACRxvrhrQRsmfRG6tXJbZI31XN/gJhIpKHZEMbsp/OpAZixrgBoyqm7+VzVNa10dKo8bJ+xamVrFwKJHmvk67Hwr3VmfJBuMIF3utw7rWALGP77UG7 GoX05oMg RgXExzUf7yvD66/5uYU8FG6L6QojiwLTWn/FNNQZx9CH3yjbfjHodpmJhmObnoc3tzIAZyDsTpLic09rxcbpAjO1YgJSqbDXFWfE35l5VrufNHmsH5B2vikZaH8ioMrIVuLf3FlDk/J0YU6aAlLvQJZBvjcH+VvWDnLy9KYu2zu4rxrH+M2mCVa0R8TFp7OyNGRIyUIFQ4vUEdzuZaut70QSFRpNe8QBJ/RvmcHXmvN8Nek6VmEaXqIsugP4V57MvSLZYDK8Ltu8oWnvztPmYZt+ur4qJU4mFyivq3OLD/DuMfG7aH7IqJqG1Hr2tkYfOIgdV97MchUeNMqDuBNX2tNXkbKBfQFlY2LCYYmBUgmynoP5ubgL4eME0aIzYfmSRxkZeOmfK9uXQou6HHND+Wyon9Zt24DMxSsIKcbQZhQMtlqqF33IAa4D9bJvnu5Oi3pK+CMKKULGNB4YTBGmfdrX3BS1lUKL2pBAIKSfp/1mP1jkT1m6Jh91anWU77Uie9G9SvZIhNKCkyItxEmOQn2nXmM50o1fm1XQIrB6eGNT3H1/etscbxJF7sW8ccdbigkjN5ncq7dAbLY+rMlmdF7TFlkPV3Ji/AHp/EbOnt2lOjJ1iQozXRLa2KnTUgGEKUHWKKjJRNzk4nLBvlBB92GgMRvMDoGQw37C72VADYEo2Jql/MhIDZMPBCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mathieu Desnoyers wrote: > In preparation for checking whether the architecture has data cache > aliasing within alloc_dax(), modify the error handling of virtio > virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as > non-fatal. > > For the transition, consider that alloc_dax() returning NULL is the > same as returning -EOPNOTSUPP. > > Co-developed-by: Dan Williams > Signed-off-by: Dan Williams > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > Signed-off-by: Mathieu Desnoyers > Cc: Alasdair Kergon > Cc: Mike Snitzer > Cc: Mikulas Patocka > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Matthew Wilcox > Cc: Arnd Bergmann > Cc: Russell King > Cc: linux-arch@vger.kernel.org > Cc: linux-cxl@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-xfs@vger.kernel.org > Cc: dm-devel@lists.linux.dev > Cc: nvdimm@lists.linux.dev > --- > fs/fuse/virtio_fs.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 5f1be1da92ce..621b1bca2d55 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include "fuse_i.h" > > @@ -795,8 +796,11 @@ static void virtio_fs_cleanup_dax(void *data) > put_dax(dax_dev); > } > > +DEFINE_FREE(cleanup_dax, struct dax_dev *, if (!IS_ERR_OR_NULL(_T)) virtio_fs_cleanup_dax(_T)) This IS_ERR_OR_NULL is ok because dax_dev is initialized to NULL, but maybe this could just be IS_ERR() and then initialize @dax_dev to ERR_PTR(-EOPNOTSUPP)?