From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D35C4828F for ; Thu, 8 Feb 2024 21:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B5AB6B0092; Thu, 8 Feb 2024 16:34:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 366536B0093; Thu, 8 Feb 2024 16:34:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B9646B0095; Thu, 8 Feb 2024 16:34:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C07F6B0092 for ; Thu, 8 Feb 2024 16:34:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CAF95161005 for ; Thu, 8 Feb 2024 21:34:47 +0000 (UTC) X-FDA: 81769941414.22.3941072 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf18.hostedemail.com (Postfix) with ESMTP id 977091C0009 for ; Thu, 8 Feb 2024 21:34:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=H69412+B; spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707428084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tg7xvE10hOpm5jxuCmhhZ3KScVtNQtple7NJ07FXD/E=; b=xun7+gfAd88uet/jturp2cLPGxI9WdgwRmLmmeo/qOMlEGtwEz3UdhB3ONqxRwdHzW/sXj OoN0W4bEg6yp8QcpP0yjv5XQJNy532vSdDY7KWKyWiCu7BjMEfyTvVgRObPmcybF2v7jaL ajM2GDlyAZTvfwmQ1HGQDfwOfGoCWfs= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1707428084; a=rsa-sha256; cv=fail; b=TZNq0kEUC5Ke/g7nW24uW8mWdQ3rqWQJEf3TFDrl9CtVxuDJRIk5tWQ1G4eGHYes2CJBX5 9VMlDdBAno2axmeLm4ATCUfZsbS58mEVX4ufZQ77g/BXKgXXPRz8j2fLDam5C/y+C7Dwmj J5QGIWln1RJqt0oXInIqNr0lzxx8kPM= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=H69412+B; spf=pass (imf18.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707428084; x=1738964084; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HVWHTwFPts5x39bVHT2Wa5fIibzIfl1Z06fK2EQFQWU=; b=H69412+B/QKPYFvTsxGRllpFXILq78lOksHHbXytOfJVvzWAV4zMQoNf zAC5RCQBPytRyy+uBZ+1sLoOmhz0jkFm7Pr8Rqu8W6ESZYKI0HN7LhOBR qGXKSbrreOqj6ECts+6WPqtLV830E6Fqx7C3uHbvd9pu9GoeG8SSQzqPm 5Mhtq8V6KeScGSIfkxHifYmsgz1aCdkmDkyENmHp+tl054K+0NliMhTkq sa5qWFIGMR7bytDStZHhVtunHD/RRUj88xxnSRsFq3XvSW48E7b8h7YkU YJvMI9nRGkOQMEtQuGcEmbw5wdZAW/RSWnpnjCmnrflaDQNvySkuV/Epk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="11971014" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="11971014" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 13:34:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="32843414" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Feb 2024 13:34:41 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 8 Feb 2024 13:34:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 8 Feb 2024 13:34:39 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 8 Feb 2024 13:34:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wm4op3j4Cc5aPwH9GFxSuPrqqaryuDTdrHiOuRxFD2V6VR1TutCbX1+sXEOqJ83DpN9FpMbO3PaIOoJm0Uh5epHDZjrtRo8n6g3rzGO4y8g05rXrWyAjGSS56NVIuHUGW5nso3PpwwfKybla05y8HCUQLEghw1DV5oD6T8T3wtC7cre3b5vehclFofRw8YFVAWijj+4fG8xuzpE57AI/68eow0qK6PjpEwvQE16OnC1E89AdHsXvu6YPp2t5pbdeXq3wtdOUJaNuY8P05xSwRn2EnEdqmkKuTrqvEm95a73ij5cP5yqUz3p+yfVlXyT2bnBRUwdUrXGlK5buNeG4LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tg7xvE10hOpm5jxuCmhhZ3KScVtNQtple7NJ07FXD/E=; b=g9DRrEW7sXhczlfQjigl67SkH+W6YCqle5MCP6KiQLUM/1e+w1jgS5Y1dxqgqfA+S3eYRZCHADVrlvLMgKfJaOuBlmH8EtjB0MJ23WKXMF1tugajKijhCFtaaeorxXXK2oH6HgCnQdfYp5q//tOsXSCHr+6sx2kawpbPKCeu3LFIBLahoWiB842rJyNn65lMUzRu0rYPuaQ03omSnprO/j7eN63Z7lZomBQ+FTgqTLebsDIBA64ksiE3WFKgzgguZFpaSO0ppK7ZA7KAQXOjoDycm/2vzXbiD63spKXd8V5n2kgMoW3t1dsk8hchqvPZT+0AgyNHU3cqO5ji+iTBow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by IA1PR11MB7271.namprd11.prod.outlook.com (2603:10b6:208:429::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 21:34:37 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2%4]) with mapi id 15.20.7270.024; Thu, 8 Feb 2024 21:34:37 +0000 Date: Thu, 8 Feb 2024 13:34:34 -0800 From: Dan Williams To: Mathieu Desnoyers , Dan Williams , Arnd Bergmann , Dave Chinner CC: , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , , , , , , , , , Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: RE: [PATCH v4 03/12] dm: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Message-ID: <65c548ea54127_afa429463@dwillia2-xfh.jf.intel.com.notmuch> References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-4-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240208184913.484340-4-mathieu.desnoyers@efficios.com> X-ClientProxiedBy: MW4PR04CA0157.namprd04.prod.outlook.com (2603:10b6:303:85::12) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|IA1PR11MB7271:EE_ X-MS-Office365-Filtering-Correlation-Id: d6d273cd-7dbd-4d16-ad30-08dc28edc00d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FcuW32EsjhY50Vf2OxkT1STdZzOuk2tBt7FmNCh3rQLmSM++/fxe9T1nIlY6sQ2Z5MMdjVVhMlCRAiDzVUgzt9v95LGgXWka97ti09sBOd53TbRnq2yajopMzW4PqDHlyheHlJ8xk8GRA/YKmHp/3qJaSao/6kJ4pFGJK84sByiC9CyR+27gHfXNRhyjOv3esL8ygAGzoepCBWQjSCK3QotJgZaNiuckKzuPnC7/Kx2uOycd/kj+C549zqYzatx10ekdvaTsCwhmeq+3dHpEkYpMUL5ROr5VFcSl1j5thMKsgE8PcRe4g04m9vsYfiGfip0zt+midRQ2MeaGofxeomFgQa67ZBS5VP7yV91g7fv1JvgxvNvb4U2GBnijgqY5te1tsrI1W1C2ZHTlIkBC7rRDmLqul46rDEVMsjy0IHIaKBlKuRurGnJsG+nn2fQwzJo0X93E2RbUIWRuCyuCIQyx1EuvvstEObENypXvegW+AI1514tyJro+UK2kjVTzB6xPATfYXh/NaVAAMEkDKjuujeNmDu+bzUHhniROMM9vnXJL2JrGgoZAoS3BkSTT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(396003)(39860400002)(366004)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(2906002)(83380400001)(38100700002)(82960400001)(41300700001)(316002)(26005)(66946007)(54906003)(110136005)(66556008)(66476007)(7416002)(4326008)(8936002)(8676002)(86362001)(6512007)(9686003)(6506007)(6666004)(5660300002)(478600001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/IGLDEBbUqiRFg5sojodJg6kcpIWtN+jc+Jbbn44hd7DbsLBNqgvPs672zDJ?= =?us-ascii?Q?LpauYE6hOltKRlpGgkQLVbK9dZXGvjbB5ACx2GAJ4uiBQMX/CvTt4aXfrzST?= =?us-ascii?Q?MWlf9FDLxnj6b7PiiZeUf3qYcR8u0sBezVDqfNVuldkoVcvN7uCl5UBk4N7b?= =?us-ascii?Q?2M/754zBaX/2YPQNQxxPo6z0mXS3ij9FZUjxuoZubj7xzmQjPJQiD6ZgHGRC?= =?us-ascii?Q?569Tq8hNKN03//ATOU0WCeXKnQ3hY+bpm4QzK5tUEECoUocH0LdcftjQ/rkw?= =?us-ascii?Q?6nUU/ohVjVtTwTTRSGyshEs1bJQd87KiTJQNWhKNHCadUUu9WcJj89Kf5N6R?= =?us-ascii?Q?kdeDsKW8poh9HIiYuW1BPkegIyxUsJHM8ZLyRkO3DQrdjfLX1s1v6M8T3B2f?= =?us-ascii?Q?Khamgzsb23Wf6U7TjthF/5UG/0lxXwYsoXv/FdYiFcG2jdCGbXXNJA4cxfmB?= =?us-ascii?Q?RaeAC475xi0sLomc62OM3H4B7BrFk2EAi4H4J48zT8ueKDPwC+tCo4aoja/Z?= =?us-ascii?Q?tkpld/Bf6jX3+4+3emsKgsAkTXcSarcOpKy+IV1bgPwZlLHh1nj5iYrZ2yKQ?= =?us-ascii?Q?1hSv06JUfu4J+fKMaCVMj2Y+HoNcR52klgLWtVudRa9Dd0dBMaKwxDd4Ej2U?= =?us-ascii?Q?amrle7clPgxY8QlcIUqoT8k7zxELEky+WTSXul4ZJ3yac8pKFBEOy2eJtBUd?= =?us-ascii?Q?Qj8B2qw4fE86D+CbZP80UoOpIpVJo2vFW4FVucKcSCMU3831fPhVfC00JElC?= =?us-ascii?Q?asTzm47HCHHlkW3czZuDAaoKySeng07QOxQW7cDCVwuWQwY9H0vgHCd3N3ZG?= =?us-ascii?Q?mhkcl+BKdfowP65g3Ek8Kgj0QeTOKtfhPRtrHGtoj/Q99CUQits1awsZZVsp?= =?us-ascii?Q?IRZ9bDWy4qVxE4rvb7Lwc3gcDSNIvKmtsTl/gRqxUfOGGjuQSapa7BDh+wNU?= =?us-ascii?Q?NemKbWUStXjgFZpUxCi8H47fATYzvG1cothVMTvh+xO9KuTT9VR/VFw9rNZT?= =?us-ascii?Q?WOVI3z/59+3qH4sKYb8TzNHxEqGF2wgLeXwyfYfkfIjNbM3OwK43DH0YSaB5?= =?us-ascii?Q?V/qoXZj9TWP/dO/ihwsdqidredFh8n2Le8sSt6/xBzhUhl9CWdMQ8BMoqP8i?= =?us-ascii?Q?70abZkCE0wA1oBUVo0aLbEIujDqkIzM7RFhmEFtSkUdcmDug+BF/mnx3zdgz?= =?us-ascii?Q?6jZLju1UnKJJbCzjS3esfBKJQewFJcoQvVXLJh9alEyei5LusV8fpO2HFoUs?= =?us-ascii?Q?iSHCWtdH6lzlxxsSw+QUEZ+4RTDzGeWaBHeAAcBxF7WpaVCuhV4RCHTmBRdz?= =?us-ascii?Q?fpbnGizGGOlR8OCUz0rdxJbBXkBNf2OVnwPdO8SKhMsj1iwgy6sd2TRFV1wU?= =?us-ascii?Q?qo/Bf2Xawd2rL+XqV79C8vnPAxC5yBZiIXTlBhizJBUT3DRIPi8Av/u69zOa?= =?us-ascii?Q?J5xav9GBbWsGmqs7Ub8Hj/2OQVULsu7lTvglUoGViNj7HYqsADyahgAMXgBC?= =?us-ascii?Q?kBS2DjGyaZ8ddvB/u/lMjbK3nUmVeVBm+WeUcKnC1LlNcZmXnU1WiLLII+KY?= =?us-ascii?Q?JQPLSJ5hPTTGvXeRkqJu8h+8E/2zdcjE0p7JZq33+D2lqLLNS0IZePhkfAJZ?= =?us-ascii?Q?aA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d6d273cd-7dbd-4d16-ad30-08dc28edc00d X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:34:37.5198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wYXHX08hjFVII3EKOEySlTQXyLvfCnphNr5FXwUu9M2TiyyoEasLMWqJ+Sui9nYEYR9+NhSjOw/EHf9sYz0eQkRhtTpnzZ+hUoAdqD+/Pic= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7271 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 977091C0009 X-Rspam-User: X-Stat-Signature: aqr5mfyct36c14g5im7ecqqwuxm73f67 X-Rspamd-Server: rspam03 X-HE-Tag: 1707428083-807737 X-HE-Meta: U2FsdGVkX1/JhUtBI19ZdRtLlFHE6a05YrtNWJbIF0Me1vLodSzodg6zURKSpUdPbOy4u08CbH8fPlL5qx0E2DZchcoYjOgQZMgypAyIMYSAWl5/cmx+IBtsLD4poCFrYToHOT/0cocy6XOfNQ19RvhXh5zXGzFfEwSiVlpr+cRITVc+gzs7791P2WcvhfoP1IYLfCwzTTuQ6i0ypQrGy4iICkTndWFtSLqJUyXVb3479wBej9iarBmHFxnp/OZ1RNHvIGwtcS17K/XurWW+ksMfKp/+kpVWCQLKFJjeBzsjtDQBskHHO0wS1lyvKniDDrdSIYIOki2SuncUBFn1WCyAAbk2Cu2CIsTql1TGLvTGytEZPOMhodB5NkH0MFK8ZF5FN3wg21yOIp+oSWDn3swD52xl5V+kfVJrxesjoREJKGJf9KQrEKNxUpu+up9PEnZdrObzWErrTiNQAEUbg/ua8eu3SRvXsyPSrLglYqOgt4Jgzi0efNdfT/oCEWbjDvbgPBp57xwWeCaQ9VS2eDGpIdbOl/lU/OcRpENNqdWzzZfwU5JUtiQ5yn1oCo2OF97liaM5YVO/PSaWUv7Pry/MmdZF5CbzOngGETm7HahtNIL9fs/PXU7NAtOVfkzKvfpFtC35YX/rAyzesF85rQj6TuQM5DYI1LLC55P5DdjHFf6qjccrJFZMzDT5Iah3Kxa1wYhee7wV+C+GHlKuwXV9ShmlIPIkQVpyFy+iqYQtcKs7edii6Fv6fna/gcufqcrXuHhXbn7/1JAcfCAjZNdOC3pqnsRmFJBxAgPmysifJqMvFb7y40H/qJkR1MOqTFV9uZIGASDdYHnXNv5DLgFjgJbmqQP5g46cSJIFOVY0FfiIARLULhNqR6YhnJwlUUSUYl+CLr+YUk3ANiAqR1qZVAEuNJtu+v5H8bs5fPqRI1/VB7TCi1Ig00Zmpyp6gQ7fovY4/j1ZGFb0+uM xq8G9Pnf +lUGHl6iePXVuep66FcZPkmiVgmvjUxMG2QgmgHsQykSeXpPr9LYgEZqCr53eU4Df/pSPlHC31eHQ4/QBmnNqdqPKn5sNItrrAary0BKtbG7+N8PcpdVCcyQHip5dq97sgTTX8k0OhRO+AnHU4sMqNawQqpVRRWbyeoJwlEHwC8d32UKfF5lLNmGgEYYYWdvOgKC7lFjSgElBFeXT3dFO8JfBegY02dEA/dRwivn30o2Squipng8esiljj6uTGXCB16VxYGeN5nObWktOa0sK6weyYYtnvZmbJi8EKhx3C74ULRAfoWe2jnXYkhyulVfEpFrGKzRqDj3sBUSWCPKvCWAdb091Bv0W+Oo7kL3wOLRGXDJ6wwQkHsc9nNztaoza9gSVwkao7k97reYfhqcjNJxzcvCY4CEKJWVZ2ZLvLrQFZkHc42Zo1QGxYG7S+uo5RvPcOJ8//p0372x9a7n2wd1G6o1WxKo+OqDDJZskgKsRqJlUoQQmRvLUJKhLupQJIS9kBQPU2vxomIxikQUTp+ivluDYlkwQzadIrfsOSem27rpVGHJOGRihpjKl8hkBWFSQPItIlBbhwExbENfRIAiY5TeZGl9n9J5UuNSMtNFvBDCjjlFmgY2nXcb1wQdQE+2DOIM1/sUNx/zg89R52UWcrObjLIIB0BqSLEc0AfDvuTB3QR3Q/GViwqojpH7dr5HuNe48CVZGmN8O38WsbJ5PuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mathieu Desnoyers wrote: > In preparation for checking whether the architecture has data cache > aliasing within alloc_dax(), modify the error handling of dm alloc_dev() > to treat alloc_dax() -EOPNOTSUPP failure as non-fatal. > > For the transition, consider that alloc_dax() returning NULL is the > same as returning -EOPNOTSUPP. > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > Suggested-by: Dan Williams > Signed-off-by: Mathieu Desnoyers > Cc: Alasdair Kergon > Cc: Mike Snitzer > Cc: Mikulas Patocka > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Matthew Wilcox > Cc: Arnd Bergmann > Cc: Russell King > Cc: linux-arch@vger.kernel.org > Cc: linux-cxl@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-xfs@vger.kernel.org > Cc: dm-devel@lists.linux.dev > Cc: nvdimm@lists.linux.dev > --- > drivers/md/dm.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index 23c32cd1f1d8..2fc22cae9089 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -2054,6 +2054,7 @@ static void cleanup_mapped_device(struct mapped_device *md) > static struct mapped_device *alloc_dev(int minor) > { > int r, numa_node_id = dm_get_numa_node(); > + struct dax_device *dax_dev; > struct mapped_device *md; > void *old_md; > > @@ -2122,15 +2123,15 @@ static struct mapped_device *alloc_dev(int minor) > md->disk->private_data = md; > sprintf(md->disk->disk_name, "dm-%d", minor); > > - if (IS_ENABLED(CONFIG_FS_DAX)) { > - md->dax_dev = alloc_dax(md, &dm_dax_ops); > - if (IS_ERR(md->dax_dev)) { > - md->dax_dev = NULL; > + dax_dev = alloc_dax(md, &dm_dax_ops); > + if (IS_ERR_OR_NULL(dax_dev)) { Similar feedback as the pmem change, lets not propagate the mistake that alloc_dax() could return NULL, none of the callers of alloc_dax() properly handled NULL and it was just luck that none of the use cases tried to use alloc_dax() in the CONFIG_DAX=n case.