From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E3AC47258 for ; Wed, 31 Jan 2024 03:13:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CF1B6B009A; Tue, 30 Jan 2024 22:13:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87E9C6B009B; Tue, 30 Jan 2024 22:13:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F81A6B009C; Tue, 30 Jan 2024 22:13:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F0FF6B009A for ; Tue, 30 Jan 2024 22:13:19 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 30D4D1A0C3D for ; Wed, 31 Jan 2024 03:13:19 +0000 (UTC) X-FDA: 81738135318.13.F6657CC Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf05.hostedemail.com (Postfix) with ESMTP id 9485A10001E for ; Wed, 31 Jan 2024 03:13:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aAVLTFRv; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706670795; a=rsa-sha256; cv=fail; b=6U+OM23ZcLNMvja43T5i+/neYGlHXTddnCW7Vuw6Obt0SS1KWuAxyX/s3L/+s9ojlQ+WeQ 49gFnKMHnSg+wmZvxvE6GKkpvEUgd5TVUEyq+OdGsY84BwMHlNqYSgbeSC3laTke92ZqVE FQX/D7KHKeXK4mWsnp1B8z4hbFOB1LA= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aAVLTFRv; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of dan.j.williams@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706670795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X780JI5Xsj+7yZEfLGUFUJNISnyXfXUFQ6EZS2GoIjE=; b=Fd8yW9MsIkPOQ8HdyAs4x9jRrnRJzqriS0ipiK32ARvcjlFHHyfMpAEMAYz2y9JyhQOJay EaoEbyAa5bX505azIXmgoKq3aOh9GghEdDchxtFQQ6RFjTYPVysL1Hi6ofn1MLRLsE4GV9 jlOQI4YsNRhlGm9DxVcgX5IJeq8C2f8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706670794; x=1738206794; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=i538GwV36CPC4xlt3uxCFy0yvg6emjTOJxYtyWdG4pc=; b=aAVLTFRvlJKTYEQ6Nmedpg+e6MOpOEZw5TpmlX9sIT/fdGkvG6jAT1MS hKAVSlNq6P/lnw7D1Hl0PtTlABcnZkO29KRCnvFDC84ke0d/BaCU4nUrc 6Wa96heQ2X9nnsGMJjMdnqNU6bFIVDugJpUh29mybTym+Qn2U/5qNg5t/ 3Zo1GoC6Q0bav5UWbX/Hlq3BUeoYoo5PbQwlpP4rvneiSziPXnWymOXab HJw3ZSipQEDSef6eRX9vrlyfZkB3KMnW02WwWvL+6/WONTkLu/bMzApNT cX4FaOmI3QdBjSpk4ZwSH6dyJ8V/XfV1Jstgu3BnZw2q7S9rvR9317rqQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="17001696" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="17001696" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 19:13:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="858670975" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="858670975" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2024 19:13:09 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 30 Jan 2024 19:13:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 30 Jan 2024 19:13:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 30 Jan 2024 19:13:09 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 30 Jan 2024 19:13:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBc54Mu1c44rxrGPUVUhYpqbVzZJlnWSdiNpWMaspIUgsbuifh3vkrJHwuym+j0/3WDLs4XANHCm1abvg/g3uFBI2w3Ux7HH5TeLDTnZVDQehrPiPK9svHCz3Ja+ZtPNv4Cfr2Le8eYcOG1X71g/d3/kwQSQ29ClAw/rY6Qy/4kvSCRNLfl9ymy1uw5UnV9AkWCFpmhHaehpOx3rpvZs/CZSY5D8Fli8juRwKpU959Lwc5u4u6kWPNV0NQSpeHJAM4DZs2ij26EKvswr9I4L3SBWWYL3uKegfibSd1FDo2X1A9CqXlNLLawFO9DiIAvk4ofzzKWUzWdrLjRV9UyUsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X780JI5Xsj+7yZEfLGUFUJNISnyXfXUFQ6EZS2GoIjE=; b=l4EQZYaeR48luLXCNl9k1YeAjRg6TamSc9iUYqw+5CbBM2I4/NXRRCKbLaLBUwqAxIlThVqIkEtKUF3pWEmkQDittL9C/PHkOmpurYkG1JzHC5HKxSoqCmKGiBpUAo2P8fZlY9bszs6NUtU3R84i2Qrp0k80lYH7VNNiESx/sOugDgPYPim7iGDtgvqbu9N79roOhAEqdrWqthyjhE7b5hca9Rd2yaO84fFmX71lNG/i3XIHptekG4wMwrZ7zl/O9Mj9m8fjSurRftbq2MMJR+y/864DeefmJAacHtpXPqFbxheQKckzMTFIYqUPlb1eQBkrjlOVWJNB/CuHRZG14w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by DM4PR11MB6407.namprd11.prod.outlook.com (2603:10b6:8:b4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Wed, 31 Jan 2024 03:13:06 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6257:f90:c7dd:f0b2%4]) with mapi id 15.20.7228.029; Wed, 31 Jan 2024 03:13:06 +0000 Date: Tue, 30 Jan 2024 19:13:03 -0800 From: Dan Williams To: Dave Chinner , Mathieu Desnoyers CC: Dan Williams , Vishal Verma , Dave Jiang , , Andrew Morton , Linus Torvalds , , , Matthew Wilcox , "Arnd Bergmann" , Russell King , , , Subject: Re: [RFC PATCH v2 8/8] dax: Fix incorrect list of dcache aliasing architectures Message-ID: <65b9babf6b3de_5a9dd294de@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20240130165255.212591-1-mathieu.desnoyers@efficios.com> <20240130165255.212591-9-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW2PR16CA0058.namprd16.prod.outlook.com (2603:10b6:907:1::35) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|DM4PR11MB6407:EE_ X-MS-Office365-Filtering-Correlation-Id: e100dab7-843d-4c85-14a5-08dc220a8b4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tnhv2tlEXlNFdwXnZ6j+MMqVWkuNEE7srhn406t2pVendERn3n1CtwxFYfDrLFbDdOYFp7cb+k+8adhZBlHn2DpTmtatkywhdQN6pI4IZqsD7jgv2KSppa/akuo9O0we4SZtMWospdXiqOx/moeh+p1S1scyVcZuCxr3EklnF/v5iE9M4Z596DE8zSLWxit51XJh0L/BFo39SiCau4QkAKiZA3ovuMo3/ZoBzX8kUcxWs0mPzDbZbVFoPkHS3YH6fcKodbfnnVD8SpYZ4PDaHX9C2Ky+G3ZxB+z2QtiZ5ImvcUTnFjA67e35iRdO9yLzvIj+R9dkJ3PZIM+9kk71IqQVxjb+t2tShssMlYZ92Srb89WocPMSV+NNS4NDwWu1AYffwuMYQA4OwIh6k3g2my4tcpwGCj1SntTa6JVsyjJvR2B8HhUaQFVk3xMkZ9QiGud4KrS1cJIuWMdQc3CEEDI5D+ym7ynbMV80TOxCRgSIuVhn+nTdzVg7fXf55Us1Qva5MNJqi+aAqq7+tg+HmRKrvmnqHrp5AnDdUagCH/UpZWMJlnErNcdtUKKyJQF0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(376002)(346002)(39860400002)(366004)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(6486002)(26005)(66476007)(6512007)(83380400001)(478600001)(66946007)(9686003)(316002)(54906003)(110136005)(66556008)(6506007)(6666004)(4326008)(86362001)(5660300002)(8676002)(8936002)(38100700002)(82960400001)(2906002)(7416002)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lfVC0cp+HqyTzLtRl0v/bnPNhjx7hUzehDtArC0jzgrlwYAPRlcXy1uioBIP?= =?us-ascii?Q?2fZqP6kOq2zQ1zVHZDBBmVORwhsGt4nEctGjtOrwWsevzeC8IH5K31xgFlzG?= =?us-ascii?Q?tO0ionj+nLdExCkmJM+X5cvJWHP7DQbMqqQfY7JI53nYXZ6/g8EUa9ZDCxgr?= =?us-ascii?Q?UNLX6m+6EETff4ETSJNZOjsixxpptW748gzBsvbKm3LCu0uagpRctzUTyrt/?= =?us-ascii?Q?OVedPU7MsGKkhytwJivbupkp5+/6fBREUQm8CPKTfsR60n7wF+fV5gGuxFPA?= =?us-ascii?Q?nPSfOYVC4NUu2h8yMpBelUp09siyhhq7k0dqZZKEX+Q0om8mn8FMzsz7Cold?= =?us-ascii?Q?t8kQbm319BFkHqkGq4VwqEjAc0Vsyj5JerDjY14U5y85xDQ+3fpJBIU4flTO?= =?us-ascii?Q?4ATQfGPnW01TfEJmn8a2LWt7ww1QC9tP27Tb8GP9DzpMNIHqpiRAjPF9zJTi?= =?us-ascii?Q?rWfwvSFK5yyCsZtw3reN8wl/IdGqlp2D0SLVkt6o8ERmU5lVL9vlA6eiRBf8?= =?us-ascii?Q?PCrdfsLT5qtIgfdo1VFj7LboH+uLCwImdWJHFKjpQi34hN8UK7by5jmwtVJ7?= =?us-ascii?Q?PgpoRcJ6ziL+OVnURYRzfF0H3rhGmoWKgXKfUuGfMHqrDUgaP/ATRpGkDDqs?= =?us-ascii?Q?i1Bg+0gGOz8GnjegqtFmQT7VDSfvBO9YEBTmuKTRaG7schJCBaJAYrWiqYjH?= =?us-ascii?Q?L34px405fAP4GrkWDA7nEsB06sbMf7uU/CUFAwapr2hBQbRslUX9+nWTqAUJ?= =?us-ascii?Q?zwYp+WE4XmByJi9kekD52Aw1e7ARcIjp6Oed0KuvANDe1jz4JtdE+D3CWaTg?= =?us-ascii?Q?P/rYrHvBF4bXob9ZB41HMZrVlBQptw4hflvT+yaJxygkB2xirDYoaHJm+msD?= =?us-ascii?Q?BHMsBMwG58r3H2dPsiUVQtO7zcEg9E738MX6UxN+d28vPvbinKDb08r3CU4F?= =?us-ascii?Q?3E5jVgX6FLsONOmccEdlulLIcyrZxldEiZXuCjgXtl4M/KRuQWjxfSQO7ZlP?= =?us-ascii?Q?1PjXnlQAp9ubSHZKEc0rR45I3bTz2fk9XcdddoVXKohlNbvCZv3xsllTYSb2?= =?us-ascii?Q?hrERY4GxWrOqISUDmjiGsDCQata4bdNPi04wyf2C4rh29nB4t4bEfg7xMfV0?= =?us-ascii?Q?OuNNY9Qh4gCpyE0GlYnWBgABZXbjfSfyDlaRppq1XYhBtOOySAhm+LyYkI3m?= =?us-ascii?Q?n+6X0RzrCMZb3rDqremId+5VGr3PfkJPI9/qfmfAej7vTKw4yqfobosoHOyR?= =?us-ascii?Q?JgIjSM8gjMXGVO7Lyw3FTtUI0eDsuqfSIC45icUg7zo6tldVvtO+sCwaDO/g?= =?us-ascii?Q?Kmjj2naiYpUkLGXe8Ai5PEv335nJUY+lbmAmPJ26LZepoop/mYR6eDNW2Cot?= =?us-ascii?Q?SRNeg+OHof3P7Lr5biOjJzwG0Ui+3kICSP1dgHPuY9aif0Z51eHkVmeFQIN4?= =?us-ascii?Q?p6nEIlCwGNefRu+Cl3PHWK9TshiPaQsikF/Uud7bbD6HmKgMl2kUUKG99z0I?= =?us-ascii?Q?FU+KVAMeaCv3UCsNza/0aGtKUe14RQ0JnFFeCsGblv6O4z38plrWFSyV/au+?= =?us-ascii?Q?2SqMXJGFQvPDjmAPbXQLbjt5mo96KHkQOF3TCpebDBAfwi7PboGKbkwlWhB4?= =?us-ascii?Q?6w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e100dab7-843d-4c85-14a5-08dc220a8b4a X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 03:13:06.2790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yMK7cnopuTv0VGY9rpz0VjJMhExERLGu+8Fg+Fn8a8IrbDzNculJ1Prdf6u4ZoAyamJiDWPlhm0ov3agtAmNgjW/KaNDoCQ0QrkrRvRRfKc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6407 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9485A10001E X-Stat-Signature: j9ozmrxo77be4airmgnbhmjqraqh9z7d X-HE-Tag: 1706670794-199280 X-HE-Meta: U2FsdGVkX1/F5IkkUdM4bDFjxST8Nj0Kx6XQK9DlFFjYhWort6M8UpU+oe0h4Sf2J34Rr3cRTO1e1SbJ75C6BPmU+/3V5QSutIxkDDh+t/MbqiUjd/iySxIFAIHdFNG9D6DnU98d2HanuVEzijELu++axbMPpY3qNatM99Gj9+6jgjuWaqgaL7lBREJ79A88wLqzLkfwpFp2m6n59q2HBbXAxXtgDC8ALZjGziTHvJTzS8aJx7FHQvFGi5HOUF0igqohbuUD6rB0lMDqk7aLFsfYh7l4uNTSOmWKFuxyJo+NbUOjOZk/sblavKdNGBDz6DxKZ+DTQPSlfG8Ztm5T2t2hC7Kf2jhTuQzXlTssfVhkoZS6Xb9peVoH4aRlUa40CIz8pOJapsGam2jkHJ5e5JLHrSrNXSYsVEdAVhVnHGDghEItDzJVw2h3d+6NkW2BYxK/4J5Q/zJfEAaz2J607BbXS15cwpSTyVGbt4i7ojUBwZzPzvTx//I0z2pI9HW0SfYbS45MqBzmM7yE5S/PcW1FXhr6VfbHgvoagOaHbHHiZ6X9kxtR4VgQ++lPt5lxCKdXDY094vdg+CkwJPDPsNLbdHserOzssigvc0LaqLsYv5C3bmMoF4fHLPNDlPS3pxTLoJDG/UcMFStt+mcjCFlkfJ1vrwWwjlBKoq5XUX9FSKP1pLXqrpqSHlb7sw7Dqg92CyVd0GEShGu5C39YnAkstfkV0kydUN50V+LfRoQcUS4JXyG+szUvIouLZcJ19+2axjOBQsg6AC9/ozgiBEGqasx1HoPgGHvS9K0e1xe38btSXDgDfLDfUzaFJBIL9ZwWeUiKPKSxp/9Z19fr+CooR7wO2wypHSF70q5aIr9r5sznN9UBF8RKkIhKf/nzShZXSZdlUaqgD1XniqS3QHNHCfbFDJgI896IOmcLRNxPE0K1N1olQQwXqUJaV2qvM6uJvNE5CktfKA3elHG SPZx9uqR bHzRRbQwwQtBecwHTwI0cIBXFI/NEEWW52K9Vfsy6QgK5x8YMpA3fkX7Mw7iZ7y+IMg+wbP8pnZh7mcym6jPRZjGn02ePf/8CutJFuFuSrwDiMQe/68k2Eb/aLAv2CeOSDKjqz4t31+UFMPiQ+eg/FZ2ajNIv+HX1ppr7OLtQso0hFRkhve85T4eZb3ONgq71+b6NbEF4PKrNN9JnekD5QMKw3Tob9+cz6LV/q7IJy3JHsXIKj3wNLHK7efAD7ndSSyk/yHZ39u1NcMdq3lQ5SEWlfyt1gmmH9g3bquJ6QNCLX5bzAOBytwnLVyfwccwAQAuTWcMr/lSsJP8vY2mQCCDZ7zSyAA+UqEzNvOKTjjhEpOdal2eKk32xJFMoFTduTakIaof8D1EqdBcXfD8jAn0nPn/olvANh4ABeErqo8r2cPKDreaRPuGnR6h3BLz0d5GxBVV5AFu/GrwBqVrb9BFh45b5Dd4D1iee9mH5eEiNXT5ljfgJVV8ChHQvgdO0u2+o9kaP973N8GF5em9KYCLnssvUkcYRoj6s2dS99WRvHDFVG1k/uJ2eohShQYXbALMYo7rh5z0ypwU/pw9vB1LyX8iq8XfM4Xct0h1RJz59vFkeKE3SLQe+5L1dPGwg3suxVv1f5LTvIKVt3qfJqkK0jwfK9llkOkF5caHWJAVmK9rMf2H5k1all4bHnYSnOTeAZTot+Ha0mSwAAKkcu+9QaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Dave Chinner wrote: > On Tue, Jan 30, 2024 at 11:52:55AM -0500, Mathieu Desnoyers wrote: > > commit d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > > prevents DAX from building on architectures with virtually aliased > > dcache with: > > > > depends on !(ARM || MIPS || SPARC) > > > > This check is too broad (e.g. recent ARMv7 don't have virtually aliased > > dcaches), and also misses many other architectures with virtually > > aliased dcache. > > > > This is a regression introduced in the v5.13 Linux kernel where the > > dax mount option is removed for 32-bit ARMv7 boards which have no dcache > > aliasing, and therefore should work fine with FS_DAX. > > > > This was turned into the following implementation of dax_is_supported() > > by a preparatory change: > > > > return !IS_ENABLED(CONFIG_ARM) && > > !IS_ENABLED(CONFIG_MIPS) && > > !IS_ENABLED(CONFIG_SPARC); > > > > Use dcache_is_aliasing() instead to figure out whether the environment > > has aliasing dcaches. > > > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > > Signed-off-by: Mathieu Desnoyers > > Cc: Andrew Morton > > Cc: Linus Torvalds > > Cc: linux-mm@kvack.org > > Cc: linux-arch@vger.kernel.org > > Cc: Dan Williams > > Cc: Vishal Verma > > Cc: Dave Jiang > > Cc: Matthew Wilcox > > Cc: Arnd Bergmann > > Cc: Russell King > > Cc: nvdimm@lists.linux.dev > > Cc: linux-cxl@vger.kernel.org > > Cc: linux-fsdevel@vger.kernel.org > > --- > > include/linux/dax.h | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/dax.h b/include/linux/dax.h > > index cfc8cd4a3eae..f59e604662e4 100644 > > --- a/include/linux/dax.h > > +++ b/include/linux/dax.h > > @@ -5,6 +5,7 @@ > > #include > > #include > > #include > > +#include > > > > typedef unsigned long dax_entry_t; > > > > @@ -80,9 +81,7 @@ static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > > } > > static inline bool dax_is_supported(void) > > { > > - return !IS_ENABLED(CONFIG_ARM) && > > - !IS_ENABLED(CONFIG_MIPS) && > > - !IS_ENABLED(CONFIG_SPARC); > > + return !dcache_is_aliasing(); > > Yeah, if this is just a one liner should go into > fs_dax_get_by_bdev(), similar to the blk_queue_dax() check at the > start of the function. > > I also noticed that device mapper uses fs_dax_get_by_bdev() to > determine if it can support DAX, but this patch set does not address > that case. Hence it really seems to me like fs_dax_get_by_bdev() is > the right place to put this check. Oh, good catch. Yes, I agree this can definitely be pushed down, but then I think it should be pushed down all the way to make alloc_dax() fail. That will need some additional fixups like: diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 8dcabf84d866..a35e60e62440 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2126,12 +2126,12 @@ static struct mapped_device *alloc_dev(int minor) md->dax_dev = alloc_dax(md, &dm_dax_ops); if (IS_ERR(md->dax_dev)) { md->dax_dev = NULL; - goto bad; + } else { + set_dax_nocache(md->dax_dev); + set_dax_nomc(md->dax_dev); + if (dax_add_host(md->dax_dev, md->disk)) + goto bad; } - set_dax_nocache(md->dax_dev); - set_dax_nomc(md->dax_dev); - if (dax_add_host(md->dax_dev, md->disk)) - goto bad; } format_dev_t(md->name, MKDEV(_major, minor)); ...to make it not fatal to fail to register the dax_dev.