From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC1DC02192 for ; Fri, 7 Feb 2025 09:01:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F4826B0083; Fri, 7 Feb 2025 04:01:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A3A26B0085; Fri, 7 Feb 2025 04:01:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192EA6B0088; Fri, 7 Feb 2025 04:01:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EFC3A6B0083 for ; Fri, 7 Feb 2025 04:01:32 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6884814176C for ; Fri, 7 Feb 2025 09:01:32 +0000 (UTC) X-FDA: 83092555224.24.CDED89F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id A138318001A for ; Fri, 7 Feb 2025 09:01:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738918890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opTlzMaKUcpoUU/ET2GEqDEa/C/GQBzV8UVg7jIrSmw=; b=7pPkNgJEe4r/IDp0XDXYveB0EdVSX1cIOdpUaIOwsmcrlbPYnIxSeH2QwIxg02gi16zjxv mMseyK6AetZYrZyh9vKOXXOZhb/BbyYgllXjLudzOkb/mvyWKSqr226wN+2XbCHFiXU3yH BFsqSfku8+5/iRjXuhC9kKPhD3QiPB4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738918890; a=rsa-sha256; cv=none; b=Q2xIw2M2OIX7qNn1wL4rk3xeyR+TdVKFMBkIekmo+N224GheiDtu6SL7HQvZpmVyTmpjTO /kciaTdA9OqhRwxO0bvTS2siPCkuORrujMm0dUQw6VKRt4e/BxtNFcHVMqEFxrnUl1eeDx YqAI4WJp0YktFPEj7gFW1cEJBD9M17E= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1E3D1063; Fri, 7 Feb 2025 01:01:52 -0800 (PST) Received: from [10.162.43.18] (K4MQJ0H1H2.blr.arm.com [10.162.43.18]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67A583F5A1; Fri, 7 Feb 2025 01:01:28 -0800 (PST) Message-ID: <65b52d7a-c913-4f62-9389-d097c70f4281@arm.com> Date: Fri, 7 Feb 2025 14:31:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/secretmem: Bool type variables should be initialized with true To: Liu Ye , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250207074237.193775-1-liuye@kylinos.cn> Content-Language: en-US From: Dev Jain In-Reply-To: <20250207074237.193775-1-liuye@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A138318001A X-Stat-Signature: 4kt1chgjw18rxwcmnd5r784rppknuahw X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1738918890-119470 X-HE-Meta: U2FsdGVkX19U9aUVJvqfeExtjPlMY+0GnzrOLqUZ9Suzh1jr9lRo6lIfTH+SeTEz1rqmaoE+pYoZfPE/LBNU7WGoagNOAIYgzn1WQdOOmDTxC1/AEP8vPEwtQWJVOc6wVrackuViKc/1+0kg+2jW76rs2xlff4ENo5+rO3vy6R/136+edFh3piF0SLVdxviXmq4qpTjufMfJX9mAMMrNGnpfVLymE1k2dMN3+1RWw3Yk0hP6mSiC+mzWxXpPT/Y8Wyf1pSg4CN5LrsTc8fd7g0MYCyAI1dgE6H5ctq7a6tsVe7eZmQxWe4pjz2D87ohzYrDSJeUHIkBH3/pswBQ8iFu6ar35SLgcmTQFJxzWKMCnN2wnvO/jOp5s0keAe1UBolPSbi4Qh/aOtxeWqlastKtM2yLqI7GgiwjxwjbNJnGOQMdyXi4sJjQiT2j1fi1k4aoOeCvZ/bnJEhB4CPCnfdfZN7SuNSTz7mjFuxR2ZxXyIw+67NkoBQco6nXoaBZAPlguAhiFFfLceO0acwTY189TrHQaT5Dhm1onSaoQXVYfnP7pYYBrZ3Y0waEnhuBeZg/B8ujsasYFv6CDX1kZ0tP1mhKdRBEtJz8wu0ZeYng9HKc9oememTZjrcoLBNMr18Fh6I/rvvAx0/CIzNQBLwrKd9rzG/l9ha0tnNTDesTj7pt/pC9om2ykP8moNmscD0Appzh5UOEuidoD70KniOAHP4JL/2hb50/fetA/K+lATXzsaa8sq2PUwLrlZz9l3RqnqU0l/qPDD+zISxMH5/fqnHkg2eaFVSyAB6NsvMA9JC+sYjx0fNq0YSov8HTPqWD5JWeHcif++n1EeXf6WNkoyoOD4tEmA4rUkLJEh1b7p6Gc6PqOR/UvPSQscGwYOm/uvhrbENzghKsN16htYk6ZVBfhL+CATqZT5Qsich5T+LT+mjQHR1+o/cmykf4wU/+/cOKDsw71DKDDn+J z9sy5GJL r2U+v7dca0mZSp8zUSj43+uF3SgtiHeRwsiLfFVYXy3QbZYS8Y5V6urW0N17zIUzErpxsoyOMJCZqWuKOAAgj1iW9M6IYnldcNY9dm1fqJFNZYdurw8Qjb/hp6tqaUJWHyAXUgiBpoTOYiQs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/02/25 1:12 pm, Liu Ye wrote: > The variable secretmem_enable is initialized with 1, which is an integer. > It would be more appropriate to use true for better readability and At the cost of messing up the git log. Please don't send trivial cosmetic changes. > consistency with the bool type. > > Signed-off-by: Liu Ye > --- > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 1b0a214ee558..2f9442d6633d 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -35,7 +35,7 @@ > #define SECRETMEM_MODE_MASK (0x0) > #define SECRETMEM_FLAGS_MASK SECRETMEM_MODE_MASK > > -static bool secretmem_enable __ro_after_init = 1; > +static bool secretmem_enable __ro_after_init = true; > module_param_named(enable, secretmem_enable, bool, 0400); > MODULE_PARM_DESC(secretmem_enable, > "Enable secretmem and memfd_secret(2) system call");