From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2D8C36010 for ; Fri, 11 Apr 2025 08:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E63C92800D6; Fri, 11 Apr 2025 04:44:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E15222800C0; Fri, 11 Apr 2025 04:44:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3D762800D6; Fri, 11 Apr 2025 04:44:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B6902800C0 for ; Fri, 11 Apr 2025 04:44:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D75C1621B9 for ; Fri, 11 Apr 2025 08:44:48 +0000 (UTC) X-FDA: 83321127456.13.1D1310B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B7C3380012 for ; Fri, 11 Apr 2025 08:44:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAmOq6at; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744361086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8UwurWG4XQGRseFWRwijIo5i7c41uQZ3O7HLReHkubA=; b=rePVnNYw2WsRAEwr1NUqNym8tVQo/APE+MYXfdK5uGfxww0maVS58YkvqX+b8I1KxMnucK Uj8Br7EgquOucdZ5n5MELFDSKsHn1wjhcbPQlvYCOpO8ct8GcduYmnHhmkdR52eyaN2eHf PE9cECupvDY7wRUckW5G0CFPrqP+vEE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744361086; a=rsa-sha256; cv=none; b=EYirJS3w4mST221kBj7j/+A3u1OPSMSdUD9Rm9cd0FoSqdhBflu+KXkVxaBxTHi6achLBM b7jQwC0xwPYTXE1xLqTXu+vWnpCueS8HdBYytDZoiRD4j7cjzooaA10+ljUUiqE4XQEfub d2jRTYHMrAAthuvgk5GQ6l7XpSyC39M= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAmOq6at; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744361079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8UwurWG4XQGRseFWRwijIo5i7c41uQZ3O7HLReHkubA=; b=FAmOq6atdv+f7NbK4Q2yhbRt8JjrNuFewkR17b78RKsxXpay/oQ01EM1T8ENxXEJ7JnSIP /+OMwuSN8jU8YG+oHAKHpemAZznYZ8msRqw/ZQHnrLgMPx0B9LjzUNdMbZzU4CxcqW5Mm0 J+vBUKrTlMLxR5S0Ug4rq8WsfL6yzWo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-whjeYm_IPA6cCGYBtCykWg-1; Fri, 11 Apr 2025 04:44:38 -0400 X-MC-Unique: whjeYm_IPA6cCGYBtCykWg-1 X-Mimecast-MFC-AGG-ID: whjeYm_IPA6cCGYBtCykWg_1744361077 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so15668335e9.3 for ; Fri, 11 Apr 2025 01:44:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744361077; x=1744965877; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8UwurWG4XQGRseFWRwijIo5i7c41uQZ3O7HLReHkubA=; b=Ekk7QbR0wSdVNzGSPh7EXcGzvi7QNI2d6CoVN/X8db2MzyBG1TQqy+5qWkoQQ1qZHI zlAVbEng3fWoKJZYk/Sv8My06T5fN4LcM1ugYl3BC7OkgWXRAl2ozfCo6PrAu/b/fIMS IcGm7ggqBkMrUVcxr1Hg1ZoeWR6PS0MBl+cWYfjhQKm/zlDLCJApGf44HzarqZNfz2AV bwK2DT/zklzlVAvkq2P+dzLNEvEiObLdZLyY0xswk7J3hwipEy0MXMRutxckxD7Rmtbo 5zg924Q/b/pi65gjkiAucuMUuyyBEBXNqePdbqCwlYKZaOSFo+2M+rWBFRfG32agxrre g3yg== X-Forwarded-Encrypted: i=1; AJvYcCW9icSDLyRmeDnuos5llJ9O3QZaLR81qweMQyAosId40kJFaQmxEFm78wfir9/hdGPHJfnxY7wQgw==@kvack.org X-Gm-Message-State: AOJu0YzeCDyq6obNLbLaHlLfNErovVUefT+tGE96/smtYeD+x5XYRlgZ bv9cTLzGzBNTuw+Pf2nhgY/quNeQNa4noftzDRqUdXmuz57ghf5QA0/FDgwl3+lofnAetCtddYN kHq7wtZMF7nCHmHtk9G0UozfgqV/B+NFOSQDj5hhAPOZAKdOK X-Gm-Gg: ASbGncvcQNaF02RmngxsSwquY8lYeVvGOaUvSfBSG8XbBL4HUfGjS7BFWKAYgCaVwew GL1ww0SHuuCtQkP8m+dCvCvblVEI1eEPdxpRV6+LZBsk/5rXnkbnmmdjis4KJ4vF2lOZfK7Glfk dfbdankiBVG8XOG8rfO3vVx2FigXSmx3nSjnB6RzL6vzrAgWOvSl/j5hcJwkL3e4h36+NG4MmN3 52Kjhpp7i2390IRPPIwhiS4MnlAcLN1uJK4uzr6f3eyDw1blav2u3ipa93Wt6FGjT+F2GhT/x8I OPPUjp6otFZ9/VVZ9g89z7eVfgMv6rJdlutuZWk5EuJQMiV787kG7ElYvMDROWNu1YGImAblu9I tAjXGi+RpnD7nlY5DsglpxLnHeB3RACWP6Koc X-Received: by 2002:a05:600c:4f45:b0:43c:fffc:7855 with SMTP id 5b1f17b1804b1-43f3a959a54mr16594525e9.15.1744361077297; Fri, 11 Apr 2025 01:44:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1yXrAjR8f83dkADb2rKYb3m67+FD3YlVi4ltf+mzQPczAXtXgQZ20dNHdLZBQkLb34RAkuw== X-Received: by 2002:a05:600c:4f45:b0:43c:fffc:7855 with SMTP id 5b1f17b1804b1-43f3a959a54mr16594285e9.15.1744361076912; Fri, 11 Apr 2025 01:44:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6800:7ddf:5fc:2ee5:f08a? (p200300cbc72668007ddf05fc2ee5f08a.dip0.t-ipconnect.de. [2003:cb:c726:6800:7ddf:5fc:2ee5:f08a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f207aeaccsm78562285e9.33.2025.04.11.01.44.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 01:44:36 -0700 (PDT) Message-ID: <65aa6e41-ff13-4c27-8a78-e7d6f2471834@redhat.com> Date: Fri, 11 Apr 2025 10:44:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() To: Baoquan He , linux-mm@kvack.org Cc: akpm@linux-foundation.org, osalvador@suse.de, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org References: <20250410035717.473207-1-bhe@redhat.com> <20250410035717.473207-2-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250410035717.473207-2-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RtEe--_0XJIeCYwQpvMNdaRtp1ioOTVtlfzWZUO5cGY_1744361077 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B7C3380012 X-Stat-Signature: 5oixxoh19x64cpifqxqoduouk74hqbmc X-Rspam-User: X-HE-Tag: 1744361085-779744 X-HE-Meta: U2FsdGVkX1+of4buj35pPjXjow9ckkjAHay8UjyQyyZN+cJjqMdj2k0JDFIVDxHjMK6y5l3V4dgkHygax2FVpr12AuDmG6ZG9X3GKbtsEa9FnV32vYcrGsjlT4WiVdVFiDuY4mFUIA4utIdIoq66DOZKdrY2r70KT5ydVF8AUjfy4DLZcnsNy4JaWvSvQ2sy4pLzduyXRr5eIE/97uje/ExvSTqketXmNoUCosnMy//tR6yDg4dInOG+ByClytLnmy52xdjTVxRTozhITGk4yXP+Dz+dLo7beCEzCX7Vj+stwPSHeG6M2LRakW98Y2XCysHPQzphSdCjA/Dvdo9yGyB4MuC/k0J0xT01US6V5DYo+TcMmPHNkxhQoH0ReGNC+5fvMySoXfhwNGyO0k/kcUR+Fzqiia9ajGqrX3RlnYeUuTPaHi9HBZSRqTqRopzGUo3R2x2lOECZBjuZOxsdbOLnY0/m6NA5Q4+X/1nVn5TFDZxkhEnZkww5X7txjToTSNZGrKg/RIEQju8YI4TP0wWGkYjpztv5yvUBZeHO2nr7cjE2YOIkgdFo6oVuoeRMgNLiivrel7RaOod8afXA2qY+AD4Hk0H82FiOekDV1zl2gIY6NwgJ6TaPi0w3wBj8LDOHc+xV9tcNu90dBtvuXUf/ACY87xsfv1roKqAO+vJDIl9auFirpFs984iwUT0kSggUBLR4DLC0M/D0MSvyELpTNtFBHXHr8ovh/l9YBMIW4yBBXBjmzTuybUc1+NBGAG8QHYEE8hOrKsDHSvIVdCJtYJPsGtMetavsVnovj2uM6WLxTCZcsZOFHsVnaR3VjXxlsEKpkhhjadllBISwF3VQ87t4WlU9WLkc0eATuQo8UDDK8N3mvS+eY+ainE2CfHnt9h86GLqHF0Qh9RQERM9KGekL1E3W9XojhHjDBSRUpn4SBJU3NpMrznBUigZEyUHuUtJmPkezWt9ZDe2 mDa3f1lG HfDclFaVX5BKV27EC70Nc6OLueRae3A2hcqRUu0NhpOh1AuXvJUyABEBDfZ2kRY6kHXiJfCf8ZF+VBHH5gscx5TsnJCGQdsP2BUcheQFDRnYkwU8ZFqictv0kQSwpbrNX8J85fCILVD+XEVsgw3G1m7WwOCA3i04SQCJRJV/NpAnoesbLDk+1sd/9y1zcGAwJWppF3bfzpUaN/UiT17S5jHq20gIPfaMHFSLp079MCckz/vhwpRhYSDfNezRBVEVwl045B2Gm8RH3MH6UC7Oposg5yYmmfd54xf70Ded/wQvVunfjB/MlbPgHKXAXEtDZF2+wRavU5An9+5Ohp1Pt2NmjhSmyHFRVs3MvJgB/X4L9J1NEqD5cjQ0HY67d3IJz/UWML8edxrG9w1fqMYNtvF3/JReBjKS3tQuZR1LCWGdw97IGcwBBsTlAIETpdI7A3oWcjjxARubclE4nDejpwsu4MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.04.25 05:57, Baoquan He wrote: > Not like fault_in_readable() or fault_in_writeable(), in > fault_in_safe_writeable() local variable 'start' is increased page > by page to loop till the whole address range is handled. However, > it mistakenly calcalates the size of handled range with 'uaddr - start'. > > Fix it here. > > Signed-off-by: Baoquan He > Fixes: fe673d3f5bf1 ("mm: gup: make fault_in_safe_writeable() use fixup_user_fault()") > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 92351e2fa876..84461d384ae2 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2207,8 +2207,8 @@ size_t fault_in_safe_writeable(const char __user *uaddr, size_t size) > } while (start != end); > mmap_read_unlock(mm); > > - if (size > (unsigned long)uaddr - start) > - return size - ((unsigned long)uaddr - start); > + if (size > start - (unsigned long)uaddr) > + return size - (start - (unsigned long)uaddr); > return 0; > } > EXPORT_SYMBOL(fault_in_safe_writeable); Acked-by: David Hildenbrand -- Cheers, David / dhildenb