From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33457CAC582 for ; Fri, 12 Sep 2025 08:57:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AEED8E0008; Fri, 12 Sep 2025 04:57:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75FBF8E0001; Fri, 12 Sep 2025 04:57:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F078E0008; Fri, 12 Sep 2025 04:57:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55BC88E0001 for ; Fri, 12 Sep 2025 04:57:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B9AFC06F3 for ; Fri, 12 Sep 2025 08:57:35 +0000 (UTC) X-FDA: 83879994870.27.59783D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id AB1F5180007 for ; Fri, 12 Sep 2025 08:57:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HZNWcQZ0; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757667452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oYE8QUsnZZBUYnfQv+SJzLEXu1JDXkSZkMxoL/oX96Y=; b=hau1rDea2SfFu5CeSnBL+FLmDZS1twq0+aTXuQqFh4zpUp8uUXAdjKPMQ7Qh7PDQX+wr0O IxNWP0Dsg/1+dU0dR/MEqkq5AiE4MuzagOVx6ua5wNpQUQoxY7AuT2u8t52vHELc7mN6uI dXmO1XLUb8Fg+DGCiK1Vv9hk3/jO/2U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757667452; a=rsa-sha256; cv=none; b=qpTVjUNZFhAMpFMrZKfd+16L71FsMWk8WkzDDeFvLrzjt23RTeWHIqm7UxHPmuOLI53LZL ON1+1K6Ox7jRBeci38WPcO89NaAkcWKQsl4rwpVnXX+ybwdwrGV5buiuIsn7sioUEiAWLp PGZbtrFDM/5C2MhMf0pWuCdN/q08Wx0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HZNWcQZ0; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757667452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oYE8QUsnZZBUYnfQv+SJzLEXu1JDXkSZkMxoL/oX96Y=; b=HZNWcQZ0zuKLWizv2Zswj9r2r3jS3mav206SA1hWkVoFGTdcxKRFj5Kw8uTogAshotT4bP IrZLb/OlUKmqvT/UBJX7nKqxy2Z6j28WkRGETbezMealmuzRN48ejgfPE9XWpoBlmAwizk bc/rViyd7+te7fKh9A5sNf9cdtXBPOw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-ZddhLrCyPyqqNUZvgheNEQ-1; Fri, 12 Sep 2025 04:57:27 -0400 X-MC-Unique: ZddhLrCyPyqqNUZvgheNEQ-1 X-Mimecast-MFC-AGG-ID: ZddhLrCyPyqqNUZvgheNEQ_1757667446 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b9912a07dso9185135e9.3 for ; Fri, 12 Sep 2025 01:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757667446; x=1758272246; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oYE8QUsnZZBUYnfQv+SJzLEXu1JDXkSZkMxoL/oX96Y=; b=LQUTYlrVNRDTqrHg4ptMRgSamL0quuYBqzu2ZE5kdCQiIYkwEy0k5h4FOkOcGSnMsl 3FhZrV1LSG42JCef2ME/7ya/8wfQ8m+rxLK3QPQuTCWsVlVmmIJOMfIfx3If2sBUXk3s hJf2QxaTeaSaMNeeMdsxOGcAyq6yFgsXt6malPNduCqcITHnYRUDwfre1CKVaVOlcGoG cjnpgmtu2BqQ/l1a6CTqLWhqUhjob9TACvx6fpxZzo4JdOh7t9UKRStGGvUU7cKD+jPY RV0Fydc7j7T72wO/B9gZo0aFAwGhGKdmtDfGylRQIJpzeeKO6DmThiu1HSsaJBgsej2y 9YvA== X-Forwarded-Encrypted: i=1; AJvYcCX0h3d829rhz1CgmzF+ofefA/nUio1HnCBTZDauJlxg4n5NyYHXLkEd/vCrRz2H+mvR1osJPixf9g==@kvack.org X-Gm-Message-State: AOJu0YxsK0f3LQ0050HDiqGBhYrTVBB0J5jGfiKIFmljZRg5/5a/djDd VaUBbXEM7AAoI2c2jJOlKJYzvCSrfcvkCS/hVQ9MMbNIIaW7uGxD5SjkOrlHsRbovUNk/oVZ0n5 KNWQiw+nme+S4WJSE1l6qbWJvZIg3q674N4SFIv50cSVtSpWZ1TLa X-Gm-Gg: ASbGncvhr2A51z3xGV3APLG+pFqJGEUtQaWFajTC+ep9lBTPSxbDWawabo5Rl/zRjCk +hvL6wuCUtwKXEFvY80wHFYKg8t4zSN0OQXeTUIQ5vseR/6OGeoPMC4iOHB+YqfHFtnz0aSNISW ynpLLypEg3kb45GPXHZjGMk5/hmU8OsgEkkU855p31Bfv45kulWyGnmGy40PWE29I+BjIx78F8G ENLw43rUp9jL8gqgmJw+eGGVSUESeFwTEN2RhP0bAtnQlPSv1Qz8r0OS91lKUOFOVU2o78SPP23 IwfL5IEj3rrCQWKgIVN7EL6e2+DJtVkpalRXoSvFg6a36aMdmKu9AmtYDjXbGfzeQVnIHIR7BeL OnyeqZSkJmKV3J4Fpds9wvJsMEuWRFDAw9gT/+lzbEo752bNHxDfXl4FymfEyuS5aajM= X-Received: by 2002:a05:600c:4f83:b0:458:bf0a:6061 with SMTP id 5b1f17b1804b1-45f211f87c8mr27523345e9.24.1757667446391; Fri, 12 Sep 2025 01:57:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbKnkz4E7alPqaRs8JDqHCnR8JIg+ATRKJh19s0WfXd11H9UFjVPHs8lZIrKmlmJxg+ga5Pg== X-Received: by 2002:a05:600c:4f83:b0:458:bf0a:6061 with SMTP id 5b1f17b1804b1-45f211f87c8mr27523045e9.24.1757667445965; Fri, 12 Sep 2025 01:57:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e01575fadsm57722265e9.6.2025.09.12.01.57.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 01:57:25 -0700 (PDT) Message-ID: <65a84778-b329-457b-a834-aa823f7db29b@redhat.com> Date: Fri, 12 Sep 2025 10:57:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: vmscan: remove folio_test_private() check in pageout() To: Baolin Wang , akpm@linux-foundation.org, hannes@cmpxchg.org Cc: mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, hughd@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <94cfb423-1dc5-43e1-bd1f-75b8d43fdc1a@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aed3zFYrtG1Kr1cgY5Zq9HRlR0rlZ2EAOfnd8Rl2e40_1757667446 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AB1F5180007 X-Stat-Signature: qoignaaw4idowib3tneyejcitnkrooo5 X-Rspam-User: X-HE-Tag: 1757667452-767497 X-HE-Meta: U2FsdGVkX18ua2ImNcdPGuRjZRboSC9p3bVojdwsgpPQHBsS55bMv6tJm2DYs8f7/JW1MqG7ys2/W7B9zuuA4Wzr9d8nhRZ0gc01Ftnfl0NJyeL5D8NNilRiBZtA8BdcDk1yuDw2RepUwkRlW5s6b7goL/Ev6bs8eIuEkLdhg8HgHD4sq9eTMAB8VTmJ9Jh+kVhZCIggsUHpKH+HZ1o8TpYtCeTMkR7M/SKpQFgQxYKj0yBCGNB/x3EiLT29tvVCPgEdzPl36QLsDwP9uN8EJkqReyjM//7gLtXLkQFRpZ09XsJ34SwvMZ/omywEMTYURJQfz1ze2n5PnbMqAB7xm7714e0rcSQQGP6B2QgaxrQjg6yzmYMSeuwFkEOq4VSHw7YgltlhFZ6SfmZQ7JorpPmwVf6OUFFC9i0sT/2g4WTKm3DGVQSMhWPQUuHwJ60wG3gr9ssNEVZOhBroBn/XPj2WKAYE8/l40J/czjjWDQUaOlQGmDSVAnLP6iwdN4RbKlSLq0humgFJ8SjcErnYAHRLCLcnpG/c+RLpLZ2Q/4zydF1/SLfn2YCzv6I2LYS7hPhGGhWPV8FcYyc5e9vMf6DQpOaJZO66bSc4cHs0zkj2geOWivrIf8Ewnjf3q0b7VtV0qfrrZiWlMBd9e7M6NEuU6rTcJYJkO9xK4kTsT+VS26/MhD79SJGpIdfjgWxyix3pbRegI8Z6xjqjUnqJNK3UalyJSYz1B83XroynpZCrydM8t1JJDl4qu5vCc1F4rbPG+iknd0ZopiHf+mNglI9gvKOauyUpm0sfOSW/b8LpKs+/maZQzoO+X+oBbq8h+eHp1+4NCbUMMq7mDNQTvtaigESuprqDxQjZuaDBktTs/2lt5SULlW8Q4A79ccVMMrqhM88CbKbror1oNj3lG9Koi/fxb99nm8YwNbLZWVFmkRZjFaM+x3sk9UblycL6Tn7fkUlImUe7IKtgxtF 9SH3A7UW lAU+rCRjaRP184rZmFnQBAzKv8C6tmp+YhfzWUZqRJ8G756sz7smZ4lBp7D38h09G0nQjfMrem4M0mA1JB9zEXVJSJ8FWGpRh8UMnCvMrACmNROr35fQujpJ6v+sW9RyL6SxvlCxQS2TMsLD6rdu808X/GC+zetM1rfMa1mwvfwso9OyQ6HAPNOQETiJJbIcKGtuVcQURiNXG29Y9q51juCAiXAchtfElNsjYSb0s00l3EmvWPecSNf6PAOwikodn+Hbq02UC7+1DdsOL8oiFdzvo5GHB969ujTHClK5vW3VLtxh5cpJQV4lqiM6XCUPUKQ2C09WD+Gd7ERHM5kGkiiHxp8JsqPTWzxEIsg73MxnORZgMXMw/uue63Wwq175xFFYzIxEdqJdP/LPhfdyzsDm6AJxMawUZbj+KpD+MNbXBFDNxEVq7eQRc1VghZhofgN4VLsW7Bs7ujNMwlxfhr23sImTtZ5cRzYOlNK5Me3PV5alfXGAFbf+AkOFyDhTsKCuyNHFyY9YvInzmT7Wb+FQs3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.09.25 10:31, Baolin Wang wrote: > > > On 2025/9/12 16:24, David Hildenbrand wrote: >> On 12.09.25 10:24, David Hildenbrand wrote: >>> On 12.09.25 05:45, Baolin Wang wrote: >>>> Currently, we no longer attempt to write back filesystem folios in >>>> pageout(), >>>> and only tmpfs/shmem folios and anonymous swapcache folios can be >>>> written back. >>> >>> Can you point me at the code where that is fenced off? > > Please see the following check in pageout(): > > if (!shmem_mapping(mapping) && !folio_test_anon(folio)) > return PAGE_ACTIVATE; > Oh! I was assuming that we had an earlier check for that, not a check afterwards. It would be worth spelling that out in the patch description. Makes sense, thanks! -- Cheers David / dhildenb