From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4951FC76196 for ; Fri, 31 Mar 2023 08:38:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EB1D6B0071; Fri, 31 Mar 2023 04:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69B056B0072; Fri, 31 Mar 2023 04:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5627A6B0074; Fri, 31 Mar 2023 04:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 47B326B0071 for ; Fri, 31 Mar 2023 04:38:56 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 17A8C1C6753 for ; Fri, 31 Mar 2023 08:38:56 +0000 (UTC) X-FDA: 80628543072.20.77D95E1 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 3C3E91A0019 for ; Fri, 31 Mar 2023 08:38:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qwp+45yD; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680251933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u0O+1iDiHGqqkLLtzjSrhhvTogFFIDtpqH3SLB/+nZA=; b=iTwGuVsf01ht8JsLUX2eRxh9lK5IMTZNxESSyzTFl7racAT2hZ3K0D4tiZzxjLtYwPJA+c tOnzwwJoxR2zhgr5bgihvK7Y0VoV6IA7K9yJW1PD/NrWJalYZFuq321diQh33sbR9m8pzH gDdf9hD5xRXB0uzBs/uKPkVTGh3LB2M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qwp+45yD; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680251933; a=rsa-sha256; cv=none; b=xS+5bXR+VAmVt2a45q6JoeOzf8r5E0qXjTQGetZ+hYiG+I+Kuc+r1FO5efmu+YenV6gNXx NKGJrfSk2qn+kYI2ReJrbWLWLyM8mr1L5VLZIXl43dVBnTi3rdxVkz0BGOHFpXY3deNRdx QHhlNI0UKGo1A4nsoCWw8DyjuyuJmPw= Received: by mail-wm1-f51.google.com with SMTP id o32so12422391wms.1 for ; Fri, 31 Mar 2023 01:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680251931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u0O+1iDiHGqqkLLtzjSrhhvTogFFIDtpqH3SLB/+nZA=; b=qwp+45yDU/8FeUG/mb5yQk4Baj8bRTtm7Uvuw+61kXsPy6YmBE2gAX1gI+C2nCvB6x 2+vrFgyZFFI9Uzw5jTqV1uFcnrLNuEFy3puFk5QDI9+zZPS72PKlQ7kg9TWY+k9DkKil jBNbcLCVOqXWQQxpjnMWudYmjIo0ZdvSKmStlm5lXx5zn1c1tGBUEfKu+i9QZS2mkSFU 4DpXDUiiDevAsNhouW7Rp3s9uaCQpI+nb2lMyUeD5PU3ZSfsSZltG9xDpFLbFbkNbt+R gMshyalbmyFewULoENqAnQH+Q/YUqQA8AfXvjoTSdk0ykLEKTiqytW+FOtcETcvtfRA5 TQGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680251931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u0O+1iDiHGqqkLLtzjSrhhvTogFFIDtpqH3SLB/+nZA=; b=2NaKq1ytDV8X69LpXbRtCQhZKz0OYjWLDkALXA0XtyOycXTPhlHieAXcAF+/UxMlNf /vnTNrhFMbDKHHF/PGLfHTIMIC3PIQ7RgwVzOFlF4kPw8gA/pRZWcZ3H7cVld5BVqEK5 gwR3WJIOAuFqpx4btoxZkdtaehib6Cnsf7Vbn4Pfiu92AUUM5mfkFmP0VZt7EKWOavmt bN9DzfQCln2MPMEOWIU7d30todzqz+Xl9AQeTIlHYezvMATmlUwZu7E/Z5QM7Zlw/BjQ pfDNPvjrXhtbJr0xv9CYLHCr70JC5GhetOZB1iL2+mEOgE2GPr9t/BcbyGFGzpDv/CLm C1xw== X-Gm-Message-State: AO0yUKUcenk6yPcfBQ5EfkdaAsiv6kiLVb969pHb7Z+sUbCCeM9Re2hu 3pE4zwX0WZGejhJcsjToMX0= X-Google-Smtp-Source: AK7set+teNQZei3rKQqSvoEESvdaLQj7q7z52K6Cha/Jmf1FC3DFlCf6DqwjFwk0c+uOGDCgCLCl/Q== X-Received: by 2002:a1c:7919:0:b0:3ee:da1:1346 with SMTP id l25-20020a1c7919000000b003ee0da11346mr20639774wme.36.1680251931504; Fri, 31 Mar 2023 01:38:51 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id c3-20020a05600c0ac300b003edf2dc7ca3sm1913937wmr.34.2023.03.31.01.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 01:38:50 -0700 (PDT) Date: Fri, 31 Mar 2023 09:38:49 +0100 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Rename addr_to_vb_xarray() function Message-ID: <65a19f0a-be4d-42c9-a75d-1356996acdda@lucifer.local> References: <20230331073727.6968-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331073727.6968-1-urezki@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C3E91A0019 X-Rspam-User: X-Stat-Signature: y8jjwfo8nhz6ngcrcmw65z6t6shsbo4m X-HE-Tag: 1680251932-528936 X-HE-Meta: U2FsdGVkX18C18FEqJr9FP6Qbm29ciCv+dI74rnH79F9xzNCbRH23TBFuCwLS0zmCqKpSPRF1WNxJc7dt3eNgcJXOqIkj02I7nfPqfGYH3ni8S63K214z8tgArdDvoyLit0U0NqT9eAd+eLZYaavgokdG5CJ9Rz4GcBsT7BT+DCfxLLeg6dw37cKYEhLuAa9MQCOv/K4PiqGVLeL+M1nNBbSkYZeOuTO0rXrPVzNk3O0ULIRsKmJsmA2wxQATYIxK6q8y1bzqNgGGFnOZ1Fbk+w86sikZUCmSlgYe0E91wrinjhj/A/5my/sUhDi0aH2UOVyqbTNYBVYlUqLzn4fQu+uaspaIgntXhb8yA47W2EEJKwJmqgi0zg7mTM3sAbdEGGq9+2OXwToTw8Z6MYFoqV3YfgmH2gDW7FZ27EqF/F9NeeFybiuuoPcETc2U+SWkrtJmYF2Z5KOOyXycOCWKx0yDlMKCnkKNyhFpfBkE2CIpvvV+d2B3SBolGabP3/bYylJsnP8MCrSBK/WySWl5pW0nHs7XQcQQR/hLmoq1R5xfZ+bIPwSFVEOkdmNNvDAr5VwniDw+Uf2g8F84+rMdw4cop9y9NG55jEtwE9prI2bu3bzMFnURUL1x93mLY5IT1YgTsBDpbygUiSn94muSGoIWlYfqCuuzZd2H2hLKtyBMOjYF5ZH5K3/VUwLc693QodjhCruZJHMyk0Ww+XlPjJ6MoPRKlhAd66NFTQbCqSAlCjUPO5gt7FdimW4tw5hKdozxftfxmtapOve+NUPfPJcCMtJKZ433Ma79NhNgPhj8PPZCjzWXLmr8LI8BhfIcQEcFNCFV1Rf6Po9sflZ4f3R1ygaangki0k8skXoLNBmgYw9UDnLwljNQJVqsyWUj0Y7TLsBw0NSMmevq4asSu444gsdgDiHBxAr3mEySzUePkStz6o1Q/z1x3MnNrgOUVL6eA+yTqGqLcxHR9T E5+qdFmF gPoNL1m3UMtIicYJek4XSVz/KkR7Iue1PD6p1BtvOWQg5eG6xRuCyx6rI9hAtE1HR8rVPjAJ1lHRumWShXBYYi52q1DCDBJgqS2GGTl2Bgr2zxMJN3GdtIO2aTdLnGZnqUrZoO0LNBwRG3yGnZVt0TMVv0r+rEmENuyE5sQnjM2K5VO1FtNlaC8gQ9Eyuzl6HAGyiitXcO/CYePA8ARScn6tUDNhAGyj9tMcwqxIML3ovMZiYoTeCGXndj7UbTIgitZdii6a85Z1i9s3oaw5DhNZl0xFQbQllhKkMqhl3WVPAkknuJTw5qjYNPf8DIXmm40iqeU0hOZOWEa/10rpoNqqs50tI14t3eBa1u+MA+pA7EPJ3WOEswBFxAXvKvp8zIuwv5BKYZmQLLcY4M/QX4SGU9l1yJ1ST+ksLaQ8Cu4Prbie3pZWdaGVpYDIhyS/aOb0neIgNX4eWqgPZT2DKp60CefAVLOLkl/mAZJerhE9FImRxfuHa3GobWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 09:37:27AM +0200, Uladzislau Rezki (Sony) wrote: > Short the name of the addr_to_vb_xarray() function to the > addr_to_vb_xa(). This aligns with other internal function > abbreviations. > > Suggested-by: Baoquan He > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 671d6d5d5b78..b8b646f8a00d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1945,7 +1945,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > * used as a hash table. When used as a hash a 'cpu' passed to > * per_cpu() is not actually a CPU but rather a hash index. > * > - * A hash function is addr_to_vb_xarray() which hashes any address > + * A hash function is addr_to_vb_xa() which hashes any address > * to a specific index(in a hash) it belongs to. This then uses a > * per_cpu() macro to access an array with generated index. > * > @@ -1971,7 +1971,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > * however xarray spinlocks protect against any contention that remains. > */ > static struct xarray * > -addr_to_vb_xarray(unsigned long addr) > +addr_to_vb_xa(unsigned long addr) > { > int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > > @@ -2048,7 +2048,7 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > bitmap_set(vb->used_map, 0, (1UL << order)); > INIT_LIST_HEAD(&vb->free_list); > > - xa = addr_to_vb_xarray(va->va_start); > + xa = addr_to_vb_xa(va->va_start); > vb_idx = addr_to_vb_idx(va->va_start); > err = xa_insert(xa, vb_idx, vb, gfp_mask); > if (err) { > @@ -2070,7 +2070,7 @@ static void free_vmap_block(struct vmap_block *vb) > struct vmap_block *tmp; > struct xarray *xa; > > - xa = addr_to_vb_xarray(vb->va->va_start); > + xa = addr_to_vb_xa(vb->va->va_start); > tmp = xa_erase(xa, addr_to_vb_idx(vb->va->va_start)); > BUG_ON(tmp != vb); > > @@ -2193,7 +2193,7 @@ static void vb_free(unsigned long addr, unsigned long size) > order = get_order(size); > offset = (addr & (VMAP_BLOCK_SIZE - 1)) >> PAGE_SHIFT; > > - xa = addr_to_vb_xarray(addr); > + xa = addr_to_vb_xa(addr); > vb = xa_load(xa, addr_to_vb_idx(addr)); > > spin_lock(&vb->lock); > @@ -3556,7 +3556,7 @@ static void vmap_ram_vread(char *buf, char *addr, int count, unsigned long flags > * Area is split into regions and tracked with vmap_block, read out > * each region and zero fill the hole between regions. > */ > - xa = addr_to_vb_xarray((unsigned long) addr); > + xa = addr_to_vb_xa((unsigned long) addr); > vb = xa_load(xa, addr_to_vb_idx((unsigned long)addr)); > if (!vb) > goto finished; > -- > 2.30.2 > I have no problem with this patch but it's a bit of a pain to apply, as doesn't apply to mm-unstable or -next as it doesn't take into account my vread_iter changes, however Andrew can probably figure it out :) I checked it manually and it's fine, so:- Reviewed-by: Lorenzo Stoakes