From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183A8CF9C71 for ; Tue, 24 Sep 2024 07:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C6766B00A8; Tue, 24 Sep 2024 03:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 976176B00AA; Tue, 24 Sep 2024 03:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817766B00AB; Tue, 24 Sep 2024 03:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 621ED6B00A8 for ; Tue, 24 Sep 2024 03:36:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DB14112181D for ; Tue, 24 Sep 2024 07:36:22 +0000 (UTC) X-FDA: 82598823804.29.07B69B8 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf12.hostedemail.com (Postfix) with ESMTP id D66F14000A for ; Tue, 24 Sep 2024 07:36:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TeIzHIRw; spf=pass (imf12.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727163223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DoLXxu3sHCyM5uOz8aZIUvfdOpT8jMclqRj2gZrUUOM=; b=k2dfwELpLRKDnhUqQkL1rbUoliqHyzqw7xkGW1kt9KAxeCKPSAcOnrXB4lNl4AuVlMmHU2 4Dknl4ee9joam3BEjypxa5XzNAi9d7HCDt7NC35PfZ5fUaGOKiXX4TmfUtOjluQyosnHIQ 3J058cZnlnMUyAqOd+xXLemNem4DnVw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TeIzHIRw; spf=pass (imf12.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727163223; a=rsa-sha256; cv=none; b=7fubzyZK22Gt0PrzdUhylGrhYIqdMNnImtvsmwyWbwn4blkIRDVREvrBo8Eh3wexXSM7/Z /hofHlEX3JsKAgRI+2AoSFczSCNfxD/zUL+2RNfdbAxg581nG6s8G9ridk2RzlwA/OKVyJ 3A9t864dV11Hgcmv0dCaH7/OKaqXFIs= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727163378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DoLXxu3sHCyM5uOz8aZIUvfdOpT8jMclqRj2gZrUUOM=; b=TeIzHIRwa9J+AAi/w/MnUrNvnJp4eggEJopgtjtdGBDKCoMm28m+up3f3+siiMNxstukd/ sRci7QOJMrJjuYp1XIEk17HMgvkqe9hLfpxdl0GvCaoKIW4HaxGHx1o9ZOHh2/3Wtf1x4o qUwgrE28b9B2kx+PKH4ccRCtzch7RJA= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: [PATCH v4 08/13] mm: copy_pte_range() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 24 Sep 2024 15:35:37 +0800 Cc: david@redhat.com, hughd@google.com, willy@infradead.org, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <65E61995-5C32-48D4-ACB4-761EEAE7A585@linux.dev> References: To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D66F14000A X-Stat-Signature: rwjx4pypsxo5z4onmphttedxbaoxgm7u X-Rspam-User: X-HE-Tag: 1727163380-464420 X-HE-Meta: U2FsdGVkX1+hc4EYFAJIG9blC0rWZ0LlbfR0Sn92/0H7m77KPpTtCgrN1azsngLKemwhTVSqp06Q+XV+PYeihg91U+1cwFqqJ2ZeLgkm2JDFPorpL0Pz3lF2YT0SC6sHxshmwXNFEzAD8wmDGlFwVm8ufwm+J7UDJC/imEFxJ5wFncvjv9rFWGy0xYC/txPI2tIdSSFWr56EwgveTYzXiJiRz99JdnztYEpkO1uu9d41MvL64nsquR2xqHqrfs9s4L7bxcuoP+nOEoHaqGKp/WFSdAhZe3XaHqT5H3fuiFkuL9tPZUGyCF5eKGz1O91rYO1N40JUveXXpIm7Y85wS85E7LTEBotdyouIBVEBCyQ+9fKUSYnUm6PVeHx8FJ0toUtPJASaQQ40c9DYPYSwnQr3inGOqY+DDJk1ow2TVDzHXZGi8HqGdckSKbgjnsUqszduVAjuANDnS26b3wtAQKG3L5pND1FPnhXRJakDknwSyhj75PofqLcHOPKcq0XvqNMwwWmvi4qqfPhgNl3eGWmXOd3qRdEOa0fnliLsU9hHAfDyrHlogBAi8dtXheAKBcevLTPwBs4yQIde57KRi/1R/+82jRJLvFo9GpfzphA4FSSw09NZTVaF+0lgGieL+31+/fSbjGhcx6ZsevIRpEd5ukRpl6l3fgkFXs8wehaVhaF6XvtZ2o05vm8Y2FrLVoUQYOFYLKEmyU0N+7W6tPbs+p8GnE1jOVVKV2F8wMPhKMa0wtYqpgFwvFv9YAFE3T6U35hS+vUmC/3U3RgxH8fwODQ5tSIYZlPSB0mBNirHwEsoPQVk9j2aMak42f6y3XSR0HYpQdMAkQJFv+5B7FBPV60WaFEehkwnRqb37XTpL2HwWNUYoVaO9IdQFQzuezLJBZcK1JAxItvwIsSQjNjn7bfRYidzDZ+DZj7XeVkpG4AHQAMlC45SBrtNRuQXU446KSGJNTgN0uWOuZK 1Iw7PYFN GFOKvY9+COZaM3BqD+kDr18DLwYHr+d5yeDyrfSxqwNxd+igFG4l5Ft+8yttd/T5xwWMkFE34VKELG2m/VJOp9qD1a9or0HzF+9mhKsx/2kn01rS9O5bt1l0B+pUiz4sU+Bch/71HFHQHQThGiQZC2oQ9sITiJX7oKE3YXS0MrAHtXTXnmNBdTp/GwtcgYu5oEmNPyCyDXs1y7x/5wO0STEFSrE0m9444TEqmy1OGB9KuAFMV/reSF+LclbUa3jZMYSUemUzBNRmPzFCoLfv5PqZsRWO3EuzyeS9OtJSUz9XND44W39t0h7BO12WVvtKtou6ExDHhhyrALlaCELV7D8w9lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Sep 24, 2024, at 14:10, Qi Zheng wrote: > > In copy_pte_range(), we may modify the src_pte entry after holding the > src_ptl, so convert it to using pte_offset_map_rw_nolock(). Since we > already hold the exclusive mmap_lock, and the copy_pte_range() and > retract_page_tables() are using vma->anon_vma to be exclusive, so the PTE > page is stable, there is no need to get pmdval and do pmd_same() check. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song