From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C8B9C433F5 for ; Mon, 3 Oct 2022 23:20:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7E656B0071; Mon, 3 Oct 2022 19:20:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D06756B0073; Mon, 3 Oct 2022 19:20:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32DC8E0001; Mon, 3 Oct 2022 19:20:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97EDC6B0071 for ; Mon, 3 Oct 2022 19:20:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F5BF1A08E7 for ; Mon, 3 Oct 2022 23:20:58 +0000 (UTC) X-FDA: 79981210596.08.31434CA Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 24CAE80015 for ; Mon, 3 Oct 2022 23:20:57 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id c68so5196965pfc.4 for ; Mon, 03 Oct 2022 16:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=Q3+69+rJNNqDIBt2xxx5swC3PNGWjqGr+kUfHliTojg=; b=gvJIJRdB34Od+qxVq+481xrryySAtsmCHUeknglYR1vdHv2WTdCjhlD6Ehyw0rK7nK NvH6TKzGlkH9s7eN3i7nt/JrfgxAFpFN32wlF1OS43AYgHUROQINDHOq8bP3jbgTHz/+ MqV1t+8eT+7O9/rrGsbajRZU3nZFOZXcM8tb9IACyz1kIEDNwbZ9namEl0541TE7J0ru 3Ig6Z6wU6pxSb+EdsQU15kZZqZLRelVneiPKIc5au/rL3LvMhoFV3Z0T8SCqV5YMbuPm wBJiHe8NsM2zsEDAsFfLuNRkhokYuz7KVtvfzFIWjVvbVWOlHoLaIK8YXn33kolhElyo GY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Q3+69+rJNNqDIBt2xxx5swC3PNGWjqGr+kUfHliTojg=; b=o7WkPEv8+BD5oQXMPjGgzbXOOWbzNyTtEPsHo0dCxwRvbB+Uua6bNoPWGnAnGzWPEW hu6Xr4peJ+P8eb/UI8lbkBHYB1uaujCpbCL0anEEYjUuILE5ai0HioeF8xXK+nAXuNl7 N4S4H2aAs7HL+nhXGdNHHT1Xn78aR+fgqiVP3RpRL+Dfh9/b9e0RXFV3fEs8JOOA2ho4 WaN6yRJ7uoP4b2xM6ZdxaNCGK/KKOcX62NRWPE1rs7hbJ7Kjomwi58UpNql5vXyuX2GG q1pWmVebJWzldiwG3AOqYF2BNuzZG+iz5peKq67s3UtQ5zxvIY9nxkr6n35El27uMlk8 l5vg== X-Gm-Message-State: ACrzQf3ximmvr2T5/AJANhsnNhUYOgM8Al+yAnIksqbhd17cIs67q/9d /vTg8smxZv9Y9Do8p3ESXG8= X-Google-Smtp-Source: AMsMyM4+Bl8P+EIRzxBRZhAs0nel50c7zZgGEkgDsjk3iTJpG+gQ2mArkGr5O1bby+RtdAE0jObniQ== X-Received: by 2002:a63:fa42:0:b0:44d:b59c:674b with SMTP id g2-20020a63fa42000000b0044db59c674bmr7093475pgk.207.1664839257026; Mon, 03 Oct 2022 16:20:57 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id q12-20020a65624c000000b0043a1c0a0ab1sm7172916pgv.83.2022.10.03.16.20.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2022 16:20:56 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2 12/39] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW From: Nadav Amit In-Reply-To: <35EEB9F0-D99A-4664-9628-27029B52CFD1@gmail.com> Date: Mon, 3 Oct 2022 16:20:53 -0700 Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "bp@alien8.de" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , Andy Lutomirski , "pavel@ucw.cz" , "arnd@arndb.de" , "Moreira, Joao" , Thomas Gleixner , "mike.kravetz@oracle.com" , "x86@kernel.org" , "linux-doc@vger.kernel.org" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Content-Transfer-Encoding: quoted-printable Message-Id: <65CF3B29-BF53-4BA3-89D9-5398CEB7F813@gmail.com> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-13-rick.p.edgecombe@intel.com> <64313344833c3b1701002a347d539e69276b66fb.camel@intel.com> <35EEB9F0-D99A-4664-9628-27029B52CFD1@gmail.com> To: "Edgecombe, Rick P" X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664839258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q3+69+rJNNqDIBt2xxx5swC3PNGWjqGr+kUfHliTojg=; b=dr3Rt09TV1+7DjlZO48x3+N2txYFX/3dqfl9vEIwSz55hEWpndCQfZv14eeGgX0TCrQjjn ugVbF25WtILsmXXpvs+XRKzhyhJ9/A7WjT/jE/7xGuvSAXri9Ydf/0BGthFa9fZH1DahNd Y8AOMRxQFoAdVY9PyaYgDnXqhNrgeE8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gvJIJRdB; spf=pass (imf02.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664839258; a=rsa-sha256; cv=none; b=nwusRw5dE2No5M44SIK0DRTrI2+Ff7+u12eMHYAmO6/4fYTDAzEIficVt4UnOUVaY5EXeD bTT+B2mKH6iBNde+wfbDbRiVNsswuFeco3uHKRxVeiBJkE/K43GG7vI8ElYp4lzzfv7IOT B+9+HfnPd0O5UA/dcZRd5AWPsTgu6Ok= X-Stat-Signature: g9qbsmiuhczt9u89x5jn5hcfny15c34d X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24CAE80015 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gvJIJRdB; spf=pass (imf02.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1664839257-669676 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 3, 2022, at 4:17 PM, Nadav Amit wrote: > On Oct 3, 2022, at 3:28 PM, Edgecombe, Rick P = wrote: >=20 >> On Mon, 2022-10-03 at 11:11 -0700, Nadav Amit wrote: >>> Did you have a look at ptep_set_access_flags() and friends and >>> checked they >>> do not need to be changed too?=20 >>=20 >> ptep_set_access_flags() doesn't actually set any additional dirty = bits >> on x86, so I think it's ok. >=20 > Are you sure about that? (lost my confidence today so I am hesitant). >=20 > Looking on insert_pfn(), I see: >=20 > entry =3D maybe_mkwrite(pte_mkdirty(entry), = vma); > if (ptep_set_access_flags(vma, addr, pte, = entry, 1)) ... >=20 > This appears to set the dirty bit while potentially leaving the = write-bit > clear. This is the scenario you want to avoid, no? No. I am not paying attention. Ignore.