From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE58C28B30 for ; Thu, 20 Mar 2025 17:31:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18AC2280003; Thu, 20 Mar 2025 13:31:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C42280001; Thu, 20 Mar 2025 13:31:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00332280003; Thu, 20 Mar 2025 13:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6E4A280001 for ; Thu, 20 Mar 2025 13:31:22 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24018BA2A9 for ; Thu, 20 Mar 2025 17:31:24 +0000 (UTC) X-FDA: 83242620888.05.ADE6647 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf26.hostedemail.com (Postfix) with ESMTP id 88FB714001E for ; Thu, 20 Mar 2025 17:31:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TEdB54qN; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf26.hostedemail.com: domain of marc.herbert@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=marc.herbert@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742491876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T4i5oAj/5eG1s5JZWUMyTx1C3jp2ogsjmV+/A6MNlOM=; b=OIU6s+Q+mKHZgCqUBkfbo2BoxPkBiXN6vRm8ywoYxyThBTl/K0vcmAu200JUjB+F3N/QOn u0pBgJ66fUDJAp0h8pojNsaBXnogRgNyQOwruWCXkW+gR64TS5YB0iIo679H5mVQQaBOxD KlErh9Vck9RtoOLDMEuZUWO/vIiTJSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742491876; a=rsa-sha256; cv=none; b=36lapiY75pUcey8mS3m5MZwojidcVQKEjextWEEsjEO3kRufYpSiHLP5Y32StRK4PIYeL2 2xIsY0Ckb8aNKc6YS6EqS0KRktMZxUFTE8nuBsL9KVfgIThro8nLWaOFiGPih7lRIQ4Ez0 QYjCjgEN+DUF905z4x57sKcTz7v2qz8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TEdB54qN; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf26.hostedemail.com: domain of marc.herbert@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=marc.herbert@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742491876; x=1774027876; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=soFbqUr3oF8SA23mqFbjb7rs05LKmXU7PMJJNAX8p4U=; b=TEdB54qN44MCRqaDmm92agRL6rlZoxCp4ehYD1xU2V7aCv2rtuZruTEM exUIfX7zz69751G7tm0MHZiMUSw6t1bjXeT4oUQE9xr7t4JB4QS7J7z8t pPT44xMB3Wl89lEKUwOOGu6l5L19Y17HZ8VU7TrNS1nM4drL7ANEQnzvG bg6N2zz4n2rO+x4ZhriTHo0vUEox4RhXzUPwlrGvThB5lzgMT5UrNsWk7 Y3dyzsSVj8ju/iufReNBpCi5HisGIHN2ksREcS+bgEwukQqIFLox496Wh awYAdKq5WkyVMtrfqfv9k9mp7PNsbf7TFLIhW23VjxS0LI1ccVomX5Qr+ g==; X-CSE-ConnectionGUID: CrzCy4EcTn6/6weRInCXjQ== X-CSE-MsgGUID: +jkEpDIIT+CByp1XS/z5aw== X-IronPort-AV: E=McAfee;i="6700,10204,11379"; a="69095421" X-IronPort-AV: E=Sophos;i="6.14,262,1736841600"; d="scan'208";a="69095421" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 10:31:14 -0700 X-CSE-ConnectionGUID: staVE5iLRNOXpGgPxamkIw== X-CSE-MsgGUID: JHMDyS7uS8qLU2EMXjDxWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,262,1736841600"; d="scan'208";a="146383640" Received: from agrisant-mobl2.amr.corp.intel.com (HELO [10.125.1.252]) ([10.125.1.252]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 10:31:13 -0700 Message-ID: <659f2fb8-97de-4a3e-9d8d-0a61f8ad552d@linux.intel.com> Date: Thu, 20 Mar 2025 10:31:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: move hugetlb_sysctl_init() to the __init section To: Andrew Morton Cc: Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250319060041.2737320-1-marc.herbert@linux.intel.com> <20250319002228.44e220b1ffadb4cc994ad4cf@linux-foundation.org> Content-Language: en-US From: Marc Herbert In-Reply-To: <20250319002228.44e220b1ffadb4cc994ad4cf@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 88FB714001E X-Stat-Signature: wkt4h3xnzfkaangyjkzkn7g5nfq9mqtd X-HE-Tag: 1742491875-286526 X-HE-Meta: U2FsdGVkX18Nx58gmMJ9EvvFdnQ0E4cabzRD5tFhbD39GI2vqcOKWKH8zTwd53QCQQ5f1R9h8GEJDnVPDfJrh4IQodxn5lA72mvU/5fbEOgCaN7vyuFt9IOCPVwmOnYI9Aj3dqi1xgnSAdnPf7FvS4dENqqFw7nDRyV0cNR2mD5Bx0EveNyRtKfBAkWNqfUBaW5zX3b0bo0b9OSIA7w5qXEHe3Wts9xFnKqqLx6lyIBHYZmq+vNjT8pquxYN4Prgn5ottN5TEbgI5HVsWMXxWY43qJNjc3xEK/ZOrzSqRCzIl5PGdar+rIdYKzqfVsCn6VZcaSG1RT8xJJdIObJv7AhnBNHkI617d/vqrBEl+fT0EwMX6BTW0W55DW8Z5obRT/As7AprjENURaCGVV/hWYQg4pJD+vkRLFb/gcLWdHMjeOA4i7rNjxZvodj5WVSReRizpH72ks5xjfIX3+Ld+pIJzrlPl65+DPPKDix5NpkwKZo+L+xDRkxEfhCnBjnZyDnwlg3ySi1t6iYsQxXY0TSmBecomqPdjJXSg1DxxUeV9hjwGG7MrvmV/mQiip7glWMhNEBOAJ79Pv4qBLOmmAkw/FMHg7DlXK4X0rkZDis1E33LpwESC1qGkQosOEpaPYeLFH2DQ2Sba87kiN4LYmEiGv095golSKOxrP6ovmf/EqXjPCmBS9hjZbrjNv1MaU/GD5A+uVK9XiYgTbA0a6VR8NBzlWbzDtKckvgG5cxmtXKvQls8Jw5bPys6zMQD8u4BpPrqvBGn8UqQkIbUwav67q2NId0NWJfEQqEz4mLeQuDHpnkAQerhKRLZoKdcGof7gg98NrJco62FhE5SqJjsen6TIpbt7adGa5lBhAyE63Vf975sUQpdNaZwGUws4tI72kKnBtbWwtAaRYLuJe15dGIk/KEfGZfwMzsNr/jBzquGxYLpNNTbLAuC80Mfo5FoLqIUTbfJhFu6LyX PqQ6Oisu BGikFrjwQkG0uq/JwXj1oSRKbpN6MWAVQml4DgjNSb2hWWFliDdIQwEtl03RNoMUPEOoa3PbhbKTJIribia+fWiGv+3p86w2zo84qMVwMb2y1eqiU0GHL6MGZzrmGVY4G6jukRQM0tVixKNX5VlkE1QDJeEUFOvFmuRJCq2HaojIJlWQmIy8YOfZVL8Wjb2U1yZ9dryYI302jNscLJNMFcWs2r/IWVlUUXIltW7dxPibTtu+HU6Co+NvXi511LoxRkt6m2+KE2/HsUqcaNQs3iA6LgH4oVEWj1UOmtpw6jgWvfN9Y4Ph6/AONm83jwBZ9Yd1v90tNmJ//2zs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, On 2025-03-19 00:22, Andrew Morton wrote: > On Wed, 19 Mar 2025 06:00:30 +0000 marc.herbert@linux.intel.com wrote: > >> hugetlb_sysctl_init() is only invoked once by an __init function and is >> merely a wrapper around another __init function so there is not reason >> to keep it. >> >> Fixes the following warning when toning down some GCC inline options: >> >> WARNING: modpost: vmlinux: section mismatch in reference: >> hugetlb_sysctl_init+0x1b (section: .text) -> >> __register_sysctl_init (section: .init.text) >> > > Huh. I wonder why this just started happening. As I just mentioned, I see this warning only because I'm playing with GCC flags. Not sure how good is that page but its name is perfect here: https://stackoverflow.com/questions/59388740/gcc-shows-different-warnings-depending-on-optimisation-level Also, https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html > The effectiveness of some warnings depends on optimizations also being > enabled. For example -Wsuggest-final-types is more effective with > link-time optimization and some instances of other warnings may not be > issued at all unless optimization is enabled. While optimization in > general improves the efficacy of control and data flow sensitive > warnings, in some cases it may also cause false positives. That particular warning was very minor but simple and valid; not a false positive. It was also the only "section mismatch" warning found in my entire configuration. Marc PS: who needs expensive static analysis tools when unusual combination of compiler flags can find issues? :-D