From: Paul Menage <menage@google.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Li Zefan <lizf@cn.fujitsu.com>, Nick Piggin <npiggin@suse.de>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 21/24] cgroup: define empty css_put() when !CONFIG_CGROUPS
Date: Wed, 2 Dec 2009 14:48:03 -0800 [thread overview]
Message-ID: <6599ad830912021448h6f939623y43fbe5fde2c36b85@mail.gmail.com> (raw)
In-Reply-To: <20091202043046.420815285@intel.com>
On Tue, Dec 1, 2009 at 7:12 PM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> --- linux-mm.orig/include/linux/cgroup.h 2009-11-02 10:18:41.000000000 +0800
> +++ linux-mm/include/linux/cgroup.h 2009-11-02 10:26:22.000000000 +0800
> @@ -581,6 +581,9 @@ static inline int cgroupstats_build(stru
> return -EINVAL;
> }
>
> +struct cgroup_subsys_state;
> +static inline void css_put(struct cgroup_subsys_state *css) {}
> +
> #endif /* !CONFIG_CGROUPS */
This doesn't sound like the right thing to do - if !CONFIG_CGROUPS,
then the code shouldn't be able to see a css structure to pass to this
function.
Paul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-02 22:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 3:12 [PATCH 00/24] hwpoison fixes and stress testing filters Wu Fengguang
2009-12-02 3:12 ` [PATCH 01/24] page-types: add standard GPL license head Wu Fengguang
2009-12-02 13:08 ` Andi Kleen
2009-12-02 3:12 ` [PATCH 02/24] migrate: page could be locked by hwpoison, dont BUG() Wu Fengguang
2009-12-02 13:09 ` Andi Kleen
2009-12-02 14:50 ` Christoph Lameter
2009-12-03 1:34 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 03/24] HWPOISON: remove the anonymous entry Wu Fengguang
2009-12-02 3:12 ` [PATCH 04/24] HWPOISON: return ENXIO on invalid pfn Wu Fengguang
2009-12-02 3:12 ` [PATCH 05/24] HWPOISON: avoid grabbing page for two times Wu Fengguang
2009-12-02 3:12 ` [PATCH 06/24] HWPOISON: abort on failed unmap Wu Fengguang
2009-12-02 13:11 ` Andi Kleen
2009-12-02 13:28 ` Wu Fengguang
2009-12-02 13:44 ` Andi Kleen
2009-12-02 3:12 ` [PATCH 07/24] HWPOISON: comment the possible set_page_dirty() race Wu Fengguang
2009-12-02 3:12 ` [PATCH 08/24] HWPOISON: comment dirty swapcache pages Wu Fengguang
2009-12-02 3:12 ` [PATCH 09/24] HWPOISON: introduce delete_from_lru_cache() Wu Fengguang
2009-12-02 3:12 ` [PATCH 10/24] HWPOISON: remove the free buddy page handler Wu Fengguang
2009-12-02 13:13 ` Andi Kleen
2009-12-02 13:31 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 11/24] HWPOISON: detect free buddy pages explicitly Wu Fengguang
2009-12-02 3:12 ` [PATCH 12/24] HWPOISON: make it possible to unpoison pages Wu Fengguang
2009-12-02 13:15 ` Andi Kleen
2009-12-02 13:31 ` Wu Fengguang
2009-12-02 13:46 ` Wu Fengguang
2009-12-02 14:03 ` Andi Kleen
2009-12-03 1:45 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 13/24] HWPOISON: introduce struct hwpoison_control Wu Fengguang
2009-12-02 13:15 ` Andi Kleen
2009-12-02 3:12 ` [PATCH 14/24] HWPOISON: return 0 if page is assured to be isolated Wu Fengguang
2009-12-02 12:47 ` Andi Kleen
2009-12-02 13:15 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 15/24] HWPOISON: add fs/device filters Wu Fengguang
2009-12-02 3:12 ` [PATCH 16/24] HWPOISON: limit hwpoison injector to known page types Wu Fengguang
2009-12-02 8:11 ` Ingo Molnar
2009-12-02 3:12 ` [PATCH 17/24] mm: export stable page flags Wu Fengguang
2009-12-02 4:42 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 18/24] HWPOISON: add page flags filter Wu Fengguang
2009-12-02 3:12 ` [PATCH 19/24] memcg: rename and export try_get_mem_cgroup_from_page() Wu Fengguang
2009-12-03 1:58 ` Balbir Singh
2009-12-02 3:12 ` [PATCH 20/24] memcg: add accessor to mem_cgroup.css Wu Fengguang
2009-12-02 3:12 ` [PATCH 21/24] cgroup: define empty css_put() when !CONFIG_CGROUPS Wu Fengguang
2009-12-02 22:48 ` Paul Menage [this message]
2009-12-02 22:52 ` Andi Kleen
2009-12-03 1:53 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 22/24] HWPOISON: add memory cgroup filter Wu Fengguang
2009-12-02 12:44 ` Andi Kleen
2009-12-02 12:58 ` Wu Fengguang
2009-12-03 1:52 ` KAMEZAWA Hiroyuki
2009-12-03 2:19 ` Wu Fengguang
2009-12-03 2:28 ` KAMEZAWA Hiroyuki
2009-12-03 2:47 ` Wu Fengguang
2009-12-03 2:58 ` KAMEZAWA Hiroyuki
2009-12-03 15:03 ` Wu Fengguang
2009-12-03 2:15 ` Li Zefan
2009-12-03 2:20 ` Wu Fengguang
2009-12-03 2:28 ` Wu Fengguang
2009-12-02 3:12 ` [PATCH 23/24] HWPOISON: add an interface to switch off/on all the page filters Wu Fengguang
2009-12-02 3:12 ` [PATCH 24/24] HWPOISON: show corrupted file info Wu Fengguang
2009-12-02 13:20 ` Andi Kleen
2009-12-02 13:37 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830912021448h6f939623y43fbe5fde2c36b85@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox