Re: [PATCH -mmotm 1/5] cgroup: introduce cancel_attach()

[Paul Menage <menage@google.com>]

On Wed, Nov 18, 2009 at 8:28 PM, Daisuke Nishimura
<nishimura@mxp.nes.nec.co.jp> wrote:
> This patch adds cancel_attach() operation to struct cgroup_subsys.
> cancel_attach() can be used when can_attach() operation prepares something
> for the subsys, but we should rollback what can_attach() operation has prepared
> if attach task fails after we've succeeded in can_attach().
>
> Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>

Reviewed-by: Paul Menage <menage@google.com>

> +                               /*
> +                                * Remember at which subsystem we've failed in
> +                                * can_attach() to call cancel_attach() only
> +                                * against subsystems whose attach() have
> +                                * succeeded(see below).

Maybe: Remember on which subsystem the can_attach() failed, so that we
only call cancel_attach() against the subsystems whose can_attach()
succeeded. (See below)

> +                               /*
> +                                * This means can_attach() of this subsystem
> +                                * have failed, so we don't need to call
> +                                * cancel_attach() against rests of subsystems.
> +                                */

Maybe: This subsystem was the one that failed the can_attach() check
earlier, so we don't need to call cancel_attach() against it or any
remaining subsystems.

Paul

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>