From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id mA46PntN027444 for ; Tue, 4 Nov 2008 06:25:49 GMT Received: from rv-out-0506.google.com (rvfb25.prod.google.com [10.140.179.25]) by spaceape14.eur.corp.google.com with ESMTP id mA46Pl3X021439 for ; Mon, 3 Nov 2008 22:25:48 -0800 Received: by rv-out-0506.google.com with SMTP id b25so2943690rvf.41 for ; Mon, 03 Nov 2008 22:25:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20081101184824.2575.5935.sendpatchset@balbir-laptop> References: <20081101184812.2575.68112.sendpatchset@balbir-laptop> <20081101184824.2575.5935.sendpatchset@balbir-laptop> Date: Mon, 3 Nov 2008 22:25:47 -0800 Message-ID: <6599ad830811032225w229d3a29k17b9a38cb76a521f@mail.gmail.com> Subject: Re: [mm] [PATCH 1/4] Memory cgroup hierarchy documentation From: Paul Menage Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Balbir Singh Cc: linux-mm@kvack.org, YAMAMOTO Takashi , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, Nick Piggin , David Rientjes , Pavel Emelianov , Dhaval Giani , Andrew Morton , KAMEZAWA Hiroyuki List-ID: On Sat, Nov 1, 2008 at 10:48 AM, Balbir Singh wrote: > + > +The memory controller by default disables the hierarchy feature. Support > +can be enabled by writing 1 to memory.features file of the root cgroup > + > +# echo 1 > memory.features > + > +The feature can be disabled by > + > +# echo 0 > memory.features That's not a very intuitive interface. Why not memory.use_hierarchy? (I presume that you're trying to cram multiple bits into a single file, but that seems a bit ugly). Paul -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org