From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9ABDC5475B for ; Fri, 1 Mar 2024 16:04:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 337EF6B0082; Fri, 1 Mar 2024 11:04:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0C36B0085; Fri, 1 Mar 2024 11:04:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13AD96B0087; Fri, 1 Mar 2024 11:04:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0192A6B0082 for ; Fri, 1 Mar 2024 11:04:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D5B4A13DF for ; Fri, 1 Mar 2024 16:04:18 +0000 (UTC) X-FDA: 81848942196.23.7DA714F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id A03E3400D4 for ; Fri, 1 Mar 2024 16:04:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UIgSXCo/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jMkoRH2D; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UIgSXCo/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jMkoRH2D; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709309041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WjR6OvQiPcuCw93mAUfU7kJQwKpvjY1JrTdttou/ro4=; b=kWAxRj2j/fNsH6EEhF3pk+3/E/wYckWkT4G+n4QB3g6ub6Clo87szRecfO8HO9qWy9iDlj VL2x/nNTpCGVLFxW+XS6+WXQvQ3AdT/g9VE7FP/8joBrfF2QyAdv43yPz+kv+7dFfuTCf4 bisSXx8fqq2ELIQt/FHRVSnXxxTOFTY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UIgSXCo/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jMkoRH2D; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UIgSXCo/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jMkoRH2D; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709309041; a=rsa-sha256; cv=none; b=CFQjLXArgfF7+Uf1MI13mgZ66PIQmsF3+BOknA9Wgv8naVlPIsztQXm6TDLS4+pzVAt59J BN2M6/D2E+B1/p3pPuhOk94pmhfPKRNGkFYUY74piTWdXfPTGWxjnytG9NprzrQHLLzTkM yr8DBb+a7bdfp1VU31wgnFMP9RPsKJw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA267206D7; Fri, 1 Mar 2024 16:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709309038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WjR6OvQiPcuCw93mAUfU7kJQwKpvjY1JrTdttou/ro4=; b=UIgSXCo/2RInJegpmI12RiPD+Dls2VU4xtaUVNW2fZsRGE3A/qfxp7qD5m5thox+LDrosy 8FKwMuk3qW3EPQXHALZ+EjVJSaYXk3ylMnvGc2ROhlWJmgTCMckdq49tYQYEGnF/JOdoLH FvhK3XkSStfgltINgYQ2K/+P0UjHp2U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709309038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WjR6OvQiPcuCw93mAUfU7kJQwKpvjY1JrTdttou/ro4=; b=jMkoRH2DN4FqIMQK3IJs1gDBY4dp8UkaCBaCtSGh7ojUuw3M/rRruKv3lnKVVXXbF5VgyF kwrWH+8HuqeLwBAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709309038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WjR6OvQiPcuCw93mAUfU7kJQwKpvjY1JrTdttou/ro4=; b=UIgSXCo/2RInJegpmI12RiPD+Dls2VU4xtaUVNW2fZsRGE3A/qfxp7qD5m5thox+LDrosy 8FKwMuk3qW3EPQXHALZ+EjVJSaYXk3ylMnvGc2ROhlWJmgTCMckdq49tYQYEGnF/JOdoLH FvhK3XkSStfgltINgYQ2K/+P0UjHp2U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709309038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WjR6OvQiPcuCw93mAUfU7kJQwKpvjY1JrTdttou/ro4=; b=jMkoRH2DN4FqIMQK3IJs1gDBY4dp8UkaCBaCtSGh7ojUuw3M/rRruKv3lnKVVXXbF5VgyF kwrWH+8HuqeLwBAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8D94E13A80; Fri, 1 Mar 2024 16:03:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jgCPIW784WXQCAAAD6G6ig (envelope-from ); Fri, 01 Mar 2024 16:03:58 +0000 Message-ID: <6594a42c-0f53-4124-9177-d1c631d9764f@suse.cz> Date: Fri, 1 Mar 2024 17:03:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slab: remove the corner case of inc_slabs_node() Content-Language: en-US To: chengming.zhou@linux.dev, cl@linux.com Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240222130233.2880176-1-chengming.zhou@linux.dev> From: Vlastimil Babka In-Reply-To: <20240222130233.2880176-1-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: + X-Rspam-User: X-Stat-Signature: gd6f616mhhns7ofoyxuk11dwyciuwmk8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A03E3400D4 X-HE-Tag: 1709309040-177392 X-HE-Meta: U2FsdGVkX1+7AtkFMPOM3aPTMPnpeJEPdixHBKQaur3oBKoHePVD+naChWgWKkfh9LxUAfA4WdCzBeCVMI9xzan9pgt7XeB8lu/r4bHdn+o20fdkyeI3N6Xu6etD9/AyJfU3DnuZ8jhZDL4mfU771OPOYmKtu5SmHndVLaVDP+j+RVy0Q2y6K+Ajdi796ONOIlBxBRFyAu0WMI2zaQPjGIEp1bhL4WzK1IyHpOxL7uerso1iVbeH+s6o274YfJuAzArhzAqSzuTsC8Boyt5gAcVrkkDuNbT7KztVzOVQjR/Z5PSlnOAvC5hHVPdeO2I9A7KpQTDTJjLMiG1Vay3mGJGjaNwmh0++IWtAqcGrFkViX1eu9kfgIIxQfyeAFGkj01QkDgg/foxbfdBE9BIuPG3a4H6nwLYWgV9JZe1V2uAnZiOBQuUKdzElql29l7aAVBZ5NC39c1g9ugnBn0FP/Mvuweryy7hG9L0mRiciHqcWsd547k5N4b9Mrw1AOL56IfLKPMM3mWJ2vL5BXumWCXAQK9GFNYGDe8jopZAfQapnK2EduogN31UhWIypcsT4EfdDOdpyatOvcE2Vyxau3wmsi/UdEcGjSf+99TUP02rBIxv7cZxVKPRtRcYCGFDENMPX35NebMWXKuXUAAnKawKqnFDW+3s8hj8rmhDf2BJ0NmXxLKi0s2qYz9540v42LzGvYWInTTjMwhw6vBS3OqkgkoNMMsgQmF//IHN7tXoWtiEmBc0CFOD5b+GqDrbzs/H2YSwq2iFn0iMfmc2OTyGOCHf4TMCdijbM0Ep/CdvUutcthZu8JdK3t7hDAVlQWhPEJ96rUnTUISQEbJ9k+2CSIG6kUwEwarccf+aHAFY/GRQa4QfVbtjLjsfxLThytvNHGfHsS2RqU9XIhonxACO6VBU36zxSZDZDYUrS/1+3NGQnNVik3InkJS80WLIeMgAWOgWY+FsSUUnnGwW 6ZGBXjO7 Q31vEXVZL7b/L7xPkKn0JbWZX60nmNpQNZD1ioNddjCBlg8j2KzmDhZ+4fVst6fAL/KzVuyaBQeTVdNucQZbfGAZjuBcySaUiZOMMQeCt47Oxb+VfSMjmhJsmhi0X6JneeRm6AR/VNMwLM4kbhYMdbgvS8UJXGc2QsJ4KuON7vLgzvGFyoLHkdPdF9Z1ju+VeIhKX03Cu6Tfy95duLSMAUgybH6W42OvcQgOp9vDiZgce7E+aaHZFKAsmdR2rFr26KMFWbb0xADmTUWeOWamccQ/ZwJx9v6BE9AkDlVeMdQl+YtCwrJgE19nMuqcGAY3/71l0XwkFCjkAx4Nr+FNiXle4CqtnEczHTzgVL4OgA2cHnM9cnd+RVxgTLSdURhp9dbN6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/22/24 14:02, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > We already have the inc_slabs_node() after kmem_cache_node->node[node] > initialized in early_kmem_cache_node_alloc(), this special case of > inc_slabs_node() can be removed. Then we don't need to consider the > existence of kmem_cache_node in inc_slabs_node() anymore. > > Signed-off-by: Chengming Zhou Well spotted, thank. Added to slab/for-next. > --- > mm/slub.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 284b751b3b64..3f413e5e1415 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1500,16 +1500,8 @@ static inline void inc_slabs_node(struct kmem_cache *s, int node, int objects) > { > struct kmem_cache_node *n = get_node(s, node); > > - /* > - * May be called early in order to allocate a slab for the > - * kmem_cache_node structure. Solve the chicken-egg > - * dilemma by deferring the increment of the count during > - * bootstrap (see early_kmem_cache_node_alloc). > - */ > - if (likely(n)) { > - atomic_long_inc(&n->nr_slabs); > - atomic_long_add(objects, &n->total_objects); > - } > + atomic_long_inc(&n->nr_slabs); > + atomic_long_add(objects, &n->total_objects); > } > static inline void dec_slabs_node(struct kmem_cache *s, int node, int objects) > { > @@ -4877,7 +4869,6 @@ static void early_kmem_cache_node_alloc(int node) > slab = new_slab(kmem_cache_node, GFP_NOWAIT, node); > > BUG_ON(!slab); > - inc_slabs_node(kmem_cache_node, slab_nid(slab), slab->objects); > if (slab_nid(slab) != node) { > pr_err("SLUB: Unable to allocate memory from node %d\n", node); > pr_err("SLUB: Allocating a useless per node structure in order to be able to continue\n");